Re: [PATCH 2/2] drm/amd/amdgpu: expose fan rpm though hwmon

2016-10-31 Thread Alex Deucher
On Sat, Oct 29, 2016 at 4:28 PM, Grazvydas Ignotas wrote: > Only for cards that are supported by powerplay. > > Signed-off-by: Grazvydas Ignotas Applied the series. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 5 + > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 21 +++

Re: [PATCH] drm/amd/powerplay: don't succeed in getters if fan is missing

2016-10-31 Thread Alex Deucher
On Sun, Oct 30, 2016 at 1:05 AM, Edward O'Callaghan wrote: > Reviewed-by: Edward O'Callaghan > > On 10/30/2016 07:32 AM, Grazvydas Ignotas wrote: >> Otherwise callers end up using uninitialized data. >> >> Signed-off-by: Grazvydas Ignotas Applied. thanks! Alex >> --- >> drivers/gpu/drm/amd/

[PATCH] drm/amdgpu: make sure ddc_bus is valid in connector unregister

2016-10-31 Thread Alex Deucher
This should only happen on boards TV connectors which do not have a ddc bus for those connectors. None of the asics supported by amdgpu support tv, so we shouldn't hit this, but check to be on the safe side (e.g., bios bug for example). Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu

Re: [PATCH 1/2] drm/radeon: disable runtime pm in certain cases

2016-10-31 Thread Christian König
Am 31.10.2016 um 16:07 schrieb Alex Deucher: If the platform does not support hybrid graphics or ATPX dGPU power control. bug: https://bugzilla.kernel.org/show_bug.cgi?id=51381 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org Acked-by: Christian König for both. --- drivers/gpu/drm

[PATCH 2/2] drm/amdgpu: disable runtime pm in certain cases

2016-10-31 Thread Alex Deucher
If the platform does not support hybrid graphics or ATPX dGPU power control. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amd

[PATCH 1/2] drm/radeon: disable runtime pm in certain cases

2016-10-31 Thread Alex Deucher
If the platform does not support hybrid graphics or ATPX dGPU power control. bug: https://bugzilla.kernel.org/show_bug.cgi?id=51381 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/radeon_device.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH] drm/amdgpu: remove amdgpu_cs_handle_lockup

2016-10-31 Thread Christian König
Am 31.10.2016 um 10:24 schrieb Huang Rui: In fence waiting, it never return -EDEADLK yet, so drop this function here. Signed-off-by: Huang Rui Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/

Re: [PATCH] drm/amdgpu: cleanup amdgpu_cs_ioctl to make code logicality clear

2016-10-31 Thread Huang Rui
On Mon, Oct 31, 2016 at 05:14:26PM +0800, Christian K�nig wrote: > Am 31.10.2016 um 09:58 schrieb Huang Rui: > > On Mon, Oct 31, 2016 at 03:53:52PM +0800, Christian K?nig wrote: > >> Am 31.10.2016 um 03:08 schrieb Huang Rui: > >>> Signed-off-by: Huang Rui > >> Looks good to me, patch is Reviewed-b

[PATCH] drm/amdgpu: remove amdgpu_cs_handle_lockup

2016-10-31 Thread Huang Rui
In fence waiting, it never return -EDEADLK yet, so drop this function here. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index d

Re: [PATCH] drm/amdgpu: cleanup amdgpu_cs_ioctl to make code logicality clear

2016-10-31 Thread Christian König
Am 31.10.2016 um 09:58 schrieb Huang Rui: On Mon, Oct 31, 2016 at 03:53:52PM +0800, Christian König wrote: Am 31.10.2016 um 03:08 schrieb Huang Rui: Signed-off-by: Huang Rui Looks good to me, patch is Reviewed-by: Christian König . BTW: amdgpu_cs_handle_lockup() is a leftover from radeon and

Re: [PATCH] drm/amdgpu: cleanup amdgpu_cs_ioctl to make code logicality clear

2016-10-31 Thread Huang Rui
On Mon, Oct 31, 2016 at 03:53:52PM +0800, Christian König wrote: > Am 31.10.2016 um 03:08 schrieb Huang Rui: > > Signed-off-by: Huang Rui > > Looks good to me, patch is Reviewed-by: Christian König > . > > BTW: amdgpu_cs_handle_lockup() is a leftover from radeon and can be > removed. Would be

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-31 Thread Michel Dänzer
On 31/10/16 05:00 PM, Christian König wrote: > Am 31.10.2016 um 07:44 schrieb Michel Dänzer: >> On 29/10/16 10:58 PM, Mike Lothian wrote: >>> I turned on vsync and everything works great in tomb raider >>> >>> :D >>> >>> Thanks again to everyone who made this possible >>> >>> On Fri, 28 Oct 2016 at

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-31 Thread Christian König
Am 31.10.2016 um 07:44 schrieb Michel Dänzer: On 29/10/16 10:58 PM, Mike Lothian wrote: I turned on vsync and everything works great in tomb raider :D Thanks again to everyone who made this possible On Fri, 28 Oct 2016 at 19:37 Mike Lothian mailto:m...@fireburn.co.uk>> wrote: Hi Mario

Re: [PATCH] drm/amdgpu: cleanup amdgpu_cs_ioctl to make code logicality clear

2016-10-31 Thread Christian König
Am 31.10.2016 um 03:08 schrieb Huang Rui: Signed-off-by: Huang Rui Looks good to me, patch is Reviewed-by: Christian König . BTW: amdgpu_cs_handle_lockup() is a leftover from radeon and can be removed. Would be nice if you can take care of this as well. Regards, Christian. --- driver