Re: [pull] radeon and amdgpu drm-next-4.12

On 29/04/17 06:54 AM, Alex Deucher wrote: > Hi Dave, > > Fixes for 4.12. Mostly updates for vega10 which is new for > 4.12. Highlights: > - Lots of vega10 fixes > - fix interruptable wait mixup > - misc display fixes for radeon and amdgpu > - misc bug fixes [...] > Michel Dänzer (1): >

Re: [PATCH] drm/amdgpu: Make amdgpu_bo_reserve use uninterruptible waits for cleanup

On 28/04/17 11:12 PM, Xie, AlexBin wrote: >> Am 28.04.2017 um 10:47 schrieb Michel Dänzer: >>> From: Michel Dänzer >>> >>> Some of these paths probably cannot be interrupted by a signal anyway. >>> Those that can would fail to clean up things if they actually got >>>

RE: Move kiq ring lock out of virt strucure

Thanks , Andres . Changed as suggested . Regards Shaoyun.liu -Original Message- From: Andres Rodriguez [mailto:andre...@gmail.com] Sent: Friday, April 28, 2017 5:41 PM To: Liu, Shaoyun; amd-gfx list (amd-gfx@lists.freedesktop.org); Deucher, Alexander Cc: brahma_sw_dev Subject: Re:

Set invalidation reg set used in amdgpu to avoid the confliction for vega10

Please have a look. Regards Shaoyun.liu 0001-drm-amdgpu-Reserve-0-2-invalidation-reg-sets-for-non.patch Description: 0001-drm-amdgpu-Reserve-0-2-invalidation-reg-sets-for-non.patch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

[pull] radeon and amdgpu drm-next-4.12

Hi Dave, Fixes for 4.12. Mostly updates for vega10 which is new for 4.12. Highlights: - Lots of vega10 fixes - fix interruptable wait mixup - misc display fixes for radeon and amdgpu - misc bug fixes The following changes since commit 73ba2d5c2bd4ecfec8fe37f20e962889b8a4c972: Merge tag

Re: Move kiq ring lock out of virt strucure

I actually have a similar patch in my tree at the moment. Only a minor nitpick (the original base also has the same problem). Can you rename 'lock_ring' to 'ring_mutex'? Usually the _lock suffix is used for spinlock_t and _mutex is used for mutexes. With that fixed you can add: Reviewed-by:

Move kiq ring lock out of virt strucure

Please have a look. Regards Shaoyun.liu 0001-drm-amdgpu-Move-kiq-ring-lock-out-of-virt-structure.patch Description: 0001-drm-amdgpu-Move-kiq-ring-lock-out-of-virt-structure.patch ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

Re: [PATCH umr] Avoid opening the DRM file by default

On Thu, Apr 27, 2017 at 12:41 PM, Tom St Denis wrote: > Opening the DRM file (/dev/dri/card%d) triggers all sorts of KMD > work to happen which is not useful if the KMD is hung or not working. > > Since --top is the only user of the file currently we simply defer > opening it

RE: [PATCH 3/3] drm/amd/powerplay: implement stop dpm task for vega10.

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Friday, April 28, 2017 1:20 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 3/3] drm/amd/powerplay: implement stop dpm task for > vega10. > >

RE: [PATCH] drm/amdgpu: add cu info wave_front_size

> -Original Message- > From: Junwei Zhang [mailto:jerry.zh...@amd.com] > Sent: Thursday, April 27, 2017 11:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander; Wang, Ken; Zhang, Jerry > Subject: [PATCH] drm/amdgpu: add cu info wave_front_size > > missed that for gfx v9 info

RE: CZ EDC param and support

Actually, the attachment was an oversight. It's easier for me to attach, open the attachment and then delete the attachment. I got only 2/3 this time. I've gotten a comment that inline patches are preferred. Sorry for the inconvenience. davep From: Koenig, Christian Sent: Friday, April 28,

Re: [PATCH] drm/amdgpu: Make amdgpu_bo_reserve use uninterruptible waits for cleanup

Am 28.04.2017 um 10:47 schrieb Michel Dänzer: > From: Michel Dänzer > > Some of these paths probably cannot be interrupted by a signal anyway. > Those that can would fail to clean up things if they actually got > interrupted. > > Signed-off-by: Michel Dänzer

[PATCH umr] Add 'no_kernel' option

This flag allows umr to perform some operations it would normally need the kernel for in userspace. This is useful if the kernel driver is misbehaving. Don't use this on a healthy system as it could invoke race conditions. This flag enables userland activities such as - reading/writing MMIO

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

Hi, > > So just not using the swapping indeed looks like the only sensible > > option. Which in turn implies there is no BGRA support for dumb > > bos. Hmm, I can see the problem. Userspace expectation appears to be > > that ADDFB configures a native endian framebuffer, which the driver

Re: [PATCH] amdgpu: add interface for reserve/unserve vmid

anyone could give a quick review? Regards, David Zhou On 2017年04月28日 17:22, Chunming Zhou wrote: Change-Id: If533576eb8a65bd019a3480d6fe2a64f23e3c944 Signed-off-by: Chunming Zhou --- amdgpu/amdgpu.h| 13 + amdgpu/amdgpu_cs.c | 30

[PATCH] amdgpu: add interface for reserve/unserve vmid

Change-Id: If533576eb8a65bd019a3480d6fe2a64f23e3c944 Signed-off-by: Chunming Zhou --- amdgpu/amdgpu.h| 13 + amdgpu/amdgpu_cs.c | 30 ++ 2 files changed, 43 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index

Re: [PATCH] Revert "drm/amdgpu: Refactor flip into prepare submit and submit. (v2)"

Am 28.04.2017 um 10:48 schrieb Michel Dänzer: On 28/04/17 05:23 PM, Christian König wrote: Am 28.04.2017 um 08:59 schrieb Michel Dänzer: On 27/04/17 07:04 PM, Christian König wrote: Am 27.04.2017 um 10:18 schrieb Michel Dänzer: From: Michel Dänzer This reverts

Re: [PATCH] drm/amdgpu: Make amdgpu_bo_reserve use uninterruptible waits for cleanup

Am 28.04.2017 um 10:47 schrieb Michel Dänzer: From: Michel Dänzer Some of these paths probably cannot be interrupted by a signal anyway. Those that can would fail to clean up things if they actually got interrupted. Signed-off-by: Michel Dänzer

Re: [PATCH] Revert "drm/amdgpu: Refactor flip into prepare submit and submit. (v2)"

On 28/04/17 05:23 PM, Christian König wrote: > Am 28.04.2017 um 08:59 schrieb Michel Dänzer: >> On 27/04/17 07:04 PM, Christian König wrote: >>> Am 27.04.2017 um 10:18 schrieb Michel Dänzer: From: Michel Dänzer This reverts commit

[PATCH] drm/amdgpu: Make amdgpu_bo_reserve use uninterruptible waits for cleanup

From: Michel Dänzer Some of these paths probably cannot be interrupted by a signal anyway. Those that can would fail to clean up things if they actually got interrupted. Signed-off-by: Michel Dänzer ---

Re: [PATCH] drm/amdgpu: add cu info wave_front_size

Sorry about that missing, since it's originally created on amdgpu-pro stack, which is a bit different about cu info definition. I will keep an eye on those patches squashing when Alex prepares the patch merging. Jerry On 04/28/2017 04:20 PM, Christian König wrote: Do I get it right that the

Re: [PATCH] drm/amdgpu: fix deadlock of reservation between cs and gpu reset v2

Agree, but libdrm doesn't allow concurrent submissions from same context, like protection 'pthread_mutex_lock(>sequence_mutex);' in amdgpu_cs_submit_one. Regards, David Zhou On 2017年04月28日 16:15, Christian König wrote: Indeed, but after a bit of thinking I've found another problem with that

Re: [RFC] drm/amd/amdgpu: get rid of else branch

Am 27.04.2017 um 18:17 schrieb Nikola Pajkovsky: This is super simple elimination of else branch and I should probably even use unlikely in if (ring->count_dw < count_dw) { However, amdgpu_ring_write() has similar if condition, but does not return after DRM_ERROR and it looks

Re: [PATCH] Revert "drm/amdgpu: Refactor flip into prepare submit and submit. (v2)"

Am 28.04.2017 um 08:59 schrieb Michel Dänzer: On 27/04/17 07:04 PM, Christian König wrote: Am 27.04.2017 um 10:18 schrieb Michel Dänzer: From: Michel Dänzer This reverts commit cb341a319f7e66f879d69af929c3dadfc1a8f31e. The purpose of the refactor was for

Re: [PATCH] drm/amdgpu: add cu info wave_front_size

Do I get it right that the branch doesn't compile without that? If yes please add a comment in the commit message so that Alex has a chance of squashing this into the original one during upstreaming. Either way the patch is Reviewed-by: Christian König as well.

Re: [PATCH] drm/amdgpu: fix deadlock of reservation between cs and gpu reset v2

Indeed, but after a bit of thinking I've found another problem with that patch. When two threads are pushing jobs into the same scheduler context we don't guarantee correct execution order any more! Before that patch it was handled by the exclusiveness we had because of reserving the VM

Re: CZ EDC param and support

You somehow messed up the attachment. Instead of individual files everything is squashed together as all-edc.patch. Please fix that otherwise proper review won't be possible. Christian. Am 28.04.2017 um 00:13 schrieb Panariti, David: The changes in the workarounds function use DRM_INFO

Re: [PATCH] Revert "drm/amdgpu: Refactor flip into prepare submit and submit. (v2)"

On 27/04/17 07:04 PM, Christian König wrote: > Am 27.04.2017 um 10:18 schrieb Michel Dänzer: >> From: Michel Dänzer >> >> This reverts commit cb341a319f7e66f879d69af929c3dadfc1a8f31e. >> >> The purpose of the refactor was for amdgpu_crtc_prepare/submit_flip to >> be used