RE: [PATCH xf86-video-amdgpu] Improve AMDGPUPreInitAccel_KMS log messages

2017-06-07 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Wednesday, June 07, 2017 9:50 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-amdgpu] Improve AMDGPUPreInitAccel_KMS > log messages > > From: Michel

[PATCH xf86-video-amdgpu] Improve AMDGPUPreInitAccel_KMS log messages

2017-06-07 Thread Michel Dänzer
From: Michel Dänzer Now it should always be clear in the log file why acceleration isn't enabled. Signed-off-by: Michel Dänzer --- src/amdgpu_glamor.c | 3 --- src/amdgpu_kms.c| 23 +-- 2 files changed, 13 insertions(+),

Re: [PATCH 4/6] drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 03:34 PM, Alex Deucher wrote: Lots more common stuff. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 103 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h

Re: [PATCH 6/6] drm/amdgpu/gfx: consolidate mqd buffer setup code

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 03:34 PM, Alex Deucher wrote: It was duplicated across multiple generations. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 66 ++

Re: [PATCH 5/6] drm/amdgpu/gfx: move mec parameter setup into sw_init

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 03:34 PM, Alex Deucher wrote: This will allow us to share more mec code. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 30 +--

Re: [PATCH 2/6] drm/amdgpu/gfx9: remove spurious line in kiq setup

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 03:34 PM, Alex Deucher wrote: This overrode what queue was actually assigned for kiq. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 3/6] drm/amdgpu: move mec queue helpers to amdgpu_gfx.h

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 03:34 PM, Alex Deucher wrote: They are gfx related, not general helpers. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 30 --

Re: [PATCH 1/6] drm/amdgpu/gfx8: whitespace change

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 03:34 PM, Alex Deucher wrote: Make it consistent. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu: add virtual display support for raven

2017-06-07 Thread Alex Deucher
Same as other asics. If enabled, exposes a user selectable number of virtual displays. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c

[PATCH 2/2] drm/amdgpu: drop deprecated drm_get_pci_dev and drm_put_dev

2017-06-07 Thread Alex Deucher
Open code them so we can adjust the order in the driver more easily. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] drm/amdgpu: call pci_[un]register_driver() directly

2017-06-07 Thread Alex Deucher
Rather than calling the deprecated drm_pci_init() and drm_pci_exit() which just wrapped the pci functions anyway. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 5/6] drm/amdgpu/gfx: move mec parameter setup into sw_init

2017-06-07 Thread Alex Deucher
This will allow us to share more mec code. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 30 +-- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 38 +-- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c |

[PATCH 6/6] drm/amdgpu/gfx: consolidate mqd buffer setup code

2017-06-07 Thread Alex Deucher
It was duplicated across multiple generations. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 66 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 4 ++ drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 71

[PATCH 2/6] drm/amdgpu/gfx9: remove spurious line in kiq setup

2017-06-07 Thread Alex Deucher
This overrode what queue was actually assigned for kiq. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index

[PATCH 1/6] drm/amdgpu/gfx8: whitespace change

2017-06-07 Thread Alex Deucher
Make it consistent. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index cfa37f1..8d39e7d 100644

[PATCH 3/6] drm/amdgpu: move mec queue helpers to amdgpu_gfx.h

2017-06-07 Thread Alex Deucher
They are gfx related, not general helpers. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 30 -- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h| 30

[PATCH 4/6] drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c

2017-06-07 Thread Alex Deucher
Lots more common stuff. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 103 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 11 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 110 ++--

Re: [PATCH 3/3] drm/amdgpu/gfx9: Raven has two MECs

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 11:10 AM, Alex Deucher wrote: This was missed when Andres' queue patches were rebased. Fixes: 42794b27 (drm/amdgpu: take ownership of per-pipe configuration v3) Signed-off-by: Alex Deucher ---

Re: [PATCH 2/3] drm/amdgpu: move gfx_v*_0_compute_queue_acquire to common code

2017-06-07 Thread axie
Reviewed-by: Alex Xie On 2017-06-07 11:10 AM, Alex Deucher wrote: Same function was duplicated in all gfx IP files. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 37 +++

Re: [PATCH 1/3] drm/amdgpu: fix mec queue policy on single MEC asics

2017-06-07 Thread axie
Hi Alex I agree that we revert the change for single MEC for the time being. Reviewed-by: Alex Xie On 2017-06-07 11:10 AM, Alex Deucher wrote: Fixes hangs on single MEC asics. Fixes: 2ed286fb434 (drm/amdgpu: new queue policy, take first 2 queues of each pipe v2)

Re: [PATCH 1/3] drm/amdgpu: fix mec queue policy on single MEC asics

2017-06-07 Thread axie
Hi Alex, In Catalyst driver source code, Stoney is listed as supported, I don't know how well it is supported though. I think at least people have run some graphic operations. What kind of hangs happens in Stoney? Is it a graphic operation hang? Or OpenCL? Or something else? How easily it

RE: [PATCH 1/3] drm/amdgpu: fix mec queue policy on single MEC asics

2017-06-07 Thread Deucher, Alexander
> -Original Message- > From: Xie, AlexBin > Sent: Wednesday, June 07, 2017 12:31 PM > To: Alex Deucher; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 1/3] drm/amdgpu: fix mec queue policy on single MEC > asics > > Hi Alex, > > In closed source driver, we

Re: [PATCH 1/3] drm/amdgpu: fix mec queue policy on single MEC asics

2017-06-07 Thread axie
Hi Alex, In closed source driver, we assign compute queues to all 4 pipes always. There is no hangs. May I know which ASIC? Assign all queues in first pipe first mec can slow things down. Thanks, Alex Bin Xie On 2017-06-07 11:10 AM, Alex Deucher wrote: Fixes hangs on single MEC asics.

RE: [PATCH 2/3] drm/amdgpu: move gfx_v*_0_compute_queue_acquire to common code

2017-06-07 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Wednesday, June 07, 2017 12:01 PM > To: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/3] drm/amdgpu: move > gfx_v*_0_compute_queue_acquire to common code > > Hi

Re: [PATCH 2/3] drm/amdgpu: move gfx_v*_0_compute_queue_acquire to common code

2017-06-07 Thread Tom St Denis
Hi Alex, This failed to apply on top of amd-staging-4.11... Am I trying the wrong branch? Cheers, Tom On 07/06/17 11:10 AM, Alex Deucher wrote: Same function was duplicated in all gfx IP files. Signed-off-by: Alex Deucher ---

Re: [PATCH libdrm v6 1/1] amdgpu: move asic id table to a separate file

2017-06-07 Thread Michel Dänzer
On 07/06/17 08:12 PM, Emil Velikov wrote: > On 7 June 2017 at 09:40, Michel Dänzer wrote: >> On 06/06/17 10:43 PM, Emil Velikov wrote: >>> On 31 May 2017 at 21:22, Samuel Li wrote: >>> --- /dev/null +++ b/amdgpu/amdgpu_asic_id.c >>> +static

[PATCH 1/3] drm/amdgpu: fix mec queue policy on single MEC asics

2017-06-07 Thread Alex Deucher
Fixes hangs on single MEC asics. Fixes: 2ed286fb434 (drm/amdgpu: new queue policy, take first 2 queues of each pipe v2) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 12 +--- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 12 +---

[PATCH 3/3] drm/amdgpu/gfx9: Raven has two MECs

2017-06-07 Thread Alex Deucher
This was missed when Andres' queue patches were rebased. Fixes: 42794b27 (drm/amdgpu: take ownership of per-pipe configuration v3) Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/3] drm/amdgpu: move gfx_v*_0_compute_queue_acquire to common code

2017-06-07 Thread Alex Deucher
Same function was duplicated in all gfx IP files. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 37 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 ++ drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 39

[PATCH] drm/amd/amdkcl: fix drm-get-put.cocci warnings

2017-06-07 Thread Julia Lawall
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci CC: annwang Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu

[PATCH] drm/amdgpu: fix drm-get-put.cocci warnings

2017-06-07 Thread Julia Lawall
Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and drm_*_unreference() helpers. Generated by: scripts/coccinelle/api/drm-get-put.cocci CC: Christian König Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu

Re: [PATCH libdrm v6 1/1] amdgpu: move asic id table to a separate file

2017-06-07 Thread Emil Velikov
On 7 June 2017 at 09:40, Michel Dänzer wrote: > On 06/06/17 10:43 PM, Emil Velikov wrote: >> On 31 May 2017 at 21:22, Samuel Li wrote: >> >>> --- /dev/null >>> +++ b/amdgpu/amdgpu_asic_id.c >> >>> +static int parse_one_line(const char *line, struct

Re: [PATCH libdrm v6 1/1] amdgpu: move asic id table to a separate file

2017-06-07 Thread Michel Dänzer
On 06/06/17 10:43 PM, Emil Velikov wrote: > On 31 May 2017 at 21:22, Samuel Li wrote: > >> --- /dev/null >> +++ b/amdgpu/amdgpu_asic_id.c > >> +static int parse_one_line(const char *line, struct amdgpu_asic_id *id) >> +{ >> + char *buf, *saveptr; >> + char *s_did;