Re: [PATCH 2/2] drm/amdgpu: Optimize mutex usage (v2)

2017-06-15 Thread Michel Dänzer
On 16/06/17 02:03 PM, Alex Xie wrote: > Use rw_semaphore instead of mutex for bo_lists. > > In original function amdgpu_bo_list_get, the waiting > for result->lock can be quite long while mutex > bo_list_lock was holding. It can make other tasks > waiting for bo_list_lock for long period too. >

[PATCH 1/2] drm/amdgpu: Optimization of AMDGPU_BO_LIST_OP_CREATE (v2)

2017-06-15 Thread Alex Xie
v2: Remove duplication of zeroing of bo list (Christian König) Move idr_alloc function to end of ioctl (Christian König) Call kfree bo_list when amdgpu_bo_list_set return error. Combine the previous two patches into this patch. Add amdgpu_bo_list_set function prototype.

[PATCH 2/2] drm/amdgpu: Optimize mutex usage (v2)

2017-06-15 Thread Alex Xie
Use rw_semaphore instead of mutex for bo_lists. In original function amdgpu_bo_list_get, the waiting for result->lock can be quite long while mutex bo_list_lock was holding. It can make other tasks waiting for bo_list_lock for long period too. Change bo_list_lock to rw_semaphore can avoid most of

[PATCH 2/2] amdgpu: use drm sync objects for shared semaphores (v5)

2017-06-15 Thread Dave Airlie
From: Dave Airlie This creates a new command submission chunk for amdgpu to add in and out sync objects around the submission. Sync objects are managed via the drm syncobj ioctls. The command submission interface is enhanced with two new chunks, one for syncobj pre

[PATCH 1/2] amdgpu/cs: split out fence dependency checking (v2)

2017-06-15 Thread Dave Airlie
From: Dave Airlie This just splits out the fence depenency checking into it's own function to make it easier to add semaphore dependencies. v2: rebase onto other changes. v1-Reviewed-by: Christian König Signed-off-by: Dave Airlie

Re: [PATCH] drm/amdgpu: don't check the default value for vm size

2017-06-15 Thread Michel Dänzer
On 16/06/17 07:21 AM, Alex Deucher wrote: > Avoids printing spurious messages like this: > [3.102059] amdgpu :01:00.0: VM size (-1) must be a power of 2 > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 > 1 file

[PATCH] drm/radeon: remove unnecessary variable in si_enable_smc_cac

2017-06-15 Thread Gustavo A. R. Silva
Remove unnecessary variable smc_result and simplify the logic related. Variable smc_result is only being used to store the return value of function si_send_msg_to_smc() and then compare this value against constant PPSMC_Result_OK. In other cases this variable is not even used after storing a

[PATCH] drm/amdgpu: don't check the default value for vm size

2017-06-15 Thread Alex Deucher
Avoids printing spurious messages like this: [3.102059] amdgpu :01:00.0: VM size (-1) must be a power of 2 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 1/3] drm/amdgpu: drop set_vga_render_state from display funcs (v3)

2017-06-15 Thread Alex Deucher
Not used. v2: include DC as well v3: handle vega10/RV Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 -

[PATCH 2/3] drm/amdgpu: remove *_mc_access from display funcs (v3)

2017-06-15 Thread Alex Deucher
These are no longer needed now that we use the fb_location programmed by the vbios. v2: update DC as well v3: handle vega10/RV Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 3/3] drm/amd/dc/dm: remove redundant display structs (v2)

2017-06-15 Thread Alex Deucher
Now that the mc_access functions are gone, we no longer need separate structs for all the different dce families in dm. v2: rebase on vega10/RV Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 105 +- 1 file

Re: [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-15 Thread Andrey Grodzovsky
Just a reminder. Thanks. On 06/09/2017 05:30 PM, Andrey Grodzovsky wrote: Problem: While running IGT kms_atomic_transition test suite i encountered a hang in drmHandleEvent immidietly follwoing an atomic_commit. After dumping the atomic state I relized that in this case there was not even one

RE: [PATCH] drm/amdgpu: drop set_vga_render_state from display funcs

2017-06-15 Thread Deucher, Alexander
> -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Thursday, June 15, 2017 2:56 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu: drop set_vga_render_state from display > funcs > > Not used. > > Reviewed-by:

[PATCH] drm/amdgpu: drop set_vga_render_state from display funcs

2017-06-15 Thread Alex Deucher
Not used. Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 -- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 -

RE: [PATCH umr] Add ability to read/write SMC registers directly

2017-06-15 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Thursday, June 15, 2017 12:54 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH umr] Add ability to read/write SMC registers directly > > On

[PATCH umr] Add ability to read/write SMC registers directly

2017-06-15 Thread Tom St Denis
On SI..VI platforms this allows access to SMC registers without kernel access. Signed-off-by: Tom St Denis --- src/app/main.c| 4 +- src/app/scan.c| 4 +- src/lib/mmio.c| 112 +++--- src/lib/read_sgpr.c

[pull] amdgpu drm-next-4.13

2017-06-15 Thread Alex Deucher
Hi Dave, A few more patches for 4.13. Mostly bug fixes and code cleanup. This is on top of my pull request from last week. The following changes since commit b58c11314a1706bf094c489ef5cb28f76478c704: drm/amdgpu: drop deprecated drm_get_pci_dev and drm_put_dev (2017-06-08 10:54:39 -0400)

Re: [PATCH umr] Don't read SGPR if wave isn't halted.

2017-06-15 Thread Xie, AlexBin
Reviewed-by: Alex Xie From: amd-gfx on behalf of Tom St Denis Sent: Thursday, June 15, 2017 8:14:51 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis,

[PATCH] drm/amdgpu: adjust default display clock

2017-06-15 Thread Alex Deucher
Increase the default display clock on newer asics to accomodate some high res modes with really high refresh rates. bug: https://bugs.freedesktop.org/show_bug.cgi?id=93826 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org ---

[PATCH] drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating

2017-06-15 Thread Alex Deucher
We were using the wrong structure which lead to an overflow on some boards. bug: https://bugs.freedesktop.org/show_bug.cgi?id=101387 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 4 ++-- 1 file changed, 2

Re: [Intel-gfx] [PATCH i-g-t] tests: Rename I915_MAX_PIPES to IGT_MAX_PIPES

2017-06-15 Thread Leo
On 2017-06-13 08:55 AM, Arkadiusz Hiler wrote: On Tue, Jun 13, 2017 at 03:41:14PM +0300, Arkadiusz Hiler wrote: On Tue, Jun 13, 2017 at 10:35:34AM +0300, Jani Nikula wrote: On Mon, 12 Jun 2017, Harry Wentland wrote: The email was sent but might be stuck in the

Re: amdgpu display corruption and hang on AMD A10-9620P

2017-06-15 Thread Carlo Caione
On Mon, Jun 12, 2017 at 12:24 PM, Carlo Caione wrote: > On Tue, May 9, 2017 at 7:03 PM, Deucher, Alexander > wrote: >>> -Original Message- >>> From: Daniel Drake [mailto:dr...@endlessm.com] >>> Sent: Tuesday, May 09, 2017 12:55 PM >>> To:

[PATCH umr] Don't read SGPR if wave isn't halted.

2017-06-15 Thread Tom St Denis
On previous generations this was allowed but on Vega10 it will result in the occasional system hang. Also like others wave status reading is only reliable if 1) the waves are halted/hung (core is active) 2) or, you disable CG/PG with cg_mask=pg_mask=0 Even with this patch hangs are possible if

Re: [PATCH libdrm v8] amdgpu: move asic id table to a separate file

2017-06-15 Thread Michel Dänzer
On 15/06/17 04:42 PM, Emil Velikov wrote: > On 15 June 2017 at 04:16, Michel Dänzer wrote: >> On 14/06/17 08:34 PM, Emil Velikov wrote: >> >>> Personally I would not have bothered with the table_max_size thing >> >> It seemed silly to reallocate the memory in the default case

Re: [PATCH libdrm v8] amdgpu: move asic id table to a separate file

2017-06-15 Thread Emil Velikov
On 15 June 2017 at 04:16, Michel Dänzer wrote: > On 14/06/17 08:34 PM, Emil Velikov wrote: >> On 13 June 2017 at 10:45, Michel Dänzer wrote: >>> From: Xiaojie Yuan >>> >>> v2: fix an off by one error and leading white spaces >>> v3: