Re: [PATCH libdrm] amdgpu: update always on cu bitmap

2017-06-20 Thread Flora Cui
each SE take 16 bit in cu_ao_mask. For ASICs with 4 SE, cu_ao_mask has invalid value. so I change cu_ao_mask to cu_ao_bitmap[4][4] and increase kmd driver version. On Tue, Jun 20, 2017 at 11:49:23AM +0200, Christian König wrote: > I'm not 100% sure what this is all about, but it clearly won't work

[PATCH 3/4] drm/amdgpu: Allow vblank_disable_immediate.

2017-06-20 Thread Mario Kleiner
With instantaneous high precision vblank timestamping that updates at leading edge of vblank, a cooked hw vblank counter which increments at leading edge of vblank, and reliable page flip execution and completion at leading edge of vblank, we should meet the requirements for fast/immediate vblank i

[PATCH 1/4] drm/vc4: Allow vblank_disable_immediate on non-fw-kms.

2017-06-20 Thread Mario Kleiner
With instantaneous high precision vblank timestamping that updates at leading edge of vblank, the emulated "hw vblank counter" from vblank timestamping which increments at leading edge of vblank, and reliable page flip execution and completion at leading edge of vblank, we should meet the requireme

Enable vblank_disable_immediate on more drivers.

2017-06-20 Thread Mario Kleiner
This patch series sets dev->vblank_disable_immediate = true on radeon/amdgpu-kms, nouveau-kms for nv50+, and vc4 for the real kms driver (as opposed to dispmanx firmware backed kms). All the drivers should be ready in theory, given their implementation, for fast vblank disable/enable. In practice,

[PATCH 2/4] drm/radeon: Allow vblank_disable_immediate.

2017-06-20 Thread Mario Kleiner
With instantaneous high precision vblank timestamping that updates at leading edge of vblank, a cooked hw vblank counter which increments at leading edge of vblank, and reliable page flip execution and completion at leading edge of vblank, we should meet the requirements for fast/immediate vblank i

[PATCH 4/4] drm/nouveau/kms/nv50-: Allow vblank_disable_immediate.

2017-06-20 Thread Mario Kleiner
With instantaneous high precision vblank timestamping that updates at leading edge of vblank, the emulated "hw vblank counter" from vblank timestamping, which increments at leading edge of vblank, and reliable page flip execution and completion at leading edge of vblank, we should meet the requirem

[PATCH 11/11] drm: remove unused and redundant callbacks

2017-06-20 Thread Peter Rosin
Drivers no longer have any need for these callbacks, and there are no users. Zap. Zap-zap-zzzap-p-pp-p. Signed-off-by: Peter Rosin --- include/drm/drm_fb_helper.h | 32 include/drm/drm_modeset_helper_vtables.h | 16 2 files changed,

[PATCH 07/11] drm: mgag200: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/mgag200/mgag200_drv.h | 5 --- dr

[PATCH 03/11] drm: ast: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/ast/ast_drv.h | 1 - drivers/gpu/

[PATCH 02/11] drm: amd: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 24 -

[PATCH 04/11] drm: cirrus: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/cirrus/cirrus_drv.h | 8 dr

[PATCH 00/11] improve the fb_setcmap helper

2017-06-20 Thread Peter Rosin
Hi! While trying to get CLUT support for the atmel_hlcdc driver, and specifically for the emulated fbdev interface, I received some push-back that my feeble in-driver attempts should be solved by the core. This is my attempt to do it right. Boris and Daniel, was this approximately what you had in

[PATCH 06/11] drm: i915: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The driver stores lut values from the fbdev interface, and is able to give them back, but does not appear to do anything with these lut values. The generic fb helpers have replaced this function, and may even have made the driver work for the C8 mode from the fbdev interface. But that is untested.

[PATCH 10/11] drm: stm: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helper .load_lut is no longer used, and can not work right without also providing the fb helpers .gamma_set and .gamma_get thus rendering the code in this driver suspect. Just remove the dead code. Signed-off-by: Peter Rosin --- drivers/gpu/drm/stm/ltdc.c | 12 dri

[PATCH 08/11] drm: nouveau: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 26 ++

[PATCH 09/11] drm: radeon: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. Signed-off-by: Peter Rosin --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 -

[PATCH 01/11] drm/fb-helper: do a generic fb_setcmap helper in terms of crtc .gamma_set

2017-06-20 Thread Peter Rosin
This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get totally obsolete. I think the gamma_store can end up invalid on error. But the way I read it, that can happen in drm_mode_gamma_set_ioctl as well, so why should this pesky legacy fbdev stuff be any better? drm_fb_helper_save

[PATCH 05/11] dmr: gma500: remove dead code and pointless local lut storage

2017-06-20 Thread Peter Rosin
The redundant fb helpers .gamma_set and .gamma_get are no longer used. Remove the dead code and hook up the crtc .gamma_set to use the crtc gamma_store directly instead of duplicating that info locally. It is a bit strange that the fb helper .load_lut was not hooked up, so this change may well mak

Re: [Intel-gfx] [PATCH i-g-t] test/kms_properties.c: fix connector-properties

2017-06-20 Thread Harry Wentland
On 2017-06-20 03:03 PM, Ville Syrjälä wrote: > On Tue, Jun 20, 2017 at 02:27:38PM -0400, Bhawanpreet Lakha wrote: >> The test doesn't consider immutable properties >> >> Legacy Test: The test trys to set the property, but if the property >> is immutable the test fails. >>

Re: [Intel-gfx] [PATCH i-g-t] test/kms_properties.c: fix connector-properties

2017-06-20 Thread Ville Syrjälä
On Tue, Jun 20, 2017 at 02:27:38PM -0400, Bhawanpreet Lakha wrote: > The test doesn't consider immutable properties > > Legacy Test: The test trys to set the property, but if the property > is immutable the test fails. > Added conditions to check if the pr

[PATCH i-g-t] test/kms_properties.c: fix connector-properties

2017-06-20 Thread Bhawanpreet Lakha
The test doesn't consider immutable properties Legacy Test: The test trys to set the property, but if the property is immutable the test fails. Added conditions to check if the property is immutable. Atomic Test: The immutable properties are added and

[PATCH umr] Add --update demo

2017-06-20 Thread Tom St Denis
In this commit we add a demo that reads the NB voltage sensor on a Carrizo in shell script. Signed-off-by: Tom St Denis --- demo/update/carrizo.update | 4 demo/update/read_sensor.sh | 17 + 2 files changed, 21 insertions(+) create mode 100644 demo/update/carrizo.update c

[PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-20 Thread Andrey Grodzovsky
Problem : While running IGT kms_atomic_transition test suite i encountered a hang in drmHandleEvent immediately following an atomic_commit. After dumping the atomic state I relized that in this case there was not even one CRTC attached to the state and only disabled planes. This probably due to a

[pull] radeon and amdgpu drm-fixes-4.12

2017-06-20 Thread Alex Deucher
Hi Dave, A few fixes for 4.12: - Add a new Polaris12 pci id - A stack corruption fix - Suspend/resume fix - PX fix - Display flickering fix The following changes since commit 7119dbdf7c52042acb1b02f116fa3257e97659ea: Merge tag 'drm-intel-fixes-2017-06-15' of git://anongit.freedesktop.org/git/

[PATCH] drm/radeon: add a PX quirk for another K53TK variant

2017-06-20 Thread Alex Deucher
Disable PX on these systems. bug: https://bugs.freedesktop.org/show_bug.cgi?id=101491 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_device.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/radeon/rade

[PATCH] drm/radeon: add a quirk for Toshiba Satellite L20-183

2017-06-20 Thread Alex Deucher
Fixes resume from suspend. bug: https://bugzilla.kernel.org/show_bug.cgi?id=196121 Reported-by: Przemek Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/radeon_combios.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_com

Re: [PATCH] drm/amdgpu: export gpu always on cu bitmap

2017-06-20 Thread Alex Deucher
On Tue, Jun 20, 2017 at 4:15 AM, Flora Cui wrote: > Change-Id: I056d8af23340d46e5140bd10cc38dfb887cc78ab > Signed-off-by: Flora Cui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 7 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- >

Re: GART write flush error on SI w/ amdgpu

2017-06-20 Thread Marek Olšák
On Tue, Jun 20, 2017 at 1:46 PM, Christian König wrote: > Am 20.06.2017 um 12:34 schrieb Marek Olšák: >> >> BTW, I noticed the flush sequence in the kernel is wrong. The correct >> flush sequence should be: >> >> 1) EVENT_WRITE_EOP - CACHE_FLUSH_AND_INV_TS - write a dword to memory, >> but no fenc

Re: GART write flush error on SI w/ amdgpu

2017-06-20 Thread Marek Olšák
On Tue, Jun 20, 2017 at 1:49 PM, Nicolai Hähnle wrote: > On 20.06.2017 12:34, Marek Olšák wrote: >> >> BTW, I noticed the flush sequence in the kernel is wrong. The correct >> flush sequence should be: >> >> 1) EVENT_WRITE_EOP - CACHE_FLUSH_AND_INV_TS - write a dword to memory, >> but no fence/int

Re: GART write flush error on SI w/ amdgpu

2017-06-20 Thread Nicolai Hähnle
On 20.06.2017 12:34, Marek Olšák wrote: BTW, I noticed the flush sequence in the kernel is wrong. The correct flush sequence should be: 1) EVENT_WRITE_EOP - CACHE_FLUSH_AND_INV_TS - write a dword to memory, but no fence/interrupt. 2) WAIT_REG_MEM on the dword to wait for idle before SURFACE_SYNC

Re: GART write flush error on SI w/ amdgpu

2017-06-20 Thread Christian König
Am 20.06.2017 um 12:34 schrieb Marek Olšák: BTW, I noticed the flush sequence in the kernel is wrong. The correct flush sequence should be: 1) EVENT_WRITE_EOP - CACHE_FLUSH_AND_INV_TS - write a dword to memory, but no fence/interrupt. 2) WAIT_REG_MEM on the dword to wait for idle before SURFACE_

Re: Atomic commit on planes with more than one possible CRTC's

2017-06-20 Thread Arkadiusz Hiler
On Fri, Jun 16, 2017 at 03:51:27PM -0400, Leo wrote: > Hello, > > > I'm looking for ideas and suggestions on how to enable IGT to work on > planes with multiple possible_crtcs during atomic commit. Amdgpu > currently has features that rely on this, and planes with multiple > crtc's are not being

Re: GART write flush error on SI w/ amdgpu

2017-06-20 Thread Marek Olšák
BTW, I noticed the flush sequence in the kernel is wrong. The correct flush sequence should be: 1) EVENT_WRITE_EOP - CACHE_FLUSH_AND_INV_TS - write a dword to memory, but no fence/interrupt. 2) WAIT_REG_MEM on the dword to wait for idle before SURFACE_SYNC. 3) SURFACE_SYNC (TC, K$, I$) 4) Write CP

Re: [PATCH libdrm] amdgpu: update always on cu bitmap

2017-06-20 Thread Daniel Vetter
On Tue, Jun 20, 2017 at 11:49:23AM +0200, Christian König wrote: > I'm not 100% sure what this is all about, but it clearly won't work like > this. > > > diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h > > index df250de..dcbe22c 100644 > > --- a/include/drm/amdgpu_drm.h > > +++ b/

Re: [PATCH libdrm] amdgpu: update always on cu bitmap

2017-06-20 Thread Christian König
I'm not 100% sure what this is all about, but it clearly won't work like this. diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index df250de..dcbe22c 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -832,7 +832,7 @@ struct drm_amdgpu_info_device {

Re: [Intel-gfx] [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-20 Thread Daniel Vetter
On Mon, Jun 19, 2017 at 04:11:35PM -0400, Andrey Grodzovsky wrote: > > > On 06/19/2017 03:24 PM, Sean Paul wrote: > > On Mon, Jun 19, 2017 at 11:35:28AM -0400, Harry Wentland wrote: > > > On 2017-06-09 05:30 PM, Andrey Grodzovsky wrote: > > > > Problem: > > > > While running IGT kms_atomic_transi

[PATCH libdrm] amdgpu: update always on cu bitmap

2017-06-20 Thread Flora Cui
Change-Id: Ie2a812716a6802f7a5a0bc09b1a8db824c5bf2ed Signed-off-by: Flora Cui --- amdgpu/amdgpu.h | 2 +- amdgpu/amdgpu_gpu_info.c | 2 +- include/drm/amdgpu_drm.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index b6779f9..34ca

Re: [PATCH] drm/amdgpu: adjust default display clock

2017-06-20 Thread Christian König
This one and "drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating" is Acked-by: Christian König as well. But you might want to ping somebody from the display side to ack as well. Regards, Christian. Am 20.06.2017 um 04:40 schrieb zhoucm1: Acked-by: Chunming Zhou On 2017年06月2

[PATCH] drm/amdgpu: export gpu always on cu bitmap

2017-06-20 Thread Flora Cui
Change-Id: I056d8af23340d46e5140bd10cc38dfb887cc78ab Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 7 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 4 +++- drivers/gpu/dr