Re: [PATCH] drm/amdgpu: Free resources of bo_list when idr_alloc fails

2017-07-05 Thread zhoucm1
Reviewed-by: Chunming Zhou On 2017年07月06日 06:27, Alex Xie wrote: Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c

RE: [PATCH] drm/amd/powerplay: fixed wrong data type declaration for ppfeaturemask

2017-07-05 Thread Zhu, Rex
Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Evan Quan Sent: Thursday, July 06, 2017 10:02 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay:

[PATCH] drm/amd/powerplay: fixed wrong data type declaration for ppfeaturemask

2017-07-05 Thread Evan Quan
Change-Id: Icbe9fa02e653edf365880fc03089e5cf01716d52 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

RE: [PATCH 2/3] drm/amdgpu/atomfirmware: implement vram_width for APUs

2017-07-05 Thread Zhang, Hawking
Series are Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Thursday, July 06, 2017 3:51 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

[PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-05 Thread Dave Airlie
From: Dave Airlie This adds kernel semaphore support to the command submission interface in what should be a backwards compatible manner, it adds a new command submission API. Signed-off-by: Dave Airlie --- amdgpu/amdgpu.h| 29 -

[PATCH] drm/syncobj: add sync obj wait interface. (v6)

2017-07-05 Thread Dave Airlie
From: Dave Airlie This interface will allow sync object to be used to back Vulkan fences. This API is pretty much the vulkan fence waiting API, and I've ported the code from amdgpu. v2: accept relative timeout, pass remaining time back to userspace. v3: return to absolute

[PATCH] drm/amdgpu: Free resources of bo_list when idr_alloc fails

2017-07-05 Thread Alex Xie
Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c index efa6903..dc87962 100644 ---

RE: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-05 Thread Li, Samuel
> - above all, as-is make check will fail Right, I did not check that. > - keeping the radeon API symmetrical to the amdgpu one would a good idea The issue is Radeon does not have a struct similar to amdgpu_device_handle. I think the current radeon API is simpler. Maybe a follow up

Re: [Intel-gfx] [PATCH v3 00/16] improve the fb_setcmap helper

2017-07-05 Thread Daniel Vetter
On Wed, Jul 05, 2017 at 10:09:21AM +0200, Peter Rosin wrote: > On 2017-07-05 08:08, Daniel Vetter wrote: > > On Tue, Jul 04, 2017 at 12:36:56PM +0200, Peter Rosin wrote: > >> Hi! > >> > >> While trying to get CLUT support for the atmel_hlcdc driver, and > >> specifically for the emulated fbdev

[PATCH 2/3] drm/amdgpu/atomfirmware: implement vram_width for APUs

2017-07-05 Thread Alex Deucher
Implement support using the new atomfirmware system info table. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 33 drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.h | 1 + 2 files changed, 34 insertions(+)

[PATCH 1/3] drm/amdgpu/atom: fix atom_fw check

2017-07-05 Thread Alex Deucher
Not all vbios images seem to set the version appropriately. Switch the check based on asic type instead. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git

[PATCH 3/3] drm/amdgpu/gmc9: get vram width from atom for Raven

2017-07-05 Thread Alex Deucher
Get it from the system info table. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 76 ++- 1 file changed, 40 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

[pull] amdgpu drm-next-4.13

2017-07-05 Thread Alex Deucher
Hi Dave, Fixes for 4.13: - Various fixes for Raven - Various fixes for Vega10 - Stability fixes for KIQ - Fix reloading the driver - Fix S3 on vega10 - Misc other fixes The following changes since commit 12d016626f99f48edbf5b006625b4e8c0de1eec7: Merge tag 'drm-amdkfd-next-2017-06-25' of

RE: [PATCH] drm/amdgpu: NO KIQ usage on nbio hdp flush routine

2017-07-05 Thread Liu, Shaoyun
Let me try again. Shaoyun.liu -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, July 05, 2017 1:15 PM To: Liu, Shaoyun Cc: Deucher, Alexander; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: NO KIQ usage on nbio hdp flush routine On

Re: [PATCH] drm/amdgpu: NO KIQ usage on nbio hdp flush routine

2017-07-05 Thread Alex Deucher
On Wed, Jul 5, 2017 at 11:04 AM, Liu, Shaoyun wrote: > Thanks . > Split the change as suggested and pushed . Doesn't look like the second patch landed yet. I don't see in queued in gerrit either. Alex > > Regards > Shaoyun.liu > > -Original Message- > From:

RE: [PATCH] drm/amdgpu: Make KIQ read/write register routine be atomic

2017-07-05 Thread Liu, Shaoyun
It's inside the gmc_v9_0_gart_flush_gpu_tlb function where it calls the nbio_v6_0_hdp_flush . I already sent out the commit for review .you can check for details . Regards Shaoyun.liu From: Liu, Monk Sent: Tuesday, July 04, 2017 11:26 PM To: Liu, Shaoyun; Christian König; Michel Dänzer Cc:

Re: The amd-stagint-4.11 doen't contain the commit ab51ee31dda1a37b473074e402394f879c51d591 in amd-staging-4.9

2017-07-05 Thread Christian König
Well the switch over to 4.11 was made in quite a haste while Alex was on vacation. I've did my best to cherry-pick everything over from 4.9 to 4.11, but it is entirely possible that the patch was either missed accidentally or committed after the switch to 4.11. Christian. Am 05.07.2017 um

Re: [Intel-gfx] [PATCH v3 00/16] improve the fb_setcmap helper

2017-07-05 Thread Peter Rosin
On 2017-07-05 08:08, Daniel Vetter wrote: > On Tue, Jul 04, 2017 at 12:36:56PM +0200, Peter Rosin wrote: >> Hi! >> >> While trying to get CLUT support for the atmel_hlcdc driver, and >> specifically for the emulated fbdev interface, I received some >> push-back that my feeble in-driver attempts

RE: The amd-stagint-4.11 doen't contain the commit ab51ee31dda1a37b473074e402394f879c51d591 in amd-staging-4.9

2017-07-05 Thread Deucher, Alexander
I guess it was just missed? Was it committed before we switched to 4.11? Once we switched to 4.11, all teams are responsible for making sure they land their patches in the current staging branch. Alex From: Liu, Monk Sent: Tuesday, July 04, 2017 11:55 PM To: Deng, Emily; Deucher, Alexander

RE: [PATCH] drm/amdgpu: NO KIQ usage on nbio hdp flush routine

2017-07-05 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Shaoyun Liu > Sent: Tuesday, July 04, 2017 2:33 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Shaoyun > Subject: [PATCH] drm/amdgpu: NO KIQ usage on nbio hdp flush routine > > nbio hdp

[PATCH umr] Improve --lookup command to allow register names.

2017-07-05 Thread Tom St Denis
This is handy if you are given a debug output with a register name and value you want to decode. For instance, a VM fault in the kernel log, $ umr -i 1 -O bits --lookup mmVM_CONTEXT1_PROTECTION_FAULT_STATUS 0x0803D00C gmc81.mmVM_CONTEXT1_PROTECTION_FAULT_STATUS => 0x0803d00c

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 11:44, Chih-Wei Huang wrote: > 2017-07-05 17:35 GMT+08:00 Emil Velikov : >> On 4 July 2017 at 07:40, Chih-Wei Huang wrote: >>> >>> Unfortunately this patch breaks Android build >>> since the two macros

Re: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-05 Thread Emil Velikov
Hi Samuel, On 30 June 2017 at 20:25, Samuel Li wrote: > Change-Id: I24b6624789d1a9dc0fd3a446b0e6f21ed5183ff2 > Signed-off-by: Samuel Li > --- > radeon/Makefile.am | 6 +++ > radeon/Makefile.sources | 6 ++- > radeon/radeon_asic_id.c | 106 >

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-05 Thread Chih-Wei Huang
2017-07-05 17:35 GMT+08:00 Emil Velikov : > On 4 July 2017 at 07:40, Chih-Wei Huang wrote: >> >> Unfortunately this patch breaks Android build >> since the two macros are not defined. >> >> Anyone is working on a fix? >> If not, I'll try to

Re: [PATCH libdrm 1/2] util: move some files to an ASIC neutral directory.

2017-07-05 Thread Emil Velikov
On 30 June 2017 at 20:24, Samuel Li wrote: Commit message should explain why we want this - aka "Will be reused in radeon with a later commit" > Change-Id: Iac1c4870253e8b8860a61b7cf175e7a25cc95921 > Signed-off-by: Samuel Li > --- > Makefile.sources

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-05 Thread Emil Velikov
On 4 July 2017 at 07:40, Chih-Wei Huang wrote: > 2017-06-12 17:50 GMT+08:00 Michel Dänzer : >> From: Xiaojie Yuan >> >> v2: fix an off by one error and leading white spaces >> v3: use thread safe strtok_r(); initialize len before

Re: [PATCH 07/11] drm/amdgpu: rename GART to SYSVM

2017-07-05 Thread Christian König
Am 05.07.2017 um 02:57 schrieb Michel Dänzer: On 05/07/17 06:11 AM, Felix Kuehling wrote: I'm afraid this will lead to more confusion when talking to different teams in AMD. At least to me "GART" was always understood to be the system-wide address translation table (VMID-0). The remnant from

Re: [PATCH v2 1/3] drm/amdgpu: remove superfluous check

2017-07-05 Thread Christian König
Patch #1 and #2 are Reviewed-by: Christian König . Patch #3 is Acked-by: Christian König . Regards, Christian. Am 05.07.2017 um 07:32 schrieb Huang Rui: Signed-off-by: Huang Rui --- Changes from V1 -> V2 -

RE: The amd-stagint-4.11 doen't contain the commit ab51ee31dda1a37b473074e402394f879c51d591 in amd-staging-4.9

2017-07-05 Thread Yu, Xiangliang
Please check it with Evan, I remember he remind us to switch to staing-4.11 From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Liu, Monk Sent: Wednesday, July 05, 2017 11:55 AM To: Deng, Emily ; Deucher, Alexander Cc:

Re: [Intel-gfx] [PATCH v3 00/16] improve the fb_setcmap helper

2017-07-05 Thread Daniel Vetter
On Tue, Jul 04, 2017 at 12:36:56PM +0200, Peter Rosin wrote: > Hi! > > While trying to get CLUT support for the atmel_hlcdc driver, and > specifically for the emulated fbdev interface, I received some > push-back that my feeble in-driver attempts should be solved > by the core. This is my attempt