[PATCH] drm/amdgpu: drop old ip definitions for gfxhub and mmhub

2017-07-27 Thread Alex Deucher
The gfxhub and mmhub code are now helpers for gmc rather than standalone IPs. When that changes these were left over. Remove them. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.h | 2 -- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.h | 3 --- 2 files changed, 5 deletions(-)

Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

2017-07-27 Thread Alex Deucher
On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook wrote: > As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use > designated initializers") mark other tableFunction entries with designated > initializers. The randstruct plugin requires designated initializers for > structures that are entir

Re: [PATCH 2/5] drm/amdgpu/sdma4: set wptr shadow atomically

2017-07-27 Thread Alex Deucher
On Thu, Jul 27, 2017 at 4:39 PM, Felix Kuehling wrote: > > On 17-07-27 03:46 PM, Alex Deucher wrote: >> No functional change until wptr polling uses this >> location (future patch). >> >> Cc: Frank Min >> Signed-off-by: Alex Deucher >> --- >> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- >>

[PATCH] drm/amdgpu: make wb 256bit function names consistent

2017-07-27 Thread Alex Deucher
Use a lower case b to be consistent with the other wb functions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(

Re: [PATCH 2/5] drm/amdgpu/sdma4: set wptr shadow atomically

2017-07-27 Thread Felix Kuehling
On 17-07-27 03:46 PM, Alex Deucher wrote: > No functional change until wptr polling uses this > location (future patch). > > Cc: Frank Min > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dr

[PATCH 2/2] drm/amdgpu: Support IOMMU on Raven

2017-07-27 Thread Yong Zhao
We achieved that by setting S(SYSTEM) and P(PDE as PTE) bit to 1 for PDEs and setting S bit to 1 for PTEs when the corresponding addresses are not occupied by gpu driver allocated buffers. Change-Id: I52e41b6e93243dbbd08d97781da1c9a60ce1f9a4 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgp

[PATCH 1/2] drm/amdgpu: Add a parameter to amdgpu_bo_create()

2017-07-27 Thread Yong Zhao
The parameter init_value contains the value to which we initialized VRAM bo when AMDGPU_GEM_CREATE_VRAM_CLEARED flag is set. Change-Id: I9ef3b9dd3ca9b98cc25dd2eaff68fbe1129c3e3c Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 4/5] drm/amdgpu/sdma4: drop allocation of poll_mem_offs

2017-07-27 Thread Alex Deucher
We already allocate this as part of the ring structure, use that instead. Cc: Frank Min Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 45 +++--- 2 files changed, 9 insertions(+), 37 deletions(-

[PATCH 5/5] drm/amdgpu/sdma4: move wptr polling setup

2017-07-27 Thread Alex Deucher
Move it up before ring enablement with all of the other engine setup and explicitly disable it for bare metal. Cc: Frank Min Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/driv

[PATCH 2/5] drm/amdgpu/sdma4: set wptr shadow atomically

2017-07-27 Thread Alex Deucher
No functional change until wptr polling uses this location (future patch). Cc: Frank Min Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/a

[PATCH 1/5] drm/amdgpu/sdma4: drop unused register header

2017-07-27 Thread Alex Deucher
nbio registers are not used in this file. Cc: Frank Min Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 5c24708..7cb5320 100644 --- a/

[PATCH 3/5] drm/amdgpu/sdma4: drop hdp flush from wptr shadow update

2017-07-27 Thread Alex Deucher
The wb buffer is in system memory, not vram so the flush is useless. Cc: Frank Min Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 939

RE: [PATCH 2/8] drm/amdgpu: consistent use u64_to_user_ptr

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 2/8] drm/amdgpu: consistent use u64_to_user_ptr > > From: Christian König > >

Re: [pull] radeon and amdgpu drm-next-4.14

2017-07-27 Thread Ferry Huberts
Out of interest as an interested list-reader, How's DC/DAL doing? I know I'd need it if I wanted to run a Vega card and am curious when we could expect it upstream :-) Thanks Ferry On 27/07/17 18:00, Alex Deucher wrote: Hi Dave, New features for 4.14: - Stop reprogramming the MC, the vbios

RE: [PATCH 8/8] drm/amdgpu: use amdgpu_bo_free_kernel more often

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 8/8] drm/amdgpu: use amdgpu_bo_free_kernel more > often > > From: Christian Köni

RE: [PATCH 7/8] drm/amdgpu: use amdgpu_bo_create_kernel more often

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 7/8] drm/amdgpu: use amdgpu_bo_create_kernel more > often > > From: Christian Kö

RE: [PATCH 6/8] drm/amdgpu: add amdgpu_bo_create_reserved

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 6/8] drm/amdgpu: add amdgpu_bo_create_reserved > > From: Christian König > > S

RE: [PATCH 5/8] drm/amdgpu: improve amdgpu_bo_create_kernel

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 5/8] drm/amdgpu: improve amdgpu_bo_create_kernel > > From: Christian König > >

RE: [PATCH 4/8] drm/amdgpu: shadow and mn list are mutal exclusive

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 4/8] drm/amdgpu: shadow and mn list are mutal exclusive mutually > > From: Chr

Re: [PATCH] drm/amdgpu: disable vcn power control for now

2017-07-27 Thread Christian König
Am 27.07.2017 um 19:04 schrieb Alex Deucher: On Thu, Jul 27, 2017 at 12:17 PM, Leo Liu wrote: The dpm control for vcn has been moved to firmware, kernel always spins "amdgpu: [powerplay] pp_dpm_powergate_uvd was not implemented", each time when application runs, disable it for now till pg/cg. A

RE: [PATCH 3/8] drm/amdgpu: move some defines around

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 3/8] drm/amdgpu: move some defines around > > From: Christian König > > Move a

RE: [PATCH 1/8] drm/amdgpu: cleanup kptr handling

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, July 27, 2017 11:44 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/8] drm/amdgpu: cleanup kptr handling > > From: Christian König > > Don't kee

Re: [PATCH] drm/amdgpu: disable vcn power control for now

2017-07-27 Thread Alex Deucher
On Thu, Jul 27, 2017 at 12:17 PM, Leo Liu wrote: > The dpm control for vcn has been moved to firmware, kernel always spins > "amdgpu: [powerplay] pp_dpm_powergate_uvd was not implemented", each > time when application runs, disable it for now till pg/cg. Also remove > clock manual setting when dpm

Re: [PATCH 1/2] drm/amdgpu: Add support for filling a buffer with 64 bit value

2017-07-27 Thread Zhao, Yong
I got it. Thanks Harry. Yong From: Wentland, Harry Sent: Thursday, July 27, 2017 11:48:13 AM To: Zhao, Yong; Christian König; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Add support for filling a buffer with 64 bit value On 2017-07-27 11:

[PATCH] drm/amdgpu: disable vcn power control for now

2017-07-27 Thread Leo Liu
The dpm control for vcn has been moved to firmware, kernel always spins "amdgpu: [powerplay] pp_dpm_powergate_uvd was not implemented", each time when application runs, disable it for now till pg/cg. Also remove clock manual setting when dpm disabled, which was inherited from uvd. Signed-off-by: L

Re: [PATCH 1/2] drm/amdgpu: Add support for filling a buffer with 64 bit value

2017-07-27 Thread Harry Wentland
On 2017-07-27 11:44 AM, Zhao, Yong wrote: > Hi Christian, > > > I used eclipse. The reason why I changed the indent is that the current > indents are composed of tabs and spaces, and I will get style warning > from checkpatch script when trying to submit it to gerrit, so I made the > indents all

[pull] radeon and amdgpu drm-next-4.14

2017-07-27 Thread Alex Deucher
Hi Dave, New features for 4.14: - Stop reprogramming the MC, the vbios already does this in asic_init - Reduce internal gart to 256M (this does not affect the ttm GTT pool size) - Initial support for huge pages - Rework bo migration logic - Lots of improvements for vega10 - Powerplay fixes - Addit

[PATCH umr] Improve NPI support (include/name/family)

2017-07-27 Thread Tom St Denis
Add the ability to include files which is useful for larger asics which can take time to parse. Now you can split it up per IP block and then include multiple IP blocks only when necessary. Also added the ability to assign family IDs (of the UMR enum sort not kernel values) and change the name of

Re: [PATCH] drm/amdgpu: remove unused power control for vcn

2017-07-27 Thread Leo Liu
On 07/26/2017 10:44 PM, Deucher, Alexander wrote: > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Leo Liu > Sent: Wednesday, July 26, 2017 3:08 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Leo > Subject: [PATCH] drm/amdgpu: remove

Re: [PATCH 1/2] drm/amdgpu: Add support for filling a buffer with 64 bit value

2017-07-27 Thread Christian König
Am 27.07.2017 um 17:48 schrieb Harry Wentland: On 2017-07-27 11:44 AM, Zhao, Yong wrote: Hi Christian, I used eclipse. The reason why I changed the indent is that the current indents are composed of tabs and spaces, and I will get style warning from checkpatch script when trying to submit it t

Re: [PATCH 1/2] drm/amdgpu: Add support for filling a buffer with 64 bit value

2017-07-27 Thread Zhao, Yong
Hi Christian, I used eclipse. The reason why I changed the indent is that the current indents are composed of tabs and spaces, and I will get style warning from checkpatch script when trying to submit it to gerrit, so I made the indents all tabs. In this case, should I still use the previous i

[PATCH 6/8] drm/amdgpu: add amdgpu_bo_create_reserved

2017-07-27 Thread Christian König
From: Christian König Same as amdgpu_bo_create_kernel, but keeps the BO reserved. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 48 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 4 +++ 2 files changed, 44 insertions(+), 8 deletio

[PATCH 1/8] drm/amdgpu: cleanup kptr handling

2017-07-27 Thread Christian König
From: Christian König Don't keep around the same pointer twice. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 26 +++--- drivers/gpu/drm/

[PATCH 8/8] drm/amdgpu: use amdgpu_bo_free_kernel more often

2017-07-27 Thread Christian König
From: Christian König Saves us even more loc. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 +- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 37 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 67 +++--- drivers/gp

[PATCH 4/8] drm/amdgpu: shadow and mn list are mutal exclusive

2017-07-27 Thread Christian König
From: Christian König Save some memory because only on of those is used at all times. TODO: Should we use an union here or just a single field? Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --gi

[PATCH 3/8] drm/amdgpu: move some defines around

2017-07-27 Thread Christian König
From: Christian König Move amdgpu_bo and related structures into amdgpu_object.h. Move amdgpu_bo_list structures to the amdgpu_bo_list functions. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 77 -- drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 2/8] drm/amdgpu: consistent use u64_to_user_ptr

2017-07-27 Thread Christian König
From: Christian König Instead of open coding the conversion from u64 to pointers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- 3 files changed

[PATCH 7/8] drm/amdgpu: use amdgpu_bo_create_kernel more often

2017-07-27 Thread Christian König
From: Christian König Saves us quite a bunch of loc. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 34 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 19 +--- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 70 +++- drivers/gpu/drm/amd/amdgpu/gfx_

[PATCH 5/8] drm/amdgpu: improve amdgpu_bo_create_kernel

2017-07-27 Thread Christian König
From: Christian König Make allocating the new BO optional. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd

RE: [PATCH] drm/amd/powerplay: delete PCC error message in smu7_hwmgr.c

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Thursday, July 27, 2017 8:33 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amd/powerplay: delete PCC error message in > smu7_hwmgr.c > > In some

[PATCH] drm/amd/powerplay: delete PCC error message in smu7_hwmgr.c

2017-07-27 Thread Rex Zhu
In some asics,Really no need to program PCC HW register. Change-Id: Ieebe926334ee2b183ad0dd57fb2e2981b405eb13 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/driv

RE: [PATCH xf86-video-ati 3/3] autogen.sh: Pass -f to autoreconf

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Thursday, July 27, 2017 2:31 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-ati 3/3] autogen.sh: Pass -f to autoreconf > > From: Michel Dänzer > >

RE: [PATCH xf86-video-amdgpu] Only handle reflection in the driver with Xorg < 1.16

2017-07-27 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Thursday, July 27, 2017 2:24 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-amdgpu] Only handle reflection in the driver > with Xorg < 1.16 > > From

Re: [PATCH 2/2] drm/amdgpu: Support IOMMU on Raven

2017-07-27 Thread Christian König
Am 26.07.2017 um 22:46 schrieb Yong Zhao: We achieved that by setting the PTEs to 2 (the SYSTEM bit is set) when the corresponding addresses are not occupied by gpu driver allocated buffers. Change-Id: I995c11c7a25bdaf7a16700d9e08a8fe287d49417 Signed-off-by: Yong Zhao [SNIP] diff --git a/dr

Re: [PATCH 1/2] drm/amdgpu: Add support for filling a buffer with 64 bit value

2017-07-27 Thread Christian König
Am 26.07.2017 um 22:45 schrieb Yong Zhao: That function will be used later to support setting a page table block with 64 bit value. Change-Id: Ib142ebd4163d6e23670a3f0ceed536d59133b942 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 19 +-- drivers/gpu/

Re: [PATCH] drm/amdgpu: remove unused power control for vcn

2017-07-27 Thread Christian König
Am 27.07.2017 um 04:44 schrieb Deucher, Alexander: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Leo Liu Sent: Wednesday, July 26, 2017 3:08 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH] drm/amdgpu: remove unused power co

Re: [PATCH] drm/amdgpu: fix header on gfx9 clear state

2017-07-27 Thread Christian König
Am 27.07.2017 um 04:13 schrieb Alex Deucher: This got missed when we open sourced this. Signed-off-by: Alex Deucher Ups, indeed that should be fixed ASAP. Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/clearstate_gfx9.h | 41 ++-- 1 file changed, 21