[PATCH 2/2] amdgpu/dc: inline a bunch of the fixed 31_32 helpers.

From: Dave Airlie This decreases code size by a few hundred bytes. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 122 --- drivers/gpu/drm/amd/display/include/fixed31_32.h | 132

[PATCH 1/2] amdgpu/dc: inline some of the fixed 32_32 fns

From: Dave Airlie This drops ~400 bytes here. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/basics/fixpt32_32.c | 60 - drivers/gpu/drm/amd/display/include/fixed32_32.h | 76 +- 2 files changed, 61

[PATCH] amdgpu/dc: remove pointless returns in the i2caux constructor paths. (v2)

From: Dave Airlie There was lots of return true, and error checking that was never used in these paths. Just remove it all. v2: I missed one return true. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/i2caux/aux_engine.c | 6 ++--

[PATCH 9/9] amdgpu/dc: fix construct return values on irq service.

From: Dave Airlie This just removes more unused return/errors paths. Signed-off-by: Dave Airlie --- .../gpu/drm/amd/display/dc/irq/dce110/irq_service_dce110.c | 14 -- .../gpu/drm/amd/display/dc/irq/dce120/irq_service_dce120.c | 14

[PATCH 5/9] amdgpu/dc: cleanup construct returns in gpio.

From: Dave Airlie This is similiar to previous patches, don't return when we don't need to, also do error checking before allocating memory, makes it simpler to cleanup after. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/gpio/hw_ddc.c

[PATCH 8/9] amdgpu: fixup construct to void paths on some more dc objects.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 10 +++--- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 18 +- drivers/gpu/drm/amd/display/dc/core/dc_surface.c | 15

[PATCH 7/9] amdgpu/dc: remove pointless return from build_pipe_hw_param

From: Dave Airlie This never returned anything else. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 6 +- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 10 ++

[PATCH 4/9] amdgpu/dc: remove pointless returns in the i2caux constructor paths.

From: Dave Airlie There was lots of return true, and error checking that was never used in these paths. Just remove it all. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/i2caux/aux_engine.c | 6 ++--

[PATCH 3/9] amdgpu/dc: make some audio functions return void

From: Dave Airlie There is no need to check for these pointers being valid at this level. Check earlier if required. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 14 ++ 1 file changed, 2 insertions(+), 12

[PATCH 2/9] amdgpu/dc: make program_regamma_pwl return void

From: Dave Airlie The return value was unused. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 4 +--- drivers/gpu/drm/amd/display/dc/dce/dce_transform.h | 2 +-

[PATCH 1/9] amdgpu/dc: make get_audio_clock_info return void.

From: Dave Airlie This function never returned false under any sane circumstances. Signed-off-by: Dave Airlie --- .../drm/amd/display/dc/dce/dce_stream_encoder.c| 75 ++ 1 file changed, 34 insertions(+), 41 deletions(-) diff

Re: global data in display/dc/dce/dce_abm.c

Hi Dave, Agreed, those should probably be per adapter. We'll take a look and fix them up. Thanks for pointing them out. Regards, Aric From: Wentland, Harry Sent: Thursday, September 28, 2017 8:29:58 PM To: Dave Airlie; amd-gfx mailing list; Cyr, Aric; Koo,

[PATCH 6/6] amdgpu/dc: make dce80 timing generator construct return void.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 8 ++-- drivers/gpu/drm/amd/display/dc/dce80/dce80_timing_generator.c | 7 +--

[PATCH 1/6] amdgpu/dc: make timing generator constructor return void.

From: Dave Airlie This can't fail as is. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 9 ++--- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 8 ++--

[PATCH 3/6] amdgpu/dc: make link encoder construct void.

From: Dave Airlie This only ever returned true. Signed-off-by: Dave Airlie --- .../gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 4 +--- .../gpu/drm/amd/display/dc/dce/dce_link_encoder.h | 2 +-

RE: some more powerplay/pwr virus size reduction patches

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Dave Airlie > Sent: Thursday, September 28, 2017 10:44 PM > To: amd-gfx mailing list; Alex Deucher > Subject: some more powerplay/pwr virus size reduction patches > > I don't think these

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

On 2017年09月13日 04:42, Marek Olšák wrote: From: Marek Olšák For amdgpu. drm_syncobj_create is renamed to drm_syncobj_create_as_handle, and new helpers drm_syncobj_create and drm_syncobj_get_handle are added. Signed-off-by: Marek Olšák ---

some more powerplay/pwr virus size reduction patches

I don't think these patches will land on the list due to size. https://cgit.freedesktop.org/~airlied/linux/log/?h=amdgpu-non-dc-cleanups The top 3 patches on that branch. These reduce the size of the driver by about 60k, by redesigning the pwrvirus upload code to use less space. I did notice

[PATCH 1/3] amdgpu/pp: use array_size to size the pwrvirus tables.

From: Dave Airlie This avoids fragile hardcoding of array size. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/powerplay/inc/fiji_pwrvirus.h | 3 +-- drivers/gpu/drm/amd/powerplay/inc/polaris10_pwrvirus.h | 5 +

Re: [PATCH 5/5] drm/amd/sched: signal and free remaining fences in amd_sched_entity_fini

On 2017年09月28日 22:55, Nicolai Hähnle wrote: From: Nicolai Hähnle Highly concurrent Piglit runs can trigger a race condition where a pending SDMA job on a buffer object is never executed because the corresponding process is killed (perhaps due to a crash). Since the

Re: [PATCH libdrm 2/4] drm: add drmSyncobjWait wrapper

On 2017年09月29日 06:10, Marek Olšák wrote: From: Marek Olšák --- include/drm/drm.h | 24 xf86drm.c | 22 ++ xf86drm.h | 3 +++ 3 files changed, 49 insertions(+) diff --git a/include/drm/drm.h

Re: [PATCH] amdgpu/dc: drop dc_ver char

On 2017-09-28 08:20 PM, Dave Airlie wrote: > From: Dave Airlie > > This isn't referenced anywhere, and if it was it should be const. > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH 2/2] amdgpu/dm: constify rgb formats.

On 2017-09-28 08:32 PM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1

Re: [PATCH 1/2] amdgpu/dm: constify plane type.

On 2017-09-28 08:32 PM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +- >

[PATCH] amdgpu/nbio: use constant nbio_hdp_flush_reg structs.

From: Dave Airlie This removes the init path as well, since the init path just did some constant init of some structs. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 38

Re: [PATCH] amdgpu/dm: constify yuv_formats.

On 2017-09-28 08:27 PM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1

Re: [PATCH] amdgpu/dc: static constify update_surface_trace_level

On 2017-09-28 08:23 PM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH 1/2] amdgpu/dc: constify a bunch of dc structs.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c | 8 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-

[PATCH 2/2] amdgpu/pp: constify soft_dummy_pp_table.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c

[PATCH 1/2] amdgpu/dm: constify plane type.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] amdgpu/dm: constify rgb formats.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Re: global data in display/dc/dce/dce_abm.c

On 2017-09-28 08:24 PM, Dave Airlie wrote: > On 29 September 2017 at 10:18, Dave Airlie wrote: >> Hi Harry, >> >> stored_backlight_registers is a global static struct in bss segment, >> it should probably be per device. > > There is also cached_wait_loop_number in >

[PATCH] amdgpu/dm: constify yuv_formats.

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Re: global data in display/dc/dce/dce_abm.c

On 29 September 2017 at 10:18, Dave Airlie wrote: > Hi Harry, > > stored_backlight_registers is a global static struct in bss segment, > it should probably be per device. There is also cached_wait_loop_number in amd/display/dc/dce/dce_dmcu.c Dave.

[PATCH] amdgpu/dc: static constify update_surface_trace_level

From: Dave Airlie Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index

[PATCH] amdgpu/dc: drop dc_ver char

From: Dave Airlie This isn't referenced anywhere, and if it was it should be const. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c

global data in display/dc/dce/dce_abm.c

Hi Harry, stored_backlight_registers is a global static struct in bss segment, it should probably be per device. Dave. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] [rfc] amdgfx/gfx: don't use static objects for de meta.

From: Dave Airlie This isn't safe if we have multiple GPUs plugged in, since there is only one copy of this struct in the bss, just allocate on stack, it's 108 bytes which should be safe. Signed-off-by: Dave Airlie ---

[PATCH] amdgpu/soc15: make the pcie index/data registers constant.

From: Dave Airlie These don't seem to change at runtime, and the initialisers are constant data. This could be improved by not selecting the apu/non-apu path on each pcie read/write access. Signed-off-by: Dave Airlie ---

[PATCH] [rfc] amdgfx/gfx: don't use static objects for ce/de meta. (v2)

From: Dave Airlie This isn't safe if we have multiple GPUs plugged in, since there is only one copy of this struct in the bss, just allocate on stack, it's 40/108 bytes which should be safe. Signed-off-by: Dave Airlie ---

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

On 29 September 2017 at 06:41, Marek Olšák wrote: > Can I get Rb for this series? > For the series, Reviewed-by: Dave Airlie Alex, please merge the two drm core precursor with patch 3. Dave. ___ amd-gfx mailing

[PATCH libdrm 2/4] drm: add drmSyncobjWait wrapper

From: Marek Olšák --- include/drm/drm.h | 24 xf86drm.c | 22 ++ xf86drm.h | 3 +++ 3 files changed, 49 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index bf3674a..4da1667 100644 ---

[PATCH libdrm 3/4] amdgpu: add amdgpu_cs_syncobj_wait

From: Marek Olšák v2: update amdgpu-symbol-check --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 20 amdgpu/amdgpu_cs.c | 12 3 files changed, 33 insertions(+) diff --git a/amdgpu/amdgpu-symbol-check

[PATCH libdrm 4/4] amdgpu: add amdgpu_cs_fence_to_handle

From: Marek Olšák v2: update amdgpu-symbol-check --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 14 ++ amdgpu/amdgpu_cs.c | 22 ++ include/drm/amdgpu_drm.h | 21 + 4 files changed, 58

[PATCH libdrm 1/4] amdgpu: add sync_file import and export functions

From: Marek Olšák v2: update amdgpu-symbol-check --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h| 30 ++ amdgpu/amdgpu_cs.c | 20 3 files changed, 52 insertions(+) diff --git

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

On Thu, Sep 14, 2017 at 10:01 AM, Emil Velikov wrote: > On 14 September 2017 at 08:56, Emil Velikov wrote: >> Hi Marek, >> >> On 12 September 2017 at 21:42, Marek Olšák wrote: >> >>> include/drm/drm_syncobj.h | 4

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

Can I get Rb for this series? Thanks, Marek On Tue, Sep 12, 2017 at 10:42 PM, Marek Olšák wrote: > From: Marek Olšák > > for being able to convert an amdgpu fence into one of the handles. > Mesa will use this. > > Signed-off-by: Marek Olšák

RE: [PATCH] drm/amd/display: Remove DWB

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Harry Wentland > Sent: Thursday, September 28, 2017 3:42 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander; Cheng, Tony; airl...@gmail.com; dri- > de...@lists.freedesktop.org;

Re: [PATCH] amdgpu/pp: move amdgpu_fuses_default into static const.

On Wed, Sep 27, 2017 at 7:37 PM, Dave Airlie wrote: > From: Dave Airlie > > There is no reason that this gets passed back into the function > from outside the file, just reference the table directly. > > Signed-off-by: Dave Airlie

Re: [PATCH][drm-next] drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible"

On Thu, Sep 28, 2017 at 6:35 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in pr_err error message and ASSERT > messages. > > Signed-off-by: Colin Ian King Applied. thanks! Alex

[PATCH] drm/amd/display: Remove DWB

It's not in a good shape and currently completely unused. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 9 - drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dwb.c | 365

Re: [PATCH 4/5] drm/amd/sched: NULL out the s_fence field after run_job

On 28.09.2017 20:39, Andres Rodriguez wrote: On 2017-09-28 10:55 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle amd_sched_process_job drops the fence reference, so NULL out the s_fence field before adding it as a callback to guard against accidentally using s_fence

RE: amdgpu_vf_errors

Hi Dave, This feature is used on Virtualization environment to send errors of amdgpu initialization fail from Guest side to Host side via mailbox (function xgpu_ai_mailbox_trans_msg in file mxgpu_ai.c). In Virtualization environment, it should not use multi GPUs. So I just created a global

RE: [alsa-devel] [PATCH 0/6 v4] Add ASoC support for AMD Stoney APUs

> -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Thursday, September 28, 2017 3:00 PM > To: Alex Deucher > Cc: alsa-de...@alsa-project.org; Takashi Iwai; Liam Girdwood; Maling list - > DRI developers; rajeev kumar; amd-gfx list; Mukunda, Vijendar; Deucher, >

Re: [PATCH] drm/amdgpu: map compute rings by least recently used pipe

On Tue, Sep 26, 2017 at 5:43 PM, Andres Rodriguez wrote: > This patch provides a guarantee that the first n queues allocated by > an application will be on different pipes. Where n is the number of > pipes available from the hardware. > > This helps avoid ring aliasing which

Re: [alsa-devel] [PATCH 0/6 v4] Add ASoC support for AMD Stoney APUs

On Thu, Sep 14, 2017 at 10:42:28AM -0700, Mark Brown wrote: > On Wed, Sep 13, 2017 at 02:49:08PM -0400, Alex Deucher wrote: > > I'm not quite sure what you mean by the cross merge. There are no > > dependencies outside this patch set. The only patches that touch drm > > are patches 1 and 2.

Re: [PATCH 0/2] Selectively spread compute rings across pipes

On Tue, Sep 26, 2017 at 2:15 PM, Felix Kuehling wrote: > The series is Acked-by: Felix Kuehling > > Regards, > Felix > > > On 2017-09-26 12:22 PM, Andres Rodriguez wrote: >> This was disabled due to an OCL perf regression as discussed on amd-gfx.

Re: [PATCH] amdgpu/pp/vega10: mark vega10_pp_tables_initialize as static.

On Thu, Sep 28, 2017 at 3:17 AM, Dave Airlie wrote: > From: Dave Airlie > > This isn't used outside this file. > > Signed-off-by: Dave Airlie Reviewed-by: Alex Deucher > --- >

Re: [PATCH] drm/amdgpu: use designated initialiser for thermal_irq_src.

On Thu, Sep 28, 2017 at 2:13 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes the 0-day build warning. > > Signed-off-by: Dave Airlie Reviewed-by: Alex Deucher > --- >

Re: [PATCH] amdgpu/pp: move PhwVega10_Magic to static const.

On Wed, Sep 27, 2017 at 7:33 PM, Dave Airlie wrote: > From: Dave Airlie > > This isn't used outside this file. > > Signed-off-by: Dave Airlie Reviewed-by: Alex Deucher > --- >

Re: [PATCH] amdgpu/pp: remove ci_smc/smumgr split.

On Wed, Sep 27, 2017 at 7:04 PM, Dave Airlie wrote: > From: Dave Airlie > > This split serves no purpose, and we can make a bunch of functions > static now. > > There are lots of cases of this sort of split in the powerplay code, > please start cleaning

RE: [PATCH 3/3] drm/amd/powerplay: delete flag PP_VALID

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Thursday, September 28, 2017 5:41 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 3/3] drm/amd/powerplay: delete flag PP_VALID > > don't need to check

RE: [PATCH v2] drm/amd/powerplay: refine code in amd_powerplay.c

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Thursday, September 28, 2017 1:06 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH v2] drm/amd/powerplay: refine code in amd_powerplay.c > > v2: not

Re: [PATCH 4/5] drm/amd/sched: NULL out the s_fence field after run_job

On 2017-09-28 10:55 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle amd_sched_process_job drops the fence reference, so NULL out the s_fence field before adding it as a callback to guard against accidentally using s_fence after it may have be freed. Signed-off-by:

Re: [PATCH 5/5] drm/amd/sched: signal and free remaining fences in amd_sched_entity_fini

Thanks for this series. I can finally finish piglit on VI. Marek On Thu, Sep 28, 2017 at 4:55 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Highly concurrent Piglit runs can trigger a race condition where a pending > SDMA job on a buffer

RE: [PATCH v2] drm/amd/display: DC I2C review

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Harry Wentland > Sent: Thursday, September 28, 2017 10:14 AM > To: amd-gfx@lists.freedesktop.org > Cc: daniel.vet...@ffwll.ch; dri-de...@lists.freedesktop.org; > seanp...@chromium.org;

Re: [PATCH] amdgpu/dc: drop dml_util_is_420

On 2017-09-27 08:55 PM, Dave Airlie wrote: > From: Dave Airlie > > This is unused code. > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- > .../gpu/drm/amd/display/dc/dml/dml_common_defs.c | 33 >

Re: [PATCH] amdgpu/dc: don't check for 0 on register read/writes always.

On 2017-09-27 10:42 PM, Dave Airlie wrote: > From: Dave Airlie > > This adds ~50k to the driver text segment, and 10k to data segment. > >text data bss dec hex filename > 2385556 396811045 2426282 2505aa >

Re: [PATCH 5/5] drm/amd/sched: signal and free remaining fences in amd_sched_entity_fini

Am 28.09.2017 um 16:55 schrieb Nicolai Hähnle: From: Nicolai Hähnle Highly concurrent Piglit runs can trigger a race condition where a pending SDMA job on a buffer object is never executed because the corresponding process is killed (perhaps due to a crash). Since the

[PATCH 2/5] drm/amd/sched: fix an outdated comment

From: Nicolai Hähnle Signed-off-by: Nicolai Hähnle --- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c

[PATCH 3/5] drm/amd/sched: move adding finish callback to amd_sched_job_begin

From: Nicolai Hähnle The finish callback is responsible for removing the job from the ring mirror list, among other things. It makes sense to add it as callback in the place where the job is added to the ring mirror list. Signed-off-by: Nicolai Hähnle

[PATCH 1/5] drm/amd/sched: rename amd_sched_entity_pop_job

From: Nicolai Hähnle The function does not actually remove the job from the FIFO, so "peek" describes it better. Signed-off-by: Nicolai Hähnle --- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 4/5] drm/amd/sched: NULL out the s_fence field after run_job

From: Nicolai Hähnle amd_sched_process_job drops the fence reference, so NULL out the s_fence field before adding it as a callback to guard against accidentally using s_fence after it may have be freed. Signed-off-by: Nicolai Hähnle Acked-by:

[PATCH 5/5] drm/amd/sched: signal and free remaining fences in amd_sched_entity_fini

From: Nicolai Hähnle Highly concurrent Piglit runs can trigger a race condition where a pending SDMA job on a buffer object is never executed because the corresponding process is killed (perhaps due to a crash). Since the job's fences were never signaled, the buffer

[PATCH][drm-next] drm/radeon: make functions alloc_pasid and free_pasid static

From: Colin Ian King The functions alloc_pasid and free_pasid are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: warning: symbol 'alloc_pasid' was not declared. Should it be static? warning: symbol

Re: [PATCH] amdgpu/dc: add static to construct function

On 2017-09-27 07:21 PM, Dave Airlie wrote: > From: Dave Airlie > > There was a global construct symbol in the module symbols, kill it. > Good catch. I should really watch out for global namespace pollution which is really not cool in the kernel tree. > Signed-off-by: Dave

Re: [PATCH] amdgpu/dc: move filter taps to being static const data (v2)

On 2017-09-27 08:22 PM, Dave Airlie wrote: > From: Dave Airlie > > This just adds two accessor methods, and moves all the data > to static const. > > v2: fix dcn build. > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland

Re: [PATCH] amdgpu/dc: separate out some common code from bios parsers.

On 2017-09-27 09:24 PM, Dave Airlie wrote: > From: Dave Airlie > > This extracts the bios parser object id handling into a common file. > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH] amdgpu/dc: drop dml display_mode_support.c (v2)

On 2017-09-27 10:29 PM, Dave Airlie wrote: > From: Dave Airlie > > This code isn't used, and this function is huge, reimport later if > going to be used. > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH] amdgpu/dc: remove wait_reg/wait_reg_func interfaces.

On 2017-09-27 11:29 PM, Dave Airlie wrote: > From: Dave Airlie > > These aren't used in the tree anywhere, and there is a TODO. > > Signed-off-by: Dave Airlie Reviewed-by: Harry Wentland > --- >

[PATCH v2] drm/amd/display: DC I2C review

While reviewing I2C in DC identified a few places. Added a couple to the TODO list. 1) Connector info read See get_ext_display_connection_info On some boards the connector information has to be read through a special I2C channel. This line is only used for this purpose and only on driver init.

Re: [PATCH 1/2] drm/amdgpu: add functions to create bo at the specified position

NAK, please use the existing functionality for that. Using amdgpu_bo_do_create() with domain=0 will just create the amdgpu_bo structure without allocating any backing memory. This BO can then pinned to the desired VRAM location using amdgpu_bo_pin(). Regards, Christian. Am 28.09.2017 um

[PATCH] drm/amdgpu: fix vf error handling

The error handling for virtual functions assumed a single vf per VM and didn't properly account for bare metal. Make the error arrays per device and add locking. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 ++--

[PATCH 3/3] drm/amd/powerplay: delete flag PP_VALID

don't need to check pp_valid, all pp export functions are moved to ip_funcs and pp_funcs. so just need to check the function point. Change-Id: Ib75cebece8fb9ebc7307f5d3cf084a813b5493db Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 3 +--

[PATCH 2/3] drm/amd/powerplay: move functions to amd_pm_funcs table

those functions are exported to DC Change-Id: I67637337ee40a6da6ecdd15fd78af0335f4c8414 Signed-off-by: Rex Zhu --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 29 +++-- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 140 +++--

[PATCH 1/2] drm/amdgpu: add functions to create bo at the specified position

Add two function to create and free bo at the specified position on the VRAM. Add a new parameter to amdgpu_bo_do_create to tell the start address of the special bo. If the start address is located in the GPU MC address space, the placement will be set to the exact place according to the size and

[PATCH] amdgpu/pp/vega10: mark vega10_pp_tables_initialize as static.

From: Dave Airlie This isn't used outside this file. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/3] drm/amd/display: DC I2C review

On Wed, Sep 27, 2017 at 9:46 PM, Harry Wentland wrote: > While reviewing I2C in DC identified a few places. Added a couple to the > TODO list. > > 1) Connector info read > > See get_ext_display_connection_info > > On some boards the connector information has to be read

[PATCH] drm/amdgpu: use designated initialiser for thermal_irq_src.

From: Dave Airlie This fixes the 0-day build warning. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c