SR-IOV need to reserve a piece of shared VRAM at the exact place
to exchange data betweem PF and VF. The start address and size of
the shared mem are passed to guest through VBIOS structure
VRAM_UsageByFirmware.
VRAM_UsageByFirmware is a general feature in VBIOS, it indicates
that VBIOS need to
Zhu, Rex would like to recall the message, "[PATCH] drm/amdgpu: correct
reference clock value on vega10".
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by:
Rex Zhu
Best Regards
Rex
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of
ken.w...@amd.com
Sent: Friday, September 29, 2017 4:35 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Ken
Subject: [PATCH] drm/amdgpu:
Yes, caused by the commit e37a7b4088da
("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c")
Replace error when split patches.
Have sent the fix patch.
Please review.
Best Regards
Rex
-Original Message-
From: Alex Deucher [mailto:alexdeuc...@gmail.com]
Sent: Friday, September
regresstion issue caused by
commit e37a7b4088da
("drm/amd/powerplay: tidy up ret checks in amd_powerplay.c")
Change-Id: I46be14d8230ad7bc9039782a56a94bb060a21423
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 74 +--
1 file
Change-Id: I8607e51a0e4153b36268e2bcf4fe594c2bfbfe23
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
Hi Alex,
Thanks for pointing out the logic error in pp_hw_init.
Please review the attached patch.
Best Regards
Rex
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex
Deucher
Sent: Saturday, September 30, 2017 12:38 AM
To:
On 2017年09月29日 20:37, Marek Olšák wrote:
On Fri, Sep 29, 2017 at 4:12 AM, Chunming Zhou wrote:
On 2017年09月29日 06:10, Marek Olšák wrote:
From: Marek Olšák
---
include/drm/drm.h | 24
xf86drm.c | 22
My mean is like the attached, I revert part of yours.
Regards,
David zhou
On 2017年09月29日 22:15, Marek Olšák wrote:
On Fri, Sep 29, 2017 at 4:13 PM, Marek Olšák wrote:
On Fri, Sep 29, 2017 at 4:44 AM, Chunming Zhou wrote:
On 2017年09月13日 04:42, Marek
Change-Id: I40fa698cd9a25df43aa4bf476c4aa0a8b043edf9
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 48 +-
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
On 09/30/2017 09:10 AM, Evan Quan wrote:
Change-Id: I598f8ab583fc9c7045a4852d6972df90a82f7472
Signed-off-by: Evan Quan
the series is
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h | 7 ++-
1 file changed, 6
> -Original Message-
> From: Evan Quan [mailto:evan.q...@amd.com]
> Sent: Friday, September 29, 2017 9:10 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander; Zhang, Jerry; Quan, Evan
> Subject: [PATCH 4/4] drm/amd/powerplay: get raven sclk and mclk levels
>
Add a better
> -Original Message-
> From: Evan Quan [mailto:evan.q...@amd.com]
> Sent: Friday, September 29, 2017 9:10 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander; Zhang, Jerry; Quan, Evan
> Subject: [PATCH 3/4] drm/amd/powerplay: get raven current sclk and mclk
>
> Change-Id:
> -Original Message-
> From: Evan Quan [mailto:evan.q...@amd.com]
> Sent: Friday, September 29, 2017 9:10 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander; Zhang, Jerry; Quan, Evan
> Subject: [PATCH 1/4] drm/amd/powerplay: added new raven ppsmc
> messages
>
> Change-Id:
> -Original Message-
> From: Evan Quan [mailto:evan.q...@amd.com]
> Sent: Friday, September 29, 2017 9:10 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander; Zhang, Jerry; Quan, Evan
> Subject: [PATCH 2/4] drm/amd/powerplay: get raven max/min gfx clocks
>
> Change-Id:
Change-Id: I56e713e16b9a794857e7ecbb7ca47e0ddd727862
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 20
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h | 2 ++
2 files changed, 22 insertions(+)
diff --git
On Fri, Sep 29, 2017 at 9:15 PM, Evan Quan wrote:
> Change-Id: I172c1e05ce026b5d600f5b3607778ab48ee2c812
> Signed-off-by: Evan Quan
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +-
> 1
Change-Id: I172c1e05ce026b5d600f5b3607778ab48ee2c812
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
Change-Id: I598f8ab583fc9c7045a4852d6972df90a82f7472
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h
Change-Id: I17120a53bc3cebd8cc7eb9f3d83124905632a409
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 28 --
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
From: Andrey Grodzovsky
Adding initial tests for locks detection when SW
scheduler FIFO is full.
The test works by submitting a batch of identical commands which make the CP
stall waiting for condition to become true. The condition is later satisfied
form a helper
On Thu, Sep 28, 2017 at 9:46 AM, Colin King wrote:
> From: Colin Ian King
>
> The functions alloc_pasid and free_pasid are local to the
> source and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
>
Thanks Oak. The change is Reviewed-by: Felix Kuehling
On 2017-09-29 10:28 AM, ozeng wrote:
> The dead circular lock senario captured is as followed.
> The idea of the fix is moving read_user_wptr outside of
> acquire_queue...release_queue critical section
>
> [
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Martin Babutzka
> Sent: Friday, September 29, 2017 2:00 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: Regressions in amd-staging-4.12 and amd-staging-drm-next
>
> Hello,
>
> At first
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Martin Babutzka
> Sent: Friday, September 29, 2017 2:00 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: Regressions in amd-staging-4.12 and amd-staging-drm-next
>
> Hello,
>
> At first
Hello,
At first congrats for submitting the pull request. I hope the dc code
is accepted and included in the 4.15 kernel.
Me and some other users of my kernel builds (https://github.com/M-Bab/l
inux-kernel-amdgpu-binaries) found further regressions in builds based
on amd-staging-4.12 and
Make sure hwmgr is valid.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
On 26/09/17 10:31 PM, Alex Deucher wrote:
> Hi Dave,
>
> First feature pull for 4.15. Highlights:
> - Per VM BO support
> - Lots of powerplay cleanups
> - Powerplay support for CI
> - pasid mgr for kfd
> - interrupt infrastructure for recoverable page faults
> - SR-IOV fixes
> - initial GPU
It's not used outside this file any longer.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/atombios_dp.c | 8
drivers/gpu/drm/radeon/radeon_mode.h | 4
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git
The dead circular lock senario captured is as followed.
The idea of the fix is moving read_user_wptr outside of
acquire_queue...release_queue critical section
[ 63.477482] WARNING: possible circular locking dependency detected
[ 63.484091] 4.12.0-kfd-ozeng #3 Not tainted
[ 63.488531]
On 2017-09-29 03:13 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This uses two things that might be Linux specific,
> __builtin_constant_p (might be gcc)
> and
> BUILD_BUG_ON. (maybe other dm's can have something similiar).
>
We can always use ifdef in our internal tree
On 2017-09-29 03:13 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> turns out to be a win to inline this.
>
> Signed-off-by: Dave Airlie
Series is
Reviewed-by: Harry Wentland
Harry
> ---
>
On 2017-09-29 01:45 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This decreases code size by a few hundred bytes.
>
> Signed-off-by: Dave Airlie
Series is
Reviewed-by: Harry Wentland
Harry
> ---
>
On Thu, Sep 28, 2017 at 8:47 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This removes the init path as well, since the init path
> just did some constant init of some structs.
>
> Signed-off-by: Dave Airlie
Reviewed-by: Alex Deucher
On Thu, Sep 28, 2017 at 8:39 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> Signed-off-by: Dave Airlie
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +-
> 1
On 2017-09-29 01:44 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> There was lots of return true, and error checking that was never used
> in these paths.
>
> Just remove it all.
>
> v2: I missed one return true.
>
> Signed-off-by: Dave Airlie
Thanks
On 2017-09-29 12:34 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This just removes more unused return/errors paths.
>
> Signed-off-by: Dave Airlie
Series is
Reviewed-by: Harry Wentland
Harry
> ---
>
On Fri, Sep 29, 2017 at 4:13 PM, Marek Olšák wrote:
> On Fri, Sep 29, 2017 at 4:44 AM, Chunming Zhou wrote:
>>
>>
>> On 2017年09月13日 04:42, Marek Olšák wrote:
>>>
>>> From: Marek Olšák
>>>
>>> For amdgpu.
>>>
>>> drm_syncobj_create is
On Fri, Sep 29, 2017 at 4:44 AM, Chunming Zhou wrote:
>
>
> On 2017年09月13日 04:42, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> For amdgpu.
>>
>> drm_syncobj_create is renamed to drm_syncobj_create_as_handle, and new
>> helpers drm_syncobj_create and
Rex, probably related to the recent cleanups in powerplay.
On Fri, Sep 29, 2017 at 10:09 AM, Dieter Nützel wrote:
> Hello all,
>
> since latest update
>
> 1d7da702e70d3c27408a3bb312c71d6be9f7bebe
> drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible"
>
> I
Hello all,
since latest update
1d7da702e70d3c27408a3bb312c71d6be9f7bebe
drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible"
I didn't get fan info with my RX580 (Polaris21) any longer.
Worked with this commit:
786df0b89fe5a0b405d4de0a1ce03003c0743ec3
drm/amd/display: fix pflip
It's used in ci_dpm.c so move it there and make it static.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/ci_dpm.c | 22 ++
drivers/gpu/drm/radeon/ci_dpm.h | 1 -
drivers/gpu/drm/radeon/ci_smc.c | 21 -
3 files changed,
Am 29.09.2017 um 09:21 schrieb Horace Chen:
SR-IOV need to reserve a piece of shared VRAM at the exact place
to exchange data betweem PF and VF. The start address and size of
the shared mem are passed to guest through VBIOS structure
VRAM_UsageByFirmware.
VRAM_UsageByFirmware is a general
Am 29.09.2017 um 02:16 schrieb Dave Airlie:
From: Dave Airlie
This isn't safe if we have multiple GPUs plugged in, since
there is only one copy of this struct in the bss, just allocate
on stack, it's 40/108 bytes which should be safe.
Signed-off-by: Dave Airlie
Quoting Alex Deucher (2017-09-27 02:36:07)
> Hi Dave,
>
> Initial pull request for DC support. We've completed a substantial amount of
> the cleanup and restructuring in our TODO. There are a few additional
> cleanups that we are continuing to work on, but I don't think there are any
>
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Friday, September 29, 2017 6:02 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH 2/2] drm/amdgpu: add header kgd_pp_interface.h
>
> move powerplay and
> -Original Message-
> From: Horace Chen [mailto:horace.c...@amd.com]
> Sent: Friday, September 29, 2017 3:21 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander; Chen, Horace
> Subject: [PATCH] drm/amdgpu: Reserve shared memory on VRAM for SR-
> IOV
>
> SR-IOV need to reserve
On Fri, Sep 29, 2017 at 4:12 AM, Chunming Zhou wrote:
>
>
> On 2017年09月29日 06:10, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> ---
>> include/drm/drm.h | 24
>> xf86drm.c | 22 ++
>> xf86drm.h
On Fri, Sep 29, 2017 at 1:42 AM, Dave Airlie wrote:
> On 29 September 2017 at 06:41, Marek Olšák wrote:
>> Can I get Rb for this series?
>>
>
> For the series,
>
> Reviewed-by: Dave Airlie
>
> Alex, please merge the two drm core precursor
On Fri, Sep 29, 2017 at 3:42 AM, wrote:
> From: Ken Wang
>
> Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474
> Signed-off-by: Ken Wang
> ---
> drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
From: Ken Wang
Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474
Signed-off-by: Ken Wang
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
move powerplay and amdgpu shared structures
and definitions to kgd_pp_interface.h
Change-Id: I4272b7974edbff3395ba8a6efebb0decd0cdfa12
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 1
Change-Id: Iea3b5ab620b536d1ab084ffc0859f44ffe7a
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 7 +++
drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h | 7 ---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git
On 26/09/17 06:22 PM, Andres Rodriguez wrote:
> Useful for testing the effects of multipipe compute without recompiling.
>
> Signed-off-by: Andres Rodriguez
I'm skeptical that it's a good idea to add a module parameter for this.
See Daniel's rationale in
Hi,
I have to forwards the review request because git send email seems not work
correctly on my machine.
From: ken.w...@amd.com
Sent: Friday, September 29, 2017 16:38
To: amd-gfx@lists.freedesktop.org
Cc: Wang, Ken
Subject: [PATCH]
From: Ken Wang
Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474
Signed-off-by: Ken Wang
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
From: Ken Wang
Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474
Signed-off-by: Ken Wang
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
From: Ken Wang
Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474
Signed-off-by: Ken Wang
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
SR-IOV need to reserve a piece of shared VRAM at the exact place
to exchange data betweem PF and VF. The start address and size of
the shared mem are passed to guest through VBIOS structure
VRAM_UsageByFirmware.
VRAM_UsageByFirmware is a general feature in VBIOS, it indicates
that VBIOS need to
OK. I have tried, it worked without any failure.
Thanks Christian.
Regards,
Horace.
-Original Message-
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sent: Thursday, September 28, 2017 10:01 PM
To: Chen, Horace ; amd-gfx@lists.freedesktop.org
Cc:
From: Dave Airlie
This is worth 300 bytes, and one less source file.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/basics/Makefile | 2 +-
.../gpu/drm/amd/display/dc/basics/signal_types.c | 80 --
From: Dave Airlie
This uses two things that might be Linux specific,
__builtin_constant_p (might be gcc)
and
BUILD_BUG_ON. (maybe other dm's can have something similiar).
This saves 4k in the bw calcs code.
Signed-off-by: Dave Airlie
---
From: Dave Airlie
This just makes it easier to find.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser.c| 6 +++---
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +-
From: Dave Airlie
turns out to be a win to inline this.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/dml/dml_common_defs.c | 19 ---
drivers/gpu/drm/amd/display/dc/dml/dml_common_defs.h | 2 --
From: Dave Airlie
This results in a ~4.5k code size reduction.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/calcs/bw_fixed.c | 93
drivers/gpu/drm/amd/display/dc/inc/bw_fixed.h | 111
2
From: Dave Airlie
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 9 -
drivers/gpu/drm/amd/display/include/fixed31_32.h | 9 ++---
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git
From: Dave Airlie
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
From: Dave Airlie
I've no idea if these are used on other platforms, but they
aren't used outside this file here, so make them static.
Drops 300 bytes.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 16
From: Dave Airlie
This only gets us 100 bytes, but may as well be consistent.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 22 ++
drivers/gpu/drm/amd/display/include/fixed31_32.h | 15
From: Dave Airlie
These aren't currently used outside this file.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 18 +-
drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h | 8
2 files changed, 13
70 matches
Mail list logo