Reviewed-and-tested-By: Xiangliang Yu
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Wednesday, November 08, 2017 2:39 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH] drm/amdgpu:fix gpu recove
I guess this because you move the resv changing out of lock of bo->resv.
Because at the beginning ttm_mem_evict_first may __ttm_bo_reserve(bo->resv)
success, and then bo->resv has been changed by another thread. That is not
matched and at this point bo->ttm_resv also may been freed already.
And
Reviewed-By: Xiangliang Yu
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Wednesday, November 08, 2017 3:08 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH] drm/amdgpu:fix gpu recover missing s
if app close CTX right after IB submit, gpu recover
will fail to find out the entity behind this guilty
job thus lead to no job skipping for this guilty job.
to fix this corner case just move the increasement of
job->karma out of the entity iteration.
v2:
only do karma increasment if bad->s_prior
From: Ken Wang
Signed-off-by: Ken Wang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
index c21adf6..057e1ec 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu
if app close CTX right after IB submit, gpu recover
will failed to find out the entity/ctx behind the guilty
job thus lead to bad job skipping in scheduler failed
to fix this corner case just move the job->karma increasing
out of the condition that the backing entity was found
that way the job its
We must remove the fence callback.
Change-Id: I5d58a3a43b82fefd6c211c4128b0c9187c191e7f
Signed-off-by: Chunming Zhou
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/scheduler/gpu_schedu
Change-Id: I1f6c81002fb2ba21c17cdc14fdde86579b28374e
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
index bb8a28b8b993
Hi Christian,
Please help reviewing.
Hi Gary,
with this change debugfs will be cleaned up by DRM, we don’t need to handle it
anymore.
—
Sincerely Yours,
Pixel
On 08/11/2017, 11:29 AM, "amd-gfx on behalf of Pixel Ding"
wrote:
>Retry at drm_dev_register instead of amdgpu_device_init
Retry at drm_dev_register instead of amdgpu_device_init.
Signed-off-by: Pixel Ding
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 11 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 15 ++-
3 files changed, 13 insertions(
Hi Christian,
I give a quick try according to your suggestion. It also works and cleaner. I
will send a new patch to revise the retry_init. Please help reviewing later.
—
Sincerely Yours,
Pixel
On 08/11/2017, 10:40 AM, "Ding, Pixel" wrote:
>Hi Christian,
>
>The retry_init only handles
RB-by: Monk Liu
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Pixel
Ding
Sent: 2017年11月8日 10:30
To: ckoenig.leichtzumer...@gmail.com; amd-gfx@lists.freedesktop.org
Cc: Ding, Pixel
Subject: [PATCH] drm/amdgpu: bypass lru touch for KIQ ring su
Hi Christian,
The retry_init only handles the failure caused by exclusive mode timeout. It
checks the MMIO to see if there’s exclusive mode timeout, and retry init if
there’s, otherwise just return error.
For exclusive timeout case, the host layer issues a FLR on this VF so driver
needn't clea
KIQ ring submission is used for register accessing on SRIOV
VF that could happen both in irq enabled and irq disabled cases.
Inversion lock could happen on adev->ring_lru_list_lock, while
this operation is useless and just adds overhead in this use
case.
Signed-off-by: Pixel Ding
---
drivers/gpu
Not sure amd-gfx is the right list for this. The code I'm talking about
is not upstream yet, and the problem being discussed occurs on the DKMS
branch.
Even though we say we don't support Tonga (there are known issues with
ROCm on Tonga), KFD will detect and initialize it. That means the HWS is
i
On 2017-11-07 03:06 PM, Ernst Sjöstrand wrote:
> From smatch:
> error: we previously assumed X could be null
>
> Signed-off-by: Ernst Sjöstrand
Entire patchset is
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 -
> 1 file chan
On 2017-11-07 03:18 PM, Ernst Sjöstrand wrote:
> Reported by smartch:
> amdgpu_dm_commit_planes() error: double unlock
> 'spin_lock:&crtc->dev->event_lock'
> amdgpu_dm_commit_planes() error: double unlock 'irqsave:flags'
>
> The error path doesn't return so we only need a single unlock.
>
> Sign
Reported by smartch:
amdgpu_dm_commit_planes() error: double unlock
'spin_lock:&crtc->dev->event_lock'
amdgpu_dm_commit_planes() error: double unlock 'irqsave:flags'
The error path doesn't return so we only need a single unlock.
Signed-off-by: Ernst Sjöstrand
---
drivers/gpu/drm/amd/display/am
Signed-off-by: Ernst Sjöstrand
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index e6bfa9f30900..218fb8ba750c 100644
--- a/dr
From smatch:
error: we previously assumed X could be null
Signed-off-by: Ernst Sjöstrand
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/d
More "warn: inconsistent indenting" fixes from smatch.
Signed-off-by: Ernst Sjöstrand
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +-
.../gpu/drm/amd/display/dc/i2caux/dce110/aux_engine_dce110.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff
On Tue, Nov 7, 2017 at 2:52 PM, Ernst Sjöstrand wrote:
> 2017-11-07 15:18 GMT+01:00 Deucher, Alexander :
>>> -Original Message-
>>> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
>>> Of Ernst Sjöstrand
>>> Sent: Monday, November 06, 2017 6:55 PM
>>> To: amd-gfx@list
Thanks, Dan, for bringing this to our attention. We (the display guys here)
weren't aware of smatch and will give it a spin and try to address some of the
remaining items (after your, Dave's, and Ernst's patches).
Harry
On 2017-11-06 06:34 AM, Dan Carpenter wrote:
> Linux-next was offline for t
2017-11-07 15:18 GMT+01:00 Deucher, Alexander :
>> -Original Message-
>> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
>> Of Ernst Sjöstrand
>> Sent: Monday, November 06, 2017 6:55 PM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Ernst Sjöstrand
>> Subject: [PATCH 3/3
On 2017-11-06 02:30 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This fixes all the current smatch:
> warn: inconsistent indenting
>
> Signed-off-by: Dave Airlie
Reviewed-by: Harry Wentland
Harry
> ---
> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +-
> .../gpu/drm/amd/displa
On 2017-11-07 08:05 AM, Andrey Grodzovsky wrote:
> Reviewed-by: Andrey Grodzovsky
>
>
> On 11/06/2017 02:21 PM, Dave Airlie wrote:
>> From: Dave Airlie
>>
>> Reported-by smatch:
>> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:966
>> dc_commit_planes_to_stream() error: potential null dere
On 2017-11-06 02:41 PM, Christian König wrote:
> Am 06.11.2017 um 20:17 schrieb Dave Airlie:
>> From: Dave Airlie
>>
>> smatch reported:
>> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71:
>> warning: non-ANSI function declaration of function
>> 'dal_cmd_t
On 2017-11-06 02:17 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> smatch reported:
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71:
> warning: non-ANSI function declaration of function
> 'dal_cmd_tbl_helper_dce80_get_table'
> drivers/gpu/drm/amd/amdgpu
On Sat, Nov 4, 2017 at 10:43 AM, Christian König
wrote:
> Adding the extra reservation of the 32bit space to the 64bit manager is
> complete nonsense and just a waste of memory and CPU cycles.
>
> Signed-off-by: Christian König
Reviewed-by: Alex Deucher
> ---
> amdgpu/amdgpu_device.c | 24 +
On Sat, Nov 4, 2017 at 10:43 AM, Christian König
wrote:
> No functional change.
>
> Signed-off-by: Christian König
Reviewed-by: Alex Deucher
> ---
> amdgpu/amdgpu_vamgr.c | 27 ++-
> 1 file changed, 14 insertions(+), 13 deletions(-)
>
> diff --git a/amdgpu/amdgpu_vamgr
On 11/7/2017 5:07 PM, Mark Brown wrote:
On Tue, Nov 07, 2017 at 07:26:03PM +0530, Mukunda,Vijendar wrote:
Removing URL links and commit-ready description in v2.
This doesn't really answer my question:
These two URLs are different, what was being reviewed here? What is
Commit-Ready suppose
On 07/11/17 02:44 PM, Christian König wrote:
> Set bo->resv to ttm_resv during BO cleanup. This way freed BOs can be
> better reaped during eviction.
>
> Signed-off-by: Roger He
> Signed-off-by: Christian König
KASAN caught some badness while running piglit with this applied, see
the attached d
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Pixel Ding
> Sent: Monday, November 06, 2017 10:08 PM
> To: ckoenig.leichtzumer...@gmail.com; amd-gfx@lists.freedesktop.org
> Cc: Ding, Pixel
> Subject: [PATCH] drm/amdgpu: bypass FB resizing
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Ernst Sjöstrand
> Sent: Monday, November 06, 2017 6:55 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Ernst Sjöstrand
> Subject: [PATCH 3/3] amdgpu/dc: Fix missing null checks in amdgpu_dm.c
>
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Ernst Sjöstrand
> Sent: Monday, November 06, 2017 6:55 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Ernst Sjöstrand
> Subject: [PATCH 2/3] amdgpu/dc: Fix potential null dereference in
> amdgpu
On Tue, Nov 07, 2017 at 07:26:03PM +0530, Mukunda,Vijendar wrote:
> Removing URL links and commit-ready description in v2.
This doesn't really answer my question:
> > These two URLs are different, what was being reviewed here? What is
> > Commit-Ready supposed to mean?
Please don't top post, re
Set bo->resv to ttm_resv during BO cleanup. This way freed BOs can be
better reaped during eviction.
Signed-off-by: Roger He
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_bo.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/d
Reviewed-by: Andrey Grodzovsky
On 11/06/2017 02:30 PM, Dave Airlie wrote:
From: Dave Airlie
This fixes all the current smatch:
warn: inconsistent indenting
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 +-
.../gpu/drm/amd/display/dc/bios/command_
Reviewed-by: Andrey Grodzovsky
On 11/06/2017 02:21 PM, Dave Airlie wrote:
From: Dave Airlie
Reported-by smatch:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:966
dc_commit_planes_to_stream() error: potential null dereference 'flip_addr'.
(kcalloc returns null)
drivers/gpu/drm/amd/amd
On 11/06/2017 02:41 PM, Christian König wrote:
Am 06.11.2017 um 20:17 schrieb Dave Airlie:
From: Dave Airlie
smatch reported:
drivers/gpu/drm/amd/amdgpu/../display/dc/bios/dce80/command_table_helper_dce80.c:351:71:
warning: non-ANSI function declaration of function
'dal_cmd_tbl_helper_dce8
On Tue, Nov 7, 2017 at 9:26 AM, Pixel Ding wrote:
> From: pding
>
> ...
>
> Signed-off-by: pding
You need to fix your git config user.name.
Gražvydas
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin
Signed-off-by: Tom St Denis
---
src/lib/read_vram.c | 44
1 file changed, 28 insertions(+), 16 deletions(-)
diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c
index 89d55ff1bef6..b78d06194add 100644
--- a/src/lib/read_vram.c
+++ b/src/lib/read_vra
Am 07.11.2017 um 08:26 schrieb Pixel Ding:
From: pding
This lock is used during register accessing in SRIOV guest.
The register accessing could happen both in irq enabled and
irq disabled cases. Always use irq-safe lock.
Signed-off-by: pding
Reviewed-by: Christian König
---
drivers/gpu
Am 07.11.2017 um 08:26 schrieb Pixel Ding:
From: pding
This lock is used during register accessing in SRIOV guest
since KIQ uses general ring submission (amdgpu_ring_commit).
The register accessing could happen both in irq enabled and
irq disabled cases. Always use irq-safe lock.
I would rath
Am 07.11.2017 um 00:54 schrieb Ernst Sjöstrand:
From smatch:
error: we previously assumed X could be null
Signed-off-by: Ernst Sjöstrand
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm
Am 07.11.2017 um 03:48 schrieb Chunming Zhou:
Otherwise there could be page protection.
Change-Id: I1f6c81002fb2ba21c17cdc14fdde86579b28374e
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/dr
Am 07.11.2017 um 03:48 schrieb Chunming Zhou:
We must remove the fence callback.
Change-Id: I5d58a3a43b82fefd6c211c4128b0c9187c191e7f
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/
Am 07.11.2017 um 04:08 schrieb Pixel Ding:
From: pding
It introduces 900ms latency in exclusive mode which causes failure
of driver loading. Host can resize the BAR before guest staring,
so the resizing is not necessary here.
Signed-off-by: pding
Reviewed-by: Christian König
---
driver
Hi Gary,
well that patch is nonsense to begin with.
amdgpu_device_init() does quite a bunch of other initialization which is
not cleaned up by amdgpu_device_fini(), so the debugfs files are only
the tip of the iceberg here.
Please revert 2316518efc459928ad1d3d2d3511ea5fbda19475 and then we c
Hi Christian,
The feature is for GPU virtualization and has been checked in, you can refer to
the following patch or commit 75b126427778218b36cfb68637e4f8d0e584b8ef.
From 2316518efc459928ad1d3d2d3511ea5fbda19475 Mon Sep 17 00:00:00 2001
From: pding
Date: Mon, 23 Oct 2017 17:22:09 +0800
Subject:
On 11/6/2017 9:54 PM, Mark Brown wrote:
On Fri, Nov 03, 2017 at 04:35:45PM -0400, Alex Deucher wrote:
Minimum time required between power On of codec and read
of RT5645_VENDOR_ID2 is 400msec. We should wait and attempt
before erroring out.
So the description says we have to wait 400ms befor
I got the infomation about this issue:
"
* If I install #491963 (failed in the report) with “./amdgpu-pro-install -y
--opencl=legacy” command, the test passed. It failed when rocm is also
installed with “./amdgpu-pro-install -y --opencl=legacy,rocm” command."
So I guess the hung is related
Removing URL links and commit-ready description in v2.
On Monday 06 November 2017 09:18 PM, Mark Brown wrote:
On Fri, Nov 03, 2017 at 04:35:43PM -0400, Alex Deucher wrote:
Signed-off-by: Vijendar Mukunda
Signed-off-by: Akshu Agrawal
Reviewed-on: https://chromium-review.googlesource.com/6596
On 07/11/17 04:29 AM, S, Shirish wrote:
> From: Shirish S
>
> This patch fixes static checker warning of
> "warn: cast after binop" introduced by
> 4d3e00dad80a: "drm/amd/display : add high part address calculation for
> underlay"
>
> Signed-off-by: Shirish S
> ---
> drivers/gpu/drm/amd/displ
54 matches
Mail list logo
