[PATCH] drm/amdgpu:cancel timer of virtual DCE(v2)

2017-11-15 Thread Monk Liu
virtual DCE Timer structure is already released after its sw_fini(), so we need to cancel the its Timer in hw_fini() otherwise the Timer canceling is missed. v2: use for loop and num_crtc to replace original code Change-Id: I03d6ca7aa07591d287da379ef4fe008f06edaff6 Signed-off-by: Monk Liu

[PATCH] drm/amdgpu:cancel timer of virtual DCE(v2)

2017-11-15 Thread Monk Liu
virtual DCE Timer structure is already released after its sw_fini(), so we need to cancel the its Timer in hw_fini() otherwise the Timer canceling is missed. v2: use for loop and num_crtc to replace original code Change-Id: I03d6ca7aa07591d287da379ef4fe008f06edaff6 Signed-off-by: Monk Liu

RE: [PATCH 2/2] drm/amdgpu:cancel timer of virtual DCE

2017-11-15 Thread Liu, Monk
Good idea -Original Message- From: Deucher, Alexander Sent: 2017年11月16日 12:14 To: Liu, Monk ; amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: RE: [PATCH 2/2] drm/amdgpu:cancel timer of virtual DCE > -Original Message- > From: amd-gfx

RE: [PATCH 2/2] drm/amdgpu:cancel timer of virtual DCE

2017-11-15 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, November 15, 2017 10:14 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH 2/2] drm/amdgpu:cancel timer of virtual DCE > > virtual DCE Timer

RE: [PATCH 1/2] drm/ttm: fix ttm_mem_evict_first once more

2017-11-15 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Wednesday, November 15, 2017 8:32 PM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org

[PATCH 2/2] drm/amdgpu:cancel timer of virtual DCE

2017-11-15 Thread Monk Liu
virtual DCE Timer structure is already released after its sw_fini(), so we need to cancel the its Timer in hw_fini() otherwise the Timer canceling is missed. Change-Id: I03d6ca7aa07591d287da379ef4fe008f06edaff6 Signed-off-by: Monk Liu ---

[PATCH 1/2] drm/amdgpu:fix virtual dce bug

2017-11-15 Thread Monk Liu
this fix the issue that access memory after freed after driver unloaded. Change-Id: I64e2488c18f5dc044b57c74567785da21fc028da Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

RE: [PATCH] drm/amdgpu: require a root bus window above 4GB for BAR resize

2017-11-15 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Wednesday, November 15, 2017 3:13 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: require a root bus window above 4GB for > BAR resize > >

[PATCH] drm/amdgpu: require a root bus window above 4GB for BAR resize

2017-11-15 Thread Christian König
Don't even try to resize the BAR when there is no window above 4GB. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[pull] amdgpu dc drm-next-4.15-dc

2017-11-15 Thread Alex Deucher
Hi Dave, Various fixes for DC for 4.15. It doesn't look like you pulled the smatch fixes for DC that I sent out last week. Those are also on this branch. The following changes since commit f368d3bfde225199eef2216b03e0ba4944a3434a: amd/display: Fix potential null dereference in dce_calcs.c

[pull] amdgpu drm-next-4.15

2017-11-15 Thread Alex Deucher
Hi Dave, Misc fixes for 4.15. The following changes since commit a9386bb051931778436db3dd6e3a163f7db92b56: Merge tag 'drm-misc-next-fixes-2017-11-08' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2017-11-09 11:59:30 +1000) are available in the git repository at:

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-15 Thread Chris Wilson
Quoting Christian König (2017-11-15 18:56:43) > Am 15.11.2017 um 18:43 schrieb Chris Wilson: > > Quoting Christian König (2017-11-15 17:34:07) > >> Am 15.11.2017 um 17:55 schrieb Chris Wilson: > >>> Quoting Chris Wilson (2017-11-14 14:34:05) > Quoting Christian König (2017-11-14 14:24:44) >

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-15 Thread Christian König
Am 15.11.2017 um 18:43 schrieb Chris Wilson: Quoting Christian König (2017-11-15 17:34:07) Am 15.11.2017 um 17:55 schrieb Chris Wilson: Quoting Chris Wilson (2017-11-14 14:34:05) Quoting Christian König (2017-11-14 14:24:44) Am 06.11.2017 um 17:22 schrieb Chris Wilson: Quoting Christian

RE: [PATCH] drm/amdgpu:fix virtual dce bug

2017-11-15 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, November 15, 2017 4:11 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH] drm/amdgpu:fix virtual dce bug > > this fix the issue that access

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-15 Thread Chris Wilson
Quoting Christian König (2017-11-15 17:34:07) > Am 15.11.2017 um 17:55 schrieb Chris Wilson: > > Quoting Chris Wilson (2017-11-14 14:34:05) > >> Quoting Christian König (2017-11-14 14:24:44) > >>> Am 06.11.2017 um 17:22 schrieb Chris Wilson: > Quoting Christian König (2017-10-30 14:59:04) >

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-15 Thread Christian König
Am 15.11.2017 um 17:55 schrieb Chris Wilson: Quoting Chris Wilson (2017-11-14 14:34:05) Quoting Christian König (2017-11-14 14:24:44) Am 06.11.2017 um 17:22 schrieb Chris Wilson: Quoting Christian König (2017-10-30 14:59:04) @@ -126,17 +127,28 @@ reservation_object_add_shared_inplace(struct

[PATCH xf86-video-amdgpu] Add amdgpu_dirty_src_drawable helper

2017-11-15 Thread Michel Dänzer
From: Michel Dänzer Allows tidying up redisplay_dirty slightly. Signed-off-by: Michel Dänzer --- src/amdgpu_drv.h | 20 ++-- src/amdgpu_kms.c | 7 ++- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git

[PATCH xf86-video-ati] Use correct ScrnInfoPtr in redisplay_dirty

2017-11-15 Thread Michel Dänzer
From: Michel Dänzer We used the destination pixmap's screen for flushing drawing commands. But when we are the master screen, the destination pixmap is from the slave screen. Fixes crash when the slave screen isn't using the same acceleration architecture as us.

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-15 Thread Chris Wilson
Quoting Chris Wilson (2017-11-14 14:34:05) > Quoting Christian König (2017-11-14 14:24:44) > > Am 06.11.2017 um 17:22 schrieb Chris Wilson: > > > Quoting Christian König (2017-10-30 14:59:04) > > >> @@ -126,17 +127,28 @@ reservation_object_add_shared_inplace(struct > > >> reservation_object *obj,

[PATCH] drm/amd/display: remove unnecessary cast and use kcalloc instead of kzalloc

2017-11-15 Thread Colin King
From: Colin Ian King Use kcalloc instead of kzalloc and the cast on the return from kzalloc is unnecessary and can be removed. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/basics/logger.c | 5 ++--- 1 file changed, 2

[PATCH umr] Add UMC60 block for vega10

2017-11-15 Thread Tom St Denis
Signed-off-by: Tom St Denis --- scripts/soc15_parse.sh| 1 + src/lib/asic/vega10.c | 1 + src/lib/ip/CMakeLists.txt | 1 + src/lib/ip/umc60.c| 55 +++ src/lib/ip/umc60_bits.i | 10 +

Re: [PATCH 2/2] drm/ttm: completely rework ttm_bo_delayed_delete

2017-11-15 Thread Michel Dänzer
On 15/11/17 01:31 PM, Christian König wrote: > There is no guarantee that the next entry on the ddelete list stays on > the list when we drop the locks. > > Completely rework this mess by moving processed entries on a temporary > list. > > Signed-off-by: Christian König

[PATCH 1/2] drm/ttm: fix ttm_mem_evict_first once more

2017-11-15 Thread Christian König
The code path isn't hit at the moment, but we need to take the lock to add the BO back to the LRU. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c

Re: [PATCH libdrm] amdgpu: Disable deadlock test suite for Vega 10

2017-11-15 Thread Christian König
Am 14.11.2017 um 15:07 schrieb Andrey Grodzovsky: The suite stalls the CP, until RCA is done the suite is disabled to not disrupt regression testing. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König Since you now have commit

[PATCH] drm/amdgpu:fix virtual dce bug

2017-11-15 Thread Monk Liu
this fix the issue that access memory after freed after driver unloaded. Change-Id: I64e2488c18f5dc044b57c74567785da21fc028da Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [DC] [CRTC:44:crtc-0] vblank wait timed out

2017-11-15 Thread Michel Dänzer
On 14/11/17 07:54 PM, Lazare, Jordan wrote: > > Would you mind attaching the full dmesg? We'll have a look. Attached. This is with Alex's drm-next-4.15-dc branch, so it doesn't seem to have been introduced by this week's DC changes. -- Earthling Michel Dänzer |

Re: [DC] [CRTC:44:crtc-0] vblank wait timed out

2017-11-15 Thread Michel Dänzer
On 15/11/17 02:52 AM, Andrey Grodzovsky wrote: > Can you try this patch ? I noticed there is a new API to use to wait for > flips instead of what we are using now. I'll give it a spin, thanks. It'll take some time to have any certainty it's fixed though. -- Earthling Michel Dänzer

Re: [DC] [CRTC:44:crtc-0] vblank wait timed out

2017-11-15 Thread Michel Dänzer
On 14/11/17 09:18 PM, Matthias wrote: > Hi, > > might this be related to this bug I reportet some time ago? > > https://bugs.freedesktop.org/show_bug.cgi?id=103489 Seems unlikely. I only see a single "vblank wait timed out" splat when the display goes off, and no machine hangs. -- Earthling

Re: [PATCH] amdgpu: Don't use DRM_ERROR when failing to allocate a BO

2017-11-15 Thread Christian König
Am 14.11.2017 um 18:54 schrieb Deucher, Alexander: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Michel Dänzer Sent: Tuesday, November 14, 2017 12:52 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH] amdgpu: Don't use DRM_ERROR when