Re: [PATCH 17/25] drm/amd/display: Do DC mode-change check when adding CRTCs

On 2017-11-16 10:32 AM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" Within atomic check, dm_update_crtcs_state is called twice. First to remove from the dc_state, and subsequently to add to it. In both calls, a secondary mode-change check is done using dc-level

Re: [PATCH 2/4] drm: amd: Fix line continuation formats

On Thu, Nov 16, 2017 at 10:50 AM, Joe Perches wrote: > On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote: >> On 2017-11-16 10:27 AM, Joe Perches wrote: >> > Line continuations with excess spacing causes unexpected output. > [] >> > @@ -872,9 +870,8 @@ static bool

Re: [PATCH] drm/amdgpu/gmc9: make some ECC messages debug only

Am 17.11.2017 um 17:41 schrieb Alex Deucher: To avoid spamming the logs on non-ECC boards. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH] drm/amdgpu/gmc9: make some ECC messages debug only

To avoid spamming the logs on non-ECC boards. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

Re: [PATCH 3/3] drm/amdgpu: expose the VA above the hole to userspace

On Thu, Nov 16, 2017 at 5:22 AM, Christian König wrote: > Let userspace know how much area we have above the 48bit VA hole on > Vega10. > > Signed-off-by: Christian König Please add a patch to bump the driver version as well. With

Re: [PATCH 1/3] drm/amdgpu: fix VA hole handling on Vega10 v2

On 17/11/17 11:28 AM, Christian König wrote: > Ping? Michel, Alex can somebody take a look? Patch 2 is Reviewed-by: Michel Dänzer With patches 1 & 3, it's not 100% clear to me what the idea is behind the handling of the hole on the kernel and userspace side. Maybe you

Re: [PATCH 4/4] drm/amdgpu: fix VCE buffer placement restrictions

On Fri, Nov 17, 2017 at 5:12 AM, Christian König wrote: > Turned out that VCE still has a placement restriction that BOs can't > cross a 4GB boundary. > > Fix this by adding a command submission parser prepass to correctly > place the buffers. > > Signed-off-by:

Re: [PATCH 3/4] drm/amdgpu: align GTT start to 4GB

On Fri, Nov 17, 2017 at 5:12 AM, Christian König wrote: > For VCE to work properly the start of the GTT space must be aligned to a > 4GB boundary. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |

Re: [PATCH 2/4] drm/amdgpu: remove VRAM size reduction

On Fri, Nov 17, 2017 at 5:12 AM, Christian König wrote: > Remove some outdated comments and all code which tries to reduce the VRAM size > mapped into the MC. > > This is superfluous and misleading since we never actually program the size. > > Signed-off-by:

Re: [PATCH 1/4] drm/amdgpu: always make gart.table_addr 64bit

On Fri, Nov 17, 2017 at 5:12 AM, Christian König wrote: > Fixing warning/compile errors on 32bit kernels. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- >

Re: [PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap macro in program_size_and_rotation

On 2017-11-10 05:31 PM, Gustavo A. R. Silva wrote: > Make use of the swap macro instead of _manually_ swapping values > and remove unnecessary variable swap. > > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo

Re: [PATCH] drm/amd/display/dc/core/dc_resource: use swap macro in rect_swap_helper

On 2017-11-10 05:38 PM, Gustavo A. R. Silva wrote: > Make use of the swap macro instead of _manually_ swapping values > and remove unnecessary variable temp. > > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo

Re: [PATCH] drm/amdgpu: remove amdgpu_pm_sysfs_init in ci_dpm.c

On Fri, Nov 17, 2017 at 3:15 AM, Rex Zhu wrote: > this function was called in amdgpu_device_init > > Change-Id: I69aa77ba7db41d2202c3d6ffd606965f0cad3106 > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher Alex > --- >

Re: [PATCH] drm/amd/pp: fix typecast error in powerplay.

On Fri, Nov 17, 2017 at 3:59 AM, Rex Zhu wrote: > resulted in data truncation > > Change-Id: I110011ba402a85fade89bb797adcf7318c0f0eb0 > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- >

Re: Operation context for TTM

On 17/11/17 11:49 AM, Christian König wrote: > Hi everyone, > > Michel already reviewed this back in April, but I didn't found time to > actually fully test it before now. > > So sending this one out once more because it's an interface change which > affects all driver using TTM. > > Please

[PATCH 5/8] drm/ttm: add context to driver move callback as well

Instead of passing the parameters manually. Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 21 +++-- drivers/gpu/drm/nouveau/nouveau_bo.c| 27

[PATCH 3/8] drm/ttm: use an operation context for ttm_bo_mem_space v2

Instead of specifying interruptible and no_wait_gpu manually. v2: rebase Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 11

[PATCH 2/8] drm/ttm: use an operation ctx for ttm_bo_init_reserved

Instead of specifying if sleeping should be interruptible. Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- drivers/gpu/drm/ttm/ttm_bo.c | 12 +---

[PATCH 8/8] drm/amdgpu: use the new TTM bytes moved counter v2

Instead of the global statistics use the per context bytes moved counter. v2: rebased Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 +++--

[PATCH 6/8] drm/ttm: add number of bytes moved to the operation context

Add some statistics how many bytes we have moved. Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/ttm/ttm_bo.c | 1 + include/drm/ttm/ttm_bo_api.h | 1 + 2 files changed, 2 insertions(+) diff --git

[PATCH 7/8] drm/amdgpu: forward operation context to ttm_bo_mem_space

This way we can finally use some more stats. Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff

[PATCH 1/8] drm/ttm: add operation ctx to ttm_bo_validate v2

Give moving a BO into place an operation context to work with. v2: rebased Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 14 -- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

Operation context for TTM

Hi everyone, Michel already reviewed this back in April, but I didn't found time to actually fully test it before now. So sending this one out once more because it's an interface change which affects all driver using TTM. Please review and/or comment. Regards, Christian.

Re: [Resend 1/3] drm/amd/include:cleanup vega10 sdma0/1 header files.

Resend patch-set which cleanup vega10's sdma0/1,hdp,mp header files. No source code change from previous thread. Just omit the preimage for deletes and omit the renames to format a resonable size patch. -- -Feifei On 11/17/2017 06:27 PM, Feifei Xu wrote: To remove include/asic_reg/vega10

Re: [Resend 1/3] drm/amd/include:cleanup vega10 sdma0/1 header files.

Am 17.11.2017 um 11:27 schrieb Feifei Xu: To remove include/asic_reg/vega10 folder,create IP folders sdma0/1. This patch cleanup asic_reg/vega10/SDMA folders. Change-Id: I861f4047cb23154f9094553b602157b01da9028e Signed-off-by: Feifei Xu Not sure if we should distinct

[PATCH] drm/amdgpu: fix rmmod KCQ disable failed error

If gfx_v8_0_hw_fini is called after amdgpu_ucode_fini_bo, we will hit KCQ disabled failed. Let amdgpu_ucode_fini_bo run after gfx_v8_0_hw_fini. BUG: SWDEV-135547 Signed-off-by: Wang Hongcheng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 3 +++

[Resend 3/3] drm/amd/include:cleanup vega10 mp header files.

To remove include/asic_reg/vega10 folder, this patch cleanup asic_reg/vega10/MP folder, and remove unused mp_9_0_default.h. Change-Id: Id53e6ab7a8bc78ff61457836b1b3ce499b158610 Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 4 +-

Re: [PATCH 1/3] drm/amdgpu: fix VA hole handling on Vega10 v2

Ping? Michel, Alex can somebody take a look? Thanks, Christian. Am 16.11.2017 um 11:22 schrieb Christian König: Similar to the CPU address space the VA on Vega10 has a hole in it. v2: use dev_dbg instead of dev_err Signed-off-by: Christian König ---

[Resend 2/3] drm/amd/include:cleanup vega10 hdp header files.

To remove include/asic_reg/vega10 folder,create IP folder hdp. This patch cleanup asic_reg/vega10/HDP folder, and remove unused hdp_4_0_default.h file. Change-Id: Ia7cd2e660ceb89a1096c195c6a67677714ccbd69 Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

[Resend 1/3] drm/amd/include:cleanup vega10 sdma0/1 header files.

To remove include/asic_reg/vega10 folder,create IP folders sdma0/1. This patch cleanup asic_reg/vega10/SDMA folders. Change-Id: I861f4047cb23154f9094553b602157b01da9028e Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 8

[PATCH 4/4] drm/amdgpu: fix VCE buffer placement restrictions

Turned out that VCE still has a placement restriction that BOs can't cross a 4GB boundary. Fix this by adding a command submission parser prepass to correctly place the buffers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 90

[PATCH 2/4] drm/amdgpu: remove VRAM size reduction

Remove some outdated comments and all code which tries to reduce the VRAM size mapped into the MC. This is superfluous and misleading since we never actually program the size. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 30

[PATCH 1/4] drm/amdgpu: always make gart.table_addr 64bit

Fixing warning/compile errors on 32bit kernels. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.h

[PATCH 3/4] drm/amdgpu: align GTT start to 4GB

For VCE to work properly the start of the GTT space must be aligned to a 4GB boundary. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amd/pp: fix typecast error in powerplay.

resulted in data truncation Change-Id: I110011ba402a85fade89bb797adcf7318c0f0eb0 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/process_pptables_v1_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] Revert "drm/radeon: dont switch vt on suspend"

On 16/11/17 07:09 PM, Alex Deucher wrote: > Ping? > > > On Tue, Nov 14, 2017 at 5:33 PM, Alex Deucher wrote: >> Fixes distorted colors on some cards on resume from suspend. >> >> This reverts commit b9729b17a414f99c61f4db9ac9f9ed987fa0cbfe. >> >> Bug:

Re: [PATCH] drm/amd/amdgpu: fix over-bound accessing in amdgpu_cs_wait_any_fence

Please shorten the commit message a bit, we really don't need the full backtrace here. Additional to that didn't Monk stumbled over the same issue before? I briefly remember seeing that patch before. Anyway patch itself is Reviewed-by: Christian König . Regards,