Which branch to test latest support for Raven Ridge?

Hi all, I've been testing and mitigating the Raven Ridge crashes. I've just compiled the kernel https://cgit.freedesktop.org/~agd5f/linux/ at branch drm-next-4.18-wip to see if it would have the necessary fix for video hangs/freezes. Unfortunetely, it still crashes in the same situations. Which

[PATCHv3] drm/amdkfd: Remove vla

There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. Switch to a constant value that covers all hardware. [1] https://lkml.org/lkml/2018/3/7/621 Reviewed-by: Felix Kuehling Acked-by: Christian König

Re: [PATCH] drm/gpu-sched: fix force APP kill hang(v4)

On 04/13/2018 10:31 AM, Christian König wrote: Am 13.04.2018 um 09:01 schrieb Emily Deng: issue: there are VMC page fault occurred if force APP kill during 3dmark test, the cause is in entity_fini we manually signal all those jobs in entity's queue which confuse the sync/dep mechanism:

Re: RFC for a render API to support adaptive sync and VRR

On 2018-04-12 05:38 PM, Stéphane Marchesin wrote: > On Tue, Apr 10, 2018 at 12:37 AM, Michel Dänzer wrote: >> On 2018-04-10 08:45 AM, Christian König wrote: >>> Am 09.04.2018 um 23:45 schrieb Manasi Navare: Thanks for initiating the discussion. Find my comments below:

Re: RFC for a render API to support adaptive sync and VRR

On 2018-04-13 12:04 PM, Daniel Vetter wrote: > On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland wrote: >> Adding dri-devel, which I should've included from the start. > > Top posting, because I'm lazy and was out sick ... > > Few observations: > - Stéphane has a great point which seems

Re: [PATCH] drm/amdgpu: defer test IBs on the rings at boot (V2)

On Fri, Apr 13, 2018 at 9:25 AM, Christian König wrote: > Am 13.04.2018 um 10:31 schrieb Shirish S: >> >> amdgpu_ib_ring_tests() runs test IB's on rings at boot >> contributes to ~500 ms of amdgpu driver's boot time. >> >> This patch defers it and ensures that its

[PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init

Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz") added support for the "BT_I2S" ACP i2s channel. As part of this change, one additional acp resource was added, but the "num_resource" count was accidentally incremented by 2. This incorrect count eventually causes

Re: RFC for a render API to support adaptive sync and VRR

On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland wrote: > Adding dri-devel, which I should've included from the start. Top posting, because I'm lazy and was out sick ... Few observations: - Stéphane has a great point which seems to have been ignored thus far. - Where's the VK extension

[PATCH v5 1/2] drm/amdgpu/gmc: steal the appropriate amount of vram for fw hand-over (v2)

From: Alex Deucher Steal 9 MB for vga emulation and fb if vga is enabled, otherwise, steal enough to cover the current display size as set by the vbios. If no memory is used (e.g., secondary or headless card), skip stolen memory reserve. v2: skip reservation if vram is

[PATCH v5 2/2] drm/amdgpu: Free VGA stolen memory as soon as possible.

Reserved VRAM is used to avoid overriding pre OS FB. Once our display stack takes over we don't need the reserved VRAM anymore. v2: Remove comment, we know actually why we need to reserve the stolen VRAM. Fix return type for amdgpu_ttm_late_init. v3: Return 0 in amdgpu_bo_late_init, rebase on

Re: [PATCH] drm/amdgpu: defer test IBs on the rings at boot (V2)

Am 13.04.2018 um 10:31 schrieb Shirish S: amdgpu_ib_ring_tests() runs test IB's on rings at boot contributes to ~500 ms of amdgpu driver's boot time. This patch defers it and ensures that its executed in amdgpu_info_ioctl() if it wasn't scheduled. V2: Use queue_delayed_work() &

RE: [PATCH 10/21] drm/amd/display: Add back code to allow for rounding error

Thanks for the comments. The input parameters are intended as uHz, but units do get translated within the function. We did not want to create new unnecessary parameters on the stack, which led up to the slightly confusing units. Maybe a better comment here would also help. And indeed, the

Re: [PATCH xf86-video-amdgpu 3/5] Keep CRTC properties consistent

On 2018-04-12 06:48 PM, Leo Li wrote: > > A side question: How does xrandr display lengthy properties, like LUTs? Presumably it would be displayed the same way as the EDID property, e.g.: EDID: 000022f06f3201010101

答复: [PATCH 2/2] drm/amd/pp: Remove dead interface

Reviewed-by: Evan Quan 发件人: amd-gfx 代表 Rex Zhu 发送时间: 2018年4月13日 16:19:14 收件人: amd-gfx@lists.freedesktop.org 抄送: Zhu, Rex 主题: [PATCH 2/2] drm/amd/pp: Remove dead interface

答复: [PATCH 1/2] drm/amdgpu: Reserved vram for smu to save debug info.

Do we need to add check for adev->pm.smu_prv_buffer_size before calling pp_reserve_vram_for_smu()? I mean maybe for dev->pm.smu_prv_buffer_size ==0, there is no need to proceed pp_reserve_vram_for_smu. Regards, Evan 发件人: amd-gfx

[PATCH 1/2] drm/amdgpu: Reserved vram for smu to save debug info.

Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 44 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6

[PATCH 1/2] drm/amdgpu: Reserved vram for smu to save debug info.

Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 44 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6

[PATCH 2/2] drm/amd/pp: Remove dead interface

Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h| 6 -- drivers/gpu/drm/amd/include/kgd_pp_interface.h | 5 - drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 29 -- 3 files changed, 40 deletions(-) diff --git

[PATCH] drm/amdgpu: defer test IBs on the rings at boot (V2)

amdgpu_ib_ring_tests() runs test IB's on rings at boot contributes to ~500 ms of amdgpu driver's boot time. This patch defers it and ensures that its executed in amdgpu_info_ioctl() if it wasn't scheduled. V2: Use queue_delayed_work() & flush_delayed_work(). Signed-off-by: Shirish S

Re: [PATCH] drm/amdgpu: defer test IBs on the rings at boot

On 4/13/2018 12:38 PM, Christian König wrote: Am 13.04.2018 um 09:01 schrieb S, Shirish: On 4/13/2018 11:53 AM, Christian König wrote: Am 13.04.2018 um 06:07 schrieb Shirish S: amdgpu_ib_ring_tests() runs test IB's on rings at boot contributes to ~500 ms of amdgpu driver's boot time.

Re: [PATCH] drm/radeon: change function signature to pass full range

On Thu, Apr 12, 2018 at 09:33:33PM +0200, Mathieu Malaterre wrote: > In function ‘radeon_process_i2c_ch’ a comparison of a u8 value against > 255 is done. Since it is always false, change the signature of this > function to use an `int` instead, which match the type used in caller: >

Re: [PATCH] drm/amd/pp: Move common code to smu_help.c

On Fri, Apr 13, 2018 at 02:08:15PM +0800, Rex Zhu wrote: > Signed-off-by: Rex Zhu Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 56 > ++ > drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.h | 21

Re: [PATCH 2/2] Revert "drm/amd/display: disable CRTCs with NULL FB on their primary plane (V2)"

On 2018-04-13 04:55 AM, S, Shirish wrote: > Hi Harry, Alex, > > The solution given while reviewing my patch was that "DC should support > enabling a CRTC without a framebuffer." I think it's weird that an enabled CRTC would end up having a NULL FB during normal operation in the first place. Any

Re: [PATCH] drm/amdgpu: defer test IBs on the rings at boot

Am 13.04.2018 um 09:01 schrieb S, Shirish: On 4/13/2018 11:53 AM, Christian König wrote: Am 13.04.2018 um 06:07 schrieb Shirish S: amdgpu_ib_ring_tests() runs test IB's on rings at boot contributes to ~500 ms of amdgpu driver's boot time. This patch defers it and adds a check to report in

[PATCH] drm/gpu-sched: fix force APP kill hang(v4)

issue: there are VMC page fault occurred if force APP kill during 3dmark test, the cause is in entity_fini we manually signal all those jobs in entity's queue which confuse the sync/dep mechanism: 1)page fault occurred in sdma's clear job which operate on shadow buffer, and shadow buffer's Gart

Re: [PATCH] drm/amdgpu: defer test IBs on the rings at boot

On 4/13/2018 11:53 AM, Christian König wrote: Am 13.04.2018 um 06:07 schrieb Shirish S: amdgpu_ib_ring_tests() runs test IB's on rings at boot contributes to ~500 ms of amdgpu driver's boot time. This patch defers it and adds a check to report in amdgpu_info_ioctl() if it was scheduled or

[PATCH] drm/amd/pp: Move common code to smu_help.c

Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 56 ++ drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.h | 21 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 43 + 3 files changed, 78

Re: [PATCH] drm/gpu-sched: fix force APP kill hang(v3)

Hi Monk/Emily, give me the weekend to take a closer look since I'm very busy this morning. In general the order of ctx_fini and vm fini is very important cause we otherwise dereference invalid pointers here. Regards, Christian. Am 13.04.2018 um 08:18 schrieb Deng, Emily: Hi Monk,

Re: [PATCH] drm/amdgpu: defer test IBs on the rings at boot

Am 13.04.2018 um 06:07 schrieb Shirish S: amdgpu_ib_ring_tests() runs test IB's on rings at boot contributes to ~500 ms of amdgpu driver's boot time. This patch defers it and adds a check to report in amdgpu_info_ioctl() if it was scheduled or not. That is rather suboptimal, but see below.

RE: [PATCH] drm/gpu-sched: fix force APP kill hang(v3)

Hi Monk, Another consideration, it will be better to put amdgpu_ctx_mgr_fini() beneath amdgpu_vm_fini, in this case, it will first set all ctx and vm entity rq to null, then set all the not scheduled job's fence to signal. Best Wishes, Emily Deng > -Original Message- > From:

RE: [PATCH] drm/gpu-sched: fix force APP kill hang(v3)

Hi Monk, Thanks your review, I will refine the code as your suggestion 1),2),3), 4),5). About 6): I think it is no relation to put the amdgpu_ctx_mgr_fini before or after amdgpu_vm_fini. Hi Christian, Do you have any thoughts about 6)? Best Wishes, Emily Deng > -Original