Re: KASAN: use-after-free in amdgpu_ttm_tt_pte_flags

2018-06-08 Thread Christian König
Going to take a look on Monday. Thanks, Christian. Am 08.06.2018 um 16:07 schrieb Michel Dänzer: KASAN picked up something during today's piglit run on amd-staging-drm-next, see attached. I've never seen this one before. ___ amd-gfx mailing list a

[PATCH xf86-video-amdgpu 6/7 v2] Compose non-legacy with legacy regamma LUT

2018-06-08 Thread sunpeng.li
From: "Leo (Sunpeng) Li" Frequently, a user may have non-legacy gamma enabled for monitor correction, while using legacy gamma for things like redshift/nightlight. To do so, we compose the two LUTs. Legacy gamma will be applied first, then non-legacy. i.e. non-legacy_LUT(legacy_LUT(in_color)).

Re: [PATCH 3/3] drm/v3d: Add a note about locking of v3d_fence_create().

2018-06-08 Thread Eric Anholt
Lucas Stach writes: > Am Dienstag, den 05.06.2018, 12:03 -0700 schrieb Eric Anholt: >> This isn't the first time I've had to argue to myself why the '++' was >> safe. > > And now you need to do the same thing with me... > >> Signed-off-by: Eric Anholt >> --- >>  drivers/gpu/drm/v3d/v3d_fence.c |

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-08 Thread Michel Dänzer
On 2018-06-08 04:33 PM, Michel Dänzer wrote: > On 2018-06-08 12:21 AM, Leo Li wrote: >> On 2018-06-06 01:03 PM, Michel Dänzer wrote: >>> On 2018-06-06 06:01 PM, Michel Dänzer wrote: Running Xorg in depth 30[0] results in completely wrong colours (everything has a red tint) with curre

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-08 Thread Michel Dänzer
On 2018-06-08 12:21 AM, Leo Li wrote: > > > On 2018-06-06 01:03 PM, Michel Dänzer wrote: >> On 2018-06-06 06:01 PM, Michel Dänzer wrote: >>> On 2018-06-01 06:03 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" This ended up being different enough from v2 to warrant a new >>>

KASAN: use-after-free in amdgpu_ttm_tt_pte_flags

2018-06-08 Thread Michel Dänzer
KASAN picked up something during today's piglit run on amd-staging-drm-next, see attached. I've never seen this one before. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer [ 386.246490] ==

Re: [PATCH v2] drm/amdgpu/vg20:support new UVD FW version naming convention

2018-06-08 Thread Leo Liu
On 06/07/2018 11:19 AM, James Zhu wrote: Vega20 UVD Firmware has a new version naming convention: [31, 30] for encode interface major [29, 24] for encode interface minor Is this major and minor for encode? The major and minor we current used in driver is for decode. Please double-check.

Re: [PATCH 3/3] drm/v3d: Add a note about locking of v3d_fence_create().

2018-06-08 Thread Lucas Stach
Am Dienstag, den 05.06.2018, 12:03 -0700 schrieb Eric Anholt: > This isn't the first time I've had to argue to myself why the '++' was > safe. And now you need to do the same thing with me... > Signed-off-by: Eric Anholt > --- >  drivers/gpu/drm/v3d/v3d_fence.c | 3 +++ >  1 file changed, 3 inser

Re: [PATCH 2/3] drm/v3d: Remove the bad signaled() implementation.

2018-06-08 Thread Lucas Stach
Am Dienstag, den 05.06.2018, 12:03 -0700 schrieb Eric Anholt: > Since our seqno value comes from a counter associated with the GPU > ring, not the entity (aka client), they'll be completed out of order. > There's actually no need for this code at all, since we don't have > enable_signaling() and th

Re: [PATCH] drm/amdgpu: change gfx8 ib test to use WB

2018-06-08 Thread Christian König
Am 08.06.2018 um 10:37 schrieb S, Shirish: On 6/8/2018 1:08 PM, Christian König wrote: Am 08.06.2018 um 07:23 schrieb zhoucm1: On 2018年06月08日 12:54, Shirish S wrote: This patch is extends the usage of WB in gfx8's ib test which was originally implemented in the below upstream patch: "ed932

Re: [PATCH] drm/amdgpu: update documentation for amdgpu_irq.c

2018-06-08 Thread Michel Dänzer
Hi Slava, On 2018-06-07 11:46 PM, Slava Abramov wrote: > Add/update function level documentation and add reference to amdgpu_irq.c > in amdgpu.rst > > Signed-off-by: Slava Abramov Thanks for working on this. I have some pretty detailed feedback below, but other than that, it looks good. > d

[PATCH] drm/amdgpu: change gfx8 ib test to use WB

2018-06-08 Thread Shirish S
This patch is extends the usage of WB in gfx8's ib test which was originally implemented in the below upstream patch "ed9324a drm/amdgpu: change gfx9 ib test to use WB" For reference below are the reasons for switching to WB: 1)Because when doing IB test we don't want to involve KIQ health status

Re: [PATCH] drm/amdgpu: change gfx8 ib test to use WB

2018-06-08 Thread S, Shirish
On 6/8/2018 1:08 PM, Christian König wrote: Am 08.06.2018 um 07:23 schrieb zhoucm1: On 2018年06月08日 12:54, Shirish S wrote: This patch is extends the usage of WB in gfx8's ib test which was originally implemented in the below upstream patch: "ed9324a drm/amdgpu: change gfx9 ib test to use WB

Re: [PATCH] drm/amdgpu: update documentation for amdgpu_irq.c

2018-06-08 Thread Christian König
Am 07.06.2018 um 23:46 schrieb Slava Abramov: Add/update function level documentation and add reference to amdgpu_irq.c in amdgpu.rst Signed-off-by: Slava Abramov --- Documentation/gpu/amdgpu.rst| 9 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 102 ++--

Re: [PATCH] drm/amdgpu: Correct the ndw of bo update mapping.

2018-06-08 Thread Christian König
Am 08.06.2018 um 07:34 schrieb Emily Deng: For buffer object that has shadow buffer, need twice commands. Signed-off-by: Emily Deng Good catch, Reviewed-by: Christian König . --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu: change gfx8 ib test to use WB

2018-06-08 Thread Christian König
Am 08.06.2018 um 07:23 schrieb zhoucm1: On 2018年06月08日 12:54, Shirish S wrote: This patch is extends the usage of WB in gfx8's ib test which was originally implemented in the below upstream patch: "ed9324a drm/amdgpu: change gfx9 ib test to use WB" You could copy the commit message from ed93

[PATCH v2] drm/amdgpu/vg20:support new UVD FW version naming convention

2018-06-08 Thread James Zhu
Vega20 UVD Firmware has a new version naming convention: [31, 30] for encode interface major [29, 24] for encode interface minor [15, 8] for firmware revision [7, 0] for hardware family id Inside kernel log UVD firmware Version: 1.1.2 (denote major.minor.revision) Signed-off-by: James Zhu