On Tue, Jun 12, 2018 at 11:46 AM, James Zhu wrote:
> Vega20 UVD Firmware has a new version naming convention:
> [31, 30] for encode interface major
> [29, 24] for encode interface minor
> [15, 8] for decode interface minor
> [7, 0] for hardware family id
>
> Signed-off-by: James Zhu
On Wed, Jun 13, 2018 at 4:03 PM, Andrey Grodzovsky
wrote:
> Add documentation for missed parameters.
>
> Signed-off-by: Andrey Grodzovsky
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
Add documentation for missed parameters.
Signed-off-by: Andrey Grodzovsky
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 6d22942..bdd6ffb 100644
at 01:41, Alex Deucher wrote:
On Tue, Jun 5, 2018 at 2:47 AM, Kai-Heng Feng
wrote:
The original issue on these laptops was about _PR3, not audio controller
prevents gfx auto suspending.
Have you verified that this this patch is still necessary with the HDA
driver fix in place?
Yes I did.
On Wed, Jun 13, 2018 at 2:27 PM, Kai-Heng Feng
wrote:
> at 01:41, Alex Deucher wrote:
>
>> On Tue, Jun 5, 2018 at 2:47 AM, Kai-Heng Feng
>> wrote:
>>>
>>> The original issue on these laptops was about _PR3, not audio controller
>>> prevents gfx auto suspending.
>>
>>
>> Have you verified that
On Mon, Jun 4, 2018 at 5:11 AM, Michel Dänzer wrote:
>
> Adding dri-devel.
>
Any opinions?
Alex
>
> On 2018-06-01 08:03 PM, Alex Deucher wrote:
>> Use chapter rather than section to align with the rst markup.
>>
>> Signed-off-by: Alex Deucher
>> ---
>> Documentation/gpu/amdgpu.rst | 2 +-
>>
On Tue, Jun 5, 2018 at 2:47 AM, Kai-Heng Feng
wrote:
> The original issue on these laptops was about _PR3, not audio controller
> prevents gfx auto suspending.
Have you verified that this this patch is still necessary with the HDA
driver fix in place?
Alex
>
> Commit 444d95f0eeef ("Partially
On Mon, Jun 4, 2018 at 4:48 AM, Rex Zhu wrote:
> 1. move ac_power to struct pm from dpm, so can be shared with powerplay
> 2. remove power_source in powerplay, use adev->pm.ac_power instand.
> 3. update ac_power before dispatch power task.
>
> Signed-off-by: Rex Zhu
Reviewed-by: Alex Deucher
thank you. Every effort to make the patches easier to follow is appreciated.
Jan
On Wed, Jun 13, 2018 at 10:39 AM, Zhu, Rex wrote:
> Hi Jan,
>
>
> Thanks for your suggestion. Obvious the patch title was inappropriate. I
> will update it.
>
> In fact, I originally plan to send this patch
- if (adev->powerplay.pp_funcs->powergate_mmhub)
- amdgpu_dpm_powergate_mmhub(adev);
+ if (adev->powerplay.pp_funcs->set_powergating_by_smu)
+ amdgpu_dpm_set_powergating_by_smu(adev,
AMD_IP_BLOCK_TYPE_GMC, 0);
Move this
Am 13.06.2018 um 16:56 schrieb Slava Abramov:
In doc comments for struct amdgpu_mn: destrution -> destruction
Signed-off-by: Slava Abramov
Good catch, Reviewed-by: Christian König .
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
In doc comments for struct amdgpu_mn: destrution -> destruction
Signed-off-by: Slava Abramov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
index
Hi Jan,
Thanks for your suggestion. Obvious the patch title was inappropriate. I will
update it.
In fact, I originally plan to send this patch internally for discussion. So
just thought that "Revert x" can cause the attention.
Best Regards
Rex
From:
Thanks guys, note taken.
Andrey
On 06/13/2018 10:01 AM, Christian König wrote:
Am 13.06.2018 um 15:57 schrieb Michel Dänzer:
On 2018-06-13 03:52 PM, Andrey Grodzovsky wrote:
Yea, will take care of this, this particular warning is all over the
place when you compile so I didn't notice my own
Am 13.06.2018 um 15:57 schrieb Michel Dänzer:
On 2018-06-13 03:52 PM, Andrey Grodzovsky wrote:
Yea, will take care of this, this particular warning is all over the
place when you compile so I didn't notice my own among others.
To avoid that problem, I recommend generating documentation first
Hi Andrey,
On 2018-06-12 04:05 PM, Andrey Grodzovsky wrote:
> Add/update function level documentation and add reference to amdgpu_vm.c
> in amdgpu.rst
>
> v2:
> Fix reference in rst file.
> Fix compilation warnings.
> Add space between function names and params list where
> it's missing.
>
>
On 2018-06-13 03:52 PM, Andrey Grodzovsky wrote:
> Yea, will take care of this, this particular warning is all over the
> place when you compile so I didn't notice my own among others.
To avoid that problem, I recommend generating documentation first
without one's patches applied, then (without
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Rex Zhu
Sent: Wednesday, June 13, 2018 6:34:44 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, Rex
Subject: [PATCH] drm/amd/pp: Add S3 support for OD feature
make custom values survive when S3 sleep
Yea, will take care of this, this particular warning is all over the
place when you compile so I didn't notice my own among others.
Andrey
On 06/13/2018 09:48 AM, Michel Dänzer wrote:
Hi Andrey,
On 2018-06-12 04:05 PM, Andrey Grodzovsky wrote:
Add/update function level documentation and
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Rex Zhu
Sent: Wednesday, June 13, 2018 3:34:05 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, Rex
Subject: [PATCH] drm/amd/pp: Remove SAMU support in powerplay
As the SAMU ip was not supported in linux,
so
On 06/13/2018 08:30 AM, Jan Vesely wrote:
Hi,
can you please improve the commit message?
seeing "Revert $HASH" conveys zero information about the code change.
I'm sorry for bringing this up again, but following AMDGPU/Radeon driver
development is an exercise in frustration for anyone who is
Hi,
can you please improve the commit message?
seeing "Revert $HASH" conveys zero information about the code change.
I'm sorry for bringing this up again, but following AMDGPU/Radeon driver
development is an exercise in frustration for anyone who is not on AMD's
payroll.
git commit logs like:
Am 13.06.2018 um 13:40 schrieb Rex Zhu:
Move the CG enablement out of delay worker thread.
1. CG/PG enablement are part of gpu hw ip initialize, we should
wait for them complete. otherwise, there are some potential conflicts,
for example, Suspend and CG enablement concurrently.
2. better run ib
Move the CG enablement out of delay worker thread.
1. CG/PG enablement are part of gpu hw ip initialize, we should
wait for them complete. otherwise, there are some potential conflicts,
for example, Suspend and CG enablement concurrently.
2. better run ib test after hw initialize completely. That
Enable PG state after CG enabled.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 33 +-
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4
2 files changed, 28 insertions(+), 9 deletions(-)
diff --git
gfx off should be controlled by GFX IP.
Powerplay only export interface to gfx ip.
This logic is same as uvd/vce cg/pg.
1. Delete the gfx pg/off ctrl code in pp_set_powergating_state
this ip function is for smu pg enablement.
2. call set_powergating_by_smu to enable/disalbe power off feature.
gfx off should be controlled by GFX IP.
Powerplay only export interface to gfx ip.
This logic is same as uvd/vce cg/pg.
1. Delete the gfx pg/off ctrl code in pp_set_powergating_state
this ip function is for smu pg enablement.
2. call set_powergating_by_smu to enable/disalbe power off feature.
Raven support gfx off feature instand of gfx powergate,
so use smu10_gfx_off_control as the powergate_gfx backend function.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Some HW ip blocks need call SMU to enter/leave power gate state.
So export common set_powergating_by_smu interface.
1. keep consistent with set_clockgating_by_smu
2. scales easily to powergate other ip(gfx) if necessary
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h
keep consistent with powergate_uvd/vce/mmhub
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 6 +++---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.c | 2 +-
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h | 2 +-
In order to keep consistent with powergate_uvd/vce.
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 4 ++--
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 ++--
drivers/gpu/drm/amd/include/kgd_pp_interface.h| 2 +-
On 2018-06-13 12:55 PM, Huang Rui wrote:
> On Fri, Jun 08, 2018 at 08:15:26PM +0200, Christian König wrote:
>> Going to take a look on Monday.
>>
>
> Christian, have you looked at this issue? If not, can I volunteer to look at
> it?
>
> Michel, may I know which test of piglit trigger this issue?
Am 13.06.2018 um 12:55 schrieb Huang Rui:
On Fri, Jun 08, 2018 at 08:15:26PM +0200, Christian König wrote:
Going to take a look on Monday.
Christian, have you looked at this issue?
Not yet, I'm still busy figuring out why restoring the resize able BAR
config doesn't work as it should.
On Fri, Jun 08, 2018 at 08:15:26PM +0200, Christian König wrote:
> Going to take a look on Monday.
>
Christian, have you looked at this issue? If not, can I volunteer to look at
it?
Michel, may I know which test of piglit trigger this issue? I tried to run
with quick.py, but didn't reproduce
Am 12.06.2018 um 20:37 schrieb Andrey Grodzovsky:
Move all instnaces of this check into a function in amdgpu_gmc.h
Rename the original function to a more proper name.
Signed-off-by: Andrey Grodzovsky
There seems to be two more candidates for that cleanup:
As the SAMU ip was not supported in linux,
so delete the SAMU support in powerplay on
asics Bonarire/Hawwii/Tonga/Fiji/Polaris/vegam.
Signed-off-by: Rex Zhu
---
.../amd/powerplay/hwmgr/smu7_clockpowergating.c| 54 --
.../amd/powerplay/hwmgr/smu7_clockpowergating.h| 1 -
36 matches
Mail list logo