[pull] amdgpu drm-fixes-4.18

2018-06-27 Thread Alex Deucher
Hi Dave, A few fixes for 4.18: - fix a read past the end of an array due to vega20 changes - fix driver on systems with non-4K pages - fix locking with pageflipping in DC that could lead to a sleep while atomic - fix VCN firmware version reporting for upcoming firmware The following changes

Re: [PATCH] drm/amdgpu: update documentation for amdgpu_drv.c

2018-06-27 Thread Zhang, Jerry (Junwei)
On 06/28/2018 02:14 AM, Sonny Jiang wrote: Signed-off-by: Sonny Jiang Nick work for amdgpu parameters. --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 117 1 file changed, 117 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Re: [PATCH 2/3] drm/amdgpu: allocate gart memory when it's required (v2)

2018-06-27 Thread Zhang, Jerry (Junwei)
On 06/28/2018 12:52 AM, Felix Kuehling wrote: On 2018-06-26 09:42 PM, Zhang, Jerry (Junwei) wrote: BTW, kfd2kgd_calls kfd2kgd looks duplicated in amdkfd_gfx_v7/8/9.c we may initialize it in a common place(at least for common members). If it has other purpose, please ignore that. Some of the

Re: [PATCH xf86-video-amdgpu 2/2] Call drmmode_crtc_gamma_do_set from drmmode_setup_colormap

2018-06-27 Thread Alex Deucher
On Wed, Jun 27, 2018 at 12:39 PM, Michel Dänzer wrote: > From: Michel Dänzer > > Instead of from drmmode_set_mode_major. There's no need to re-set the > gamma LUT on every modeset, the kernel should preserve it. > > Signed-off-by: Michel Dänzer Series is: Reviewed-by: Alex Deucher > --- >

Re: [PATCH v2 xf86-video-amdgpu] Don't apply gamma to HW cursor data if colour management is enabled

2018-06-27 Thread Alex Deucher
On Wed, Jun 27, 2018 at 12:20 PM, Michel Dänzer wrote: > From: Michel Dänzer > > In that case (with DC as of 4.17 kernels), the display hardware applies > gamma to the HW cursor. > > v2: > * Also use all 0s when alpha == 0 in the gamma passthrough case. > > Bugzilla:

Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code

2018-06-27 Thread Abramov, Slava
I wonder how '#if 0' made its way upstream, but besides this Reviewed-by: Slava Abramov From: amd-gfx on behalf of Michel Dänzer Sent: Wednesday, June 27, 2018 12:39:40 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-amdgpu 1/2] Remove #if

[PATCH] drm/amdgpu: update documentation for amdgpu_drv.c

2018-06-27 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 117 1 file changed, 117 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 6841497..8e418e4 100644 ---

Re: [PATCH] drm/amdgpu: allocate gart memory when it's required (v3)

2018-06-27 Thread Felix Kuehling
On 2018-06-27 04:28 AM, Junwei Zhang wrote: > Instead of calling gart memory on every bo pin, > allocates it on demand > > v2: fix error handling > v3: drop the change for kfd gtt bo mapping, not needed. > > Signed-off-by: Junwei Zhang Acked-by: Felix Kuehling > --- >

Re: [PATCH 2/3] drm/amdgpu: allocate gart memory when it's required (v2)

2018-06-27 Thread Felix Kuehling
On 2018-06-26 09:42 PM, Zhang, Jerry (Junwei) wrote: > > BTW, kfd2kgd_calls kfd2kgd looks duplicated in amdkfd_gfx_v7/8/9.c > we may initialize it in a common place(at least for common members). > If it has other purpose, please ignore that. Some of the function pointers in kfd2kgd_calls are

[PATCH xf86-video-amdgpu 2/2] Call drmmode_crtc_gamma_do_set from drmmode_setup_colormap

2018-06-27 Thread Michel Dänzer
From: Michel Dänzer Instead of from drmmode_set_mode_major. There's no need to re-set the gamma LUT on every modeset, the kernel should preserve it. Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-)

[PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code

2018-06-27 Thread Michel Dänzer
From: Michel Dänzer This has always been disabled, no need to keep it. Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 12 1 file changed, 12 deletions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 1563417a7..5fe49b607 100644 ---

[PATCH v2 xf86-video-amdgpu] Don't apply gamma to HW cursor data if colour management is enabled

2018-06-27 Thread Michel Dänzer
From: Michel Dänzer In that case (with DC as of 4.17 kernels), the display hardware applies gamma to the HW cursor. v2: * Also use all 0s when alpha == 0 in the gamma passthrough case. Bugzilla: https://bugs.freedesktop.org/106578 Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 25

Re: [PATCH] dma-buf: Move BUG_ON from _add_shared_fence to _add_shared_inplace

2018-06-27 Thread Michel Dänzer
On 2018-06-27 01:50 PM, Chris Wilson wrote: > Quoting Michel Dänzer (2018-06-26 15:31:47) >> From: Michel Dänzer >> >> Fixes the BUG_ON spuriously triggering under the following >> circumstances: >> >> * ttm_eu_reserve_buffers processes a list containing multiple BOs using >> the same

Re: [PATCH 1/2] drm/amdgpu: Add stutter mode ctrl in module parameter

2018-06-27 Thread Alex Deucher
On Wed, Jun 27, 2018 at 6:25 AM, rex zhu wrote: > Enable stutter mode can save power in low DRAM use cases > including but not limited to productivity application use, > web browsing, and video playback. > > Currently this feature is disabled by default. > > Make bit 17 in module parameter

Re: [PATCH 2/2] drm/amd/display: Ctrl stutter mode through module parameter

2018-06-27 Thread Alex Deucher
On Wed, Jun 27, 2018 at 6:25 AM, rex zhu wrote: > use ppfeaturemask to enable/disable stutter mode. > > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[bug report] drm/amd/display: Fix indentation in dcn10 resource constructor

2018-06-27 Thread Dan Carpenter
Hello Hersen Wu, The patch cb1d7eacb58f: "drm/amd/display: Fix indentation in dcn10 resource constructor" from May 8, 2018, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c:1008 construct() warn: inconsistent

Re: [PATCH] drm/amdgpu: allocate gart memory when it's required (v3)

2018-06-27 Thread Huang Rui
On Wed, Jun 27, 2018 at 04:28:18PM +0800, Junwei Zhang wrote: > Instead of calling gart memory on every bo pin, > allocates it on demand > > v2: fix error handling > v3: drop the change for kfd gtt bo mapping, not needed. > > Signed-off-by: Junwei Zhang Reviewed-by: Huang Rui > --- >

Re: [PATCH 1/2] drm/amdgpu: Add stutter mode ctrl in module parameter

2018-06-27 Thread Huang Rui
On Wed, Jun 27, 2018 at 06:25:28PM +0800, rex zhu wrote: > Enable stutter mode can save power in low DRAM use cases > including but not limited to productivity application use, > web browsing, and video playback. > > Currently this feature is disabled by default. > > Make bit 17 in module

Re: [PATCH] dma-buf: Move BUG_ON from _add_shared_fence to _add_shared_inplace

2018-06-27 Thread Chris Wilson
Quoting Michel Dänzer (2018-06-26 15:31:47) > From: Michel Dänzer > > Fixes the BUG_ON spuriously triggering under the following > circumstances: > > * ttm_eu_reserve_buffers processes a list containing multiple BOs using > the same reservation object, so it calls >

[PATCH umr] remove casts and replace with portable formatters in output

2018-06-27 Thread Tom St Denis
Signed-off-by: Tom St Denis --- src/lib/dump_ib.c | 18 +-- src/lib/read_vram.c | 210 +- src/lib/umr_llvm_disasm.c | 8 +- src/lib/umr_read_pm4_stream.c | 4 +- 4 files changed, 120 insertions(+), 120 deletions(-) diff --git

[PATCH 2/2] drm/amd/display: Ctrl stutter mode through module parameter

2018-06-27 Thread rex zhu
use ppfeaturemask to enable/disable stutter mode. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 1/2] drm/amdgpu: Add stutter mode ctrl in module parameter

2018-06-27 Thread rex zhu
Enable stutter mode can save power in low DRAM use cases including but not limited to productivity application use, web browsing, and video playback. Currently this feature is disabled by default. Make bit 17 in module parameter amdgpu_pp_feature_mask as stutter mode mask, so user can

Re: [PATCH] drm/amdgpu: allocate gart memory when it's required (v3)

2018-06-27 Thread Zhang, Jerry (Junwei)
On 06/27/2018 05:01 PM, Koenig, Christian wrote: Am 27.06.2018 10:29 schrieb Junwei Zhang : Instead of calling gart memory on every bo pin, allocates it on demand v2: fix error handling v3: drop the change for kfd gtt bo mapping, not needed. Signed-off-by: Junwei Zhang

Re: [PATCH] drm/amdgpu: allocate gart memory when it's required (v3)

2018-06-27 Thread Koenig, Christian
Am 27.06.2018 10:29 schrieb Junwei Zhang : Instead of calling gart memory on every bo pin, allocates it on demand v2: fix error handling v3: drop the change for kfd gtt bo mapping, not needed. Signed-off-by: Junwei Zhang Looks good to me on first glance, but I'm on vacation and can't do a

[PATCH] drm/amdgpu: allocate gart memory when it's required (v3)

2018-06-27 Thread Junwei Zhang
Instead of calling gart memory on every bo pin, allocates it on demand v2: fix error handling v3: drop the change for kfd gtt bo mapping, not needed. Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-06-27 Thread Michal Hocko
This is the v2 of RFC based on the feedback I've received so far. The code even compiles as a bonus ;) I haven't runtime tested it yet, mostly because I have no idea how. Any further feedback is highly appreciated of course. --- From ec9a7241bf422b908532c4c33953b0da2655ad05 Mon Sep 17 00:00:00

RE: [PATCH] drm/amdgpu: remove duplicated codes

2018-06-27 Thread Zhou, David(ChunMing)
Feel free add my RB on that. Thanks, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Flora Cui Sent: Wednesday, June 27, 2018 3:06 PM To: Zhou, David(ChunMing) Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amdgpu: remove duplicated codes

2018-06-27 Thread Flora Cui
the fence_context and seqno is init in amdgpu_vm_manager_init() & amdgpu_vmid_mgr_init(). remove the amdgpu_vmid_mgr_init() copy. Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 - 1 file changed, 5 deletions(-)

RE: [PATCH] drm/amdgpu: remove duplicated codes

2018-06-27 Thread Zhou, David(ChunMing)
Please add patch's comment to describe where and where are duplicated. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Flora Cui Sent: Wednesday, June 27, 2018 2:10 PM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH]

Re: [PATCH] drm/amdgpu: remove duplicated codes

2018-06-27 Thread Zhang, Jerry (Junwei)
On 06/27/2018 02:10 PM, Flora Cui wrote: Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 Signed-off-by: Flora Cui Good catch. Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH] drm/amdgpu: remove duplicated codes

2018-06-27 Thread Flora Cui
Change-Id: Ic0dbd693bac093e54eb95b5e547c89b64a5743b8 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c index a1c78f9..3a072a7 100644 ---