Re: 答复: [PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-24 Thread Takashi Iwai
On Wed, 25 Jul 2018 07:38:37 +0200, Qu, Jim wrote: > > Jim: Just like Alex said, we want driver can get eld info when hotplug in new > device. amdgpu driver is a bit difference from radeon driver, it is not a > suitable place to call notify() function in *_audio_enable() , since they are > not

Re: 答复: [PATCH 3/4] drm/radeon: Add audio component support

2018-07-24 Thread jimqu
On 2018年07月25日 13:28, Takashi Iwai wrote: On Wed, 25 Jul 2018 05:32:52 +0200, Qu, Jim wrote: @@ -269,6 +271,10 @@ static void radeon_audio_enable(struct radeon_device *rdev, if (rdev->audio.funcs->enable) rdev->audio.funcs->enable(rdev, pin, enable_mask); + +

答复: [PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-24 Thread Qu, Jim
See comments in line. Thanks JimQu 发件人: amd-gfx 代表 Takashi Iwai 发送时间: 2018年7月23日 22:50 收件人: alsa-de...@alsa-project.org 抄送: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org 主题: [PATCH 4/4] drm/amdgpu: Add audio component support This

Re: 答复: [PATCH 3/4] drm/radeon: Add audio component support

2018-07-24 Thread Takashi Iwai
On Wed, 25 Jul 2018 05:32:52 +0200, Qu, Jim wrote: > @@ -269,6 +271,10 @@ static void radeon_audio_enable(struct radeon_device > *rdev, > > if (rdev->audio.funcs->enable) > rdev->audio.funcs->enable(rdev, pin, enable_mask); > + > + if (acomp && acomp->audio_ops &&

[PATCH 2/2] drm/amdgpu: fix a reversed condition

2018-07-24 Thread Rex Zhu
This test was reversed so it would end up leading to vddnb value can't be read on APU. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

[PATCH 1/2] drm/amd/pp: Convert voltage unit in mV*4 to mV on CZ/ST

2018-07-24 Thread Rex Zhu
the voltage showed in debugfs and hwmon should be in mV Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c

答复: [PATCH 3/4] drm/radeon: Add audio component support

2018-07-24 Thread Qu, Jim
Hi Takashi lwai, Sorry, I have to use outlook again, since my mail client had some problems that did not receive these series patches. See the commands in line. Thanks JimQu 发件人: amd-gfx 代表 Takashi Iwai 发送时间: 2018年7月23日 22:50 收件人:

[PATCH] gpu/drm/radeon: Do not evict VRAM with disabled HIBERNATE

2018-07-24 Thread Paul Menzel
From: Paul Menzel Date: Wed, 18 Jul 2018 18:15:44 +0200 Improve commit d796d844 (drm/radeon/kms: make hibernate work on IGPs) to only migrate VRAM objects if the Linux kernel is actually built with support for hibernation (suspend to disk). Link:

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-24 Thread David Rientjes
On Tue, 24 Jul 2018, Michal Hocko wrote: > oom_reap_task_mm should return false when __oom_reap_task_mm return > false. This is what my patch did but it seems this changed by > http://www.ozlabs.org/~akpm/mmotm/broken-out/mm-oom-remove-oom_lock-from-oom_reaper.patch > so that one should be fixed.

Re: [PATCH] gpu: drm: amdgpu: Replace mdelay with msleep in cik_pcie_gen3_enable()

2018-07-24 Thread Alex Deucher
On Mon, Jul 23, 2018 at 10:29 AM, Jia-Ju Bai wrote: > cik_pcie_gen3_enable() is only called by cik_common_hw_init(), which is > never called in atomic context. > cik_pcie_gen3_enable() calls mdelay() to busily wait, which is not > necessary. > mdelay() can be replaced with msleep(). > > This is

Re: [PATCH] RFC: drm/amd/display: enable ABGR and XBGR formats (v2)

2018-07-24 Thread Alex Deucher
On Tue, Jul 17, 2018 at 2:38 PM, Mauro Rossi wrote: > Hi Alex, > > Il giorno mar 17 lug 2018 alle ore 15:43 Alex Deucher > ha scritto: >> >> On Sun, Jul 15, 2018 at 10:03 PM, Mauro Rossi >> wrote: >> > From: Mauro Rossi >> > >> > (v1) {A,X}BGR code paths are added in amdgpu_dm, by using an

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 16:17:47 +0200 Michal Hocko wrote: > On Fri 20-07-18 17:09:02, Andrew Morton wrote: > [...] > > - Undocumented return value. > > > > - comment "failed to reap part..." is misleading - sounds like it's > > referring to something which happened in the past, is in fact > >

Re: [PATCH xf86-video-ati] Use strcpy for RandR output property names

2018-07-24 Thread Alex Deucher
On Tue, Jul 24, 2018 at 11:32 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Instead of strncpy with the string length. Avoids new warnings with GCC > 8: > > ../../src/drmmode_display.c: In function ‘drmmode_output_create_resources’: > ../../src/drmmode_display.c:2240:2: warning: ‘strncpy’

[PATCH 4/5] drm/amd/display: Prevent PSR from being enabled if initialization fails

2018-07-24 Thread Bhawanpreet Lakha
From: Anthony Koo [Why] PSR_SET command is sent to the microcontroller in order to initialize parameters needed for PSR feature, such as telling the microcontroller which pipe is driving the PSR supported panel. When this command is skipped or fails, the microcontroller may program the wrong

[PATCH 1/5] drm/amd/display: Retry link training again

2018-07-24 Thread Bhawanpreet Lakha
[Why] Some receivers seem to fail the first link training but are good on subsequent tries. We want to retry link training again. This fixes HTC vive pro not lighting up after being disabled. [How] Check if the link training passed without fall back if this is not the case then we retry link

[PATCH 3/5] drm/amd/display: Fix Vega10 black screen after mode change

2018-07-24 Thread Bhawanpreet Lakha
From: "Jerry (Fangzhi) Zuo" [Why] The sequence is slightly changed when bring .set_bandwidth out from the end of programming backend to the end of programming surface. Vega10 doesn't like to get clocks updated if stream_count is zero in the current context (Atomic Reset). [How] Do not update

[PATCH 5/5] drm/amd/display: DC 3.1.59

2018-07-24 Thread Bhawanpreet Lakha
From: Harry Wentland Change-Id: I803d8ba47f3362a8877630dca127020bd7189095 Signed-off-by: Harry Wentland Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/5] DC Patches Jul 24, 2018

2018-07-24 Thread Bhawanpreet Lakha
Summary of changes: * Flattening aux_engine and engine * Fix Vega black screen issue Anthony Koo (1): drm/amd/display: Prevent PSR from being enabled if initialization fails Bhawanpreet Lakha (2): drm/amd/display: Retry link training again drm/amd/display: flatten aux_engine and

[PATCH 2/5] drm/amd/display: flatten aux_engine and engine

2018-07-24 Thread Bhawanpreet Lakha
[Why] engine and aux_engine are unnecessary layers we want to remove this layer. [How] flatten engine and aux engine structs into one struct called aux_engine and remove all references to the engine struct. Change-Id: I6078129857865c8924c3c030d0afc43d7c9d75ff Signed-off-by: Bhawanpreet Lakha

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-24 Thread Marek Olšák
Christian, Would you please give me an Rb if the patch is OK with you? I have spoken with Michel and he would be OK with me pushing it as long as it gets an Rb from either you or Alex. Thanks, Marek On Wed, Jul 11, 2018 at 8:47 PM, Marek Olšák wrote: > From: Marek Olšák > > --- >

Re: [PATCH] drm/amdgpu: Fix RLC safe mode test in gfx_v9_0_enter_rlc_safe_mode

2018-07-24 Thread Michel Dänzer
On 2018-07-24 07:20 PM, Paul Menzel wrote: > On 07/20/18 18:33, Michel Dänzer wrote: >> From: Michel Dänzer >> >> We were testing the register offset, instead of the value stored in the >> register, therefore always timing out the loop. >> >> This reduces suspend time of the system in the bug

Re: [PATCH] drm/amdgpu: Fix RLC safe mode test in gfx_v9_0_enter_rlc_safe_mode

2018-07-24 Thread Paul Menzel
Dear Michel, On 07/20/18 18:33, Michel Dänzer wrote: > From: Michel Dänzer > > We were testing the register offset, instead of the value stored in the > register, therefore always timing out the loop. > > This reduces suspend time of the system in the bug report below by ~600 > ms. > >

[PATCH xf86-video-amdgpu 1/4] Move DRM event queue related initialization to amdgpu_drm_queue_init

2018-07-24 Thread Michel Dänzer
From: Michel Dänzer And make amdgpu_drm_queue_handler not directly accessible outside of amdgpu_drm_queue.c. Signed-off-by: Michel Dänzer --- src/amdgpu_dri2.c | 14 -- src/amdgpu_drm_queue.c | 11 +-- src/amdgpu_drm_queue.h | 5 + src/amdgpu_kms.c | 2 +-

[PATCH xf86-video-amdgpu 3/4] Defer vblank event handling while waiting for a pending flip

2018-07-24 Thread Michel Dänzer
From: Michel Dänzer This is a more robust way to prevent hangs due to nested calls to drmHandleEvent. Signed-off-by: Michel Dänzer --- src/amdgpu_drm_queue.c | 124 + src/amdgpu_drm_queue.h | 1 + src/drmmode_display.c | 18 --

[PATCH xf86-video-amdgpu 2/4] Add amdgpu_drm_wait_pending_flip function

2018-07-24 Thread Michel Dänzer
From: Michel Dänzer Replacing the drmmode_crtc_wait_pending_event macro. Signed-off-by: Michel Dänzer --- src/amdgpu_drm_queue.c | 13 + src/amdgpu_drm_queue.h | 1 + src/drmmode_display.c | 22 -- 3 files changed, 18 insertions(+), 18 deletions(-) diff

Re: [PATCH] drm/amdgpu: move the amdgpu_fbdev_set_suspend() further up

2018-07-24 Thread Alex Deucher
On Tue, Jul 24, 2018 at 12:02 AM, Shirish S wrote: > This patch moves amdgpu_fbdev_set_suspend() to the beginning > of suspend sequence. > > This is to ensure fbcon does not to write to the VRAM > after GPU is powerd down. > > Signed-off-by: Shirish S > Reviewed-by: Michel Dänzer Reviewed-by:

[PATCH] drm/amdgpu/gmc9: clarify GPUVM fault error message

2018-07-24 Thread Alex Deucher
The address printed is the actual address, not the page. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index

[PATCH xf86-video-ati] Use strcpy for RandR output property names

2018-07-24 Thread Michel Dänzer
From: Michel Dänzer Instead of strncpy with the string length. Avoids new warnings with GCC 8: ../../src/drmmode_display.c: In function ‘drmmode_output_create_resources’: ../../src/drmmode_display.c:2240:2: warning: ‘strncpy’ output truncated before terminating nul copying 8 bytes from a

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-24 Thread Michal Hocko
On Fri 20-07-18 17:09:02, Andrew Morton wrote: [...] > - Undocumented return value. > > - comment "failed to reap part..." is misleading - sounds like it's > referring to something which happened in the past, is in fact > referring to something which might happen in the future. > > - fails

Re: [PATCH] drm/amdgpu: Don't warn on destroying a pinned BO

2018-07-24 Thread Michel Dänzer
On 2018-07-24 02:47 PM, Christian König wrote: > Am 23.07.2018 um 18:50 schrieb Michel Dänzer: >> On 2018-07-19 05:39 PM, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> The warning turned out to be not so useful, as BO destruction tends to >>> be deferred to a workqueue. >>> >>> Also, we

Re: [PATCH 3/5] drm/amdgpu: enable system interrupt for jrbc

2018-07-24 Thread Christian König
Am 23.07.2018 um 21:53 schrieb Boyuan Zhang: On 2018-07-19 02:51 PM, Alex Deucher wrote: On Wed, Jul 18, 2018 at 4:39 PM, wrote: From: Boyuan Zhang Enable system interrupt for jrbc during engine starting time. Signed-off-by: Boyuan Zhang ---   drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 8

Re: [PATCH] drm/amdgpu: Don't warn on destroying a pinned BO

2018-07-24 Thread Christian König
Am 23.07.2018 um 18:50 schrieb Michel Dänzer: On 2018-07-19 05:39 PM, Michel Dänzer wrote: From: Michel Dänzer The warning turned out to be not so useful, as BO destruction tends to be deferred to a workqueue. Also, we should be preventing any damage from this now, so not really important