Re: [PATCH] drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.

2018-07-25 Thread Zhang, Jerry (Junwei)
On 07/26/2018 04:29 AM, Bas Nieuwenhuizen wrote: Every set_pages_array_wb call resulted in cross-core interrupts and TLB flushes. Merge more of them for less overhead. This reduces the time needed to free a 1.6 GiB GTT WC buffer as part of Vulkan CTS from ~2 sec to < 0.25 sec. (Allocation

Re: [PATCH] drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.

2018-07-25 Thread Huang Rui
On Wed, Jul 25, 2018 at 10:29:50PM +0200, Bas Nieuwenhuizen wrote: > Every set_pages_array_wb call resulted in cross-core > interrupts and TLB flushes. Merge more of them for > less overhead. > > This reduces the time needed to free a 1.6 GiB GTT WC > buffer as part of Vulkan CTS from ~2 sec to

Re: [pull] amdgpu drm-fixes-4.18

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 3:23 PM, Alex Deucher wrote: > Hi Dave, Dave, looks like I mixed up branches and missed some patches earlier in the series. Please to drop this request. Thanks, Alex > > Fixes for some power features not getting set properly after a suspend cycle > on vega10. > > The

Re: [pull] amdgpu drm-fixes-4.18

2018-07-25 Thread Rune Petersen
Hi, On 2018-07-25 21:23, Alex Deucher wrote: Hi Dave, Fixes for some power features not getting set properly after a suspend cycle on vega10. The following changes since commit 02e546eacceaaad4494e2ea8fb5014f00f9c4bef: Merge branch 'linux-4.18' of git://github.com/skeggsb/linux into

[pull] amdgpu, scheduler, drm-next-4.19

2018-07-25 Thread Alex Deucher
Hi Dave, Updates for 4.19. Mostly bug fixes and cleanups. Highlights: - Internal API cleanup in GPU scheduler - Decouple i2c and aux abstractions in DC - Update maintainers - Misc cleanups - Misc bug fixes The following changes since commit 500775074f88d9cf5416bed2ca19592812d62c41: Merge

Re: [PATCH] drm/amdgpu: implement harvesting support for UVD 7.2 (v3)

2018-07-25 Thread James Zhu
Missing out the RB, Reviewed-by: James Zhu On 2018-07-25 05:29 PM, Alex Deucher wrote: On Wed, Jul 25, 2018 at 5:26 PM, James Zhu wrote: This patch is James Zhu Is that an RB or an AB or? Alex On 2018-07-25 05:02 PM, Alex Deucher wrote: Properly handle cases where one or more

Re: [PATCH] drm/amdgpu: implement harvesting support for UVD 7.2 (v3)

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 5:26 PM, James Zhu wrote: > > This patch is James Zhu Is that an RB or an AB or? Alex > > > On 2018-07-25 05:02 PM, Alex Deucher wrote: >> >> Properly handle cases where one or more instance of the IP >> block may be harvested. >> >> v2: make sure ip_num_rings is

Re: [PATCH] drm/amdgpu: implement harvesting support for UVD 7.2 (v3)

2018-07-25 Thread James Zhu
This patch is  James Zhu On 2018-07-25 05:02 PM, Alex Deucher wrote: Properly handle cases where one or more instance of the IP block may be harvested. v2: make sure ip_num_rings is initialized amdgpu_queue_mgr.c v3: rebase on Christian's UVD changes, drop unused var Signed-off-by: Alex

[PATCH] drm/amdgpu: implement harvesting support for UVD 7.2 (v3)

2018-07-25 Thread Alex Deucher
Properly handle cases where one or more instance of the IP block may be harvested. v2: make sure ip_num_rings is initialized amdgpu_queue_mgr.c v3: rebase on Christian's UVD changes, drop unused var Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 17 +---

Re: [PATCH] drm/amdgpu: implement harvesting support for UVD 7.2 (v2)

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 4:21 PM, James Zhu wrote: > > > On 2018-07-23 05:53 PM, Alex Deucher wrote: >> >> Properly handle cases where one or more instance of the IP >> block may be harvested. >> >> v2: make sure ip_num_rings is initialized amdgpu_queue_mgr.c >> >> Signed-off-by: Alex Deucher >>

[PATCH] drm/ttm: Merge hugepage attr changes in ttm_dma_page_put.

2018-07-25 Thread Bas Nieuwenhuizen
Every set_pages_array_wb call resulted in cross-core interrupts and TLB flushes. Merge more of them for less overhead. This reduces the time needed to free a 1.6 GiB GTT WC buffer as part of Vulkan CTS from ~2 sec to < 0.25 sec. (Allocation still takes more than 2 sec though) Signed-off-by: Bas

Re: [PATCH] drm/amdgpu: implement harvesting support for UVD 7.2 (v2)

2018-07-25 Thread James Zhu
On 2018-07-23 05:53 PM, Alex Deucher wrote: Properly handle cases where one or more instance of the IP block may be harvested. v2: make sure ip_num_rings is initialized amdgpu_queue_mgr.c Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 10 -

Re: [PATCH 2/2] drm/amdgpu: patch the IBs for the second UVD instance v2

2018-07-25 Thread James Zhu
On 2018-07-25 07:05 AM, Christian König wrote: Patch the IBs for the second UVD instance so that userspace don't need to care about the instance they submit to. v2: use direct IB patching Signed-off-by: Christian König Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c |

Re: [PATCH 1/2] drm/amdgpu: add support for inplace IB patching for MM engines v2

2018-07-25 Thread James Zhu
Yes, it works great. Reviewed-by: James Zhu Tested-by: James Zhu for the series On 2018-07-25 07:05 AM, Christian König wrote: We are going to need that for the second UVD instance on Vega20. v2: rename to patch_cs_in_place Signed-off-by: Christian König ---

[pull] amdgpu drm-fixes-4.18

2018-07-25 Thread Alex Deucher
Hi Dave, Fixes for some power features not getting set properly after a suspend cycle on vega10. The following changes since commit 02e546eacceaaad4494e2ea8fb5014f00f9c4bef: Merge branch 'linux-4.18' of git://github.com/skeggsb/linux into drm-fixes (2018-07-20 10:27:53 +1000) are available

Re: [PATCH xf86-video-amdgpu] glamor: Set AMDGPU_CREATE_PIXMAP_DRI2 for DRI3 pixmaps

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 12:38 PM, Michel Dänzer wrote: > From: Michel Dänzer > > Not doing this resulted in falling back to software for DRI3 client > presentation operations with ShadowPrimary. > > Signed-off-by: Michel Dänzer Reviewed-by: Alex Deucher > --- > src/amdgpu_dri3.c | 1 + > 1

Re: [PATCH xf86-video-amdgpu 4/4] Remove drmmode_crtc_private_rec::present_vblank_* related code

2018-07-25 Thread Alex Deucher
On Tue, Jul 24, 2018 at 1:16 PM, Michel Dänzer wrote: > From: Michel Dänzer > > Not needed anymore with the more robust mechanism introduced in the > previous change. > > Signed-off-by: Michel Dänzer Series is: Acked-by: Alex Deucher > --- > src/amdgpu_kms.c | 9 - >

[PATCH xf86-video-amdgpu] glamor: Set AMDGPU_CREATE_PIXMAP_DRI2 for DRI3 pixmaps

2018-07-25 Thread Michel Dänzer
From: Michel Dänzer Not doing this resulted in falling back to software for DRI3 client presentation operations with ShadowPrimary. Signed-off-by: Michel Dänzer --- src/amdgpu_dri3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amdgpu_dri3.c b/src/amdgpu_dri3.c index

Re: [PATCH 2/2] drm/amdgpu: patch the IBs for the second UVD instance v2

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 7:05 AM, Christian König wrote: > Patch the IBs for the second UVD instance so that userspace don't need > to care about the instance they submit to. > > v2: use direct IB patching > > Signed-off-by: Christian König > Reviewed-by: Alex Deucher > --- >

Re: [PATCH 3/5] drm/amdgpu: enable system interrupt for jrbc

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 10:01 AM, Boyuan Zhang wrote: > > > On 2018-07-24 08:50 AM, Christian König wrote: >> >> Am 23.07.2018 um 21:53 schrieb Boyuan Zhang: >>> >>> >>> >>> On 2018-07-19 02:51 PM, Alex Deucher wrote: On Wed, Jul 18, 2018 at 4:39 PM, wrote: > > From: Boyuan

Re: [PATCH 2/2] drm/amdgpu: fix a reversed condition

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 1:03 AM, Rex Zhu wrote: > This test was reversed so it would end up leading to vddnb value > can't be read on APU. > > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH 1/2] drm/amd/pp: Convert voltage unit in mV*4 to mV on CZ/ST

2018-07-25 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, July 25, 2018 1:03:12 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 1/2] drm/amd/pp: Convert voltage unit in mV*4 to mV on CZ/ST the voltage showed in debugfs and

Re: [PATCH 3/5] drm/amdgpu: enable system interrupt for jrbc

2018-07-25 Thread Boyuan Zhang
On 2018-07-24 08:50 AM, Christian König wrote: Am 23.07.2018 um 21:53 schrieb Boyuan Zhang: On 2018-07-19 02:51 PM, Alex Deucher wrote: On Wed, Jul 18, 2018 at 4:39 PM, wrote: From: Boyuan Zhang Enable system interrupt for jrbc during engine starting time. Signed-off-by: Boyuan Zhang

Re: [PATCH] drm/amd: Add missing fields in atom_integrated_system_info_v1_11

2018-07-25 Thread Alex Deucher
On Wed, Jul 25, 2018 at 9:45 AM, Harry Wentland wrote: > This structure needs to align with structure in atomfirmware table. > Update it. > > Signed-off-by: Harry Wentland Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++ > 1 file changed, 11

[PATCH] drm/amd: Add missing fields in atom_integrated_system_info_v1_11

2018-07-25 Thread Harry Wentland
This structure needs to align with structure in atomfirmware table. Update it. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h

Re: [PATCH 1/2] drm/amdgpu: add support for inplace IB patching for MM engines v2

2018-07-25 Thread James Zhu
Hi Christian, Sure, Let me find a time to try this afternoon. Best Regards! James Zhu On 2018-07-25 08:18 AM, Christian König wrote: Hi James, can you give those two patches another try on a Vega20? At least in theory it should work now. Thanks in advance, Christian. Am 25.07.2018 um

Re: [PATCH 1/2] drm/amdgpu: add support for inplace IB patching for MM engines v2

2018-07-25 Thread Christian König
Hi James, can you give those two patches another try on a Vega20? At least in theory it should work now. Thanks in advance, Christian. Am 25.07.2018 um 13:05 schrieb Christian König: We are going to need that for the second UVD instance on Vega20. v2: rename to patch_cs_in_place

[PATCH 1/2] drm/amdgpu: add support for inplace IB patching for MM engines v2

2018-07-25 Thread Christian König
We are going to need that for the second UVD instance on Vega20. v2: rename to patch_cs_in_place Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 22 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h |

[PATCH 2/2] drm/amdgpu: patch the IBs for the second UVD instance v2

2018-07-25 Thread Christian König
Patch the IBs for the second UVD instance so that userspace don't need to care about the instance they submit to. v2: use direct IB patching Signed-off-by: Christian König Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 27 +++ 1 file changed, 27

Re: [PATCH 2/2] drm/amdgpu: fix a reversed condition

2018-07-25 Thread Quan, Evan
Series is Reviewed-by: Evan Quan From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, July 25, 2018 1:03:13 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 2/2] drm/amdgpu: fix a reversed condition This test was reversed so it would end up

Re: [PATCH] gpu/drm/radeon: Do not evict VRAM with disabled HIBERNATE

2018-07-25 Thread Christian König
Am 25.07.2018 um 11:34 schrieb Paul Menzel: Dear Christian, On 07/25/18 10:34, Christian König wrote: Am 25.07.2018 um 00:15 schrieb Paul Menzel: From: Paul Menzel Date: Wed, 18 Jul 2018 18:15:44 +0200 Improve commit d796d844 (drm/radeon/kms: make hibernate work on IGPs) to only migrate

Re: [PATCH] gpu/drm/radeon: Do not evict VRAM with disabled HIBERNATE

2018-07-25 Thread Paul Menzel
Dear Christian, On 07/25/18 10:34, Christian König wrote: > Am 25.07.2018 um 00:15 schrieb Paul Menzel: >> From: Paul Menzel >> Date: Wed, 18 Jul 2018 18:15:44 +0200 >> >> Improve commit d796d844 (drm/radeon/kms: make hibernate work on IGPs) to >> only migrate VRAM objects if the Linux kernel

Re: [PATCH] drm/amdgpu: move the amdgpu_fbdev_set_suspend() further up

2018-07-25 Thread Huang Rui
On Tue, Jul 24, 2018 at 09:32:40AM +0530, Shirish S wrote: > This patch moves amdgpu_fbdev_set_suspend() to the beginning > of suspend sequence. > > This is to ensure fbcon does not to write to the VRAM > after GPU is powerd down. > > Signed-off-by: Shirish S > Reviewed-by: Michel Dänzer

Re: [PATCH] gpu/drm/radeon: Do not evict VRAM with disabled HIBERNATE

2018-07-25 Thread Christian König
Am 25.07.2018 um 00:15 schrieb Paul Menzel: From: Paul Menzel Date: Wed, 18 Jul 2018 18:15:44 +0200 Improve commit d796d844 (drm/radeon/kms: make hibernate work on IGPs) to only migrate VRAM objects if the Linux kernel is actually built with support for hibernation (suspend to disk). Link:

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

2018-07-25 Thread Christian König
Patch is Reviewed-by: Christian König Regards, Christian. Am 24.07.2018 um 20:11 schrieb Marek Olšák: Christian, Would you please give me an Rb if the patch is OK with you? I have spoken with Michel and he would be OK with me pushing it as long as it gets an Rb from either you or Alex.

Re: y4T�TCH 4/4] drm/amdgpu: Add audio component support

2018-07-25 Thread Takashi Iwai
On Wed, 25 Jul 2018 10:02:34 +0200, jimqu wrote: > > > > On 2018年07月25日 13:46, Takashi Iwai wrote: > > On Wed, 25 Jul 2018 07:38:37 +0200, > > Qu, Jim wrote: > >> Jim: Just like Alex said, we want driver can get eld info when hotplug in > >> new device. amdgpu driver is a bit difference from

Re: 答复: [PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-25 Thread jimqu
On 2018年07月25日 13:46, Takashi Iwai wrote: On Wed, 25 Jul 2018 07:38:37 +0200, Qu, Jim wrote: Jim: Just like Alex said, we want driver can get eld info when hotplug in new device. amdgpu driver is a bit difference from radeon driver, it is not a suitable place to call notify() function in

Re: [PATCH] drm/amdgpu/gmc9: clarify GPUVM fault error message

2018-07-25 Thread Zhang, Jerry (Junwei)
On 07/25/2018 12:54 AM, Alex Deucher wrote: The address printed is the actual address, not the page. Signed-off-by: Alex Deucher Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-25 Thread Michal Hocko
On Tue 24-07-18 12:53:07, Andrew Morton wrote: [...] > > On top of that the proposed cleanup looks as follows: > > > > Looks good to me. Seems a bit strange that we omit the pr_info() > output if the mm was partially reaped - people would still want to know > this? Not very important though.

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-25 Thread Michal Hocko
On Tue 24-07-18 14:07:49, David Rientjes wrote: [...] > mm/oom_kill.c: clean up oom_reap_task_mm() fix > > indicate reaping has been partially skipped so we can expect future skips > or another start before finish. But we are not skipping. This is essentially the same case as mmap_sem trylock