On 08/22/2018 11:05 PM, Christian König wrote:
Should work on Vega10 as well, but with an obvious performance hit.
Older APUs can be enabled as well, but will probably be more work.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 11 ++-
1 file changed,
On 08/22/2018 06:12 PM, Huang Rui wrote:
I continue to work for bulk moving that based on the proposal by Christian.
Background:
amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of
them on the end of LRU list one by one. Thus, that cause so many BOs moved to
the end
On 08/22/2018 11:05 PM, Christian König wrote:
Add a helper function to figure them out only once.
Signed-off-by: Christian König
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 --
1 file changed, 28 insertions(+), 33 deletions(-)
diff
On 08/22/2018 11:05 PM, Christian König wrote:
Add a helper to get the root PD address and remove the workarounds from
the GMC9 code for that.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/Makefile | 3 +-
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 +-
On Wed, Aug 22, 2018 at 12:04:53PM +0200, Christian König wrote:
> Check if we should call the function instead of providing the forced
> flag.
>
> Signed-off-by: Christian König
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++-
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38
>
On 08/22/2018 11:05 PM, Christian König wrote:
Add the necessary handling.
Signed-off-by: Christian König
Looks going to use GTT for page table.
What kind of scenario to use that?
could it be replaced by CPU updating page table in system memory?
Regards,
Jerry
---
Patch 2 ~ 6 are
Reviewed-by: Junwei Zhang
Jerry
On 08/22/2018 11:05 PM, Christian König wrote:
Preparation for following changes. This validates the root PD twice,
but the overhead of that should be minimal.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8
On 08/23/2018 03:46 AM, Alex Deucher wrote:
On Wed, Aug 22, 2018 at 11:05 AM Christian König
wrote:
Just another leftover from radeon.
I can't remember exactly what chip this was for. Are you sure this
isn't still required for SI or something like that?
FYI.
Some projects still use SI
On Wed, Aug 22, 2018 at 7:26 AM Yintian Tao wrote:
>
> It will be more safe to make full-acess include both phase1 and phase2.
> Then accessing special registeris wherever at phase1 or phase2 will not
> block any shutdown and suspend process under virtualization.
>
> Signed-off-by: Yintian Tao
On 08/23/2018 06:25 AM, Felix Kuehling wrote:
Hi all,
Oded has offered to make me co-maintainer of KFD, as he's super busy at
work and less responsive than he used to be.
At the same time we're about to send out the first patches to merge KFD
and AMDGPU into a single kernel module.
With that
On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling wrote:
> Hi all,
>
> Oded has offered to make me co-maintainer of KFD, as he's super busy at
> work and less responsive than he used to be.
>
> At the same time we're about to send out the first patches to merge KFD
> and AMDGPU into a single kernel
Hi all,
Oded has offered to make me co-maintainer of KFD, as he's super busy at
work and less responsive than he used to be.
At the same time we're about to send out the first patches to merge KFD
and AMDGPU into a single kernel module.
With that in mind I'd like to propose to upstream KFD
Acked-by: Felix Kuehling
The amdgpu_amdkfd_gpuvm code looked different than I remembered. There
are some important patches missing upstream that I'll roll into my next
patch series.
Regards,
Felix
On 2018-08-22 11:05 AM, Christian König wrote:
> Add a helper to get the root PD address and
On Wed, Aug 22, 2018 at 7:26 AM Rex Zhu wrote:
>
> 1. initialize kiq before initialize gfx ring.
> 2. set kiq ring ready immediately when kiq initialize
>successfully.
> 3. split function gfx_v9_0_kiq_resume into two functions.
> gfx_v9_0_kiq_resume is for kiq initialize.
>
On Wed, Aug 22, 2018 at 5:31 PM Oak Zeng wrote:
>
Please provide a patch description.
Alex
> Signed-off-by: Oak Zeng
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 ++--
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
See comments inline ...
Regards,
Felix
On 2018-08-22 05:10 PM, Oak Zeng wrote:
> Signed-off-by: Oak Zeng
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 ++--
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 +---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +-
On Wed, Aug 22, 2018 at 12:44 PM Felix Kuehling wrote:
>
> You're right, but that's a bit fragile and convoluted. I'll fix KFD to
> handle this more robustly. See the attached (untested) patch.
Yes, this patch that makes the whole "has to use current mm" or uses
"get_task_mm()" looks good from a
Hi Dave,
Fixes for 4.19:
- Fix build when KCOV is enabled
- Misc display fixes
- A couple of SR-IOV fixes
- Fence fixes for eviction handling for KFD
- Misc other fixes
The following changes since commit 3d63a3c14741ed015948943076f3c6a2f2cd7b27:
Merge tag 'drm-msm-next-2018-08-10' of
From: David Francis
[Why]
The function pointers of the dce_i2c_hw struct were never
accessed from outside dce_i2c_hw.c and had only one version.
As function pointers take up space and make debugging difficult,
and they are not needed in this case, they should be removed.
[How]
Remove the
From: Ken Chalmers
[Why]
Now that we "scale" time delays correctly on Maximus (as of diags svn
r170115), the forced "35 ms" wait time now becomes 35 ms * 500 = 17.5
seconds, which is far too long. Even having to repeat polling a
register once causes excessive delays on Maximus.
[How]
Just use
From: Leo Li
Summary of change:
* Flattening and cleaning up of i2c code
* Spelling and grammar fixups in amdgpu_dm
* Implement hardware state logging via debugfs
David Francis (4):
drm/amd/display: Eliminate i2c hw function pointers
drm/amd/display: Improve spelling, grammar, and
From: SivapiriyanKumarasamy
[Why]
There is currently an intermittent hang from a memory leak in
DTN stress testing. It is caused by unfreed memory during driver
disable.
[How]
Do a dc_sink_release in the case that skips it incorrectly.
Signed-off-by: SivapiriyanKumarasamy
Reviewed-by: Aric
From: "Leo (Sunpeng) Li"
[Why]
drm_handle_vblank is deprecated. Use drm_crtc_handle_vblank instead.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: David Francis
Acked-by: Leo Li
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 --
1 file changed, 4 insertions(+), 6
From: David Francis
[Why]
The i2c code contains two structs that contain the same
information as i2c_payload
[How]
Replace references to those structs with references to
i2c_payload
dce_i2c_transaction_request->status was written to but never read,
so all references to it are removed
From: Nicholas Kazlauskas
[Why]
Logging hardware state can be done by triggering a write to the
debugfs file. It would also be useful to be able to read the hardware
state from the debugfs file to be able to generate a clean log without
timestamps.
[How]
Usage: cat
From: Eric Yang
[Why]
On PCO and up, whenever SMU receive message to indicate active
display count = 0. SMU will turn off 48MHZ TMDP reference clock
by writing to 1 TMDP_48M_Refclk_Driver_PWDN. Once this clock is
off, no PHY register will respond to register access. This means
our current
From: David Francis
[Why]
Good spelling and grammar makes comments
more pleasant and clearer.
Linux has coding standards for comments
that we should try to follow.
[How]
Fix obvious spelling and grammar issues
Ensure all comments use '/*' and '*/' and multi-line comments
follow linux
From: David Francis
[Why]
The dce_i2c_hw code contained four funtcions that were only
called in one place and did not have a clearly delineated
purpose.
[How]
Inline these functions, keeping the same functionality.
This is not a functional change.
The functions disable_i2c_hw_engine and
From: Tony Cheng
Signed-off-by: Tony Cheng
Reviewed-by: Steven Chiu
Acked-by: Leo Li
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index 2bb7719..9ce14a2
From: Nicholas Kazlauskas
[Why]
We have logging methods for printing hardware state for newer ASICs
but no way to trigger the log output.
[How]
Add support for triggering the output via writing to a debugfs file
entry. Log output currently goes into dmesg for convenience, but
accessing via a
On Wed, Aug 22, 2018 at 12:37 PM Oded Gabbay wrote:
>
> Having said that, I think we *are* protected by the mmu_notifier
> release because if the process suddenly dies, we will gracefully clean
> the process's data in our driver and on the H/W before returning to
> the mm core code. And before we
On Wed, Aug 22, 2018 at 10:58 PM Linus Torvalds
wrote:
>
> On Wed, Aug 22, 2018 at 12:37 PM Oded Gabbay wrote:
> >
> > Having said that, I think we *are* protected by the mmu_notifier
> > release because if the process suddenly dies, we will gracefully clean
> > the process's data in our driver
On Wed, Aug 22, 2018 at 11:06 AM Christian König
wrote:
>
> Add a helper function to figure them out only once.
>
> Signed-off-by: Christian König
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 --
> 1 file changed, 28 insertions(+), 33
On Wed, Aug 22, 2018 at 11:05 AM Christian König
wrote:
>
> sed -i "s/gart.robj/gart.bo/" drivers/gpu/drm/amd/amdgpu/*.c
> sed -i "s/gart.robj/gart.bo/" drivers/gpu/drm/amd/amdgpu/*.h
>
> Just cleaning up radeon leftovers.
>
> Signed-off-by: Christian König
Reviewed-by: Alex Deucher
> ---
>
On Wed, Aug 22, 2018 at 11:05 AM Christian König
wrote:
>
> Move setting the GART addr for window based copies into the TTM code who
> uses it.
>
> Signed-off-by: Christian König
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
>
On Wed, Aug 22, 2018 at 11:05 AM Christian König
wrote:
>
> Add a helper function for getting the root PD addr and cleanup join the
> two VM related functions and cleanup the function name.
>
> No functional change.
>
> Signed-off-by: Christian König
Reviewed-by: Alex Deucher
> ---
>
On Wed, Aug 22, 2018 at 11:05 AM Christian König
wrote:
>
> Just another leftover from radeon.
I can't remember exactly what chip this was for. Are you sure this
isn't still required for SI or something like that?
Alex
>
> Signed-off-by: Christian König
> ---
>
On 2018-08-22 02:13 PM, Christian König wrote:
> Adding Felix because the KFD part of amdgpu is actually his
> responsibility.
>
> If I'm not completely mistaken the release callback of the
> mmu_notifier should take care of that for amdgpu.
You're right, but that's a bit fragile and convoluted.
On Wed, Aug 22, 2018 at 7:44 PM Linus Torvalds
wrote:
> One of the complex ones is the amdgpu driver. It does a
> "use_mm(mmptr)" deep deep in the guts of a macro that ends up being
> used in fa few places, and it's very hard to tell if it's right.
>
> It looks almost certainly buggy (there is no
On Wed, Aug 22, 2018 at 12:56 PM Alex Deucher wrote:
>
> On Wed, Aug 22, 2018 at 6:05 AM Christian König
> wrote:
> >
> > Instead of hammering hard on the GPU try a soft recovery first.
> >
> > v2: reorder code a bit
> >
> > Signed-off-by: Christian König
> > ---
> >
Guys and gals,
this is a *very* random list of people on the recipients list, but we
had a subtle TLB shootdown issue in the VM, and that brought up some
issues when people then went through the code more carefully.
I think we have a handle on the TLB shootdown bug itself. But when
people were
On Wed, Aug 22, 2018 at 11:33 AM Linus Torvalds
wrote:
>
> On Wed, Aug 22, 2018 at 11:21 AM Paolo Bonzini wrote:
> >
> > Yes, KVM is correct but the i915 bits are at least fishy. It's probably
> > as simple as adding a mmget/mmput pair respectively in kvmgt_guest_init
> > and kvmgt_guest_exit,
On Wed, Aug 22, 2018 at 11:21 AM Paolo Bonzini wrote:
>
> Yes, KVM is correct but the i915 bits are at least fishy. It's probably
> as simple as adding a mmget/mmput pair respectively in kvmgt_guest_init
> and kvmgt_guest_exit, or maybe mmget_not_zero.
Definitely mmget_not_zero(). If it was
Hi Linus:
Thanks for letting us know that. We would fix this ASAP. The kvmgt.c
module is a part of GVT-g code. It's our fault that we didn't find this
mis-uses, not i915 or KVM guys. Wish they would feel better after seeing
this message.
Thanks,
Zhi.
On 08/23/18 00:44, Linus Torvalds
On 22/08/2018 18:44, Linus Torvalds wrote:
> An example of something that *isn't* right, is the i915 kvm interface,
> which does
>
> use_mm(kvm->mm);
>
> on an mm that was initialized in virt/kvm/kvm_main.c using
>
> mmgrab(current->mm);
> kvm->mm = current->mm;
>
>
Adding Felix because the KFD part of amdgpu is actually his responsibility.
If I'm not completely mistaken the release callback of the mmu_notifier
should take care of that for amdgpu.
Regards,
Christian.
Am 22.08.2018 um 18:44 schrieb Linus Torvalds:
Guys and gals,
this is a *very*
Am 22.08.2018 um 19:40 schrieb Felix Kuehling:
On 2018-08-22 02:55 AM, Christian König wrote:
Am 21.08.2018 um 23:45 schrieb Felix Kuehling:
[snip]
+ } else {
+ struct sysinfo si;
+ unsigned int phys_ram_gb;
+
+ /* Optimal VM size depends on the amount of physical
+
On 2018-08-22 02:55 AM, Christian König wrote:
> Am 21.08.2018 um 23:45 schrieb Felix Kuehling:
[snip]
>> + } else {
>>> + struct sysinfo si;
>>> + unsigned int phys_ram_gb;
>>> +
>>> + /* Optimal VM size depends on the amount of physical
>>> + * RAM available.
On Wed, Aug 22, 2018 at 05:37:22PM +0100, Daniel Stone wrote:
> Hi Rodrigo,
>
> On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote:
> > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote:
> > > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote:
> > > > - Sticking to fdo bugzilla and
On Wed, Aug 22, 2018 at 6:05 AM Christian König
wrote:
>
> Instead of hammering hard on the GPU try a soft recovery first.
>
> v2: reorder code a bit
>
> Signed-off-by: Christian König
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 ++
> drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 24
Hi Michel,
Thanks. I know the root cause, and will fix this issue today.
Best Regards
Rex
> -Original Message-
> From: Michel Dänzer
> Sent: Thursday, August 23, 2018 12:31 AM
> To: Zhu, Rex
> Cc: amd-gfx@lists.freedesktop.org
> Subject: Regression: Kaveri VCE ring test fails
>
>
>
Hi Rodrigo,
On Wed, 22 Aug 2018 at 17:06, Rodrigo Vivi wrote:
> On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote:
> > On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote:
> > > - Sticking to fdo bugzilla and disabling gitlab issues for at least
> > > drm-intel for the time being.
Hi,
On Wed, 22 Aug 2018 at 15:44, Daniel Vetter wrote:
> On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula
> wrote:
> > Just a couple of concerns from drm/i915 perspective for starters:
> >
> > - Patchwork integration. I think we'll want to keep patchwork for at
> > least intel-gfx etc. for the
Hi Rex,
I bisected a regression to your "drm/amd/pp: Unify
powergate_uvd/vce/mmhub to set_powergating_by_smu" change. Since this
change, the VCE ring test fails on this Kaveri laptop, which prevents
the amdgpu driver from initializing at all, see the the attached kern.log.
If I disable VCE via
Hi,
On Wed, 22 Aug 2018 at 16:02, Emil Velikov wrote:
> On 22 August 2018 at 12:44, Daniel Vetter wrote:
> > I think it's time to brainstorm a bit about the gitlab migration. Basic
> > reasons:
> >
> > - fd.o admins want to deprecate shell accounts and hand-rolled
> > infrastructure, because
On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote:
> On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote:
>
> > - Sticking to fdo bugzilla and disabling gitlab issues for at least
> > drm-intel for the time being. Doing that migration in the same go is a
> > bit much I think.
On 08/22/2018 11:05 AM, Christian König wrote:
Should work on Vega10 as well, but with an obvious performance hit.
Older APUs can be enabled as well, but will probably be more work.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 11 ++-
1 file
Move setting the GART addr for window based copies into the TTM code who
uses it.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 --
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 -
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git
Preparation for following changes. This validates the root PD twice,
but the overhead of that should be minimal.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
We can easily figure out the address on the fly.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.h | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 7 +++
Helper to get the PDE for a PD/PT.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 37 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 21 --
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h |
Add a helper function to figure them out only once.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 --
1 file changed, 28 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
Add a helper function for getting the root PD addr and cleanup join the
two VM related functions and cleanup the function name.
No functional change.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 160 -
1 file changed, 74 insertions(+), 86
sed -i "s/gart.robj/gart.bo/" drivers/gpu/drm/amd/amdgpu/*.c
sed -i "s/gart.robj/gart.bo/" drivers/gpu/drm/amd/amdgpu/*.h
Just cleaning up radeon leftovers.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 32
Should work on Vega10 as well, but with an obvious performance hit.
Older APUs can be enabled as well, but will probably be more work.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git
Just another leftover from radeon.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 ---
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
Add the necessary handling.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index e412eb8e347c..3393a329fc9c 100644
---
Add a helper to get the root PD address and remove the workarounds from
the GMC9 code for that.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/Makefile | 3 +-
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
Hi Dan,
On 22 August 2018 at 12:44, Daniel Vetter wrote:
> Hi all,
>
> I think it's time to brainstorm a bit about the gitlab migration. Basic
> reasons:
>
> - fd.o admins want to deprecate shell accounts and hand-rolled
> infrastructure, because it's a pain to keep secure
>
> - gitlab will
Series is Acked-by: Andrey Grodzovsky
Andrey
On 08/22/2018 06:05 AM, Christian König wrote:
Check if we should call the function instead of providing the forced
flag.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++-
On Wed, Aug 22, 2018 at 3:13 PM, Jani Nikula
wrote:
> On Wed, 22 Aug 2018, Daniel Vetter wrote:
>> Hi all,
>>
>> I think it's time to brainstorm a bit about the gitlab migration. Basic
>> reasons:
>>
>> - fd.o admins want to deprecate shell accounts and hand-rolled
>> infrastructure, because
On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote:
> - Sticking to fdo bugzilla and disabling gitlab issues for at least
> drm-intel for the time being. Doing that migration in the same go is a
> bit much I think. Reassignment across bugzilla and gitlab will be an
> issue.
Can you
On 08/22/2018 01:28 AM, Paul Menzel wrote:
Dear Andrey,
Am 21.08.2018 um 23:23 schrieb Andrey Grodzovsky:
Problem:
When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning
as bellow and page fault happen because adev->gart.pages already
freed by the
time amdgpu_gart_unbind
On 08/22/2018 02:57 AM, Christian König wrote:
Am 21.08.2018 um 23:23 schrieb Andrey Grodzovsky:
Problem:
When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning
as bellow and page fault happen because adev->gart.pages already
freed by the
time amdgpu_gart_unbind is called.
Acked-by: Alex Deucher
From: amd-gfx on behalf of Rex Zhu
Sent: Wednesday, August 22, 2018 2:41:19 AM
To: amd-gfx@lists.freedesktop.org; Francis, David; Wentland, Harry
Cc: Zhu, Rex
Subject: [PATCH v2] drm/amd/display: Fix bug use wrong pp interface
Used
On Wed, 22 Aug 2018, Daniel Vetter wrote:
> Hi all,
>
> I think it's time to brainstorm a bit about the gitlab migration. Basic
> reasons:
>
> - fd.o admins want to deprecate shell accounts and hand-rolled
> infrastructure, because it's a pain to keep secure
>
> - gitlab will allow us to add
On Wed, Aug 22, 2018 at 01:44:56PM +0200, Daniel Vetter wrote:
> Hi all,
>
> I think it's time to brainstorm a bit about the gitlab migration. Basic
> reasons:
>
> - fd.o admins want to deprecate shell accounts and hand-rolled
> infrastructure, because it's a pain to keep secure
>
> - gitlab
>-Original Message-
>From: Christian König
>Sent: Wednesday, August 22, 2018 8:24 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset
>
>Am 22.08.2018 um 06:39 schrieb Emily Deng:
>> When in gpu reset, don't use kiq, it will
Am 22.08.2018 um 06:39 schrieb Emily Deng:
When in gpu reset, don't use kiq, it will generate more TDR.
Signed-off-by: Emily Deng
Patch #1 is Reviewed-by: Christian König .
Patch #2 actually not necessary since we should never flush the tlb from
interrupt context.
Patch #3: I would
Ping..
>-Original Message-
>From: amd-gfx On Behalf Of Emily
>Deng
>Sent: Wednesday, August 22, 2018 12:39 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily
>Subject: [PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset
>
>When in gpu reset, don't use kiq, it will generate more
Am 22.08.2018 um 14:07 schrieb Emily Deng:
SWDEV-146499: hang during multi vulkan process testing
cause:
the second frame's PREAMBLE_IB have clear-state
and LOAD actions, those actions ruin the pipeline
that is still doing process in the previous frame's
work-load IB.
fix:
need insert pipeline
SWDEV-146499: hang during multi vulkan process testing
cause:
the second frame's PREAMBLE_IB have clear-state
and LOAD actions, those actions ruin the pipeline
that is still doing process in the previous frame's
work-load IB.
fix:
need insert pipeline sync if have context switch for
SRIOV
Hi all,
I think it's time to brainstorm a bit about the gitlab migration. Basic reasons:
- fd.o admins want to deprecate shell accounts and hand-rolled
infrastructure, because it's a pain to keep secure
- gitlab will allow us to add committers on our own, greatly
simplifying that process (and
1. initialize kiq before initialize gfx ring.
2. set kiq ring ready immediately when kiq initialize
successfully.
3. split function gfx_v9_0_kiq_resume into two functions.
gfx_v9_0_kiq_resume is for kiq initialize.
gfx_v9_0_kcq_resume is for kcq initialize.
Signed-off-by: Rex Zhu
1. initialize kiq before initialize gfx ring.
2. set kiq ring ready immediately when kiq initialize
successfully.
3. split function gfx_v8_0_kiq_resume into two functions.
gfx_v8_0_kiq_resume is for kiq initialize.
gfx_v8_0_kcq_resume is for kcq initialize.
Signed-off-by: Rex Zhu
---
It will be more safe to make full-acess include both phase1 and phase2.
Then accessing special registeris wherever at phase1 or phase2 will not
block any shutdown and suspend process under virtualization.
Signed-off-by: Yintian Tao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12
On Wed, Aug 22, 2018 at 05:56:10PM +0800, zhoucm1 wrote:
>
>
> On 2018年08月22日 17:34, Daniel Vetter wrote:
> > On Wed, Aug 22, 2018 at 04:38:56PM +0800, Chunming Zhou wrote:
> > > stub fence will be used by timeline syncobj as well.
> > >
> > > Change-Id:
I continue to work for bulk moving that based on the proposal by Christian.
Background:
amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of
them on the end of LRU list one by one. Thus, that cause so many BOs moved to
the end of the LRU, and impact performance
On Wed, Aug 22, 2018 at 11:59 AM, zhoucm1 wrote:
>
>
> On 2018年08月22日 17:31, Daniel Vetter wrote:
>>
>> On Wed, Aug 22, 2018 at 05:28:17PM +0800, zhoucm1 wrote:
>>>
>>>
>>> On 2018年08月22日 17:24, Daniel Vetter wrote:
On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote:
>
Try to kill waves on the SQ.
v2: only for the GFX ring for now.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index
Instead of hammering hard on the GPU try a soft recovery first.
v2: reorder code a bit
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 24
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4
Try to kill waves on the SQ.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 44707f94b2c5..ab5cacea967b 100644
---
Try to kill waves on the SQ.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
index 95452c5a9df6..a15d9c0f233b 100644
---
Check if we should call the function instead of providing the forced
flag.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 --
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +-
Try to kill waves on the SQ.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
index 95452c5a9df6..a15d9c0f233b 100644
---
At this point the command submission can still be interrupted.
Signed-off-by: Christian König
Acked-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
Try to kill waves on the SQ.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 44707f94b2c5..ab5cacea967b 100644
---
Instead of hammering hard on the GPU try a soft recovery first.
v2: reorder code a bit
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 24
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4
Check if we should call the function instead of providing the forced
flag.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 --
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +-
1 - 100 of 140 matches
Mail list logo
