Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-23 Thread Zhang, Jerry (Junwei)
On 08/24/2018 06:37 AM, Felix Kuehling wrote: Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This

[PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-23 Thread Felix Kuehling
Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This makes more VM space available for ROCm

Re: [PATCH 2/3] drm/amdgpu: Remove CONFIG_HSA_AMD_MODULE

2018-08-23 Thread Felix Kuehling
On 2018-08-23 11:17 AM, Amber Lin wrote: > After amdkfd is merged to amdgpu, CONFIG_HSA_AMD_MODULE no longer exists. > > Change-Id: I42096cdf887e0d776075f3dd3e8d3f153aff4e85 > Signed-off-by: Amber Lin Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 26

Re: [PATCH 1/3] drm/amdgpu: Merge amdkfd into amdgpu

2018-08-23 Thread Felix Kuehling
I believe you also need to edit drivers/gpu/drm/Kconfig. Otherwise amdkfd/Kconfig will be included twice. With that fixed, this commit is Reviewed-by: Felix Kuehling But let's give amdgpu reviewers some more time to respond. Thanks,   Felix On 2018-08-23 11:17 AM, Amber Lin wrote: > Since KFD

Re: [PATCH v2] drm/amd/display: Fix bug use wrong pp interface

2018-08-23 Thread Harry Wentland
On 2018-08-20 03:54 AM, Rex Zhu wrote: > Used wrong pp interface, the original interface is > exposed by dpm on SI and paritial CI. > > Pointed out by Francis David > > v2: dal only need to set min_dcefclk and min_fclk to smu. > so use display_clock_voltage_request interface, >

Re: [PATCH 2/5] drm/amdgpu: add ring soft recovery v2

2018-08-23 Thread Marek Olšák
On Thu, Aug 23, 2018 at 2:51 AM Christian König wrote: > > Am 22.08.2018 um 21:32 schrieb Marek Olšák: > > On Wed, Aug 22, 2018 at 12:56 PM Alex Deucher wrote: > >> On Wed, Aug 22, 2018 at 6:05 AM Christian König > >> wrote: > >>> Instead of hammering hard on the GPU try a soft recovery first.

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-23 Thread Harry Wentland
On 2018-08-17 10:11 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. > > Signed-off-by: Hans Verkuil > Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++-- >

Re: [PATCH 1/4] drm/amdgpu: add ring soft recovery v3

2018-08-23 Thread Christian König
Am 23.08.2018 um 17:20 schrieb Zhu, Rex: -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Thursday, August 23, 2018 7:24 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 1/4] drm/amdgpu: add ring soft recovery v3 Instead of hammering hard on the GPU try a soft

Re: Possible use_mm() mis-uses

2018-08-23 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 11:16 PM Zhenyu Wang wrote: > > yeah, that's the clear way to fix this imo. We only depend on guest > life cycle to access guest memory properly. Here's proposed fix, will > verify and integrate it later. Thanks, this looks sane to me, Linus

[PATCH xf86-video-ati 1/2] Add m4 directory

2018-08-23 Thread Michel Dänzer
From: Michel Dänzer Although normally it only warns about it, under some circumstances, aclocal can error out if this directory doesn't exist. Signed-off-by: Michel Dänzer --- .gitignore| 5 - m4/.gitignore | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) create mode

[PATCH xf86-video-ati 2/2] Use AC_CONFIG_MACRO_DIR instead of AC_CONFIG_MACRO_DIRS

2018-08-23 Thread Michel Dänzer
From: Michel Dänzer Older versions of autoconf only supported the former. Signed-off-by: Michel Dänzer --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 444862f3b..b6da673ea 100644 --- a/configure.ac +++ b/configure.ac @@

Re: [PATCH 3/3] drm/amdgpu: Move KFD parameters to amdgpu

2018-08-23 Thread Alex Deucher
On Thu, Aug 23, 2018 at 11:18 AM Amber Lin wrote: > > After merging KFD into amdgpu, move module parameters defined in KFD to > amdgpu_drv.c, where other module parameters are declared. > > Change-Id: I2de8d6c96bb49554c028bbc84bdb194f974c9278 > Signed-off-by: Amber Lin > --- >

RE: [PATCH 1/4] drm/amdgpu: add ring soft recovery v3

2018-08-23 Thread Zhu, Rex
> -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Thursday, August 23, 2018 7:24 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/4] drm/amdgpu: add ring soft recovery v3 > > Instead of hammering hard on the GPU try a soft recovery first. > > v2:

[PATCH 1/3] drm/amdgpu: Merge amdkfd into amdgpu

2018-08-23 Thread Amber Lin
Since KFD is only supported by single GPU driver, it makes sense to merge amdgpu and amdkfd into one module. This patch is the initial step: merge Kconfig and Makefile. Change-Id: I21c996ba29d393c1bf8064bdb2f5d89541159649 Signed-off-by: Amber Lin --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1

[PATCH 2/3] drm/amdgpu: Remove CONFIG_HSA_AMD_MODULE

2018-08-23 Thread Amber Lin
After amdkfd is merged to amdgpu, CONFIG_HSA_AMD_MODULE no longer exists. Change-Id: I42096cdf887e0d776075f3dd3e8d3f153aff4e85 Signed-off-by: Amber Lin --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 26 +++--- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git

[PATCH 3/3] drm/amdgpu: Move KFD parameters to amdgpu

2018-08-23 Thread Amber Lin
After merging KFD into amdgpu, move module parameters defined in KFD to amdgpu_drv.c, where other module parameters are declared. Change-Id: I2de8d6c96bb49554c028bbc84bdb194f974c9278 Signed-off-by: Amber Lin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 41 +

Re: [PATCH 1/3] drm/amdgpu: Fix vce initialize failed on Kaveri/Mullins

2018-08-23 Thread Michel Dänzer
On 2018-08-23 2:59 p.m., Zhu, Rex wrote: >> From: Michel Dänzer >> On 2018-08-23 11:24 a.m., Rex Zhu wrote: >>> Forgot to add vce pg support via smu for Kaveri/Mullins. >>> >>> Regresstion issue caused by >>> 'commit 561a5c83eadd ("drm/amd/pp: Unify powergate_uvd/vce/mmhub >> to >>>

Re: [PATCH] drm/amdgpu: enable GTT PD/PT for raven v2

2018-08-23 Thread Andrey Grodzovsky
Acked-by: Andrey Grodzovsky Andrey On 08/23/2018 08:33 AM, Christian König wrote: Should work on Vega10 as well, but with an obvious performance hit. Older APUs can be enabled as well, but will probably be more work. v2: fix error checking Signed-off-by: Christian König ---

Re: [PATCH 1/4] drm/amdgpu: add ring soft recovery v3

2018-08-23 Thread Huang Rui
On Thu, Aug 23, 2018 at 01:23:31PM +0200, Christian König wrote: > Instead of hammering hard on the GPU try a soft recovery first. > > v2: reorder code a bit > v3: increase timeout to 10ms, increment GPU reset counter > > Signed-off-by: Christian König Series are Reviewed-by: Huang Rui > ---

RE: [PATCH 2/3] drm/amdgpu: Power up uvd block when hw_fini

2018-08-23 Thread Zhu, Rex
> -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Thursday, August 23, 2018 6:58 PM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/3] drm/amdgpu: Power up uvd block when hw_fini > > On 2018-08-23 11:24 a.m., Rex Zhu wrote: > > when

Re: Possible use_mm() mis-uses

2018-08-23 Thread Paolo Bonzini
On 23/08/2018 08:07, Zhenyu Wang wrote: > On 2018.08.22 20:20:46 +0200, Paolo Bonzini wrote: >> On 22/08/2018 18:44, Linus Torvalds wrote: >>> An example of something that *isn't* right, is the i915 kvm interface, >>> which does >>> >>> use_mm(kvm->mm); >>> >>> on an mm that was

Re: [PATCH 11/11] drm/amdgpu: enable GTT PD/PT for raven

2018-08-23 Thread Christian König
Am 23.08.2018 um 14:54 schrieb Huang Rui: On Wed, Aug 22, 2018 at 11:44:04AM -0400, Andrey Grodzovsky wrote: On 08/22/2018 11:05 AM, Christian König wrote: Should work on Vega10 as well, but with an obvious performance hit. Older APUs can be enabled as well, but will probably be more work.

RE: [PATCH 1/3] drm/amdgpu: Fix vce initialize failed on Kaveri/Mullins

2018-08-23 Thread Zhu, Rex
> -Original Message- > From: Michel Dänzer > Sent: Thursday, August 23, 2018 6:59 PM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org; Kuehling, Felix > > Subject: Re: [PATCH 1/3] drm/amdgpu: Fix vce initialize failed on > Kaveri/Mullins > > On 2018-08-23 11:24 a.m., Rex Zhu wrote:

Re: [PATCH] drm/amdgpu: Remove duplicated power source update

2018-08-23 Thread Deucher, Alexander
In that case, Reviewed-by: Alex Deucher From: amd-gfx on behalf of Zhu, Rex Sent: Thursday, August 23, 2018 8:41:28 AM To: Alex Deucher Cc: Wu, Hersen; amd-gfx list Subject: RE: [PATCH] drm/amdgpu: Remove duplicated power source update Hi Alex, We get

Re: [PATCH 11/11] drm/amdgpu: enable GTT PD/PT for raven

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 11:44:04AM -0400, Andrey Grodzovsky wrote: > > > On 08/22/2018 11:05 AM, Christian König wrote: > >Should work on Vega10 as well, but with an obvious performance hit. > > > >Older APUs can be enabled as well, but will probably be more work. Raven's VRAM is actually the

Re: [PATCH 10/11] drm/amdgpu: add helper for VM PD/PT allocation parameters

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:16PM +0200, Christian König wrote: > Add a helper function to figure them out only once. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 -- > 1 file changed, 28 insertions(+),

Re: [PATCH 09/11] drm/amdgpu: add amdgpu_gmc_get_pde_for_bo helper

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:15PM +0200, Christian König wrote: > Helper to get the PDE for a PD/PT. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 37 +++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 2 ++ >

RE: [PATCH] drm/amdgpu: Remove duplicated power source update

2018-08-23 Thread Zhu, Rex
Hi Alex, We get initial state in amdgpu_device_init. Best Regards Rex > -Original Message- > From: Alex Deucher > Sent: Thursday, August 23, 2018 8:37 PM > To: Zhu, Rex > Cc: amd-gfx list ; Wu, Hersen > > Subject: Re: [PATCH] drm/amdgpu: Remove duplicated power source update > >

[PATCH 1/5] drm/amdgpu: remove extra root PD alignment

2018-08-23 Thread Christian König
Just another leftover from radeon. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 --- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 2/5] drm/amdgpu: add helper for VM PD/PT allocation parameters

2018-08-23 Thread Christian König
Add a helper function to figure them out only once. Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 -- 1 file changed, 28 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

RE: KFD co-maintainership and branch model

2018-08-23 Thread Deucher, Alexander
> -Original Message- > From: Christian König > Sent: Thursday, August 23, 2018 3:01 AM > To: Oded Gabbay ; Dave Airlie > > Cc: Deucher, Alexander ; Kuehling, Felix > ; amd-gfx list > Subject: Re: KFD co-maintainership and branch model > > Am 23.08.2018 um 08:54 schrieb Oded Gabbay: > >

Re: [PATCH] drm/amdgpu: Remove duplicated power source update

2018-08-23 Thread Alex Deucher
On Thu, Aug 23, 2018 at 2:40 AM Rex Zhu wrote: > > when ac/dc switch, driver will be notified by acpi event. > then the power source will be updated. so don't need to > get power source when set power state. Don't we need this to get the initial state? Maybe we should move this to one of the

[PATCH 5/5] drm/amdgpu: enable GTT PD/PT for raven v2

2018-08-23 Thread Christian König
Should work on Vega10 as well, but with an obvious performance hit. Older APUs can be enabled as well, but will probably be more work. v2: fix error checking Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 - 1 file changed, 12 insertions(+), 1

[PATCH 4/5] drm/amdgpu: add amdgpu_gmc_get_pde_for_bo helper

2018-08-23 Thread Christian König
Helper to get the PDE for a PD/PT. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 37 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 21 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h |

[PATCH 3/5] drm/amdgpu: add GMC9 support for PDs/PTs in system memory

2018-08-23 Thread Christian König
Add the necessary handling. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index a82b3eb429e8..453bd7ea50e7 100644 ---

[PATCH] drm/amdgpu: enable GTT PD/PT for raven v2

2018-08-23 Thread Christian König
Should work on Vega10 as well, but with an obvious performance hit. Older APUs can be enabled as well, but will probably be more work. v2: fix error checking Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 13 - 1 file changed, 12 insertions(+), 1

Re: [PATCH 08/11] drm/amdgpu: add amdgpu_gmc_pd_addr helper

2018-08-23 Thread Christian König
Am 23.08.2018 um 05:07 schrieb Zhang, Jerry (Junwei): On 08/22/2018 11:05 PM, Christian König wrote: Add a helper to get the root PD address and remove the workarounds from the GMC9 code for that. Signed-off-by: Christian König ---   drivers/gpu/drm/amd/amdgpu/Makefile   |  3 +-  

Re: [PATCH 02/11] drm/amdgpu: validate the VM root PD from the VM code

2018-08-23 Thread Christian König
Am 23.08.2018 um 09:28 schrieb Huang Rui: On Wed, Aug 22, 2018 at 05:05:08PM +0200, Christian König wrote: Preparation for following changes. This validates the root PD twice, but the overhead of that should be minimal. Signed-off-by: Christian König ---

Re: [PATCH 08/11] drm/amdgpu: add amdgpu_gmc_pd_addr helper

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:14PM +0200, Christian König wrote: > Add a helper to get the root PD address and remove the workarounds from > the GMC9 code for that. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- >

Re: [PATCH 07/11] drm/amdgpu: add GMC9 support for PDs/PTs in system memory

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:13PM +0200, Christian König wrote: > Add the necessary handling. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 07/11] drm/amdgpu: add GMC9 support for PDs/PTs in system memory

2018-08-23 Thread Huang Rui
On Thu, Aug 23, 2018 at 10:50:49AM +0800, Zhang, Jerry (Junwei) wrote: > On 08/22/2018 11:05 PM, Christian König wrote: > >Add the necessary handling. > > > >Signed-off-by: Christian König > > Looks going to use GTT for page table. > What kind of scenario to use that? > could it be replaced by

Re: [PATCH 05/11] drm/amdgpu: rename gart.robj into gart.bo

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:11PM +0200, Christian König wrote: > sed -i "s/gart.robj/gart.bo/" drivers/gpu/drm/amd/amdgpu/*.c > sed -i "s/gart.robj/gart.bo/" drivers/gpu/drm/amd/amdgpu/*.h > > Just cleaning up radeon leftovers. > > Signed-off-by: Christian König Yes, the 'bo' is the better

[PATCH 3/4] drm/amdgpu: implement soft_recovery for GFX8 v2

2018-08-23 Thread Christian König
Try to kill waves on the SQ. v2: only for the GFX ring for now. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index

[PATCH 1/4] drm/amdgpu: add ring soft recovery v3

2018-08-23 Thread Christian König
Instead of hammering hard on the GPU try a soft recovery first. v2: reorder code a bit v3: increase timeout to 10ms, increment GPU reset counter Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 25

Re: [PATCH 04/11] drm/amdgpu: move setting the GART addr into TTM

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:10PM +0200, Christian König wrote: > Move setting the GART addr for window based copies into the TTM code who > uses it. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 -- >

[PATCH 2/4] drm/amdgpu: implement soft_recovery for GFX7

2018-08-23 Thread Christian König
Try to kill waves on the SQ. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 95452c5a9df6..a15d9c0f233b 100644 ---

[PATCH 4/4] drm/amdgpu: implement soft_recovery for GFX9

2018-08-23 Thread Christian König
Try to kill waves on the SQ. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 44707f94b2c5..ab5cacea967b 100644 ---

Re: [PATCH 5/5] drm: add syncobj timeline support v2

2018-08-23 Thread Christian König
Am 23.08.2018 um 11:58 schrieb zhoucm1: On 2018年08月23日 17:15, Christian König wrote: Am 23.08.2018 um 10:25 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline

Re: [PATCH 1/3] drm/amdgpu: Fix vce initialize failed on Kaveri/Mullins

2018-08-23 Thread Michel Dänzer
On 2018-08-23 11:24 a.m., Rex Zhu wrote: > Forgot to add vce pg support via smu for Kaveri/Mullins. > > Regresstion issue caused by > 'commit 561a5c83eadd ("drm/amd/pp: Unify powergate_uvd/vce/mmhub > to set_powergating_by_smu")' You can replace this paragraph with Fixes: 561a5c83eadd

Re: [PATCH 2/3] drm/amdgpu: Power up uvd block when hw_fini

2018-08-23 Thread Michel Dänzer
On 2018-08-23 11:24 a.m., Rex Zhu wrote: > when hw_fini/suspend, smu only need to power up uvd block > if uvd pg is supported, don't need to call vce to do hw_init. Do you really mean VCE here, not UVD? > diff --git a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c > b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c

Re: [PATCH 5/5] drm: add syncobj timeline support v2

2018-08-23 Thread zhoucm1
On 2018年08月23日 17:15, Christian König wrote: Am 23.08.2018 um 10:25 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations:   

Re: [PATCH 5/5] drm: add syncobj timeline support v2

2018-08-23 Thread zhoucm1
On 2018年08月23日 17:08, Daniel Vetter wrote: On Thu, Aug 23, 2018 at 04:25:42PM +0800, Chunming Zhou wrote: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following

[PATCH 3/3] drm/amdgpu: Remove dead code in amdgpu_pm.c

2018-08-23 Thread Rex Zhu
As we have unify powergate_uvd/vce/mmhub to set_powergating_by_smu, and set_powergating_by_smu was supported by both dpm and powerplay. so remove the else case. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 35 -- 1 file changed, 35

[PATCH 2/3] drm/amdgpu: Power up uvd block when hw_fini

2018-08-23 Thread Rex Zhu
when hw_fini/suspend, smu only need to power up uvd block if uvd pg is supported, don't need to call vce to do hw_init. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c

[PATCH 1/3] drm/amdgpu: Fix vce initialize failed on Kaveri/Mullins

2018-08-23 Thread Rex Zhu
Forgot to add vce pg support via smu for Kaveri/Mullins. Regresstion issue caused by 'commit 561a5c83eadd ("drm/amd/pp: Unify powergate_uvd/vce/mmhub to set_powergating_by_smu")' Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 41 +++-- 1 file

Re: [PATCH 2/5] drm/amdgpu: add ring soft recovery v2

2018-08-23 Thread Christian König
Am 23.08.2018 um 09:17 schrieb Huang Rui: On Wed, Aug 22, 2018 at 12:55:43PM -0400, Alex Deucher wrote: On Wed, Aug 22, 2018 at 6:05 AM Christian König wrote: Instead of hammering hard on the GPU try a soft recovery first. v2: reorder code a bit Signed-off-by: Christian König ---

Re: [PATCH 5/5] drm: add syncobj timeline support v2

2018-08-23 Thread Christian König
Am 23.08.2018 um 10:25 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * Host query - A host operation that allows

Re: [PATCH 2/5] drm: rename null fence to stub fence in syncobj

2018-08-23 Thread Christian König
Am 23.08.2018 um 10:25 schrieb Chunming Zhou: stub fence will be used by timeline syncobj as well. Mhm, I'm leaning a bit towards renaming it but "null" fence or "stub" fence doesn't make a large difference to me. Point is that it is a fence which is always signaled right from the

Re: [PATCH 5/5] drm: add syncobj timeline support v2

2018-08-23 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 04:25:42PM +0800, Chunming Zhou wrote: > VK_KHR_timeline_semaphore: > This extension introduces a new type of semaphore that has an integer payload > identifying a point in a timeline. Such timeline semaphores support the > following operations: >* Host query - A host

Re: [PATCH 4/5] drm: expand replace_fence to support timeline point

2018-08-23 Thread Christian König
Am 23.08.2018 um 10:25 schrieb Chunming Zhou: we can place a fence to a timeline point after expanded. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 16 +---

Re: [PATCH 1/5] drm: fix syncobj null_fence_enable_signaling

2018-08-23 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 11:02 AM, Christian König wrote: > Am 23.08.2018 um 10:25 schrieb Chunming Zhou: >> >> That is certainly totally nonsense. dma_fence_enable_sw_signaling() >> is the function who is calling this callback. >> >> Signed-off-by: Chunming Zhou >> Cc: Jason Ekstrand > > > For

Re: [PATCH 3/5] drm: expand drm_syncobj_find_fence to support timeline point

2018-08-23 Thread Christian König
Am 23.08.2018 um 10:25 schrieb Chunming Zhou: we can fetch timeline point fence after expanded. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 6 -- drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--

Re: [PATCH 1/5] drm: fix syncobj null_fence_enable_signaling

2018-08-23 Thread Christian König
Am 23.08.2018 um 10:25 schrieb Chunming Zhou: That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand For this one: Reviewed-by: Christian König --- drivers/gpu/drm/drm_syncobj.c |

Re: [PATCH 2/6] drm/amdgpu: cleanup GPU recovery check a bit

2018-08-23 Thread Christian König
Am 23.08.2018 um 04:54 schrieb Huang Rui: On Wed, Aug 22, 2018 at 12:04:53PM +0200, Christian König wrote: Check if we should call the function instead of providing the forced flag. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++-

[PATCH 5/5] drm: add syncobj timeline support v2

2018-08-23 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * Host query - A host operation that allows querying the payload of the timeline semaphore.

[PATCH 3/5] drm: expand drm_syncobj_find_fence to support timeline point

2018-08-23 Thread Chunming Zhou
we can fetch timeline point fence after expanded. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 6 -- drivers/gpu/drm/v3d/v3d_gem.c | 4 ++-- drivers/gpu/drm/vc4/vc4_gem.c | 2 +-

[PATCH 4/5] drm: expand replace_fence to support timeline point

2018-08-23 Thread Chunming Zhou
we can place a fence to a timeline point after expanded. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 16 +--- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/v3d/v3d_gem.c

[PATCH 2/5] drm: rename null fence to stub fence in syncobj

2018-08-23 Thread Chunming Zhou
stub fence will be used by timeline syncobj as well. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index

[PATCH 1/5] drm: fix syncobj null_fence_enable_signaling

2018-08-23 Thread Chunming Zhou
That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_syncobj.c

Re: [PATCH 03/11] drm/amdgpu: cleanup VM handling in the CS a bit

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:09PM +0200, Christian König wrote: > Add a helper function for getting the root PD addr and cleanup join the > two VM related functions and cleanup the function name. > > No functional change. > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- >

Re: [PATCH 02/11] drm/amdgpu: validate the VM root PD from the VM code

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:08PM +0200, Christian König wrote: > Preparation for following changes. This validates the root PD twice, > but the overhead of that should be minimal. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 > 1 file changed,

Re: [PATCH 01/11] drm/amdgpu: remove extra root PD alignment

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 05:05:07PM +0200, Christian König wrote: > Just another leftover from radeon. > > Signed-off-by: Christian König Acked-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +--- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 --- > 2 files changed, 1

Re: [PATCH 2/5] drm/amdgpu: add ring soft recovery v2

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 12:55:43PM -0400, Alex Deucher wrote: > On Wed, Aug 22, 2018 at 6:05 AM Christian König > wrote: > > > > Instead of hammering hard on the GPU try a soft recovery first. > > > > v2: reorder code a bit > > > > Signed-off-by: Christian König > > --- > >

Re: KFD co-maintainership and branch model

2018-08-23 Thread Christian König
Am 23.08.2018 um 08:54 schrieb Oded Gabbay: On Thu, Aug 23, 2018 at 4:34 AM David Airlie wrote: On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling wrote: Hi all, Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be. At the same

Re: KFD co-maintainership and branch model

2018-08-23 Thread Oded Gabbay
On Thu, Aug 23, 2018 at 4:34 AM David Airlie wrote: > > On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling > wrote: > > Hi all, > > > > Oded has offered to make me co-maintainer of KFD, as he's super busy at > > work and less responsive than he used to be. > > > > At the same time we're about to

Re: [PATCH 01/11] drm/amdgpu: remove extra root PD alignment

2018-08-23 Thread Christian König
Am 22.08.2018 um 21:46 schrieb Alex Deucher: On Wed, Aug 22, 2018 at 11:05 AM Christian König wrote: Just another leftover from radeon. I can't remember exactly what chip this was for. Are you sure this isn't still required for SI or something like that? Actually as far as I know it is not

Re: [PATCH 2/5] drm/amdgpu: add ring soft recovery v2

2018-08-23 Thread Christian König
Am 22.08.2018 um 21:32 schrieb Marek Olšák: On Wed, Aug 22, 2018 at 12:56 PM Alex Deucher wrote: On Wed, Aug 22, 2018 at 6:05 AM Christian König wrote: Instead of hammering hard on the GPU try a soft recovery first. v2: reorder code a bit Signed-off-by: Christian König ---

Re: [PATCH 3/6] drm/amdgpu: add ring soft recovery v2

2018-08-23 Thread Huang Rui
On Wed, Aug 22, 2018 at 12:04:54PM +0200, Christian König wrote: > Instead of hammering hard on the GPU try a soft recovery first. > > v2: reorder code a bit > > Signed-off-by: Christian König Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 ++ >

[PATCH] drm/amdgpu: Remove duplicated power source update

2018-08-23 Thread Rex Zhu
when ac/dc switch, driver will be notified by acpi event. then the power source will be updated. so don't need to get power source when set power state. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 8 1 file changed, 8 deletions(-) diff --git

Re: Possible use_mm() mis-uses

2018-08-23 Thread Zhenyu Wang
On 2018.08.22 20:20:46 +0200, Paolo Bonzini wrote: > On 22/08/2018 18:44, Linus Torvalds wrote: > > An example of something that *isn't* right, is the i915 kvm interface, > > which does > > > > use_mm(kvm->mm); > > > > on an mm that was initialized in virt/kvm/kvm_main.c using > > > >