Re: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase

On 2018年09月06日 08:28, Felix Kuehling wrote: The intent of two commits was lost in the last rebase: 810955b drm/amdgpu: Fix acquiring VM on large-BAR systems b5d21aa drm/amdgpu: Don't use shadow BO for compute context This commit restores the original behaviour: * Don't set

Re: [PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase

On 09/06/2018 08:28 AM, Felix Kuehling wrote: The intent of two commits was lost in the last rebase: 810955b drm/amdgpu: Fix acquiring VM on large-BAR systems b5d21aa drm/amdgpu: Don't use shadow BO for compute context This commit restores the original behaviour: * Don't set

[PATCH 1/1] drm/amdgpu: Fix compute VM BO params after rebase

The intent of two commits was lost in the last rebase: 810955b drm/amdgpu: Fix acquiring VM on large-BAR systems b5d21aa drm/amdgpu: Don't use shadow BO for compute context This commit restores the original behaviour: * Don't set AMDGPU_GEM_CREATE_NO_CPU_ACCESS for page directories to allow

[PATCH xf86-video-ati] Fix uninitialized use of local variable pitch in radeon_setup_kernel_mem

From: Michel Dänzer Fixes server reset. Pointed out by clang: ../../src/radeon_kms.c:2721:9: warning: variable 'pitch' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (!info->front_buffer) { ^~~ ../../src/radeon_kms.c:2765:27:

[PATCH 13/13] drm/amdkfd: Generate xGMI direct iolink

From: Shaoyun Liu Generate xGMI iolink for upper level usage Change-Id: I37bc29fee45cb10d1da849956055c59d823f6f5d Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 78 ++- 1 file changed, 68 insertions(+), 10

[PATCH 12/13] drm/amdkfd: Add new iolink type defines

From: Shaoyun Liu Update the iolink type defines according to the new thunk spec Change-Id: Ie155641b6bfbe005ae0e12c5c31c68157247ea26 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_crat.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

[PATCH 11/13] drm/amdkfd: kfd expose the hive_id of the device through its node properties

From: Shaoyun Liu Thunk will generate the XGMI topology information when necessary with the hive_id for each specified device Change-Id: I3bbc37bd2af4295e24357ce82f2c760162aff9ca Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 +++

[PATCH 10/13] drm/amdgpu: get_hive_id from amdgpu side

From: Shaoyun Liu Retrieve hive_id from amdgpu device Change-Id: I9bb4d87870edf638b477a9088f14bc84b70e71e2 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 7 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +

[PATCH 09/13] drm/amd/include: Add get_hive_id interface in kfd2kgd

From: Shaoyun Liu KFD need to get hive id from amdgpu to build up the XGMI topology Change-Id: If68ea8fd7fb17b7ffb581f45d8406925578d96b8 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/include/kgd_kfd_interface.h | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 08/13] drm/amdgpu : Generate XGMI topology info from driver level

From: Shaoyun Liu Driver will save an array of XGMI hive info, each hive will have a list of devices that have the same hive ID. Change-Id: Ia2934d5b624cffa3283bc0a37679eddbd387cbdd Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/Makefile| 2

[PATCH 07/13] drm/amdgpu: Add place holder functions for xgmi topology interface with psp

From: Shaoyun Liu Add dummy function for xgmi function interface with psp Change-Id: I01f35baf5a4b96e9654d448c9892be3cd72c05b7 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 26 ++ 1 file changed, 26 insertions(+)

[PATCH 06/13] drm/amdgpu : Add psp function interfaces for XGMI support

From: Shaoyun Liu Place holder for XGMI support Change-Id: I924fa3693366409de0218009c7f709cb464854cc Signed-off-by: Shaoyun Liu Reviewed-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 34 + 1 file changed, 34 insertions(+) diff --git

[PATCH 05/13] drm/amdgpu/gmc9: populate xgmi info for vega20

From: Alex Deucher Call the new gfxhub 1.1 function to get the xgmi info. Acked-by: Huang Rui Acked-by: Slava Abramov Reviewed-by :Shaoyun liu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH 04/13] drm/amdgpu/gmc9: Adjust xgmi offset

From: Alex Deucher On hives with xgmi enabled, the fb_location aperture is a size which defines the total framebuffer size of all nodes in the hive. Each GPU in the hive has the same view via the fb_location aperture. GPU0 starts at offset (0 * segment size), GPU1 starts at offset (1 * segment

[PATCH 03/13] drm/amdgpu/gmc9: add a new gfxhub 1.1 helper for xgmi

From: Alex Deucher Used to populate the xgmi info on vega20. v2: PF_MAX_REGION is val - 1 (Ray) Acked-by: Huang Rui Acked-by: Slava Abramov Reviewed-by :Shaoyun liu Signed-off-by: Alex Deucher Change-Id: Ia7b7f112880e69cdbcf73a8abf04cd6ef303940c --- drivers/gpu/drm/amd/amdgpu/Makefile

[PATCH 02/13] drm/amdgpu/gmc: add initial xgmi structure to amdgpu_gmc structure

From: Alex Deucher Initial pass at a structure to store xgmi info. xgmi is a high speed cross gpu interconnect. Acked-by: Huang Rui Acked-by: Slava Abramov Reviewed-by :Shaoyun liu Signed-off-by: Alex Deucher Change-Id: I8b373bd847c857dd7cbefa55d1ede2a8785deb06 ---

[PATCH 01/13] drm/amd/include: update the bitfield define for PF_MAX_REGION

From: Shaoyun Liu Correct the definition based on vega20 register spec Change-Id: Ifde296134d00423cdf1078c8249d044f5b5cf5a5 Signed-off-by: Shaoyun Liu Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/include/asic_reg/gc/gc_9_2_1_sh_mask.h | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] drm/amdgpu: set bulk_moveable to false when a per VM is released

Hi Tom, please check if that patch helps with your KASAN problem. Thanks, Christian. Am 05.09.2018 um 17:08 schrieb Christian König: Otherwise we might run into a use after free during bulk move. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 1 file

[PATCH] drm/amdgpu: set bulk_moveable to false when a per VM is released

Otherwise we might run into a use after free during bulk move. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index

Re: Patches for XGMI support

Please use git send-email instead of attaching the changes. And make sure the patches apply to amd-staging-drm-next, not drm-next! Regards, Christian. Am 05.09.2018 um 17:02 schrieb Liu, Shaoyun: Here is a list of patches in the topic branch for XGMI support , now I try to merge them into

Patches for XGMI support

Here is a list of patches in the topic branch for XGMI support , now I try to merge them into drm-next . Please have a look . Regards Shaoyun.liu 0001-drm-amd-include-update-the-bitfield-define-for-PF_MA.patch Description: 0001-drm-amd-include-update-the-bitfield-define-for-PF_MA.patch

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

On 5 September 2018 at 14:20, Thomas Hellstrom wrote: >> In that case, please give me 24h to do a libdrm release before pushing. >> I had to push some workarounds for the sandboxing mentioned earlier :-\ >> >> Thanks >> Emil > > > Ouch, I just pushed the patch, but feel free to cut the release

Re: two KASANs in TTM logic

Logs attached. Tom On 09/05/2018 08:02 AM, Christian König wrote: Still not the slightest idea what is causing this and the patch definitely fixes things a lot. Can you try to enable list debugging in your kernel? Thanks, Christian. Am 04.09.2018 um 19:18 schrieb Tom St Denis: Sure:

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

On 09/05/2018 03:07 PM, Emil Velikov wrote: On 5 September 2018 at 11:10, Thomas Hellstrom wrote: Hi, Emil, On 09/05/2018 11:33 AM, Emil Velikov wrote: On 4 September 2018 at 23:33, Dave Airlie wrote: On Tue, 4 Sep 2018 at 03:00, Thomas Hellstrom wrote: On 09/03/2018 06:33 PM, Daniel

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

On 5 September 2018 at 11:10, Thomas Hellstrom wrote: > Hi, Emil, > > > On 09/05/2018 11:33 AM, Emil Velikov wrote: >> >> On 4 September 2018 at 23:33, Dave Airlie wrote: >>> >>> On Tue, 4 Sep 2018 at 03:00, Thomas Hellstrom >>> wrote: On 09/03/2018 06:33 PM, Daniel Vetter wrote:

[PATCH] drm/amdgpu: Fix typo in warning message

From 0974a1477e9118fbf76b5c89e0c3e604c1acd7da Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Wed, 8 Aug 2018 16:23:30 +0200 Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: two KASANs in TTM logic

Hi Christian, Will in a sec. I'm doing a piglit run with Felix's KFD patch on top of HEAD~ just to verify that everything before that is peachy on my Raven+Polaris rig. Tom On 09/05/2018 08:02 AM, Christian König wrote: Still not the slightest idea what is causing this and the patch

Re: two KASANs in TTM logic

Still not the slightest idea what is causing this and the patch definitely fixes things a lot. Can you try to enable list debugging in your kernel? Thanks, Christian. Am 04.09.2018 um 19:18 schrieb Tom St Denis: Sure: d2917f399e0b250f47d07da551a335843a24f835 is the first bad commit commit

Re: [PATCH v3 03/13] fbdev: add kerneldoc do remove_conflicting_framebuffers()

Dear Michał, Thank you for documenting the function. Do you mean *to* instead of *do* in the commit message summary? On 09/01/18 16:08, Michał Mirosław wrote: > Document remove_conflicting_framebuffers() behaviour. > > Signed-off-by: Michał Mirosław > --- > drivers/video/fbdev/core/fbmem.c

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

Hi, Emil, On 09/05/2018 11:33 AM, Emil Velikov wrote: On 4 September 2018 at 23:33, Dave Airlie wrote: On Tue, 4 Sep 2018 at 03:00, Thomas Hellstrom wrote: On 09/03/2018 06:33 PM, Daniel Vetter wrote: On Mon, Sep 03, 2018 at 11:16:29AM +0200, Thomas Hellstrom wrote: On 08/31/2018 05:30

[PATCH xf86-video-ati 1/2] Always delete entry from list in drm_queue_handler

From: Michel Dänzer We left entries without a handler hook in the list, so the list could keep taking longer to process and use up more memory. (Ported from amdgpu commit 7eea3e2cd74eed22e982319144e18ae5b1087b78) Signed-off-by: Michel Dänzer --- src/radeon_drm_queue.c | 2 +- 1 file changed,

[PATCH xf86-video-ati 2/2] Don't use xorg_list_for_each_entry_safe for signalled flips

From: Michel Dänzer drm_wait_pending_flip can get called from drm_handle_event, in which case xorg_list_for_each_entry_safe can end up processing the same entry in both. To avoid this, just process the first list entry until the list is empty. (Ported from amdgpu commit

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

On 4 September 2018 at 23:33, Dave Airlie wrote: > On Tue, 4 Sep 2018 at 03:00, Thomas Hellstrom wrote: >> >> On 09/03/2018 06:33 PM, Daniel Vetter wrote: >> > On Mon, Sep 03, 2018 at 11:16:29AM +0200, Thomas Hellstrom wrote: >> >> On 08/31/2018 05:30 PM, Thomas Hellstrom wrote: >> >>> On

[PATCH v2 xf86-video-amdgpu] Bail early from drm_wait_pending_flip if there's no pending flip

From: Michel Dänzer No need to process any events in that case. v2: * Re-check drmmode_crtc->flip_pending after processing each event Signed-off-by: Michel Dänzer --- src/amdgpu_drm_queue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amdgpu_drm_queue.c

CentOS 7 as hostos: gim error:(set_new_adapter:617) asic does not support SRIOV

Hello! I'm trying to use an AMD FirePro S7150 in a CentOS 7.3 system. Here is some information regarding the setup: [root@host001 /]# uname -r 3.10.0-514.el7.x86_64 [root@host001 /]# dmesg | grep gim [ 10.887502] gim: loading out-of-tree module taints kernel. [ 10.887809] gim: module

gim error:(set_new_adapter:791) fail to enable MSI

I'm working on AMD FirePro S7150 GPU passthrough by SRIOV on CentOS 7.3 (kernel = 3.10.0-514). According to the two patches from https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization, I have patched the kernel and rebooted. Iommu and sriov are both enabled, 8 VFs can be found. But

Re: [PATCH 5/5] [RFC]drm: add syncobj timeline support v3

Am 05.09.2018 um 05:36 schrieb zhoucm1: On 2018年09月04日 17:20, Christian König wrote: Am 04.09.2018 um 11:00 schrieb zhoucm1: On 2018年09月04日 16:42, Christian König wrote: Am 04.09.2018 um 10:27 schrieb zhoucm1: On 2018年09月04日 16:05, Christian König wrote: Am 04.09.2018 um 09:53 schrieb