On Mon, 2018-11-12 at 16:01 +0100, Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own __drm_atomic_h
There seems too many " if (adev->asic_type == CHIP_VEGA20)" judgement.
Maybe you can eliminate some or split it into two functions.
Regards,
Evan
> -Original Message-
> From: amd-gfx On Behalf Of
> Kenneth Feng
> Sent: 2018年11月20日 13:54
> To: amd-gfx@lists.freedesktop.org
> Cc: Feng, Kenn
Due to the register name and setting change of HDP
memory light sleep on Vega20,change accordingly in
the driver.
Signed-off-by: Kenneth Feng
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 42 ++
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/drivers
On Tue, Oct 30, 2018 at 12:36:08PM -0400, Mikulas Patocka wrote:
> The macros PCI_EXP_LNKCAP_SLS_*GB are values, not bit masks. We must mask
> the register and compare it against them.
>
> This patch fixes errors "amdgpu: [powerplay] failed to send message 261
> ret is 0" errors when PCIe-v3 card
On 2018-11-19 3:57 p.m., Deucher, Alexander wrote:
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Yang, Philip
>> Sent: Monday, November 19, 2018 3:20 PM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Yang, Philip
>> Subject: [PATCH 3/3] drm/amdgpu: enable paging queue based on FW
>>
> -Original Message-
> From: amd-gfx On Behalf Of
> Yang, Philip
> Sent: Monday, November 19, 2018 3:20 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Yang, Philip
> Subject: [PATCH 3/3] drm/amdgpu: enable paging queue based on FW
> version
>
> Based SDMA fw version to enable has_page_queu
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Yang, Philip
Sent: Monday, November 19, 2018 3:20:07 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yang, Philip
Subject: [PATCH 2/3] drm/amdgpu: enable paging queue doorbell support v4
Because increase SDMA_DOORB
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Yang, Philip
Sent: Monday, November 19, 2018 3:20:00 PM
To: amd-gfx@lists.freedesktop.org
Cc: Yang, Philip
Subject: [PATCH 1/3] drm/amdgpu: fix typo in function sdma_v4_0_page_resume
This looks like copy pas
I'll grab it for my -fixes pull this week.
Alex
From: Kuehling, Felix
Sent: Monday, November 19, 2018 3:02:27 PM
To: Deucher, Alexander; amd-gfx@lists.freedesktop.org
Cc: Joerg Roedel
Subject: Re: [PATCH] drm/amdgpu: Fix oops when pp_funcs->switch_power_profile
Based SDMA fw version to enable has_page_queue support. Have to move
sdma_v4_0_init_microcode from sw_init to early_init, to load firmware
and init fw_version before set_ring/buffer/vm_pte_funcs use it.
Change-Id: Ife5d4659d28bc2a7012b48947b27e929749d87c1
Signed-off-by: Philip Yang
---
drivers/g
Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for paging queue
will
break SRIOV, instead we can reserve and map two doorbell pages for amdgpu,
paging
queues doorbell index use same index as SDMA gfx queues index but on second
page.
For Vega20, after we change doorbell layout to
This looks like copy paste typo
Change-Id: Iee3fd3a551650ec9199bc030a7886e92000b02e7
Signed-off-by: Philip Yang
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
b/drivers/gpu/drm/amd/amdgp
Hi Christian,
On 2018-11-19 6:24 a.m., Christian König wrote:
> Am 15.11.18 um 20:10 schrieb Yang, Philip:
>> paging queues doorbell index use existing assignment
>> sDMA_HI_PRI_ENGINE0/1
>> index, and increase SDMA_DOORBELL_RANGE size from 2 dwords to 4
>> dwords to
>> enable the new doorbell ind
I pushed the change to amd-staging-drm-next. I'd also like to get it
into drm-fixes. Should I cherry-pick it to your drm-fixes-4.20 branch on
fd.o?
Thanks,
Felix
On 2018-11-15 4:59 p.m., Deucher, Alexander wrote:
>
> Reviewed-by: Alex Deucher
>
> -
-Original Message-
From: Lyude Paul
Sent: November 16, 2018 6:25 PM
To: amd-gfx@lists.freedesktop.org
Cc: Wentland, Harry ; Li, Sun peng (Leo)
; Deucher, Alexander ; Koenig,
Christian ; Zhou, David(ChunMing)
; David Airlie ; Zuo, Jerry
; Li, Roman ; Cheng, Tony
; Daniel Vetter ; S, S
On Mon, Nov 19, 2018 at 7:03 AM Christian König
wrote:
>
> Am 19.11.18 um 12:55 schrieb Takashi Iwai:
> > Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver
> > doesn't work properly in initrd. Let's add it.
> >
> > Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239
> > Fixe
On Mon, Nov 19, 2018 at 10:22 AM Rex Zhu wrote:
>
> The static struct drm_driver *driver was
> not used because drm_pci_init was deprecated
>
> v2: Remove static pointer pdriver
>
> Reviewed-by: Christian König
> Signed-off-by: Rex Zhu
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/am
On Mon, Nov 19, 2018 at 11:59 AM Greathouse, Joseph
wrote:
>
> Reading the sysfs files pp_sclk_od and pp_mclk_od return the
> percentage difference between the VBIOS-provided default
> frequency and the current (possibly user-set) frequency in
> the highest SCLK and MCLK DPM states, respectively.
On Mon, Nov 19, 2018 at 2:17 PM Brajeswar Ghosh
wrote:
>
> Remove gca/gfx_8_0_enum.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm
Remove gca/gfx_8_0_enum.h which is included more than once
Signed-off-by: Brajeswar Ghosh
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 3d0f277a6523..4ca1ecf1ffd7 1
On Wed, Nov 14, 2018 at 10:44 AM Alex Deucher wrote:
>
> On Tue, Oct 30, 2018 at 2:00 PM Alex Deucher wrote:
> >
> > On Tue, Oct 30, 2018 at 12:36 PM Mikulas Patocka
> > wrote:
> > >
> > > The macros PCI_EXP_LNKCAP_SLS_*GB are values, not bit masks. We must mask
> > > the register and compare i
Sure, I'll do it.
-Original Message-
From: Lyude Paul
Sent: November 19, 2018 1:52 PM
To: Zuo, Jerry ; amd-gfx@lists.freedesktop.org
Cc: Wentland, Harry ; Li, Sun peng (Leo)
; Deucher, Alexander ; Koenig,
Christian ; Zhou, David(ChunMing)
; David Airlie ; Li, Roman
; S, Shirish ; Dan
Cool! If it did actually fix those problems, would you mind making sure this
gets Cc'd to stable when it gets pushed upstream?
On Mon, 2018-11-19 at 15:00 +, Zuo, Jerry wrote:
> Reviewed-by: Jerry (Fangzhi) Zuo
>
> The change fixed MST + SST daisy chain and S3 scenarios. The issue shows
> hu
Reading the sysfs files pp_sclk_od and pp_mclk_od return the
percentage difference between the VBIOS-provided default
frequency and the current (possibly user-set) frequency in
the highest SCLK and MCLK DPM states, respectively.
Writing to these files provides an easy mechanism for
setting a highe
On Sun, Nov 18, 2018 at 11:12 PM Monk Liu wrote:
>
> there is a hw issue that disallow us to use strong
> BURST_WRITE for SDMA0/1 engines, without force
> BURST_WRITE field set to 0x1 (64B) we will hit
> h/w bug during stress MMHUB transist
>
> Signed-off-by: Monk Liu
Acked-by: Alex Deucher
>
The static struct drm_driver *driver was
not used because drm_pci_init was deprecated
v2: Remove static pointer pdriver
Reviewed-by: Christian König
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git
The static struct drm_driver *driver was
not used because drm_pci_init was deprecated
v2: Remove static pointer pdriver
Reviewed-by: Christian König
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git
Reviewed-by: Jerry (Fangzhi) Zuo
The change fixed MST + SST daisy chain and S3 scenarios. The issue shows huge
delay in MST + SST daisy chain, and soft hang in S3 resume.
The aux sequence is changed by failed iteration search in
drm_connector_for_each_possible_encoder().
The failure of search
Am 19.11.18 um 12:55 schrieb Takashi Iwai:
Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver
doesn't work properly in initrd. Let's add it.
Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239
Fixes: 8eaf2b1faaf4 ("drm/amdgpu: switch firmware path for SI parts")
Cc:
Signed
Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver
doesn't work properly in initrd. Let's add it.
Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239
Fixes: 8eaf2b1faaf4 ("drm/amdgpu: switch firmware path for SI parts")
Cc:
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/a
Am 15.11.18 um 20:10 schrieb Yang, Philip:
paging queues doorbell index use existing assignment sDMA_HI_PRI_ENGINE0/1
index, and increase SDMA_DOORBELL_RANGE size from 2 dwords to 4 dwords to
enable the new doorbell index.
v2: disable paging queue doorbell on Vega10 and Vega12 with SRIOV
Change
Am 19.11.18 um 12:07 schrieb Rex Zhu:
The static struct drm_driver *driver was
not used because drm_pci_init was deprecated
Signed-off-by: Rex Zhu
Reviewed-by: Christian König
Can you of hand see what "pdriver" is used for? That looks suspicious
like something deprecated as well.
Regards
The static struct drm_driver *driver was
not used because drm_pci_init was deprecated
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/am
On 2018-11-18 9:22 p.m., Alan Coopersmith wrote:
> Signed-off-by: Alan Coopersmith
> ---
>
> Unlike the similar updates to the other Xorg project README's, this leaves
> your bugzilla link in place, as well as the instructions to submit patches
> to your mailing list instead of suggesting gitlab
> -Original Message-
> From: Huang Rui [mailto:ray.hu...@amd.com]
> Sent: Monday, November 19, 2018 3:53 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Huang, Ray
> Subject: [PATCH] drm/amdgpu: add checking to avoid null pointer without
> enabling powerplay
>
> This patch adds the checking
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Alex Deucher
> Sent: Saturday, November 17, 2018 2:25 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/amdgpu/psp: use define rather than magic number
>
David,
Your patch works great. If you are not aware, the ABM does not work
anymore after the display turns off and back on again. Setting ABM level
to 0 and back to 4 makes it start working again though. This happens
when my display turns off automatically, but you can replicate this by
runni
Am 16.11.18 um 19:25 schrieb Alex Deucher:
Use the define rather than hardcoded value.
Signed-off-by: Alex Deucher
Acked-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.
Am 16.11.18 um 14:31 schrieb Huang, Trigger:
Hi,
Would you help on it?
-Original Message-
From: amd-gfx On Behalf Of Trigger Huang
Sent: Thursday, November 15, 2018 3:30 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Trigger
Subject: [PATCH V3] drm/scheduler: Fix bad job be re-process
Am 16.11.18 um 10:34 schrieb Chris Wilson:
As amd_uvd_resume() accesses the uvd ring, it must be initialised first
or else we trigger errors like:
[5.595963] [drm] Found UVD firmware Version: 1.87 Family ID: 17
[5.595969] [drm] PSP loading UVD firmware
[5.596266] [ cut he
Am 16.11.18 um 09:23 schrieb Huang, Ray:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Chengming Gui
Sent: Friday, November 16, 2018 4:21 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gui, Jack
Subject: [PATCH revert] Revert "drm/amdgpu: use GMC
Am 15.11.18 um 22:56 schrieb Kuehling, Felix:
On Vega20 and other pre-production GPUs, powerplay is not enabled yet.
Check for NULL pointers before calling pp_funcs function pointers.
Also affects Kaveri.
CC: Joerg Roedel
Signed-off-by: Felix Kuehling
Acked-by: Christian König
---
driv
Acked-by: Feifei Xu
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Monday, November 19, 2018 12:20 PM
To: amd-gfx@lists.freedesktop.org
Cc: Quan, Evan
Subject: [PATCH] drm/amd/powerplay: disable Vega20 DS related features
Disable these features on Vega20 for now.
Change-
43 matches
Mail list logo
