Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

2019-01-15 Thread Christian König
Am 15.01.19 um 23:01 schrieb Grodzovsky, Andrey: On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: On 01/11/2019 02:11 PM, Koenig, Christian wrote: Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: On 01/11/2019 04:42 AM, Koenig, Christian wrote: Am 10.01.19 um 16:56 schrieb Grodzovsky, Andre

Re: [PATCH libdrm] amdgpu: update amdgpu_drm.h

2019-01-15 Thread Christian König
Am 15.01.19 um 20:25 schrieb Marek Olšák: From: Marek Olšák Maybe note in the commit message from which upstream kernel. With that in place the patch is Reviewed-by: Christian König --- include/drm/amdgpu_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/drm/a

[PATCH 2/2] drm/amdgpu: fix wrong APU judgement

2019-01-15 Thread Evan Quan
Fix the APU judgement to make it really work as expected. Change-Id: Iedc7d280e2bb68dd1b3732adb3b36ff9b05d84af Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/dri

[PATCH 1/2] drm/amdgpu: check PSP support before adding the ip block

2019-01-15 Thread Evan Quan
So that we do not need to check this in every internal function. Change-Id: Id986ad97ffddc769e4f7cc7e41d1780b93dba9b9 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 24 drivers/gpu/drm/amd/amdgpu/soc15.c | 13 - 2 files changed, 8

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Alex Deucher
On Tue, Jan 15, 2019 at 5:41 AM Daniel Vetter wrote: > > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all >

RE: [[PATCH v2]drm/amdgpu/psp: ignore psp response status] drm/amdgpu/psp: ignore psp response status

2019-01-15 Thread Liu, Aaron
Yes, thanks. I have modified the typo mistake of "response". BR, Aaron Liu > -Original Message- > From: Paul Menzel > Sent: Tuesday, January 15, 2019 7:07 PM > To: Liu, Aaron > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [[PATCH v2]drm/amdgpu/psp: ignore psp reponse status] > drm/a

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

2019-01-15 Thread Grodzovsky, Andrey
On 01/11/2019 05:03 PM, Andrey Grodzovsky wrote: > > > On 01/11/2019 02:11 PM, Koenig, Christian wrote: >> Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: >>> On 01/11/2019 04:42 AM, Koenig, Christian wrote: Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: > [SNIP] But we will

[PATCH libdrm] amdgpu: update amdgpu_drm.h

2019-01-15 Thread Marek Olšák
From: Marek Olšák --- include/drm/amdgpu_drm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 1ceec56d..be84e43c 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -319,20 +319,26 @@ struct drm_amdgpu_gem

RE: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Wu, Hersen
Hi, Alex, You are right! Thanks, Hersen From: Deucher, Alexander Sent: Tuesday, January 15, 2019 12:18 PM To: Wu, Hersen ; Alex Deucher Cc: Li, Sun peng (Leo) ; amd-gfx@lists.freedesktop.org; Wentland, Harry Subject: Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven

Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Deucher, Alexander
So 95f05a3a2e6895ecfd8b4f64b5d6c6 is still valid even with your patch and we should keep it? Thanks Alex From: Wu, Hersen Sent: Tuesday, January 15, 2019 12:04:30 PM To: Alex Deucher Cc: Deucher, Alexander; Li, Sun peng (Leo); amd-gfx@lists.freedesktop.org; We

RE: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Wu, Hersen
My change will NOT revert 95f05a3a2e6895ecfd8b4f64b5d6c6. Thanks Hersen -Original Message- From: Alex Deucher Sent: Tuesday, January 15, 2019 12:01 PM To: Wu, Hersen Cc: Deucher, Alexander ; Li, Sun peng (Leo) ; amd-gfx@lists.freedesktop.org; Wentland, Harry Subject: Re: [PATCH] d

Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Alex Deucher
I'm not sure I understand. If we were to apply your proposed patch, could we revert 95f05a3a2e6895ecfd8b4f64b5d6c6 ? Thanks, Alex On Tue, Jan 15, 2019 at 11:57 AM Wu, Hersen wrote: > > Hi, Alex, > > > > Hersen’s change is for older version of eDP fast boot up ( > bios_get_vga_enabled_displays

RE: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Wu, Hersen
Hi, Alex, Hersen's change is for older version of eDP fast boot up ( bios_get_vga_enabled_displays is called). Chrome tree source still use bios_get_vga_enabled_displays for fast boot up. Harry's change is new implementation of eDP fast boot up. Hersen's change will not revert Harry's change.

Re: [PATCH] drm/amdgpu: Add missing power attribute to APU check

2019-01-15 Thread Alex Deucher
Ping? On Wed, Jan 9, 2019 at 10:23 PM Alex Deucher wrote: > > Add missing power_average to visible check for power > attributesi for APUs. Was missed before. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: radeon 0000:1d:00.0: GPU lockup (current fence id 0x00000000017a66bf last fence id 0x00000000017a67a1 on ring 0)

2019-01-15 Thread Borislav Petkov
On Sat, Jan 12, 2019 at 09:50:51PM +0100, Borislav Petkov wrote: > Hi guys, > > my odyssey with the GPU continues. This time it didn't reset itself > but started spewing a single line about the hardware locking up. > > The machine was responsive to sysrq so I was able to write out > /var/log/mess

Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Deucher, Alexander
Can this patch be reverted with this change? commit 95f05a3a2e6895ecfd8b4f64b5d6c6cf0b6a3f4a Author: Alex Deucher Date: Thu Aug 16 15:35:21 2018 -0500 drm/amdgpu/display: disable eDP fast boot optimization on DCE8 Seems to cause blank screens. Bug: https://bugs.freedesktop.org/s

Re: [PATCH 4/4] drm/amd/powerplay: support retrieving and adjusting dcefclock power levels

2019-01-15 Thread Deucher, Alexander
Seems reasonable to me. With those changes, Reviewed-by: Alex Deucher From: Quan, Evan Sent: Tuesday, January 15, 2019 1:59:42 AM To: Alex Deucher Cc: amd-gfx list; Deucher, Alexander Subject: RE: [PATCH 4/4] drm/amd/powerplay: support retrieving and adjusting

Re: [PATCH] drm/amdgpu: Setting doorbell range registers earlier

2019-01-15 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Zeng, Oak Sent: Monday, January 14, 2019 5:39:41 PM To: amd-gfx@lists.freedesktop.org Cc: Zeng, Oak Subject: [PATCH] drm/amdgpu: Setting doorbell range registers earlier HW doorbell writing routing policy: w

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Oleksandr Andrushchenko
On 1/15/19 2:26 PM, Neil Armstrong wrote: On 15/01/2019 11:41, Daniel Vetter wrote: Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal her

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Tuesday, 15 January 2019 12:41:37 EET Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actuall

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Neil Armstrong
On 15/01/2019 11:41, Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And

Re: [[PATCH v2]drm/amdgpu/psp: ignore psp reponse status] drm/amdgpu/psp: ignore psp reponse status

2019-01-15 Thread Paul Menzel
Dear Aaron, On 01/15/19 07:30, Liu, Aaron wrote: > The psp code only support ucode loading at the beginning, but forgot > to remove the checking when more and more PSP command get into PSP. I didn’t know that, and missed that your patch is not only about microcode loading. > So some old PSP FW

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Jani Nikula
On Tue, 15 Jan 2019, Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And

Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic

2019-01-15 Thread Paul Menzel
Dear Hersen, dear Leo, Some nitpicks. Could you not put the problem statement in the commit message summary, but the solution? For example: > Fix eDP fast bootup for pre-raven asics On 01/14/19 23:36, sunpeng...@amd.com wrote: > From: hersen wu > > [Why] bios will light up eDP before sw drive

Re: [PATCH] drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START

2019-01-15 Thread Koenig, Christian
Am 15.01.19 um 07:19 schrieb Liu, Monk: > The max_pfn is now 1'''' (bytes) which is above 48 bit now, > and it with AMDGPU_GMC_HOLE_MASK make it to zero > > And in code "amdgpu_driver_open_kms()" I saw @Zhu, Rex write the code as : > > "csa_addr = amdgpu_csa_vadr(adev) & AMDGP