Undefined behaviour in drivers/gpu/drm/radeon/r200.c:480:34 - shift exponent 4096 is too large

2019-02-11 Thread Meelis Roos
Got UBSAN warning from Dell D600 running 5.0.0-rc4-00218-g12491ed354d2. The warning did not happen on bootup but during xfce session start or console switch. [ 15.323113] radeon :01:00.0: putting AGP V2 device into 4x mode [ 15.323134] radeon :01:00.0: GTT: 128M 0xE000 -

[PATCH] drm/amdgpu: don't clamp debugfs register access to the BAR size

2019-02-11 Thread Alex Deucher via amd-gfx
This prevents us from accessing extended registers in tools like umr. The register access functions already check if the offset is beyond the BAR size and use the indirect accessors with locking so this is safe. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3

Re: [PATCH] drm/amd/display: Use vrr friendly pageflip throttling in DC.

2019-02-11 Thread Kazlauskas, Nicholas
On 2/11/19 10:01 AM, Michel Dänzer wrote: > On 2019-02-09 7:52 a.m., Mario Kleiner wrote: >> In VRR mode, keep track of the vblank count of the last >> completed pageflip in amdgpu_crtc->last_flip_vblank, as >> recorded in the pageflip completion handler after each >> completed flip. >> >> Use

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-11 Thread Daniel Vetter
On Mon, Feb 11, 2019 at 4:01 PM Kazlauskas, Nicholas wrote: > > On 2/11/19 3:35 AM, Daniel Vetter wrote: > > On Mon, Feb 11, 2019 at 04:22:24AM +0100, Mario Kleiner wrote: > >> The pageflip completion timestamps transmitted to userspace > >> via pageflip completion events are supposed to describe

Re: [PATCH] drm/amd/display: Use vrr friendly pageflip throttling in DC.

2019-02-11 Thread Michel Dänzer
On 2019-02-09 7:52 a.m., Mario Kleiner wrote: > In VRR mode, keep track of the vblank count of the last > completed pageflip in amdgpu_crtc->last_flip_vblank, as > recorded in the pageflip completion handler after each > completed flip. > > Use that count to prevent mmio programming a new

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-11 Thread Kazlauskas, Nicholas
On 2/11/19 3:35 AM, Daniel Vetter wrote: > On Mon, Feb 11, 2019 at 04:22:24AM +0100, Mario Kleiner wrote: >> The pageflip completion timestamps transmitted to userspace >> via pageflip completion events are supposed to describe the >> time at which the first pixel of the new post-pageflip scanout

Re: [PATCH] drm/amd/display: Use vrr friendly pageflip throttling in DC.

2019-02-11 Thread Kazlauskas, Nicholas
On 2/9/19 1:52 AM, Mario Kleiner wrote: > In VRR mode, keep track of the vblank count of the last > completed pageflip in amdgpu_crtc->last_flip_vblank, as > recorded in the pageflip completion handler after each > completed flip. > > Use that count to prevent mmio programming a new pageflip >

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-11 Thread Daniel Vetter
On Mon, Feb 11, 2019 at 04:22:24AM +0100, Mario Kleiner wrote: > The pageflip completion timestamps transmitted to userspace > via pageflip completion events are supposed to describe the > time at which the first pixel of the new post-pageflip scanout > buffer leaves the video output of the gpu.

Re: [PATCH v2 2/2] drm/drv: drm_dev_unplug(): Move out drm_dev_put() call

2019-02-11 Thread Daniel Vetter
On Fri, Feb 08, 2019 at 03:01:03PM +0100, Noralf Trønnes wrote: > This makes it possible to use drm_dev_unplug() with the upcoming > devm_drm_dev_init() which will do drm_dev_put() in its release callback. > > Cc: Alex Deucher > Cc: Christian König > Cc: David (ChunMing) Zhou > Cc: Dave Airlie