[PATCH] drm/amdgpu: remove some old unused dpm helpers

2019-02-14 Thread Alex Deucher via amd-gfx
Carried over from radeon, but no longer used. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 88 - drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 9 --- 2 files changed, 97 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c

Re: [PATCH 2/4] drm/amdgpu: Add last_non_cp in amdgpu_doorbell_index

2019-02-14 Thread Kuehling, Felix
Please add a patch description. It may make sense to define a first_non_cp doorbell index too. In patch 3 you have this, which is a bit inconsistent: + gpu_resources.non_cp_doorbells_start = + adev->doorbell_index.sdma_engine[0]; +

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Christian König via amd-gfx
Am 14.02.19 um 20:03 schrieb Grodzovsky, Andrey: On 2/14/19 12:54 PM, Kazlauskas, Nicholas wrote: On 2/14/19 12:47 PM, Grodzovsky, Andrey wrote: On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: On 2/14/19 11:07 AM, Michel Dänzer wrote: On

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 12:54 PM, Kazlauskas, Nicholas wrote: > On 2/14/19 12:47 PM, Grodzovsky, Andrey wrote: >> On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: >>> On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: On 2/14/19 11:07 AM, Michel Dänzer wrote: > On 2019-02-14 4:54 p.m., Kazlauskas,

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Kazlauskas, Nicholas
On 2/14/19 12:47 PM, Grodzovsky, Andrey wrote: > > On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: >> On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: >>> On 2/14/19 11:07 AM, Michel Dänzer wrote: On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: > On 2/14/19 10:42 AM, Grodzovsky,

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: > On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: >> On 2/14/19 11:07 AM, Michel Dänzer wrote: >>> On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: > On 2/14/19 4:05 AM, Christian König

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Michel Dänzer
On 2019-02-14 5:57 p.m., Kazlauskas, Nicholas wrote: > On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: >> >> On 2/14/19 11:07 AM, Michel Dänzer wrote: >>> On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: > On 2/14/19 4:05 AM, Christian

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Kazlauskas, Nicholas
On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: > > On 2/14/19 11:07 AM, Michel Dänzer wrote: >> On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: >>> On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: On 2/14/19 4:05 AM, Christian König wrote: > Am 13.02.19 um 19:58 schrieb Andrey

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 11:07 AM, Michel Dänzer wrote: > On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: >> On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: >>> On 2/14/19 4:05 AM, Christian König wrote: Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: > When ring hang happens

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Michel Dänzer
On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: > On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: >> On 2/14/19 4:05 AM, Christian König wrote: >>> Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 10:54 AM, Kazlauskas, Nicholas wrote: > On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: >> On 2/14/19 4:05 AM, Christian König wrote: >>> Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved and

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Kazlauskas, Nicholas
On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: > > On 2/14/19 4:05 AM, Christian König wrote: >> Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: >>> When ring hang happens amdgpu_dm_commit_planes during flip is holding >>> the BO reserved and then stack waiting for fences to signal in >>>

Re: "ring gfx timeout" with Vega 64 on mesa 19.0.0-rc2 and kernel 5.0.0-rc6 (GPU reset still not works)

2019-02-14 Thread Grodzovsky, Andrey
Got it. Andrey On 2/14/19 4:32 AM, Christian König wrote: Hey Andrey, this is on Vega10, so the ASIC always stops after it sees the first fault. I'm actually working on implementing that it should continue without interruption. Regards, Christian. Am 13.02.19 um 22:47 schrieb Grodzovsky,

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 4:05 AM, Christian König wrote: > Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: >> When ring hang happens amdgpu_dm_commit_planes during flip is holding >> the BO reserved and then stack waiting for fences to signal in >> reservation_object_wait_timeout_rcu (which won't signal

Re: [Intel-gfx] [PATCH 0/3] Make DRM DSC helpers more generally usable

2019-02-14 Thread Jani Nikula via amd-gfx
On Wed, 13 Feb 2019, David Francis wrote: > drm_dsc could use some work so that drm drivers other than > i915 can make use of it their own DSC implementations > > Move rc compute, a function that forms part of the DSC spec, > into drm. Update it to DSC 1.2. Also change the packing function > to

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-14 Thread Dan Carpenter via amd-gfx
Hi David, url: https://github.com/0day-ci/linux/commits/David-Francis/Make-DRM-DSC-helpers-more-generally-usable/20190214-052541 smatch warnings: drivers/gpu/drm/drm_dsc.c:306 drm_dsc_compute_rc_parameters() warn: impossible condition '(vdsc_cfg->nfl_bpg_offset > 65535) =>

Re: "ring gfx timeout" with Vega 64 on mesa 19.0.0-rc2 and kernel 5.0.0-rc6 (GPU reset still not works)

2019-02-14 Thread Christian König via amd-gfx
Hey Andrey, this is on Vega10, so the ASIC always stops after it sees the first fault. I'm actually working on implementing that it should continue without interruption. Regards, Christian. Am 13.02.19 um 22:47 schrieb Grodzovsky, Andrey: Looks like you are still running this without the

Re: "ring gfx timeout" with Vega 64 on mesa 19.0.0-rc2 and kernel 5.0.0-rc6 (GPU reset still not works)

2019-02-14 Thread Michel Dänzer
[ Puts on list administrator hat ] On 2019-02-14 5:16 a.m., Mikhail Gavrilov via amd-gfx wrote: > > Just in case, I duplicated all the files on the file sharing service Mega: > https://mega.nz/#F!pgYCjYrS!NkeTFIja_qwmxqLoSEUyzA Please only share such large files via an external service, don't

Re: [PATCH v2 1/4] drm/sched: Fix entities with 0 rqs.

2019-02-14 Thread Christian König via amd-gfx
Am 13.02.19 um 22:03 schrieb Alex Deucher via amd-gfx: On Wed, Jan 30, 2019 at 5:43 AM Christian König wrote: Am 30.01.19 um 02:53 schrieb Bas Nieuwenhuizen: Some blocks in amdgpu can have 0 rqs. Job creation already fails with -ENOENT when entity->rq is NULL, so jobs cannot be pushed.

Re: [PATCH] drm/amdgpu/powerplay: declare firmware for CI cards

2019-02-14 Thread Christian König via amd-gfx
Reviewed-by: Christian König Am 13.02.19 um 21:17 schrieb James Zhu: This patch is Reviewed-by: James Zhu Tested-by: James Zhu On 2019-02-13 3:10 p.m., Alex Deucher via amd-gfx wrote: Missing firmware declaration caused firmware requirement to not be noted by the module and may cause

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Christian König via amd-gfx
Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved and then stack waiting for fences to signal in reservation_object_wait_timeout_rcu (which won't signal because there was a hnag). Then when we try to shutdown

[PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN

2019-02-14 Thread Bo YU via amd-gfx
From: Bo Yu Calling "amdgpu_ring_test_helper" without checking return value Signed-off-by: Bo Yu --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

Re: [PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN

2019-02-14 Thread Bo YU via amd-gfx
Ok, drop it. On Thu, Feb 14, 2019 at 1:09 PM Zhou, David(ChunMing) wrote: > > > > -Original Message- > > From: Bo YU > > Sent: Thursday, February 14, 2019 12:46 PM > > To: Deucher, Alexander ; Koenig, Christian > > ; Zhou, David(ChunMing) > > ; airl...@linux.ie; dan...@ffwll.ch; Zhu,