Re: [PATCH V2] drm/amdgpu: Fix VM clean check method

2019-05-01 Thread Kuehling, Felix
On 2019-04-30 10:48 a.m., Trigger Huang wrote: > [CAUTION: External Email] > > amdgpu_vm_make_compute is used to turn a GFX VM into a compute VM, > the prerequisite is this VM is clean. Let's check if some page tables > are already filled , while not check if some mapping is already made. > >

Re: [PATCH] drm/amdgpu: Add IDH_QUERY_ALIVE event for SR-IOV

2019-05-01 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Trigger Huang Sent: Tuesday, April 30, 2019 4:30 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Trigger Subject: [PATCH] drm/amdgpu: Add IDH_QUERY_ALIVE event for SR-IOV [CAUTION: External Email] SR-IOV host

Re: [PATCH v13 10/20] kernel, arm64: untag user pointers in prctl_set_mm*

2019-05-01 Thread Vincenzo Frascino
Hi Andrey, sorry for the late reply, I came back from holiday and try to catch up with the emails. On 4/29/19 3:23 PM, Andrey Konovalov wrote: > On Fri, Apr 26, 2019 at 4:50 PM Catalin Marinas > wrote: >> >> On Mon, Apr 01, 2019 at 06:44:34PM +0200, Andrey Konovalov wrote: >>> On Fri, Mar 22,

Re: [PATCH 2/2] drm/amdgpu: Add PCIe replay count sysfs file

2019-05-01 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Russell, Kent Sent: Wednesday, May 1, 2019 8:01 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 2/2] drm/amdgpu: Add PCIe replay count sysfs file [CAUTION: External Email]

Re: [PATCH 2/2] drm/amdkfd: Cosmetic cleanup

2019-05-01 Thread Kuehling, Felix
Thank you Kent! The series is Reviewed-by: Felix Kuehling On 2019-05-01 8:31 a.m., Russell, Kent wrote: > [CAUTION: External Email] > > Fix some spacing issues, log output, uses of !=NULL/==NULL, unneeded > extra lines and clean up a declaration from =1 to =true for clarity > > Change-Id:

[PATCH 4/4] drm/amdkfd: Check against device cgroup

2019-05-01 Thread Kasiviswanathan, Harish
Participate in device cgroup. All kfd devices are exposed via /dev/kfd. So use /dev/dri/renderN node. Before exposing the device to a task check if it has permission to access it. If the task (based on its cgroup) can access /dev/dri/renderN then expose the device via kfd node. If the task

[PATCH 1/4] drm/amdkfd: Store kfd_dev in iolink and cache properties

2019-05-01 Thread Kasiviswanathan, Harish
This is required to check against cgroup permissions. Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 ++ drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 3 +++ 2 files changed, 13 insertions(+) diff --git

[PATCH 3/4] device_cgroup: Export __devcgroup_check_permission

2019-05-01 Thread Kasiviswanathan, Harish
For AMD compute (amdkfd) driver. All AMD compute devices are exported via single device node /dev/kfd. As a result devices cannot be controlled individually using device cgroup. AMD compute devices will rely on its graphics counterpart that exposes /dev/dri/renderN node for each device. For each

[PATCH 2/4] drm/amd: Pass drm_device to kfd

2019-05-01 Thread Kasiviswanathan, Harish
kfd needs drm_device to call into drm_cgroup functions Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c| 2 ++

[PATCH 0/4] AMDKFD (AMD GPU compute) support for device cgroup.

2019-05-01 Thread Kasiviswanathan, Harish
amdkfd (part of amdgpu) driver supports the AMD GPU compute stack. amdkfd exposes only a single device /dev/kfd even if multiple AMD GPU (compute) devices exist in a system. However, amdgpu drvier exposes a separate render device file /dev/dri/renderDN for each device. To participate in device

RE: [PATCH] drm/amdgpu: Add IDH_QUERY_ALIVE event for SR-IOV

2019-05-01 Thread Huang, Trigger
Hi Guys, Would you help on this patch? Thanks & Best Wishes, Trigger Huang -Original Message- From: amd-gfx On Behalf Of Trigger Huang Sent: Tuesday, April 30, 2019 4:30 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Trigger Subject: [PATCH] drm/amdgpu: Add IDH_QUERY_ALIVE event for

RE: [PATCH] drm/amdgpu: Rearm IRQ in Vega10 SR-IOV if IRQ lost

2019-05-01 Thread Huang, Trigger
Hi Christian, Yes, it is the HW guys who suggested to rearm it. Thanks & Best Wishes, Trigger Huang -Original Message- From: Christian König Sent: Wednesday, May 01, 2019 1:10 AM To: Huang, Trigger ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Rearm IRQ in Vega10

[PATCH 1/2] drm/amdgpu: Fix CIK references in gmc_v8

2019-05-01 Thread Russell, Kent
gmc_v8 is for VI, not CIK, so fix those references Change-Id: Ifa46212fbeadbec7e73ba28d02e97339ffcfb5d1 Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c

[PATCH 2/2] drm/amdkfd: Cosmetic cleanup

2019-05-01 Thread Russell, Kent
Fix some spacing issues, log output, uses of !=NULL/==NULL, unneeded extra lines and clean up a declaration from =1 to =true for clarity Change-Id: I638231cde4887a3c2da0b70e5fee77059cfb0bf2 Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 6 --

[PATCH 1/2] drm/amdgpu: Add replay counter defines to NBIO headers

2019-05-01 Thread Russell, Kent
Add the PCIE_RX_NUM_NACK and PCIE_RX_NUM_NACK_GENERATED values to the NBIO SMN headers in preparation for exposing the number of PCIe replays via sysfs Change-Id: I36c98b915f191ee2e37d32dc07167c286939d663 Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/include/asic_reg/nbio/nbio_6_1_smn.h

[PATCH 2/2] drm/amdgpu: Add PCIe replay count sysfs file

2019-05-01 Thread Russell, Kent
Add a sysfs file for reporting the number of PCIe replays (NAKs). This returns the sum of NAKs received and NAKs generated Change-Id: I135d5964ea13309754f80519c84a4eb3d360aab6 Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +++