Re: [PATCH] drm: add drm device name

2019-09-16 Thread Jani Nikula
On Mon, 16 Sep 2019, Marek Olšák wrote: > The purpose is to get rid of all PCI ID tables for all drivers in > userspace. (or at least stop updating them) > > Mesa common code and modesetting will use this. I'd think this would warrant a high level description of what you want to achieve in the

Re: linux-next: Tree for Sep 4 (amd/display/)

2019-09-16 Thread Kees Cook
On Wed, Sep 4, 2019 at 1:58 PM Randy Dunlap wrote: > > On 9/4/19 6:34 AM, Stephen Rothwell wrote: > > Hi all, > > > > News: this will be the last linux-next I will release until Sept 30. > > > > Changes since 20190903: > > > > on x86_64: > > In file included from >

[PATCH] drm/amd/display: memory leak

2019-09-16 Thread Navid Emamdoost
In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated clk_src needs release. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 3 ++- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 1 +

RE: [PATCH] drm/amd/powerplay: implement VCN power gating control interface

2019-09-16 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: Liang, Prike Sent: Tuesday, September 17, 2019 10:54 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Feng, Kenneth ; Huang, Ray ; Liu, Aaron ; Liang, Prike Subject: [PATCH] drm/amd/powerplay: implement VCN power gating control

Re: [Patch] drm/amdgpu: add navi12 pci id

2019-09-16 Thread Yin, Tianci (Rico)
Thanks Hawking! From: Zhang, Hawking Sent: Tuesday, September 17, 2019 11:02 To: Yin, Tianci (Rico) Cc: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Xu, Feifei ; Yuan, Xiaojie ; Xiao, Jack ; Long, Gang Subject: Re: [Patch] drm/amdgpu: add navi12 pci

Re: [Patch] drm/amdgpu: add navi12 pci id

2019-09-16 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang mailto:hawking.zh...@amd.com>> Regards, Hawking Sent from my iPhone On Sep 16, 2019, at 22:57, Yin, Tianci (Rico) mailto:tianci@amd.com>> wrote: <0001-drm-amdgpu-add-navi12-pci-id.patch> ___ amd-gfx mailing list

RE: [PATCH] drm/amdgpu/ras: use GPU PAGE_SIZE/SHIFT for reserving pages

2019-09-16 Thread Zhou1, Tao
Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: 2019年9月17日 3:51 > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu/ras: use GPU PAGE_SIZE/SHIFT for reserving > pages > > We are reserving vram pages

[Patch] drm/amdgpu: add navi12 pci id

2019-09-16 Thread Yin, Tianci (Rico)
From ec0d4e0069877a5a763972da4393b3c11404108d Mon Sep 17 00:00:00 2001 From: "Tianci.Yin" Date: Tue, 17 Sep 2019 10:35:34 +0800 Subject: [PATCH] drm/amdgpu: add navi12 pci id Add Navi12 PCI id support. Change-Id: Ic4e63f46f6ddf856910018dc3ddc2093d87873d0 Signed-off-by: Tianci.Yin ---

[PATCH] drm/amd/powerplay: implement VCN power gating control interface

2019-09-16 Thread Liang, Prike
VCN Gat/Ungat by processing the SMU power up/down message, otherwise S3 will resume failed as JPEG always power off during start VCN stage. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 28 +++- 1 file changed, 27 insertions(+), 1

Re: [PATCH] drm: add drm device name

2019-09-16 Thread Marek Olšák
The purpose is to get rid of all PCI ID tables for all drivers in userspace. (or at least stop updating them) Mesa common code and modesetting will use this. Marek On Sat, Sep 7, 2019 at 3:48 PM Daniel Vetter wrote: > On Sat, Sep 7, 2019 at 3:18 AM Rob Clark wrote: > > > > On Fri, Sep 6,

Re: [PATCH] drm/amd/display: build failed for DCN2.1

2019-09-16 Thread Mark Brown
On Mon, Sep 16, 2019 at 11:12:03PM +0100, Mark Brown wrote: > On Mon, Sep 16, 2019 at 01:51:15PM -0700, Nick Desaulniers wrote: > > > + Mark > > I think this was a result of the resolved merge conflict. See the > > -next only commit titled: > > Merge remote-tracking branch 'drm/drm-next' >

Re: [PATCH] drm/amd/display: Fix compile error due to 'endif' missing

2019-09-16 Thread Mark Brown
On Tue, Sep 17, 2019 at 02:46:48AM +0900, Masahiro Yamada wrote: > On Mon, Sep 16, 2019 at 1:46 PM Austin Kim wrote: > > gcc throws compile error with below message: > GNU Make throws ... Xinpeng Liu via Nick Desaulniers sent a description of the problem and a patch so I think I'll be able to

Re: [PATCH] drm/amd/display: build failed for DCN2.1

2019-09-16 Thread Mark Brown
On Mon, Sep 16, 2019 at 01:51:15PM -0700, Nick Desaulniers wrote: > + Mark > I think this was a result of the resolved merge conflict. See the > -next only commit titled: > Merge remote-tracking branch 'drm/drm-next' Yes, the DRM and the Kbuild people really need to coordinate with each

Re: [PATCH] drm/amdgpu: cleanup creating BOs at fixed location

2019-09-16 Thread Li, Sun peng (Leo)
On 2019-09-13 8:08 a.m., Christian König wrote: > The placement is something TTM/BO internal and the RAS code should > avoid touching that directly. > > Add a helper to create a BO at a fixed location and use that instead. > > Signed-off-by: Christian König > --- >

Re: [PATCH] docs: drm/amdgpu: Resolve build warnings

2019-09-16 Thread Alex Deucher
On Mon, Sep 16, 2019 at 3:28 AM Adam Zerella wrote: > > Some of the documentation formatting could be improved > which will resolve some Sphinx amdgpu build warnings e.g > > WARNING: Unexpected indentation. > WARNING: Block quote ends without a blank line; unexpected unindent. > WARNING: Inline

[PATCH] drm/amdgpu/ras: use GPU PAGE_SIZE/SHIFT for reserving pages

2019-09-16 Thread Alex Deucher
We are reserving vram pages so they should be aligned to the GPU page size. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

Re: [PATCH] drm/amdgpu: Fix regression crash on boot.

2019-09-16 Thread Christian König
Am 16.09.19 um 21:35 schrieb Andrey Grodzovsky: Regression on Vega20 caused by 0d9a80213829e092c1a85166b660ebf2c7af573e. Not setting BO ptr to null will confuse amdgpu_bo_create_reserved. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König ---

[PATCH] drm/amdgpu: Fix regression crash on boot.

2019-09-16 Thread Andrey Grodzovsky
Regression on Vega20 caused by 0d9a80213829e092c1a85166b660ebf2c7af573e. Not setting BO ptr to null will confuse amdgpu_bo_create_reserved. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] drm/amdgpu: use PAGE_SHIFT rather than PAGE_SIZE to get the shift

2019-09-16 Thread Christian König
Am 16.09.19 um 20:43 schrieb Alex Deucher: Looks like a copy and paste typo. Fixes: 0d9a80213829 ("drm/amdgpu: cleanup creating BOs at fixed location") Signed-off-by: Alex Deucher Reviewed-by: Christian König for the series. Sorry for the noise, I don't have hardware to actually test that

Re: [PATCH] drm/amdgpu/vm: fix documentation for amdgpu_vm_bo_param

2019-09-16 Thread Christian König
Am 16.09.19 um 20:22 schrieb Alex Deucher: Add new parameters. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

Re: [PATCH 1/2] drm/amdgpu: use PAGE_SHIFT rather than PAGE_SIZE to get the shift

2019-09-16 Thread Grodzovsky, Andrey
Series is Reviewed-by: Andrey Grodzovsky Andrey On 9/16/19 2:43 PM, Alex Deucher wrote: > Looks like a copy and paste typo. > > Fixes: 0d9a80213829 ("drm/amdgpu: cleanup creating BOs at fixed location") > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- >

[PATCH 1/2] drm/amdgpu: use PAGE_SHIFT rather than PAGE_SIZE to get the shift

2019-09-16 Thread Alex Deucher
Looks like a copy and paste typo. Fixes: 0d9a80213829 ("drm/amdgpu: cleanup creating BOs at fixed location") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

[PATCH 2/2] drm/amdgpu: fix documentation for amdgpu_bo_create_kernel_at

2019-09-16 Thread Alex Deucher
Typo in the function name. Fixes: 0d9a80213829 ("drm/amdgpu: cleanup creating BOs at fixed location") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

Re: [PATCH] drm/amdgpu/vm: fix documentation for amdgpu_vm_bo_param

2019-09-16 Thread Grodzovsky, Andrey
Reviewed-by: Andrey Grodzovsky Andrey On 9/16/19 2:22 PM, Alex Deucher wrote: > Add new parameters. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >

[PATCH] drm/amdgpu/vm: fix documentation for amdgpu_vm_bo_param

2019-09-16 Thread Alex Deucher
Add new parameters. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index f1175f9f4b80..54549a26ee01 100644 ---

Re: [PATCH] drm/amd/display: Fix compile error due to 'endif' missing

2019-09-16 Thread Mark Brown
On Tue, Sep 17, 2019 at 02:46:48AM +0900, Masahiro Yamada wrote: > (+CC Stephen Rothwell, Mark Brown) > > On Mon, Sep 16, 2019 at 1:46 PM Austin Kim wrote: > > > > gcc throws compile error with below message: > > GNU Make throws ... > > I don't have the original patch so I don't know what

[PATCH v2 2/4] drm/amd: Pass drm_device to kfd

2019-09-16 Thread Kasiviswanathan, Harish
kfd needs drm_device to call into drm_cgroup functions Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c| 2 ++

[PATCH v2 3/4] device_cgroup: Export devcgroup_check_permission

2019-09-16 Thread Kasiviswanathan, Harish
For AMD compute (amdkfd) driver. All AMD compute devices are exported via single device node /dev/kfd. As a result devices cannot be controlled individually using device cgroup. AMD compute devices will rely on its graphics counterpart that exposes /dev/dri/renderN node for each device. For each

[PATCH v2 4/4] drm/amdkfd: Check against device cgroup

2019-09-16 Thread Kasiviswanathan, Harish
Participate in device cgroup. All kfd devices are exposed via /dev/kfd. So use /dev/dri/renderN node. Before exposing the device to a task check if it has permission to access it. If the task (based on its cgroup) can access /dev/dri/renderN then expose the device via kfd node. If the task

[PATCH v2 1/4] drm/amdkfd: Store kfd_dev in iolink and cache properties

2019-09-16 Thread Kasiviswanathan, Harish
This is required to check against cgroup permissions. Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 ++ drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 3 +++ 2 files changed, 13 insertions(+) diff --git

AMDKFD (AMD GPU compute) support for device cgroup.

2019-09-16 Thread Kasiviswanathan, Harish
Hi Tejun, Sorry. Resending these patches as I got distracted with other stuff and couldn't follow through. As per our previous discussion the plan was to upstream these changes (mainly patch 3 "Export devcgroup_check_permission") through Alex Deucher's amd-staging-drm-next and Dave Airlie's

Re: [PATCH] drm/amdkfd: Delete unused KFD_IS_* macro

2019-09-16 Thread Kuehling, Felix
On 2019-09-16 12:33 p.m., Zhao, Yong wrote: > These were deleted before, but somehow showed up again. Delete them again. > > Change-Id: I19b3063932380cb74a01d505e8e92f897a2c2cb7 > Signed-off-by: Yong Zhao Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 4 >

Re: [PATCH] drm/amd/display: Fix compile error due to 'endif' missing

2019-09-16 Thread Masahiro Yamada
(+CC Stephen Rothwell, Mark Brown) On Mon, Sep 16, 2019 at 1:46 PM Austin Kim wrote: > > gcc throws compile error with below message: GNU Make throws ... This is probably a merge mistake in linux-next. If so, this should be directly fixed in the linux-next. If it is not fixed in time,

Re: [PATCH] drm/amdkfd: Delete unused KFD_IS_DGPU macro

2019-09-16 Thread Kuehling, Felix
On 2019-09-16 12:26 p.m., wrote: > This was deleted before, but somehow showed up again. Delete it again. > > Change-Id: I19b3063932380cb74a01d505e8e92f897a2c2cb7 > Signed-off-by: Yong Zhao > --- > drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [PATCH] drm/amdkfd: Delete unused KFD_IS_* macro

2019-09-16 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Zhao, Yong Sent: Monday, September 16, 2019 12:33 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH] drm/amdkfd: Delete unused KFD_IS_* macro These were deleted before, but somehow showed up

[PATCH] drm/amdkfd: Delete unused KFD_IS_* macro

2019-09-16 Thread Zhao, Yong
These were deleted before, but somehow showed up again. Delete them again. Change-Id: I19b3063932380cb74a01d505e8e92f897a2c2cb7 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h

[PATCH] drm/amdkfd: Delete unused KFD_IS_DGPU macro

2019-09-16 Thread Zhao, Yong
This was deleted before, but somehow showed up again. Delete it again. Change-Id: I19b3063932380cb74a01d505e8e92f897a2c2cb7 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h

[GIT PULL] Please pull hmm related changes

2019-09-16 Thread Jason Gunthorpe
Hi Linus, Continuing on the cleanup theme from last merge window, here is another set of hmm and closely related patches that are largely cleanups and bug fixes without any particularly notable functional change. The diffstat below covers a wide section of the kernel, but a lot of this is caused

[PATCH] drm/amd/display: build failed for DCN2.1

2019-09-16 Thread Xinpeng Liu
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/Makefile:70: *** missing `endif'. Stop. make[4]: *** [drivers/gpu/drm/amd/amdgpu] Error 2 Signed-off-by: Xinpeng Liu --- drivers/gpu/drm/amd/display/dc/dml/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git

RE: [PATCH] drm/amdgpu: cleanup creating BOs at fixed location

2019-09-16 Thread Chen, Guchun
Reviewed-by: Guchun Chen -Original Message- From: Christian König Sent: Friday, September 13, 2019 8:08 PM To: Grodzovsky, Andrey ; Zhou1, Tao ; Chen, Guchun ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: cleanup creating BOs at fixed location The placement is

Re: [PATCH] drm/amdgpu: fix ras ctrl debugfs node leak

2019-09-16 Thread Christian König
Am 16.09.19 um 07:47 schrieb Chen, Guchun: Use debugfs_remove_recursive to remove the whole debugfs directory instead of removing the node one by one. Change-Id: I27e9edab20d568b16d0163f8c7c3d81fb6832acd Signed-off-by: Guchun Chen Reviewed-by: Christian König ---

[PATCH] docs: drm/amdgpu: Resolve build warnings

2019-09-16 Thread Adam Zerella
Some of the documentation formatting could be improved which will resolve some Sphinx amdgpu build warnings e.g WARNING: Unexpected indentation. WARNING: Block quote ends without a blank line; unexpected unindent. WARNING: Inline emphasis start-string without end-string. Signed-off-by: Adam

RE: [PATCH] drm/amdgpu: Fix EEPROM checksum calculation.

2019-09-16 Thread Chen, Guchun
Perhaps you need to remove the period from commit title. With that fixed, this patch is: Reviewed-by: Guchun Chen -Original Message- From: Andrey Grodzovsky Sent: Saturday, September 14, 2019 12:09 AM To: amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhou1, Tao ; Grodzovsky,