Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Nick Desaulniers
On Wed, Oct 2, 2019 at 2:24 PM Alex Deucher wrote: > > On Wed, Oct 2, 2019 at 5:19 PM Nick Desaulniers > wrote: > > > > Alex, do you know why the AMDGPU driver uses a different stack > > alignment (16B) than the rest of the x86 kernel? (see > > arch/x86/Makefile which uses 8B stack alignment).

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 5:19 PM Nick Desaulniers wrote: > > On Wed, Oct 2, 2019 at 5:03 AM Arnd Bergmann wrote: > > > > Just like all the other variants, this one passes invalid > > compile-time options with clang after the new code got > > merged: > > > > clang: error: unknown argument:

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Nick Desaulniers
On Wed, Oct 2, 2019 at 5:03 AM Arnd Bergmann wrote: > > Just like all the other variants, this one passes invalid > compile-time options with clang after the new code got > merged: > > clang: error: unknown argument: '-mpreferred-stack-boundary=4' > scripts/Makefile.build:265: recipe for target

Re: [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-02 Thread Nick Desaulniers
On Wed, Oct 2, 2019 at 10:07 AM Nathan Chancellor wrote: > > On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built > Linux wrote: > > > Apparently this bug is still present in both the released clang-9 > > > and the current development version of clang-10. > > > I was

[pull] amdgpu drm-fixes-5.4

2019-10-02 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.4. Nothing too major. Enabling bulk moves is not exactly a bug fix, but it's been working well for a while and it improves performance and reduces latency in command submission. If you have concerns, I can respin without it. The following changes since commit

Re: [PATCH 0/6] amdgpu build fixes

2019-10-02 Thread Arnd Bergmann
On Wed, Oct 2, 2019 at 8:47 PM Alex Deucher wrote: > > On Wed, Oct 2, 2019 at 8:02 AM Arnd Bergmann wrote: > > > > Here are a couple of build fixes from my backlog in the randconfig > > tree. It would be good to get them all into linux-5.4. > > > > Arnd > > > > Arnd Bergmann (6): > >

Re: [PATCH 0/6] amdgpu build fixes

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 8:02 AM Arnd Bergmann wrote: > > Here are a couple of build fixes from my backlog in the randconfig > tree. It would be good to get them all into linux-5.4. > > Arnd > > Arnd Bergmann (6): > drm/amdgpu: make pmu support optional, again > drm/amdgpu: hide another

[PATCH 19/38] drm/amd/display: fix bug with check for HPD Low in verify link cap

2019-10-02 Thread Bhawanpreet Lakha
From: Sivapiriyan Kumarasamy [Why] There is a bug when determining if link training should be retried when HPD is low in dp_verify_link_cap_with_retries. [How] Correctly, fail dp_verify_link_cap_with_retries without retry when HPD is low. Change-Id: I6fbf64c28f0aac96252a508715a806927fb86d63

[PATCH 20/38] drm/amd/display: Use dcn1 Optimal Taps Get

2019-10-02 Thread Bhawanpreet Lakha
From: Wesley Chalmers [WHY] dpp2_get_optimal_number_of_taps is incorrect, and dcn2 should be using dpp1_get_optimal_number_of_taps instead Change-Id: I421c9b8d9dc244d37f2bd9f99027ce2cca2b8817 Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Bhawanpreet Lakha ---

[PATCH 34/38] drm/amd/display: Fix dongle_caps containing stale information.

2019-10-02 Thread Bhawanpreet Lakha
From: David Galiffi [WHY] During detection: function: get_active_converter_info populates link->dpcd_caps.dongle_caps only when dpcd_rev >= DPCD_REV_11 and DWN_STRM_PORTX_TYPE is DOWN_STREAM_DETAILED_HDMI or DOWN_STREAM_DETAILED_DP_PLUS_PLUS. Otherwise, it is not cleared, and stale information

[PATCH 36/38] drm/amd/display: Skip DIG Check if Link is Virtual for Display Count

2019-10-02 Thread Bhawanpreet Lakha
From: Sung Lee [WHY] Without a check for virtual links, every link's DIG was getting checked for enabled or disabled. If link was virtual, since it did not have a DIG, this would cause issues. [HOW] Skip DIG Enable check if link is virtual and add virtual link to to display count. Change-Id:

[PATCH 30/38] drm/amd/display: use vbios message to call smu for dpm level

2019-10-02 Thread Bhawanpreet Lakha
From: Charlene Liu [Description] use vbios message to call smu for dpm level also only program dmdata in vsyncflip as HW requirement. Change-Id: Iaad00db1a5f8e203b708d2605ff16e8b3b323b2b Signed-off-by: Charlene Liu Reviewed-by: Dmytro Laktyushkin Acked-by: Bhawanpreet Lakha ---

[PATCH 29/38] drm/amd/display: Fix maybe-uninitialized warning

2019-10-02 Thread Bhawanpreet Lakha
From: Leo Li [Why] Compiling with GCC 9.1.0 gives the following warning (I have warnings-as-errors enabled): drivers/gpu/drm/amd/amdgpu/../dal-dev/dc/core/dc.c: In function 'dc_validate_seamless_boot_timing': drivers/gpu/drm/amd/amdgpu/../dal-dev/dc/core/dc.c:1180:8: error: 'se' may be used

[PATCH 32/38] drm/amd/display: 3.2.54

2019-10-02 Thread Bhawanpreet Lakha
From: Aric Cyr Change-Id: I8ccb02411c552f679cb08ace8652f5c9d4fe3b4f Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h

[PATCH 21/38] drm/amd/display: 3.2.53

2019-10-02 Thread Bhawanpreet Lakha
From: Aric Cyr Change-Id: I1985922707a40f9ce5f6c01385bded36058206f2 Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h

[PATCH 08/38] drm/amd/display: fix hotplug during display off

2019-10-02 Thread Bhawanpreet Lakha
From: Joseph Gravenor [why] HPD is not suppressed when we lower clocks on renoir. B/c of this we do link training when the 48mhz refclk is off, which will cause ASIC hang. [how] Exit optimized power state for detection purpose. Change-Id: I6010a25cf5b5990a137136462d3a7bc3af367439

[PATCH 33/38] drm/amd/display: Add capability check for static ramp calc

2019-10-02 Thread Bhawanpreet Lakha
From: Jaehyun Chung [Why] Static ramp to max refresh rate does not have capability check on calculated v_total. Programming a lower v_total_min and max than the total causes continuous spurious HPDs. [How] Add a capability check after v_total calculation similar to calculate v_total helper

[PATCH 24/38] drm/amd/display: fix code to control 48mhz refclk

2019-10-02 Thread Bhawanpreet Lakha
From: Eric Yang [Why] The SMU message to enable this feature looks at argument. Previous code didn't send right argument. This change will allow the feature to be be enabled. [How] Fixed one issue where SMU message to enable the feature was sent without setting the parameter. Change-Id:

[PATCH 14/38] drm/amd/display: check phy dpalt lane count config

2019-10-02 Thread Bhawanpreet Lakha
From: Lewis Huang [Why] Type-c PHY config is not align with dpcd lane count. When those values didn't match, it cause driver do link training with 4 lane but phy only can output 2 lane. The link trainig always fail. [How] 1. Modify get_max_link_cap function. According DPALT_DP4 to update max

[PATCH 12/38] drm/amd/display: 3.2.52

2019-10-02 Thread Bhawanpreet Lakha
From: Anthony Koo Change-Id: I98f27f86f683ed714241496f82254cb39023d8c7 Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 04/38] drm/amd/display: Add Logging for Gamma Related information

2019-10-02 Thread Bhawanpreet Lakha
From: Wyatt Wood [Why] A recent bug showed that logging would be useful in debugging various gamma issues. [How] Fix formatting for easier graphing. Prevent performance hit when doing diag. Change-Id: I4f2a3afeecc4a5018096f54a23ff4f0ea04e Signed-off-by: Wyatt Wood Reviewed-by: Aric Cyr

[PATCH 25/38] drm/amd/display: add guard for SMU ver, for 48mhz clk

2019-10-02 Thread Bhawanpreet Lakha
From: Joseph Gravenor [why] dp_48m_refclk_driver_pwdn is persistent through S3 and S5. This was worked arround in SMU FW 55.21.0. Earlier FW don't have this fix so we will hang on reboot [how] add a guard for smu versions before SMU FW 55.21.0 Change-Id:

[PATCH 26/38] drm/amd/display: Update number of dcn21 audio endpoints

2019-10-02 Thread Bhawanpreet Lakha
From: Michael Strauss [WHY] Number of audio endpoints wasn't updated from dcn20's 6 when created [HOW] Changed num_audio to 4 to match the correct sbios value Change-Id: I2b79ef72762d6b4e5ff491c1ddf58847f96c973b Signed-off-by: Michael Strauss Reviewed-by: Yongqiang Sun Acked-by: Bhawanpreet

[PATCH 16/38] drm/amd/display: Properly round nominal frequency for SPD

2019-10-02 Thread Bhawanpreet Lakha
From: Aric Cyr [Why] Some displays rely on the SPD verticle frequency maximum value. Must round the calculated refresh rate to the nearest integer. [How] Round the nominal calculated refresh rate to the nearest whole integer. Change-Id: I4347428f35a899fad028a9ee1b02ea3c84231f22 Signed-off-by:

[PATCH 37/38] drm/amd/display: hook up notify watermark ranges and get clock table

2019-10-02 Thread Bhawanpreet Lakha
From: Eric Yang [Why] Previously SMU was giving us 0s for the clock table. Now they have valid clock table. We should use theirs. Also, need to send SMU watermark ranges for selecting optimal watermarks. Change-Id: I59cefd343ddb7ebf00164854c6b43407e7c07c4e Signed-off-by: Eric Yang ---

[PATCH 28/38] drm/amd/display: add more checks to validate seamless boot timing

2019-10-02 Thread Bhawanpreet Lakha
From: Martin Leung [why] we found using an active DP to HDMI panel that we weren't validating dp_pixel_format and hardware timing v_front_porch, causing screen to blank and/or corrupt while attempting a seamless boot. [how] added checks during dc_validate_seamless_boot_timing for these values

[PATCH 38/38] drm/amd/display: add renoir specific watermark range and clk helper

2019-10-02 Thread Bhawanpreet Lakha
From: Dmytro Laktyushkin Doing this allows us to split it for diffrent asics. This design will be helpful for future Asciis. Change-Id: I7f06c1ad9aa5ca30abf6953fc172edee75402862 Signed-off-by: Dmytro Laktyushkin --- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 23 +++

[PATCH 27/38] drm/amd/display: add new active dongle to existent w/a

2019-10-02 Thread Bhawanpreet Lakha
From: Vitaly Prosyak [Why & How] Dongle 0x00E04C power down all internal circuits including AUX communication preventing reading DPCD table. Encoder will skip DP RX power down on disable output to keep receiver powered all the time. Change-Id: I7401a88be1dc15fd45ab1b4964b79ba3184e7610

[PATCH 15/38] drm/amd/display: Restore should_update_pstate_support after bad revert

2019-10-02 Thread Bhawanpreet Lakha
From: Joshua Aberback [Why] This function was mistakenly reverted as part of a legitimate revert. The old version that was reverted to has bad logic, and is causing situations where p-state change support is being toggled when it shouldn't be, resulting in hangs. Change-Id:

[PATCH 31/38] drm/amd/display: make aux defer delay and aux sw start delay seperate

2019-10-02 Thread Bhawanpreet Lakha
From: Xiaodong Yan [why] 1. defer delay and sw start delay has been mixed up, defer delay was programmed to AUX_SW_CONTROL:AUX_SW_START_DELAY. 2. There's no delay for defer [how] 1. Set aux sw start to 0 2. Add delay for defer scenario Change-Id: Ibc470b99980e474604fe884758b5bf049325eab0

[PATCH 22/38] drm/amd/display: Program DWB watermarks from correct state

2019-10-02 Thread Bhawanpreet Lakha
From: Julian Parkin [Why] When diags adds a DWB via a stream update, we calculate MMHUBBUB paramaters, but dc->current_state has not yet been updated when the DWB programming happens. This leads to overflow on high bandwidth tests since the incorrect MMHUBBUB arbitration parameters are

[PATCH 10/38] drm/amd/display: add explicit comparator as default optimization check

2019-10-02 Thread Bhawanpreet Lakha
From: Jun Lei [why] memcmp is vulnerable to regression due to dc_clocks structures not being organized properly (not "current" clock related structures being at the beginning of the structure) and causes unnecessary setting of the optimize bit [how] add a dcn sepcific comparator, implement for

[PATCH 17/38] drm/amd/display: Add output bitrate to DML calculations

2019-10-02 Thread Bhawanpreet Lakha
From: Nikola Cornij [why] Output bitrate was mistakenly left out, causing corruption on some DSC low resolution (such as 800x600) modes. Change-Id: I47962603773d106a810a0b1b829dbd4168a53e47 Signed-off-by: Nikola Cornij Reviewed-by: Dmytro Laktyushkin Acked-by: Bhawanpreet Lakha ---

[PATCH 23/38] drm/amd/display: exit PSR during detection

2019-10-02 Thread Bhawanpreet Lakha
From: Eric Yang [Why] If 48mhz refclk is turned off during PSR, we will have issue doing link training during detection. [How] Get out of PSR before detection Change-Id: Ibe8c0a8caf787e1338c0cdbc4b9938f862290895 Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Bhawanpreet Lakha

[PATCH 35/38] drm/amd/display: correct stream LTE_340MCSC_SCRAMBLE value

2019-10-02 Thread Bhawanpreet Lakha
From: Wayne Lin [Why] HDMI 2.0 requires scrambling under specific conditions. We refer to stream property LTE_340MCSC_SCRAMBLE to determine whether en/dis scrambling. While creating stream for sink, we setup LTE_340MCSC_SCRAMBLE by referring to edid_caps. However, dm_helpers_parse_edid_caps()

[PATCH 18/38] drm/amd/display: wait for set pipe mcp command completion

2019-10-02 Thread Bhawanpreet Lakha
From: Josip Pavic [Why] When the driver sends a pipe set command to the DMCU FW, it does not wait for the command to complete. This can lead to unpredictable behavior if, for example, the driver were to request a pipe disable to the FW via MCP, then power down some hardware before the firmware

[PATCH 06/38] drm/amd/display: Reprogram FMT on pipe change

2019-10-02 Thread Bhawanpreet Lakha
From: Julian Parkin [Why] When planes are added or removed from a stream, the change in pipe usage from dynamic MPC combine can cause a second stream using ODM combine to pick a different pipe to combine with. In this scenario, a different OPP is connected to the ODM without programming its

[PATCH 09/38] drm/amd/display: add support for VSIP info packet

2019-10-02 Thread Bhawanpreet Lakha
From: Wayne Lin [Why] The vendor specific infoframe is needed for HDMI while displaying specific modes. DC supports sending it, but we aren't currently building it [How] Add mod_build_hf_vsif_infopacket() to build the vendor specific info packet. Change-Id:

[PATCH 11/38] drm/amd/display: Add missing shifts and masks for dpp registers on dcn2

2019-10-02 Thread Bhawanpreet Lakha
From: Joshua Aberback [Why] The register CM_TEST_DEBUG_DATA is used in dpp1_program_input_csc, which is called from dpp2_cnv_setup, but the shifts and masks for the fields of that register are not initialized for dcn2. This causes all reads of that register to return 0. Change-Id:

[PATCH 02/38] drm/amd/display: Correct values in AVI infoframe

2019-10-02 Thread Bhawanpreet Lakha
From: Wayne Lin [Why] While displaying 4k modes defined in HDMI1.4b, should set VIC to 0 and use VSP HDMI_VIC to indicate the mode. [How] Use functions defined in drm to set up the VIC correspondingly. Change-Id: Ib85ce7bacd6d7f26b765dd970ec8c024fe630a21 Signed-off-by: Wayne Lin Reviewed-by:

[PATCH 13/38] drm/amd/display: build up VSIF infopacket

2019-10-02 Thread Bhawanpreet Lakha
From: Wayne Lin [Why] Didn't send VSIF infopacket when it's 4k mode defined in HDMI 1.4b. For HDMI 1.4b, While displaying 4k modes, it should send VSP. [How] Call mod_build_hf_vsif_infopacket() function to build info frame and send it. Change-Id: I1fb7d6d74970b4a50b57346698662cbc8b19d0e4

[PATCH 00/38] DC Patches 02 Oct 2019

2019-10-02 Thread Bhawanpreet Lakha
Summary Of Changes *fix compile warnings *dcn21 fixes (audio, clk_mgr) *DML output calculations update Anthony Koo (1): drm/amd/display: 3.2.52 Aric Cyr (4): drm/amd/display: Update V_UPDATE whenever VSTARTUP changes drm/amd/display: Properly round nominal frequency for SPD

[PATCH 01/38] drm/amd/display: Added pixel dynamic expansion control.

2019-10-02 Thread Bhawanpreet Lakha
From: Robin Singh [Why] To compare the crc of the framebuffer data at input of display pipeline with the crc of the otg, we need to disable pixel formatter's dynamic expansion feature during crc capture and keep it enable in the normal operation. [HOW] Expose a new interface in DM and dc for

[PATCH 05/38] drm/amd/display: Update V_UPDATE whenever VSTARTUP changes

2019-10-02 Thread Bhawanpreet Lakha
From: Aric Cyr [Why] If VSTARTUP changes due to bandwidth requirements, we must recalculate and update VLINE2 as well for proper flip reporting. [How] After all calls to program_global_sync which reconfigures VSTARTUP, also make sure to update V_UPDATE (i.e. VLINE2 on DCNx). Change-Id:

[PATCH 03/38] drm/amd/display: skip enable stream on disconnected display

2019-10-02 Thread Bhawanpreet Lakha
From: Wenjing Liu [why] Virtual signal means there is no display attached. In this case we will assign a virtual signal type to the stream. We should only enable the front end of the stream but not the back end. [how] When stream is enabling with virtual signal type, skip backend programming.

[PATCH 07/38] drm/amd/display: fix pipe re-assignment when odm present

2019-10-02 Thread Bhawanpreet Lakha
From: Dmytro Laktyushkin Currently pipe split may steal an existing ODM pipe depending on stream sequence. This change prevents that from happening as easily. Change-Id: I2e604894aaef2c782284fcc12d4e9a7381cf6eab Signed-off-by: Dmytro Laktyushkin Reviewed-by: Gary Kattan Acked-by: Bhawanpreet

RE: [PATCH 2/2] drm/radeon: finally fix the racy VMA setup

2019-10-02 Thread Huang, Ray
Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Friday, September 27, 2019 8:34 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: [PATCH 2/2] drm/radeon: finally fix the racy VMA setup Finally clean up the VMA

RE: [PATCH] drm/amdgpu: don't increment vram lost if we are in hibernation

2019-10-02 Thread Huang, Ray
Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, October 1, 2019 5:48 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: don't increment vram lost if we are in hibernation We reset the GPU as part of

RE: [PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault

2019-10-02 Thread Huang, Ray
Ahh.  Reviewed-by: Huang Rui -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, October 2, 2019 4:38 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault Just a gentle ping on

Re: [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-02 Thread Nathan Chancellor
On Wed, Oct 02, 2019 at 09:51:37AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote: > > Apparently this bug is still present in both the released clang-9 > > and the current development version of clang-10. > > I was hoping we would not need a workaround in clang-9+, but > > it seems that

Re: [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-02 Thread Nick Desaulniers
> Apparently this bug is still present in both the released clang-9 > and the current development version of clang-10. > I was hoping we would not need a workaround in clang-9+, but > it seems that we do. I think I'd rather: 1. mark AMDGPU BROKEN if CC_IS_CLANG. There are numerous other issues

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 11:39 AM Arnd Bergmann wrote: > > On Wed, Oct 2, 2019 at 5:12 PM Alex Deucher wrote: > > On Wed, Oct 2, 2019 at 10:51 AM Arnd Bergmann wrote: > > > > > > > Nothing should really change with regards to the -msse flag here, only > > > the stack alignment flag changed. Maybe

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Arnd Bergmann
On Wed, Oct 2, 2019 at 5:12 PM Alex Deucher wrote: > On Wed, Oct 2, 2019 at 10:51 AM Arnd Bergmann wrote: > > > > Nothing should really change with regards to the -msse flag here, only > > the stack alignment flag changed. Maybe there was some other change > > in your Makefile that conflicts

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 10:51 AM Arnd Bergmann wrote: > > On Wed, Oct 2, 2019 at 4:17 PM Alex Deucher wrote: > > > > I'm getting an error with gcc with this patch: > > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o > >

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Arnd Bergmann
On Wed, Oct 2, 2019 at 4:17 PM Alex Deucher wrote: > > I'm getting an error with gcc with this patch: > CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In > function ‘calculate_wm_set_for_vlevel’: >

Re: [PATCH v2 0/9] drm/print: add and use drm_debug_enabled()

2019-10-02 Thread Jani Nikula
On Tue, 24 Sep 2019, Jani Nikula wrote: > drm/print: move drm_debug variable to drm_print.[ch] > drm/print: add drm_debug_enabled() > drm/etnaviv: use drm_debug_enabled() to check for debug categories > drm/i2c/sil164: use drm_debug_enabled() to check for debug categories > drm/msm: use

Re: [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 8:03 AM Arnd Bergmann wrote: > > Just like all the other variants, this one passes invalid > compile-time options with clang after the new code got > merged: > > clang: error: unknown argument: '-mpreferred-stack-boundary=4' > scripts/Makefile.build:265: recipe for target

RE: [bug report] drm/amd/display: Fix exception from AUX acquire failure

2019-10-02 Thread Koo, Anthony
Hi Dan, Thanks for the heads! I will work on a patch to address this issue. Regards, Anthony -Original Message- From: Dan Carpenter Sent: Wednesday, October 2, 2019 7:58 AM To: Koo, Anthony Cc: amd-gfx@lists.freedesktop.org Subject: [bug report] drm/amd/display: Fix exception from

Re: [PATCH] drm/amd/display: memory leak

2019-10-02 Thread Alex Deucher
On Tue, Oct 1, 2019 at 5:00 PM Navid Emamdoost wrote: > > Would you please review this patch? > Applied. thanks! Alex > > Thanks, > Navid. > > On Mon, Sep 16, 2019 at 10:21 PM Navid Emamdoost > wrote: > > > > In dcn*_clock_source_create when dcn20_clk_src_construct fails allocated > >

Re: [PATCH 1/2] drm/amdgpu/vcn: use amdgpu_ring_test_helper instead of

2019-10-02 Thread Gustavo A. R. Silva
On 10/1/19 17:17, Liu, Leo wrote: > amdgpu_ring_test_ring, so it will determine whether the ring is ready > > Signed-off-by: Leo Liu > Cc: Gustavo A. R. Silva Acked-by: Gustavo A. R. Silva > --- > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 - > drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 21

Re: [PATCH] drm/amdgpu: remove set but not used variable 'pipe'

2019-10-02 Thread Alex Deucher
On Mon, Sep 30, 2019 at 3:03 AM yu kuai wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > rivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function > ‘amdgpu_gfx_graphics_queue_acquire’: > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:234:16: warning: > variable ‘pipe’ set but not used

Re: [PATCH] drm/amdgpu: Initialize variable before use

2019-10-02 Thread Alex Deucher
On Mon, Sep 30, 2019 at 4:09 PM Siqueira, Rodrigo wrote: > > The 'debug_data' variable gets printed in debug statements without a > prior initialization in the function > hubbub1_verify_allow_pstate_change_high, as reported when building with > gcc 9.1.0: > > warning: ‘debug_data’ may be used

Re: [PATCH] drm/amdgpu: Drop unused variable and statement

2019-10-02 Thread Alex Deucher
On Wed, Oct 2, 2019 at 3:19 AM Austin Kim wrote: > > Even though 'smu8_smu' is declared, it is not used after below statement. > >smu8_smu = hwmgr->smu_backend; > > So 'unused variable' could be safely removed > to stop warning message as below: > >

Re: [PATCH] drm/amdgpu: fix structurally dead code vcn_v2_5_hw_init

2019-10-02 Thread Gustavo A. R. Silva
On 10/1/19 17:21, Liu, Leo wrote: OK. So, maybe we can add a comment pointing that out? >>> That could be better. >>> >> Great. I'm glad it's not a bug. I'll write a patch for that so other >> people don't waste time taking a look. > > Thanks, just sent two patches to add comment, and

Re: [PATCH 1/2] drm/amdgpu/vcn: use amdgpu_ring_test_helper instead of

2019-10-02 Thread James Zhu
Reviewed-by: James Zhu for this series On 2019-10-01 6:17 p.m., Liu, Leo wrote: > amdgpu_ring_test_ring, so it will determine whether the ring is ready > > Signed-off-by: Leo Liu > Cc: Gustavo A. R. Silva > --- > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 - >

[PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576

2019-10-02 Thread Arnd Bergmann
Code in the amdgpu driver triggers a bug when using clang to build an arm64 kernel: /tmp/sdma_v4_0-f95fd3.s: Assembler messages: /tmp/sdma_v4_0-f95fd3.s:44: Error: selected processor does not support `bfc w0,#1,#5' I expect this to be fixed in llvm soon, but we can also work around it by

[PATCH 1/6] drm/amdgpu: make pmu support optional, again

2019-10-02 Thread Arnd Bergmann
When CONFIG_PERF_EVENTS is disabled, we cannot compile the pmu portion of the amdgpu driver: drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c:48:38: error: no member named 'hw' in 'struct perf_event' struct hw_perf_event *hwc = >hw; ~ ^

[PATCH 2/6] drm/amdgpu: hide another #warning

2019-10-02 Thread Arnd Bergmann
An earlier patch of mine disabled some #warning statements that get in the way of build testing, but then another instance was added around the same time. Remove that as well. Fixes: b5203d16aef4 ("drm/amd/amdgpu: hide #warning for missing DC config") Fixes: e1c14c43395c ("drm/amdgpu: Enable DC

[PATCH 3/6] drm/amdgpu: display_mode_vba_21: remove uint typedef

2019-10-02 Thread Arnd Bergmann
The type definition for 'uint' clashes with the generic kernel headers: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:43:22: error: redefinition of typedef 'uint' is a C11 feature [-Werror,-Wtypedef-redefinition] include/linux/types.h:92:23: note: previous definition

[PATCH 5/6] [RESEND] drm/amd/display: hide an unused variable

2019-10-02 Thread Arnd Bergmann
Without CONFIG_DEBUG_FS, we get a warning for an unused variable: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6020:33: error: unused variable 'source' [-Werror,-Wunused-variable] Hide the variable in an #ifdef like its only users. Fixes: 14b2584636c6 ("drm/amd/display: add

[PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang

2019-10-02 Thread Arnd Bergmann
Just like all the other variants, this one passes invalid compile-time options with clang after the new code got merged: clang: error: unknown argument: '-mpreferred-stack-boundary=4' scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.o'

[PATCH 0/6] amdgpu build fixes

2019-10-02 Thread Arnd Bergmann
Here are a couple of build fixes from my backlog in the randconfig tree. It would be good to get them all into linux-5.4. Arnd Arnd Bergmann (6): drm/amdgpu: make pmu support optional, again drm/amdgpu: hide another #warning drm/amdgpu: display_mode_vba_21: remove uint typedef

[bug report] drm/amd/display: Fix exception from AUX acquire failure

2019-10-02 Thread Dan Carpenter
Hello Anthony Koo, The patch dcf1a988678e: "drm/amd/display: Fix exception from AUX acquire failure" from Feb 6, 2019, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:108 dm_dp_aux_transfer() error:

Re: [PATCH] drm/drm_edid: correct VIC and HDMI_VIC under HDMI 2.0

2019-10-02 Thread Ville Syrjälä
On Tue, Sep 24, 2019 at 01:26:21PM +0800, Wayne Lin wrote: > In HDMI 1.4 defines 4k modes without specific aspect ratio. > However, in HDMI 2.0, adds aspect ratio attribute to distinguish different > 4k modes. > > According to Appendix E of HDMI 2.0 spec, source should use VSIF to > indicate VIC

Re: [PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault

2019-10-02 Thread Christian König
Just a gentle ping on this. Everybody on XDC, or can we get this comitted? Am 27.09.19 um 14:34 schrieb Christian König: That is needed by at least a cleanup in radeon. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 ++- include/drm/ttm/ttm_bo_api.h| 2 ++ 2

Re: [Follow-up] Status of AMD Sensor Fusion HUB for Linux

2019-10-02 Thread Luya Tshimbalanga
On 2019-09-26 10:03 a.m., Alex Deucher wrote: On Thu, Sep 26, 2019 at 3:59 AM Luya Tshimbalanga wrote: Hello, What is the current status of the driver or module for AMD Sensor Fusion HUB for mobile Raven Ridge family? To this day, majority of mobile powered device equipped with that APU

Re: [PATCH] drm/amdgpu: don't increment vram lost if we are in hibernation

2019-10-02 Thread Christian König
Am 01.10.19 um 23:48 schrieb Alex Deucher: We reset the GPU as part of our hibernation sequence so we need to make sure we don't mark vram as lost in that case. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=111879 Signed-off-by: Alex Deucher Acked-by: Christian König ---

Re: [PATCH v4] drm/amdgpu: fix multiple memory leaks in acp_hw_init

2019-10-02 Thread Koenig, Christian
Am 02.10.19 um 05:46 schrieb Navid Emamdoost: > In acp_hw_init there are some allocations that needs to be released in > case of failure: > > 1- adev->acp.acp_genpd should be released if any allocation attemp for > adev->acp.acp_cell, adev->acp.acp_res or i2s_pdata fails. > 2- all of those