On Fri, Oct 4, 2019 at 7:29 PM Tuikov, Luben wrote:
>
> On 2019-10-04 3:16 a.m., Christian König wrote:
> > Am 04.10.19 um 01:39 schrieb Tuikov, Luben:
> >> Use the ALIGN() macro to set "num_dw" to a
> >> multiple of 8, i.e. lower 3 bits cleared.
> >>
> >> Signed-off-by: Luben Tuikov
> >
> >
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c: In function
dce110_enable_audio_stream:
drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:949:23: warning:
variable pp_smu set but not used [-Wunused-but-set-variable]
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dwb_scl.c: In function
dwb_program_horz_scalar:
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dwb_scl.c:725:11: warning: variable
h_ratio_chroma set but not used [-Wunused-but-set-variable]
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c: In function
dpp2_get_optimal_number_of_taps:
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c:359:11: warning: variable
pixel_width set but not used [-Wunused-but-set-variable]
It is not used since
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c: In function calc_rc_params:
drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c:180:6: warning: variable
source_bpp set but not used [-Wunused-but-set-variable]
It is not used since commit 97bda0322b8a
Fix sparse warnings:
drivers/gpu/drm/amd/display/dc/core/dc_link.c:687:6: warning: symbol
'wait_for_alt_mode' was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: zhengbin
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +-
1 file changed, 1 insertion(+), 1
zhengbin (5):
drm/amd/display: Make function wait_for_alt_mode static
drm/amd/display: Remove set but not used variable 'source_bpp'
drm/amd/display: Remove set but not used variables
'h_ratio_chroma','v_ratio_chroma'
drm/amd/display: Remove set but not used variable 'pixel_width'
On 2019-10-04 3:16 a.m., Christian König wrote:
> Am 04.10.19 um 01:39 schrieb Tuikov, Luben:
>> Use the ALIGN() macro to set "num_dw" to a
>> multiple of 8, i.e. lower 3 bits cleared.
>>
>> Signed-off-by: Luben Tuikov
>
> Reviewed-by: Christian König
Hi Christian,
No ACK?
I've been running
Looks good to me.
Reviewed-by: Zhan Liu
-Original Message-
From: amd-gfx On Behalf Of
roman...@amd.com
Sent: 2019/October/04, Friday 3:45 PM
To: amd-gfx@lists.freedesktop.org
Cc: Berthe, Abdoulaye ; Liu, Zhan ;
Li, Roman ; Wentland, Harry ;
Deucher, Alexander ; Lakha, Bhawanpreet
On Fri, Oct 4, 2019 at 3:01 PM Messinger, Ori wrote:
>
> The vram vendor can be found as a separate sysfs file at:
> /sys/class/drm/card[X]/device/mem_info_vram_vendor
> The vram vendor is displayed as a string value.
>
> Change-Id: Iaa3ccf3f483ee6536281fe72ba241a6e0d43
> Signed-off-by: Ori
From: Roman Li
DC needs them to support configurable aux timeout on vega
Signed-off-by: Roman Li
---
drivers/gpu/drm/amd/include/asic_reg/dce/dce_12_0_sh_mask.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/include/asic_reg/dce/dce_12_0_sh_mask.h
The vram vendor can be found as a separate sysfs file at:
/sys/class/drm/card[X]/device/mem_info_vram_vendor
The vram vendor is displayed as a string value.
Change-Id: Iaa3ccf3f483ee6536281fe72ba241a6e0d43
Signed-off-by: Ori Messinger
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 63
Reviewed-by: Andrey Grodzovsky
Andrey
On 10/4/19 2:38 PM, Alex Deucher wrote:
> It's only used in amdgpu_device.c and the naming also
> reflects that. Move it there.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 +-
>
It's only used in amdgpu_device.c and the naming also
reflects that. Move it there.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 64 +
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 67
Martin wrote:
Dear AMD Developers,
I am building your amd-staging-drm-next kernels for more than 2 years now and
patch this up with the official kernel patches and ubuntu's sauce patches: [1]
One of the kernel users reports about hibernation problems since quite a while
and he gives detailed
On Fri, Oct 4, 2019 at 10:48 AM Zeng, Oak wrote:
>
> On device initialization, a trunk of GTT memory is pre-allocated for
typo: trunk -> chunk
Alex
> HIQ and all SDMA queues mqd. The size of this allocation was wrong.
> The correct sdma engine number should be PCIe-optimized SDMA engine
>
On Fri, Oct 4, 2019 at 11:08 AM Randy Dunlap wrote:
>
> On 10/3/19 10:59 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20191003:
> >
>
> on x86_64:
> CONFIG_DRM_AMDGPU=y
> # CONFIG_DRM_AMDGPU_SI is not set
> # CONFIG_DRM_AMDGPU_CIK is not set
> CONFIG_DRM_AMDGPU_USERPTR=y
>
On 2019-10-03 10:46 a.m., Nicholas Kazlauskas wrote:
> [Why]
> Many userspace assumes that the DRM plane index indicates the plane
> z-order, with a lower index being lower depth and a higher index being
> higher depth. This is currently what we assume in DM.
>
> DRM has a zpos plane property to
I'm pretty sure the gart_enable function is not the right place for
this. GART is for GPU access to system memory. HDP is for host access to
GPU memory. Also, I would expect anything done in gart_enable to be
undone in gart_disable. If that's not the intention, maybe this should
go in
Hi Philip,
Am 04.10.19 um 15:40 schrieb Yang, Philip:
> Thanks Joe for the test, I will add your Tested-by.
>
> Hi Christian,
>
> May you help review? The change removes the get user pages from
> gem_userptr_ioctl, this was done if flags AMDGPU_GEM_USERPTR_VALIDATE is
> set, and delay the get
Am 04.10.19 um 15:51 schrieb Nirmoy Das:
> cleanup error handling code and make sure temporary info array
> with the handles are freed by amdgpu_bo_list_put() on
> idr_replace()'s failure.
>
> Signed-off-by: Nirmoy Das
Reviewed-by: Christian König
> ---
>
Ping...
Regards,
Oak
-Original Message-
From: Zeng, Oak
Sent: Thursday, September 19, 2019 5:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Kuehling, Felix ; Koenig, Christian
; Zeng, Oak
Subject: [PATCH] drm/amdgpu: Enable gfx cache probing on HDP write for arcturus
This allows gfx
On 2019-10-04 10:48, Zeng, Oak wrote:
> Previously only PCIe-optimized SDMA engine hqds were
> exposed in debug fs. Print all SDMA engine hqds.
>
> Change-Id: I03756fc0fa99169d88e265560f505ed186242b02
> Reported-by: Jonathan Kim
> Signed-off-by: Jonathan Kim
> Signed-off-by: Oak Zeng
Minor
On 10/3/19 10:59 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20191003:
>
on x86_64:
CONFIG_DRM_AMDGPU=y
# CONFIG_DRM_AMDGPU_SI is not set
# CONFIG_DRM_AMDGPU_CIK is not set
CONFIG_DRM_AMDGPU_USERPTR=y
CONFIG_DRM_AMDGPU_GART_DEBUGFS=y
ld:
On 2019-10-04 10:48, Zeng, Oak wrote:
> On device initialization, a trunk of GTT memory is pre-allocated for
> HIQ and all SDMA queues mqd. The size of this allocation was wrong.
> The correct sdma engine number should be PCIe-optimized SDMA engine
> number plus xgmi SDMA engine number.
>
>
On device initialization, a trunk of GTT memory is pre-allocated for
HIQ and all SDMA queues mqd. The size of this allocation was wrong.
The correct sdma engine number should be PCIe-optimized SDMA engine
number plus xgmi SDMA engine number.
Change-Id: Iecd11ae4f5a314591566772aa2a23e1fe4b94275
Previously only PCIe-optimized SDMA engine hqds were
exposed in debug fs. Print all SDMA engine hqds.
Change-Id: I03756fc0fa99169d88e265560f505ed186242b02
Reported-by: Jonathan Kim
Signed-off-by: Jonathan Kim
Signed-off-by: Oak Zeng
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c |
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^/\t/' -i */Kconfig
Signed-off-by: Krzysztof Kozlowski
---
Changes since v1:
1. Fix also DRM_AMD_DC_HDCP (new arrival since v1).
---
drivers/gpu/drm/Kconfig
On Fri, Oct 04, 2019 at 10:41:20AM +, Lin, Wayne wrote:
>
>
>
> From: Ville Syrjälä
> Sent: Thursday, October 3, 2019 21:29
> To: Lin, Wayne
> Cc: dri-de...@lists.freedesktop.org ;
> amd-gfx@lists.freedesktop.org ; Li, Sun peng
> (Leo) ; Kazlauskas,
cleanup error handling code and make sure temporary info array
with the handles are freed by amdgpu_bo_list_put() on
idr_replace()'s failure.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff
Add proper ifdefs around CIK code in kfd setup.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index 0db273587af4..d898adf25fbb
Thanks Joe for the test, I will add your Tested-by.
Hi Christian,
May you help review? The change removes the get user pages from
gem_userptr_ioctl, this was done if flags AMDGPU_GEM_USERPTR_VALIDATE is
set, and delay the get user pages to amdgpu_cs_parser_bos, and check if
user pages are
On Fri, Oct 4, 2019 at 3:29 AM Koenig, Christian
wrote:
>
> Am 03.10.19 um 23:40 schrieb Colin King:
> > From: Colin Ian King
> >
> > There is a return statement that is not reachable and a variable that
> > is not used. Remove them.
> >
> > Addresses-Coverity: ("Structurally dead code")
> >
On Fri, Oct 4, 2019 at 3:28 AM Koenig, Christian
wrote:
>
> Am 03.10.19 um 23:52 schrieb Colin King:
> > From: Colin Ian King
> >
> > The boolean variable pasid_mapping_needed is not initialized and
> > there are code paths that do not assign it any value before it is
> > is read later. Fix
On Fri, Oct 4, 2019 at 8:25 AM zhengbin wrote:
>
> Fix sparse warnings:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:32:6:
> warning: symbol 'lp_write_i2c' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:42:6:
>
On Thu, Oct 3, 2019 at 4:35 PM Raul E Rangel wrote:
>
> dcn20_resource.c:2636:9: error: missing braces around initializer
> [-Werror=missing-braces]
> struct _vcs_dpi_voltage_scaling_st
> calculated_states[MAX_CLOCK_LIMIT_STATES] = {0};
> ^
>
> Fixes: 7ed4e6352c16f ("drm/amd/display:
Hi Michel,
Am 04.10.19 um 13:36 schrieb Michel Lespinasse:
On Fri, Oct 04, 2019 at 06:54:54AM +, Koenig, Christian wrote:
Am 03.10.19 um 22:18 schrieb Davidlohr Bueso:
The amdgpu_vm interval tree really wants [a, b) intervals,
NAK, we explicitly do need an [a, b[ interval here.
Hi
Fix sparse warnings:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:32:6: warning:
symbol 'lp_write_i2c' was not declared. Should it be static?
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_hdcp.c:42:6: warning:
symbol 'lp_read_i2c' was not declared. Should it be
On Fri, Oct 04, 2019 at 06:54:54AM +, Koenig, Christian wrote:
> Am 03.10.19 um 22:18 schrieb Davidlohr Bueso:
> > The amdgpu_vm interval tree really wants [a, b) intervals,
>
> NAK, we explicitly do need an [a, b[ interval here.
Hi Christian,
Just wanted to confirm where you stand on this
From: Ville Syrjälä
Sent: Thursday, October 3, 2019 21:29
To: Lin, Wayne
Cc: dri-de...@lists.freedesktop.org ;
amd-gfx@lists.freedesktop.org ; Li, Sun peng
(Leo) ; Kazlauskas, Nicholas
Subject: Re: [PATCH] drm/drm_edid: correct VIC and HDMI_VIC under HDMI
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Kuehling,
Felix
Sent: 2019年10月4日 6:01
To: amd-gfx@lists.freedesktop.org; Grodzovsky, Andrey
Cc: Cox, Philip
Subject: [PATCH 1/1] drm/amdgpu: Fix error handling in amdgpu_ras_recovery_init
Am 03.10.19 um 23:40 schrieb Colin King:
> From: Colin Ian King
>
> There is a return statement that is not reachable and a variable that
> is not used. Remove them.
>
> Addresses-Coverity: ("Structurally dead code")
> Fixes: de7b45babd9b ("drm/amdgpu: cleanup creating BOs at fixed location
>
Am 03.10.19 um 23:52 schrieb Colin King:
> From: Colin Ian King
>
> The boolean variable pasid_mapping_needed is not initialized and
> there are code paths that do not assign it any value before it is
> is read later. Fix this by initializing pasid_mapping_needed to
> false.
>
>
Am 04.10.19 um 01:39 schrieb Tuikov, Luben:
Use the ALIGN() macro to set "num_dw" to a
multiple of 8, i.e. lower 3 bits cleared.
Signed-off-by: Luben Tuikov
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 11 ++-
1 file changed, 2 insertions(+), 9
Am 03.10.19 um 22:18 schrieb Davidlohr Bueso:
> The amdgpu_vm interval tree really wants [a, b) intervals,
NAK, we explicitly do need an [a, b[ interval here.
Regards,
Christian.
> not fully closed ones. As such convert it to use the new
> interval_tree_gen.h, and also rename the 'last'
45 matches
Mail list logo
