Re: [PATCH] drm/amd/powerplay: skip unsupported clock limit settings on Arcturus V2

2019-10-23 Thread Alex Deucher
On Wed, Oct 23, 2019 at 4:53 AM Quan, Evan wrote: > > For Arcturus, clock limit settings on uclk/socclk/fclk domains > are not supported. > > V2: simplify the code to support both SGPU and MGPU cases > > Change-Id: I1286289e3770f0421f0d22989437e26d3f7b2ec4 > Signed-off-by: Evan Quan Acked-by:

[pull] amdgpu drm-fixes-5.4

2019-10-23 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.4 for amdgpu. The following changes since commit 5c1e34b5159ec65bf33e2c1a62fa7158132c10cf: Merge tag 'drm-misc-fixes-2019-10-17' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2019-10-18 06:40:28 +1000) are available in the Git repository at:

[PATCH] Ring range argument improvements (v2)

2019-10-23 Thread Tuikov, Luben
The valid contents of rings is invariably the range [rptr, wptr). Augment the ring range to interpret the '.' ("here") notation to mean rptr or wptr when given on the left or right of the range limits. This augments the range notation as follows: 1) No range given, print the whole ring. 2) [.]

[PATCH] Ring range argument improvements

2019-10-23 Thread Tuikov, Luben
The valid contents of rings is invariably the range [rptr, wptr). Augment the ring range to interpret the '.' ("here") notation to mean rptr or wptr when given on the left or right of the range limits. This augments the range notation as follows: 1) No range given, print the whole ring. 2) [.]

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-23 Thread Jerome Glisse
On Mon, Oct 21, 2019 at 07:06:00PM +, Jason Gunthorpe wrote: > On Mon, Oct 21, 2019 at 02:40:41PM -0400, Jerome Glisse wrote: > > On Tue, Oct 15, 2019 at 03:12:27PM -0300, Jason Gunthorpe wrote: > > > From: Jason Gunthorpe > > > > > > 8 of the mmu_notifier using drivers (i915_gem, radeon_mn,

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-23 Thread Jerome Glisse
On Wed, Oct 23, 2019 at 11:32:16AM +0200, Christian König wrote: > Am 23.10.19 um 11:08 schrieb Daniel Vetter: > > On Tue, Oct 22, 2019 at 03:01:13PM +, Jason Gunthorpe wrote: > > > On Tue, Oct 22, 2019 at 09:57:35AM +0200, Daniel Vetter wrote: > > > > > > > > The unusual bit in all of this

Re: [PATCH 18/37] drm/amd/display: Allow inverted gamma

2019-10-23 Thread Kazlauskas, Nicholas
On 2019-10-23 11:44 a.m., Li, Sun peng (Leo) wrote: > > > On 2019-10-23 11:23 a.m., Michel Dänzer wrote: >> On 2019-10-17 9:13 p.m., sunpeng...@amd.com wrote: >>> From: Aidan Yang >>> >>> [why] >>> There's a use case for inverted gamma >>> and it's been confirmed that negative slopes are ok.

Re: [PATCH v2] drm/amdgpu: Add DC feature mask to disable fractional pwm

2019-10-23 Thread Li, Sun peng (Leo)
On 2019-10-23 10:19 a.m., Lukáš Krejčí wrote: > On Mon, 2019-10-21 at 15:44 -0400, sunpeng...@amd.com wrote: >> From: Leo Li >> >> [Why] >> >> Some LED panel drivers might not like fractional PWM. In such cases, >> backlight flickering may be observed. >> >> [How] >> >> Add a DC feature mask to

Re: [PATCH 18/37] drm/amd/display: Allow inverted gamma

2019-10-23 Thread Li, Sun peng (Leo)
On 2019-10-23 11:23 a.m., Michel Dänzer wrote: > On 2019-10-17 9:13 p.m., sunpeng...@amd.com wrote: >> From: Aidan Yang >> >> [why] >> There's a use case for inverted gamma >> and it's been confirmed that negative slopes are ok. >> >> [how] >> Remove code for blocking non-monotonically

Re: [PATCH] Cleanup: replace prefered with preferred

2019-10-23 Thread Mark Salyzyn
On 10/23/19 4:56 AM, Jarkko Sakkinen wrote: On Tue, Oct 22, 2019 at 02:41:45PM -0700, Mark Salyzyn wrote: Replace all occurrences of prefered with preferred to make future checkpatch.pl's happy. A few places the incorrect spelling is matched with the correct spelling to preserve existing user

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring

2019-10-23 Thread Nirmoy
Thanks Updated and pushed to  brahma HEAD:refs/for/amd-staging-drm-next On 10/23/19 5:21 PM, Koenig, Christian wrote: > Maybe say parameter instead of variable in the subject. > > Am 23.10.19 um 16:35 schrieb Nirmoy Das: >> Signed-off-by: Nirmoy Das > Apart from that Acked-by: Christian König >

Re: [PATCH 18/37] drm/amd/display: Allow inverted gamma

2019-10-23 Thread Michel Dänzer
On 2019-10-17 9:13 p.m., sunpeng...@amd.com wrote: > From: Aidan Yang > > [why] > There's a use case for inverted gamma > and it's been confirmed that negative slopes are ok. > > [how] > Remove code for blocking non-monotonically increasing gamma > > Signed-off-by: Aidan Yang > Reviewed-by:

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring

2019-10-23 Thread Koenig, Christian
Maybe say parameter instead of variable in the subject. Am 23.10.19 um 16:35 schrieb Nirmoy Das: > Signed-off-by: Nirmoy Das Apart from that Acked-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +-- >

Re: [PATCH] drm/radeon: remove assignment for return value

2019-10-23 Thread Harry Wentland
On 2019-10-19 3:32 a.m., Wambui Karuga wrote: > Remove unnecessary assignment for return value and have the > function return the required value directly. > Issue found by coccinelle: > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > >

Re: [PATCH] drm/amd/amdgpu: correct length misspelling

2019-10-23 Thread Harry Wentland
On 2019-10-19 3:34 a.m., Wambui Karuga wrote: > Correct the "_LENTH" mispelling in the AMDGPU_MAX_TIMEOUT_PARAM_LENGTH > constant. > > Signed-off-by: Wambui Karuga This patch would be better sent in a patch set with the "make undeclared variables static" patch. You can do that by providing a

Re: [PATCH] drm/amd/amdgpu: make undeclared variables static

2019-10-23 Thread Harry Wentland
On 2019-10-19 3:24 a.m., Wambui Karuga wrote: > Make the `amdgpu_lockup_timeout` and `amdgpu_exp_hw_support` variables > static to remove the following sparse warnings: > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:103:19: warning: symbol > 'amdgpu_lockup_timeout' was not declared. Should it be

Re: [PATCH v2] drm/amdgpu: Add DC feature mask to disable fractional pwm

2019-10-23 Thread Lukáš Krejčí
On Mon, 2019-10-21 at 15:44 -0400, sunpeng...@amd.com wrote: > From: Leo Li > > [Why] > > Some LED panel drivers might not like fractional PWM. In such cases, > backlight flickering may be observed. > > [How] > > Add a DC feature mask to disable fractional PWM, and associate it with > the

Re: [PATCH] dc.c:use kzalloc without test

2019-10-23 Thread Harry Wentland
On 2019-10-23 4:32 a.m., zhongshiqi wrote: > dc.c:583:null check is needed after using kzalloc function > > Signed-off-by: zhongshiqi Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH] drm/amdgpu/sdma5: do not execute 0-sized IBs (v2)

2019-10-23 Thread Pelloux-prayer, Pierre-eric
Hi Alex, On 23/10/2019 14:50, Deucher, Alexander wrote: >> -Original Message- >> From: amd-gfx On Behalf Of >> Christian König >> Sent: Wednesday, October 23, 2019 3:33 AM >> To: Pelloux-prayer, Pierre-eric ; amd- >> g...@lists.freedesktop.org >> Subject: Re: [PATCH] drm/amdgpu/sdma5: do

RE: [PATCH] drm/amdgpu/sdma5: do not execute 0-sized IBs (v2)

2019-10-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Wednesday, October 23, 2019 3:33 AM > To: Pelloux-prayer, Pierre-eric ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu/sdma5: do not execute 0-sized IBs (v2) > > Am 22.10.19 um 19:22 schrieb

RE: [PATCH] drm/amdgpu: Fix SDMA hang when performing VKexample test

2019-10-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > chen gong > Sent: Wednesday, October 23, 2019 2:51 AM > To: amd-gfx@lists.freedesktop.org > Cc: Gong, Curry > Subject: [PATCH] drm/amdgpu: Fix SDMA hang when performing VKexample > test > > VKexample test hang during

Re: [PATCH] drm/amdgpu: call amdgpu_vm_prt_fini before deleting the root PD

2019-10-23 Thread Christian König
Am 23.10.19 um 14:02 schrieb Pelloux-prayer, Pierre-eric: amdgpu_vm_prt_fini uses "vm->root.base.bo" so it must still be valid when we call it. Fixes: b65709a92156 ("drm/amdgpu: reserve the root PD while freeing PASIDs") Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König

[PATCH] drm/amdgpu: call amdgpu_vm_prt_fini before deleting the root PD

2019-10-23 Thread Pelloux-prayer, Pierre-eric
amdgpu_vm_prt_fini uses "vm->root.base.bo" so it must still be valid when we call it. Fixes: b65709a92156 ("drm/amdgpu: reserve the root PD while freeing PASIDs") Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 19 ++- 1 file changed, 10

Re: [PATCH] Cleanup: replace prefered with preferred

2019-10-23 Thread Jarkko Sakkinen
On Tue, Oct 22, 2019 at 02:41:45PM -0700, Mark Salyzyn wrote: > Replace all occurrences of prefered with preferred to make future > checkpatch.pl's happy. A few places the incorrect spelling is > matched with the correct spelling to preserve existing user space API. > > Signed-off-by: Mark

Re: [PATCH] Cleanup: replace prefered with preferred

2019-10-23 Thread Laurent Pinchart
Hi Mark, Thank you for the patch. On Tue, Oct 22, 2019 at 02:41:45PM -0700, Mark Salyzyn wrote: > Replace all occurrences of prefered with preferred to make future > checkpatch.pl's happy. A few places the incorrect spelling is > matched with the correct spelling to preserve existing user space

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-23 Thread Christian König
Am 23.10.19 um 11:08 schrieb Daniel Vetter: On Tue, Oct 22, 2019 at 03:01:13PM +, Jason Gunthorpe wrote: On Tue, Oct 22, 2019 at 09:57:35AM +0200, Daniel Vetter wrote: The unusual bit in all of this is using a lock's critical region to 'protect' data for read, but updating that same data

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-23 Thread Daniel Vetter
On Tue, Oct 22, 2019 at 03:01:13PM +, Jason Gunthorpe wrote: > On Tue, Oct 22, 2019 at 09:57:35AM +0200, Daniel Vetter wrote: > > > > The unusual bit in all of this is using a lock's critical region to > > > 'protect' data for read, but updating that same data before the lock's > > > critical

[PATCH] drm/amd/powerplay: skip unsupported clock limit settings on Arcturus V2

2019-10-23 Thread Quan, Evan
For Arcturus, clock limit settings on uclk/socclk/fclk domains are not supported. V2: simplify the code to support both SGPU and MGPU cases Change-Id: I1286289e3770f0421f0d22989437e26d3f7b2ec4 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 13 ++

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-23 Thread Jason Gunthorpe
On Tue, Oct 22, 2019 at 09:57:35AM +0200, Daniel Vetter wrote: > > The unusual bit in all of this is using a lock's critical region to > > 'protect' data for read, but updating that same data before the lock's > > critical secion. ie relying on the unlock barrier to 'release' program > > ordered

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-23 Thread Jason Gunthorpe
On Tue, Oct 22, 2019 at 07:56:12AM -0400, Dennis Dalessandro wrote: > On 10/21/2019 12:58 PM, Jason Gunthorpe wrote: > > On Mon, Oct 21, 2019 at 11:55:51AM -0400, Dennis Dalessandro wrote: > > > On 10/15/2019 2:12 PM, Jason Gunthorpe wrote: > > > > This is still being tested, but I figured to send

[PATCH] Cleanup: replace prefered with preferred

2019-10-23 Thread Mark Salyzyn
Replace all occurrences of prefered with preferred to make future checkpatch.pl's happy. A few places the incorrect spelling is matched with the correct spelling to preserve existing user space API. Signed-off-by: Mark Salyzyn --- Documentation/networking/ip-sysctl.txt| 2 +-

Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking

2019-10-23 Thread Dennis Dalessandro
On 10/21/2019 12:58 PM, Jason Gunthorpe wrote: On Mon, Oct 21, 2019 at 11:55:51AM -0400, Dennis Dalessandro wrote: On 10/15/2019 2:12 PM, Jason Gunthorpe wrote: This is still being tested, but I figured to send it to start getting help from the xen, amd and hfi drivers which I cannot test

[PATCH -next] drm/amdgpu: remove set but not used variable 'adev'

2019-10-23 Thread YueHaibing
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1221:24: warning: variable adev set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:488:24: warning: variable adev set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:547:24: warning:

Displayport on thunderbolt dock is down although X thinks it is up

2019-10-23 Thread Klaus Kusche
Hello, the thunderbolt maintainers told me that the following question should be directed to the gfx people: I use a dell precision 7740 notebook with amd polaris 12 graphics. The notebook is connected or hotplugged to a noname thunderbolt dock with displayport or hdmi monitors connected to

Re: [PATCH] drm/amdgpu/sdma5: do not execute 0-sized IBs (v2)

2019-10-23 Thread Christian König
Am 22.10.19 um 19:22 schrieb Pelloux-prayer, Pierre-eric: This seems to help with https://bugs.freedesktop.org/show_bug.cgi?id=111481. v2: insert a NOP instead of skipping all 0-sized IBs to avoid breaking older hw Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König

RE: [PATCH] drm/amdgpu: Fix SDMA hang when performing VKexample test

2019-10-23 Thread Liu, Aaron
Reviewed-by: Aaron Liu BR, Aaron Liu > -Original Message- > From: amd-gfx On Behalf Of chen > gong > Sent: Wednesday, October 23, 2019 2:51 PM > To: amd-gfx@lists.freedesktop.org > Cc: Gong, Curry > Subject: [PATCH] drm/amdgpu: Fix SDMA hang when performing VKexample > test > >

[PATCH] drm/amdgpu: Fix SDMA hang when performing VKexample test

2019-10-23 Thread chen gong
VKexample test hang during Occlusion/SDMA/Varia runs. Clear XNACK_WATERMK in reg SDMA0_UTCL1_WATERMK to fix this issue. Signed-off-by: chen gong --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

Re: [PATCH] UPSTREAM: drm/amd/display: Fix Apple dongle cannot be successfully detected

2019-10-23 Thread S, Shirish
The UPSTREAM tag in the commit message needs to be removed. On 10/21/2019 1:24 PM, Louis Li wrote: > [Why] > External monitor cannot be displayed consistently, if connecting > via this Apple dongle (A1621, USB Type-C to HDMI). > By experiments, it is confirmed that the dongle needs 200ms at least