Hi Xiaojie,
This was reported by Zhigang team. Under their special use case, scratch
register 7 has be to 0 to perform asic init(@Luo, Zhigang right?).
And considering old asics(vega20/10) also applied this change.
So, I think it's reasonable(and recommend by SMU fw team) to apply this on the
This patch fixes the following warning:
-Wformat-overflow=
Signed-off-by: Luben Tuikov
---
tests/amdgpu/meson.build | 1 +
tests/amdgpu/ras_tests.c | 41
2 files changed, 30 insertions(+), 12 deletions(-)
diff --git a/tests/amdgpu/meson.build
This patch fixes:
-Wunused-function
Signed-off-by: Luben Tuikov
---
tests/amdgpu/ras_tests.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/ras_tests.c b/tests/amdgpu/ras_tests.c
index d714be73..4c395382 100644
--- a/tests/amdgpu/ras_tests.c
+++
This patch fixes the following warnings:
-Wformat=
-Wmaybe-uninitialized
-Wmisleading-indentation
-Wstringop-truncation
-Wunused-function
-Wunused-variable
It also removes forward declarations and moves
global functions to the bottom, keeping locals
at the top, in ras_tests.c.
Signed-off-by:
On 2019-12-03 9:35 a.m., mikita.lip...@amd.com wrote:
> From: David Francis
>
> This field on drm_dp_mst_branch was never filled
>
> It is initialized to zero when the port is kzallocced.
> When a port is added to the list, increment num_ports,
> and when a port is removed from the list,
Hi Evan,
Just out of curiosity, may I know what issue are you trying to fix?
I used to see vbios post failure (hangs in atombios init table) after baco exit
occasionally on navi.
BR,
Xiaojie
> On Dec 6, 2019, at 11:37 AM, Evan Quan wrote:
>
> This is needed for coming asic init on performing
This is needed for coming asic init on performing gpu reset.
Change-Id: If3671a24d239e3d288665fadaa2c40c87d5da40b
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
I've seen a few people reported this issue on Freedesktop/Bugzilla. For example:
https://bugs.freedesktop.org/show_bug.cgi?id=24.
They all experienced this issue while playing games. The higher GPU clock is,
the more frequent issue can be reproduced.
Also, some Reddit users pointed out all
Reviewed-by: Evan Quan
> -Original Message-
> From: amd-gfx On Behalf Of Andrey
> Grodzovsky
> Sent: Friday, December 6, 2019 3:30 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Grodzovsky, Andrey
>
> Subject: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10.
>
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20191203]
[cannot apply to drm-intel/for-linux-next linus/master v5.4-rc8
drm-exynos/exynos-drm-next v5.4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the
On 2019-12-05 5:16 p.m., Liu, Zhan wrote:
>
>
>> -Original Message-
>> From: Alex Deucher
>> Sent: 2019/December/05, Thursday 5:13 PM
>> To: Liu, Zhan
>> Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander
>>
>> Subject: Re: [PATCH] drm/amdgpu/display: add fallthrough comment
>>
>>
- Original Message -
> From: "Harry Wentland"
> To: "Liu, Zhan" , "Timothy Pearson"
> , "amd-gfx"
>
> Sent: Thursday, December 5, 2019 5:19:22 PM
> Subject: Re: amdgpu: Enable full DCN support on POWER
> On 2019-12-05 6:02 p.m., Liu, Zhan wrote:
>>
>>
>>> -Original Message-
On 12/2/19 6:42 PM, Jason Gunthorpe wrote:
...
> Regarding the ugly names.. Naming has been really hard here because
> currently everything is a 'mmu notifier' and the natural abberviations
> from there are crummy. Here is the basic summary:
>
> struct mmu_notifier_mm (ie the mm->mmu_notifier_mm)
On 2019-12-05 6:02 p.m., Liu, Zhan wrote:
>
>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Timothy Pearson
>> Sent: 2019/December/05, Thursday 4:58 PM
>> To: amd-gfx
>> Subject: [PATCH] [RFC v2] amdgpu: Enable full DCN support on POWER
>>
>> DCN requires floating point
Hello,
one of my computers has been crashing while gaming rather a lot
lately, with kernel messages pointing to amdgpu. First line see
subject, rest in the attached log.
SSH still works, attempts to shutdown/reboot don't quite finish.
Radeon VII in an Asus Pro WS X570-Ace. Ubuntu 18.04.3 HWE,
> -Original Message-
> From: amd-gfx On Behalf Of
> Timothy Pearson
> Sent: 2019/December/05, Thursday 4:58 PM
> To: amd-gfx
> Subject: [PATCH] [RFC v2] amdgpu: Enable full DCN support on POWER
>
> DCN requires floating point support to operate. Add the appropriate
> x86/ppc64 guards
> -Original Message-
> From: Alex Deucher
> Sent: 2019/December/05, Thursday 5:13 PM
> To: Liu, Zhan
> Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander
>
> Subject: Re: [PATCH] drm/amdgpu/display: add fallthrough comment
>
> On Thu, Dec 5, 2019 at 5:10 PM Liu, Zhan wrote:
> >
>
On Thu, Dec 5, 2019 at 5:10 PM Liu, Zhan wrote:
>
>
>
> > -Original Message-
> > From: amd-gfx On Behalf Of Alex
> > Deucher
> > Sent: 2019/December/05, Thursday 4:39 PM
> > To: amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander
> > Subject: [PATCH] drm/amdgpu/display: add
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: 2019/December/05, Thursday 4:39 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/amdgpu/display: add fallthrough comment
>
> To avoid a compiler warning.
>
> Signed-off-by:
DCN requires floating point support to operate. Add the appropriate
x86/ppc64 guards and FPU / AltiVec / VSX context switches to DCN.
Signed-off-by: Timothy Pearson
---
drivers/gpu/drm/amd/display/Kconfig | 8 +-
drivers/gpu/drm/amd/display/dc/Makefile | 1 +
Sent this a bit too early, still running through checks. Watch for a V2
shortly.
- Original Message -
> From: "Timothy Pearson"
> To: "amd-gfx"
> Sent: Thursday, December 5, 2019 3:39:24 PM
> Subject: [PATCH] [RFC] amdgpu: Enable full DCN support on POWER
> DCN requires floating
To avoid a compiler warning.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
index 191b68b8163a..f1a5d2c6aa37 100644
---
DCN requires floating point support to operate. Add the appropriate
x86/ppc64 guards and FPU / AltiVec / VSX context switches to DCN.
Signed-off-by: Timothy Pearson
---
drivers/gpu/drm/amd/display/Kconfig | 8 +-
drivers/gpu/drm/amd/display/dc/Makefile | 1 +
> -Original Message-
> From: Andrey Grodzovsky
> Sent: Thursday, December 5, 2019 2:30 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Grodzovsky,
> Andrey
> Subject: [PATCH] drm/amdgpu: Fix BACO entry failure in NAVI10.
>
> BACO feature must be kept enabled to allow
BACO feature must be kept enabled to allow entry into
BACO state in SMU during runtime suspend.
Signed-off-by: Andrey Grodzovsky
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
On 2019-12-03 9:35 a.m., mikita.lip...@amd.com wrote:
> From: Mikita Lipski
>
> Adding PBN attribute to drm_dp_vcpi_allocation structure to
> keep track of how much bandwidth each Port requires.
> Adding drm_dp_mst_atomic_check_bw_limit to verify that
> state's bandwidth needs doesn't exceed
Am 05.12.19 um 17:45 schrieb Felix Kuehling:
On 2019-12-05 8:39 a.m., Christian König wrote:
When a BO is evicted immedially invalidate the mapped PTEs.
I think you mentioned that this is just a proof of concept.
I also need this for immediately getting rid of mappings in DMA-buf
based
On 2019-12-05 11:10 a.m., Philip Yang wrote:
One comment in line.
With it is fixed, this is reviewed by Philip Yang
Philip
On 2019-12-04 11:13 p.m., Felix Kuehling wrote:
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index
Yeah, but we should try to unify the memory management.
I mean we must have a common rational on how much memory page tables are
going to use.
If we allow applications to oversubscribe or not is a completely
different topic.
Regards,
Christian.
Am 05.12.19 um 18:05 schrieb Felix Kuehling:
I don't think this should go into amdgpu_vram_mgr. KFD tries to avoid
running out of VRAM for page tables because we cannot oversubscribe
memory within a process and we want to avoid compute processes evicting
each other because that would mean thrashing. Those limitation don't
apply to
On 2019-12-05 8:39 a.m., Christian König wrote:
When a BO is evicted immedially invalidate the mapped PTEs.
I think you mentioned that this is just a proof of concept. I wouldn't
submit the patch like this because it's overkill for VMs that don't want
to use recoverable page faults and
On 2019-12-05 8:39 a.m., Christian König wrote:
Don't add the VM update fences to the resv object and remove
the handling to stop implicitely syncing to them.
Ongoing updates prevent page tables from being evicted and we manually
block for all updates to complete before releasing PDs and PTS.
On 2019-12-05 8:39 a.m., Christian König wrote:
Allows us to reduce the overhead while syncing to fences a bit.
v2: also drop adev parameter from the functions
Signed-off-by: Christian König
Reviewed-by: Felix Kuehling
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--
On 2019-12-05 8:39 a.m., Christian König wrote:
This allows to invalidate VM entries without taking the reservation lock.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 39 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 +++
2 files
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a runqueue based
on entity/ctx's priority for a
Please ignore this one as I forgot to add the Reviewed-by
Regards,
Nirmoy
On 12/5/19 5:01 PM, Nirmoy Das wrote:
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of
One comment in line.
With it is fixed, this is reviewed by Philip Yang
Philip
On 2019-12-04 11:13 p.m., Felix Kuehling wrote:
Use filep->private_data to store a pointer to the kfd_process data
structure. Take an extra reference for that, which gets released in
the kfd_release callback. Check
On 12/5/19 4:43 PM, Christian König wrote:
Am 05.12.19 um 15:48 schrieb Nirmoy Das:
EXPORT_SYMBOL(drm_sched_entity_set_priority);
@@ -490,18 +474,20 @@ void drm_sched_entity_select_rq(struct
drm_sched_entity *entity)
struct dma_fence *fence;
struct drm_sched_rq *rq;
- if
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a runqueue based
on entity/ctx's priority for a
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a runqueue based
on entity/ctx's priority for a
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a runqueue based
on entity/ctx's priority for a
On Tue, Dec 03, 2019 at 02:42:12AM +, Jason Gunthorpe wrote:
> On Sat, Nov 30, 2019 at 10:23:31AM -0800, Linus Torvalds wrote:
> > On Sat, Nov 30, 2019 at 10:03 AM Linus Torvalds
> > wrote:
> > >
> > > I'll try to figure the code out, but my initial reaction was "yeah,
> > > not in my VM".
>
Am 05.12.19 um 15:48 schrieb Nirmoy Das:
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a
[AMD Official Use Only - Internal Distribution Only]
You could enable UVD support on amdgpu using the original firmware from radeon,
but you'd have to adjust the memory map on the GPU for SI to match radeon. So
updated firmware is not a requirement per se, it's just needed to keep the
memory
Hi Matthew,
Am 05.12.19 um 15:16 schrieb Matthew Taylor:
Hi,
Back in November 2017, Piotr Redlewski, provided some patches for UVD
support in the SI cards, the thread had the same subject as this message.
The outcome of a conversation between himself and other developers on
the list was to
> -Original Message-
> From: amd-gfx On Behalf Of
> Rodrigo Siqueira
> Sent: 2019/December/05, Thursday 8:59 AM
> To: =dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org; amd-
> g...@lists.freedesktop.org
> Cc: Li, Sun peng (Leo) ; Berthe, Abdoulaye
> ; Jani Nikula ;
>
On 12/5/19 3:42 PM, Nirmoy Das wrote:
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a
Hi,
Back in November 2017, Piotr Redlewski, provided some patches for UVD
support in the SI cards, the thread had the same subject as this message.
The outcome of a conversation between himself and other developers on the
list was to wait for something in updated firmware. As this was over 2
FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP
1.4a. This commit adds the address registers for
FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1.
Cc: Abdoulaye Berthe
Cc: Harry Wentland
Cc: Leo Li
Cc: Jani Nikula
Cc: Manasi Navare
Cc: Ville Syrjälä
On Thu, Dec 5, 2019 at 2:26 AM Xiaojie Yuan wrote:
>
> Fixes: b86a1aa36a92 ("drm/amd/display: rename DCN1_0 kconfig to DCN")
> Signed-off-by: Xiaojie Yuan
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a runqueue based
on entity/ctx's priority for a
When a BO is evicted immedially invalidate the mapped PTEs.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
Don't add the VM update fences to the resv object and remove
the handling to stop implicitely syncing to them.
Ongoing updates prevent page tables from being evicted and we manually
block for all updates to complete before releasing PDs and PTS.
This way we can do updates even without the resv
Allows us to reduce the overhead while syncing to fences a bit.
v2: also drop adev parameter from the functions
Signed-off-by: Christian König
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 19 +++---
When a page tables needs to be evicted the VM code should
decide if that is possible or not.
Signed-off-by: Christian König
Reviewed-by: Felix Kuehling
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 22 ++
This allows to invalidate VM entries without taking the reservation lock.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 39 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 +++
2 files changed, 36 insertions(+), 7 deletions(-)
diff --git
[AMD Official Use Only - Internal Distribution Only]
Thanks Christian,
I will modify and resend.
Regards,
Nirmoy
From: Koenig, Christian
Sent: Thursday, December 5, 2019 1:29:49 PM
To: Das, Nirmoy ; Nirmoy Das ;
Deucher, Alexander ; Ho, Kenny
Cc:
[AMD Official Use Only - Internal Distribution Only]
Series are Reviewed-by: Kevin Wang
Best Regards,
Kevin
From: amd-gfx on behalf of Xiaomeng Hou
Sent: Thursday, December 5, 2019 7:50 PM
To: amd-gfx@lists.freedesktop.org
Cc: Hou, Xiaomeng (Matthew)
Am 05.12.19 um 12:04 schrieb Nirmoy:
Hi Christian,
I am not exactly sure about drm_sched_entity_set_priority() I wonder
if just changing
entity->priority to ctx->override_priority should work. With this
change drm_sched_entity_select_rq()
will chose a rq based on entity->priority which
Am 05.12.19 um 11:52 schrieb Nirmoy Das:
Entity currently keeps a copy of run_queue list and modify it in
drm_sched_entity_set_priority(). Entities shouldn't modify run_queue
list. Use drm_gpu_scheduler list instead of drm_sched_rq list
in drm_sched_entity struct. In this way we can select a
the unit of variable AverageGfxActivity defined in smu12 metrics
struct is centi, so the retrieved value should be divided by 100 before
return.
Change-Id: Ia7873597977cb5479b015d632ab24a7aa20a1cfb
Signed-off-by: Xiaomeng Hou
---
drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +-
1 file
implement sensor interface of feature mask for debugfs.
Change-Id: Ia085aab4c82b978e1e8c8ddc3ca6278b9dec8005
Signed-off-by: Xiaomeng Hou
---
drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 3 ++
drivers/gpu/drm/amd/powerplay/renoir_ppt.c| 1 +
drivers/gpu/drm/amd/powerplay/smu_v12_0.c
implement smu12 get_clk_freq interface to get clock frequency like
MCLK/SCLK.
Change-Id: I2481d649811c15cd2d8e2741242b2928a32413fc
Signed-off-by: Xiaomeng Hou
---
drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 4 ++
drivers/gpu/drm/amd/powerplay/renoir_ppt.c| 49 +++
add sensor interface of get gpu temperature for debugfs.
Change-Id: I2499b6652fad6d5d776b6ed4cd5157636583ed39
Signed-off-by: Xiaomeng Hou
---
drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 22 ++
1 file changed, 22 insertions(+)
diff --git
Hi Christian,
I am not exactly sure about drm_sched_entity_set_priority() I wonder if
just changing
entity->priority to ctx->override_priority should work. With this
change drm_sched_entity_select_rq()
will chose a rq based on entity->priority which seems to me correct. But
is this
Sorry, just forgot to add the mailing list.
Am 05.12.19 um 11:49 schrieb Christian König:
Hi guys,
I've seen some patches flying by to change how much VRAM is reserved
for page tables in the KFD.
Would it make sense to fully move that into amdgpu_vram_mgr.c?
Regards,
Christian.
[Why]
This patch is trying to address the issue observed when hotplug DP
daisy chain monitors.
e.g.
src-mstb-mstb-sst -> src (unplug) mstb-mstb-sst -> src-mstb-mstb-sst
(plug in again)
Once unplug a DP MST capable device, driver will call
drm_dp_mst_topology_mgr_set_mst() to disable MST. In
Hi guys,
I was wondering why the heck Felix wants to add another lock for over an
hour before I realized that I accidentally forget to send out patch #4
and #5.
And yes what you describe is exactly what my patch #4 is doing and patch
#5 is then a prove of concept to use the new interface
68 matches
Mail list logo
