[AMD Public Use]
Sorry for any inconvenience I brought.
Thank you so much Lyude, I will have a look on that fix patch later.
> -Original Message-
> From: Lyude Paul
> Sent: Saturday, January 18, 2020 4:45 AM
> To: Sean Paul
> Cc: Lin, Wayne ; dri-de...@lists.freedesktop.org;
>
[AMD Official Use Only - Internal Distribution Only]
Thanks for the catch. Reviewed-by: Oak Zeng
Regards,
Oak
-Original Message-
From: Pan, Xinhui
Sent: Tuesday, January 21, 2020 10:10 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zeng, Oak
Subject: [PATCH]
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Feifei Xu
-Original Message-
From: amd-gfx On Behalf Of Pan, Xinhui
Sent: 2020年1月22日 11:10
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Zeng, Oak
Subject: [PATCH] drm/amdgpu: initialize bo_va_list when
bo_va_list is list_head, so initialize it.
Signed-off-by: xinhui pan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index
On 2020-01-21 11:50 a.m., Nirmoy Das wrote:
> Currently we pre-allocate entities and fences for all the HW IPs on
> context creation and some of which are might never be used.
>
> This patch tries to resolve entity/fences wastage by creating entities
> for a HW IP only when it is required.
>
>
On 2020-01-21 11:50 a.m., Nirmoy Das wrote:
> Do not allocate all the entity at once. This is required for
> dynamic amdgpu_ctx_entity creation.
>
> Signed-off-by: Nirmoy Das
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 130
> 1 file changed, 65 insertions(+), 65
Thank for the reviews. I pushed patch 1 and 2 because they're obvious
fixes. They have passed local testing on a Vega10. I'm still waiting for
an opportunity to test the re-worked workaround in patch 3 on a
problematic system with Vega20 and XGMI.
Regards,
Felix
On 2020-01-17 8:37 p.m.,
On 2020-01-21 5:21 p.m., James Zhu wrote:
Fix vcn2.5 instance issue, vcn0 and vcn1 have same register offset
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 +-
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 88 -
2 files changed, 45
On 2020-01-21 4:06 p.m., Leo Liu wrote:
On 2020-01-21 3:55 p.m., James Zhu wrote:
Since SOC15_DPG_MODE_OFFSET is always the same for all instances, we
should not put [inst]
in the argument list. I will easily make bug in the future.
Like being said, we have the consistent format throughout
Fix vcn2.5 instance issue, vcn0 and vcn1 have same register offset
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 +-
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 88 -
2 files changed, 45 insertions(+), 45 deletions(-)
diff --git
Patch v2 4 and 5 are:
Reviewed-by: Leo Liu
On 2020-01-21 4:39 p.m., James Zhu wrote:
Fix typo error, should be inst_idx instead of inst.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Use inst_idx relacing inst in SOC15_DPG_MODE macro to avoid confusion.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
Fix typo error, should be inst_idx instead of inst.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
index 60fe3c4..ff4f4f7
On 2020-01-21 3:58 p.m., James Zhu wrote:
Actually RREG32_SOC15_DPG_MODE_2_0 has a bug inside to miss using inst
as inst_idx,
If there is a bug, you should clearly specify the bug in the commit
message and fix it in a patch, and then if you think the code-name
conversion need to be fixed,
On 2020-01-21 3:55 p.m., James Zhu wrote:
Since SOC15_DPG_MODE_OFFSET is always the same for all instances, we
should not put [inst]
in the argument list. I will easily make bug in the future.
Like being said, we have the consistent format throughout the entire
driver for the offset as
Actually RREG32_SOC15_DPG_MODE_2_0 has a bug inside to miss using inst
as inst_idx,
So I want to clean up the header first to use inst_idx for abbreviation
of instance index.
James
On 2020-01-21 3:30 p.m., Leo Liu wrote:
On 2020-01-21 12:50 p.m., James Zhu wrote:
On 2020-01-21 12:43
Since SOC15_DPG_MODE_OFFSET is always the same for all instances, we
should not put [inst]
in the argument list. I will easily make bug in the future.
James
On 2020-01-21 3:23 p.m., Leo Liu wrote:
On 2020-01-21 12:48 p.m., James Zhu wrote:
On 2020-01-21 12:40 p.m., Leo Liu wrote:
On
It is not for DPG mode, but for SPG mode.
Just want to reuse the SPG mode instance harvest check here.
James
On 2020-01-21 3:20 p.m., Leo Liu wrote:
On 2020-01-21 12:47 p.m., James Zhu wrote:
On 2020-01-21 12:29 p.m., Leo Liu wrote:
On 2020-01-21 11:19 a.m., James Zhu wrote:
Fix a bug
On 2020-01-21 12:50 p.m., James Zhu wrote:
On 2020-01-21 12:43 p.m., Leo Liu wrote:
On 2020-01-21 11:19 a.m., James Zhu wrote:
Use inst_idx relacing inst in SOC15_DPG_MODE macro
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 22 +++---
1 file
On 2020-01-21 12:48 p.m., James Zhu wrote:
On 2020-01-21 12:40 p.m., Leo Liu wrote:
On 2020-01-21 11:19 a.m., James Zhu wrote:
Fix vcn2.5 instance issue, vcn0 and vcn1 have same register offset
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 4 +-
On 2020-01-21 12:47 p.m., James Zhu wrote:
On 2020-01-21 12:29 p.m., Leo Liu wrote:
On 2020-01-21 11:19 a.m., James Zhu wrote:
Fix a bug for the 2nd vcn instance at start and stop.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 12
1 file changed, 8
On 2020-01-21 12:43 p.m., Leo Liu wrote:
On 2020-01-21 11:19 a.m., James Zhu wrote:
Use inst_idx relacing inst in SOC15_DPG_MODE macro
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
On 2020-01-21 12:40 p.m., Leo Liu wrote:
On 2020-01-21 11:19 a.m., James Zhu wrote:
Fix vcn2.5 instance issue, vcn0 and vcn1 have same register offset
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 4 +-
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 86
On 2020-01-21 12:29 p.m., Leo Liu wrote:
On 2020-01-21 11:19 a.m., James Zhu wrote:
Fix a bug for the 2nd vcn instance at start and stop.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git
On 2020-01-21 11:19 a.m., James Zhu wrote:
Use inst_idx relacing inst in SOC15_DPG_MODE macro
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git
On 2020-01-21 11:19 a.m., James Zhu wrote:
Fix vcn2.5 instance issue, vcn0 and vcn1 have same register offset
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 4 +-
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 86
On 2020-01-21 11:19 a.m., James Zhu wrote:
Fix a bug for the 2nd vcn instance at start and stop.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
This patch is
Reviewed-by: Leo Liu
On 2020-01-21 11:19 a.m., James Zhu wrote:
Share vcn_v2_0_dec_ring_test_ring to vcn2.5 to support
vcn software ring.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.h | 1 +
Do not allocate all the entity at once. This is required for
dynamic amdgpu_ctx_entity creation.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 130
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git
Currently we pre-allocate entities and fences for all the HW IPs on
context creation and some of which are might never be used.
This patch tries to resolve entity/fences wastage by creating entities
for a HW IP only when it is required.
Signed-off-by: Nirmoy Das
---
Use inst_idx relacing inst in SOC15_DPG_MODE macro
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
Fix vcn2.5 instance issue, vcn0 and vcn1 have same register offset
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 4 +-
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 86
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 88
Fix a bug for the 2nd vcn instance at start and stop.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
index
Share vcn_v2_0_dec_ring_test_ring to vcn2.5 to support
vcn software ring.
Signed-off-by: James Zhu
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.h | 1 +
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:628:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c:630:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/nv.c:953:40-45: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/nv.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/athub_v1_0.c:77:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/athub_v1_0.c:79:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1528:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c:1530:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
This patch series remove unnecessary conversion to bool in dir
drivers/gpu/drm/amd/amdgpu/, which is detected by coccicheck.
Chen Zhou (14):
drm/amdgpu: remove unnecessary conversion to bool in mmhub_v1_0.c
drm/amdgpu: remove unnecessary conversion to bool in vega10_ih.c
drm/amdgpu: remove
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/navi10_ih.c:429:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:530:51-56: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/athub_v2_0.c:80:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/athub_v2_0.c:82:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:4737:43-48: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/vega10_ih.c:720:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c:526:40-45: WARNING:
conversion to bool not needed here
./drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c:528:40-45: WARNING:
conversion to bool not needed here
Signed-off-by: Chen Zhou
---
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2883:68-73: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +++-
1 file changed, 3 insertions(+), 5
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/soc15.c:1474:40-45: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 28 ++--
1 file changed, 14 insertions(+),
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c:2180:40-45: WARNING
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Fixes coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:4259:43-48: WARNING:
conversion to bool not needed here
and many more similar messages.
Signed-off-by: Chen Zhou
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 4 ++--
2
If we're worrying about spelling and grammar, see one more nitpick inline.
On 1/20/20 10:35 AM, Nirmoy Das wrote:
> expand sched_list definition for better understanding.
> Also fix a typo atleast -> at least
>
> Signed-off-by: Nirmoy Das
> ---
> drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
Allocate fences for each entity and remove ctx->fences reference as
fences should be bound to amdgpu_ctx_entity instead amdgpu_ctx.
Signed-off-by: Nirmoy Das
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 44 +++--
Am 21.01.20 um 14:05 schrieb Nirmoy Das:
Allocate fences for each entity and remove ctx->fences reference as
fences should be bound to amdgpu_ctx_entity instead amdgpu_ctx.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 43 +++--
Allocate fences for each entity and remove ctx->fences reference as
fences should be bound to amdgpu_ctx_entity instead amdgpu_ctx.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 43 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.h | 1 -
2 files
[AMD Official Use Only - Internal Distribution Only]
Thanks very much Christian!
From: Koenig, Christian
Sent: Tuesday, January 21, 2020 4:52
To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org
Cc: Tuikov, Luben ; Deucher, Alexander
; Zhang, Hawking ; Xu,
54 matches
Mail list logo
