On 6/22/20 5:41 AM, Daniel Vetter wrote:
On Sun, Jun 21, 2020 at 02:03:02AM -0400, Andrey Grodzovsky wrote:
On device removal reroute all CPU mappings to dummy page per drm_file
instance or imported GEM object.
Signed-off-by: Andrey Grodzovsky
---
drivers/gpu/drm/ttm/ttm_bo_vm.c | 65
Tried, didn't have any impact
Andrey
On 6/23/20 5:04 AM, Michel Dänzer wrote:
On 2020-06-23 7:14 a.m., Andrey Grodzovsky wrote:
I am fighting with Thunderbird to make limit a line to 80 chars but
nothing helps. Any suggestions please.
Maybe try disabling mail.compose.default_to_paragraph,
On 6/23/20 9:16 AM, Christian König wrote:
Am 23.06.20 um 12:22 schrieb Daniel Vetter:
On Mon, Jun 22, 2020 at 03:48:29PM -0400, Alex Deucher wrote:
On Mon, Jun 22, 2020 at 3:38 PM Christian König
wrote:
Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky:
Use the new TTM interface to
On 6/23/20 2:05 AM, Greg KH wrote:
On Tue, Jun 23, 2020 at 12:51:00AM -0400, Andrey Grodzovsky wrote:
On 6/22/20 12:45 PM, Greg KH wrote:
On Mon, Jun 22, 2020 at 12:07:25PM -0400, Andrey Grodzovsky wrote:
On 6/22/20 7:21 AM, Greg KH wrote:
On Mon, Jun 22, 2020 at 11:51:24AM +0200, Daniel
On Wed, Jun 24, 2020 at 12:31 AM Dave Chinner wrote:
>
> On Sun, Jun 21, 2020 at 01:42:05PM -0400, Qian Cai wrote:
> > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote:
> > > fs_reclaim_acquire/release nicely catch recursion issues when
> > > allocating GFP_KERNEL memory against
On Tue, Jun 23, 2020 at 6:18 PM Qian Cai wrote:
>
> On Sun, Jun 21, 2020 at 10:01:03PM +0200, Daniel Vetter wrote:
> > On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote:
> > > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote:
> > > >
> > > > On Wed, Jun 10, 2020 at 09:41:01PM +0200,
Applied. Thanks!
Alex
On Tue, Jun 23, 2020 at 5:33 PM John van der Kamp wrote:
>
> Make sure we pass through ret label to unlock the mutex.
>
> Signed-off-by: John van der Kamp
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 6 --
> 1 file changed, 4 insertions(+), 2
Make sure we pass through ret label to unlock the mutex.
Signed-off-by: John van der Kamp
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c
On Tue, Jun 23, 2020 at 5:02 PM John van der Kamp wrote:
>
> Try to mail the patch again, this time inline. Hope this is how you can
> process it.
Can you use git to create the patch (git commit -a -s) and use git to
generate the patch (git format-patch -1) and then send that out? Make
sure to
From: Ville Syrjälä
[ Upstream commit 34b86b75dfc90ab3d996c224314ce51772a3b351 ]
Mostly a cocci-job, but it flat out refused to remove the
declaration in drivers/gpu/drm/amd/display/dc/core/dc.c so
had to do that part manually.
@swap@
identifier TEMP;
expression A,B;
@@
- TEMP = A;
- A = B;
-
Try to mail the patch again, this time inline. Hope this is how you can
process it.
John
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c
index dcf84a61de37..949d10ef8304 100644
---
Am 2020-06-20 um 4:54 a.m. schrieb Bernard Zhao:
> The function kobject_init_and_add alloc memory like:
> kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> ->kmalloc_slab, in err branch this memory not free. If use
Hi Mukul,
See some comments inline ...
Am 2020-06-23 um 1:18 p.m. schrieb Mukul Joshi:
> Lockdep is spewing circular locking dependency warning when
> reading SDMA usage stats.
>
> 150.887733] ==
> [ 150.893903] WARNING: possible circular
Hi John,
The patch looks correct. Can you please send a proper patch
so that we can apply it.
Thanks,
Nirmoy
On 6/23/20 7:48 PM, John van der Kamp wrote:
Hello,
I was reading some code and came across this which looks like a mutex
not being unlocked when an error happens. I don't know
On Tue, Jun 23, 2020 at 02:44:24PM -0400, Felix Kuehling wrote:
> Am 2020-06-23 um 3:39 a.m. schrieb Daniel Vetter:
> > On Fri, Jun 12, 2020 at 1:35 AM Felix Kuehling
> > wrote:
> >> Am 2020-06-11 um 10:15 a.m. schrieb Jason Gunthorpe:
> >>> On Thu, Jun 11, 2020 at 10:34:30AM +0200, Daniel
Hello,
I was reading some code and came across this which looks like a mutex not
being unlocked when an error happens. I don't know what the code does or
how to test it, but it looks quite obvious. Patch is attached.
Johndiff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c
Am 2020-06-23 um 3:39 a.m. schrieb Daniel Vetter:
> On Fri, Jun 12, 2020 at 1:35 AM Felix Kuehling wrote:
>> Am 2020-06-11 um 10:15 a.m. schrieb Jason Gunthorpe:
>>> On Thu, Jun 11, 2020 at 10:34:30AM +0200, Daniel Vetter wrote:
> I still have my doubts about allowing fence waiting from
From: Denis Efremov
[ Upstream commit 43a562774fceba867e8eebba977d7d42f8a2eac7 ]
Use kfree() instead of kvfree() to free rgb_user in
calculate_user_regamma_ramp() because the memory is allocated with
kcalloc().
Signed-off-by: Denis Efremov
Signed-off-by: Alex Deucher
Signed-off-by: Sasha
From: Denis Efremov
[ Upstream commit 43a562774fceba867e8eebba977d7d42f8a2eac7 ]
Use kfree() instead of kvfree() to free rgb_user in
calculate_user_regamma_ramp() because the memory is allocated with
kcalloc().
Signed-off-by: Denis Efremov
Signed-off-by: Alex Deucher
Signed-off-by: Sasha
From: Denis Efremov
[ Upstream commit 43a562774fceba867e8eebba977d7d42f8a2eac7 ]
Use kfree() instead of kvfree() to free rgb_user in
calculate_user_regamma_ramp() because the memory is allocated with
kcalloc().
Signed-off-by: Denis Efremov
Signed-off-by: Alex Deucher
Signed-off-by: Sasha
Lockdep is spewing circular locking dependency warning when
reading SDMA usage stats.
150.887733] ==
[ 150.893903] WARNING: possible circular locking dependency detected
[ 150.905917] --
[
On Sun, Jun 21, 2020 at 10:01:03PM +0200, Daniel Vetter wrote:
> On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote:
> > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote:
> > >
> > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote:
> > > > fs_reclaim_acquire/release nicely
On Mon, Jun 22, 2020 at 5:56 PM Denis Efremov wrote:
>
> clk_s is checked twice in a row in ni_init_smc_spll_table().
> fb_div should be checked instead.
>
> Fixes: 69e0b57a91ad ("drm/radeon/kms: add dpm support for cayman (v5)")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Denis Efremov
[AMD Public Use]
No problem.
Reviewed-by: Alex Deucher
From: Das, Nirmoy
Sent: Tuesday, June 23, 2020 12:04 PM
To: Nirmoy Das ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Das, Nirmoy
Subject: Re: [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK
The release_firmware() function is NULL tolerant so we do not need
to check for NULL param before calling it.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 6 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 ++
On 6/23/20 5:59 PM, Nirmoy Das wrote:
arcturus doesn't support DCEFCLK
Fixes: c67c791cd87d (drm/amd/powerplay: return current DCEFCLK on sysfs read)
Hi Alex,
Can you please squash this with c67c791cd87d (drm/amd/powerplay: return
current DCEFCLK on sysfs read)
I was bit too confident
arcturus doesn't support DCEFCLK
Fixes: c67c791cd87d (drm/amd/powerplay: return current DCEFCLK on sysfs read)
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Nirmoy Das
Sent: Tuesday, June 23, 2020 5:43 AM
To: amd-gfx@lists.freedesktop.org
Cc: Das, Nirmoy
Subject: [PATCH 1/1] drm/amd/powerplay: return current
On 2020/6/23 下午4:22, Michel Dänzer wrote:
> On 2020-06-23 2:23 a.m., Qu Wenruo wrote:
>> Hi guys,
>
>> Firstly thanks for the awesome renoir CPUs.
>
>> However it looks like there are still some bugs in the Linux
>> support, especially with external monitors.
>
>> My setup: - Laptop: Lenovo
Am 23.06.20 um 12:22 schrieb Daniel Vetter:
On Mon, Jun 22, 2020 at 03:48:29PM -0400, Alex Deucher wrote:
On Mon, Jun 22, 2020 at 3:38 PM Christian König
wrote:
Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky:
Use the new TTM interface to invalidate all exsisting BO CPU mappings
form all user
Am 23.06.20 um 12:25 schrieb Daniel Vetter:
On Tue, Jun 23, 2020 at 01:00:02AM -0400, Andrey Grodzovsky wrote:
On 6/22/20 5:45 AM, Daniel Vetter wrote:
On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote:
Helper function to be used to invalidate all BOs CPU mappings
once device
Hi Roland & vmwgfx maintainers,
Thomas has played around with these annotations on his vmwgfx setup,
and found some issues. Apparently in the atomic_commit_tail path when
handling the dirty rectangle stuff you acquire a ttm reservation,
which is a no-go since it could deadlock with other paths -
On Tue, Jun 23, 2020 at 01:00:02AM -0400, Andrey Grodzovsky wrote:
>
> On 6/22/20 5:45 AM, Daniel Vetter wrote:
> > On Sun, Jun 21, 2020 at 02:03:03AM -0400, Andrey Grodzovsky wrote:
> > > Helper function to be used to invalidate all BOs CPU mappings
> > > once device is removed.
> > >
> > >
On Mon, Jun 22, 2020 at 03:48:29PM -0400, Alex Deucher wrote:
> On Mon, Jun 22, 2020 at 3:38 PM Christian König
> wrote:
> >
> > Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky:
> > > Use the new TTM interface to invalidate all exsisting BO CPU mappings
> > > form all user proccesses.
> > >
> > >
This fixes incorrect output when reading pp_dpm_dcefclk sysfs.
Output before this patch:
cat /sys/devices/pci:/pp_dpm_dcefclk
0: 506Mhz
1: 42949671Mhz *
2: 1266Mhz
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 +++
On 2020-06-23 7:14 a.m., Andrey Grodzovsky wrote:
> I am fighting with Thunderbird to make limit a line to 80 chars but
> nothing helps. Any suggestions please.
Maybe try disabling mail.compose.default_to_paragraph, or check other
*wrap* settings.
--
Earthling Michel Dänzer |
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 2020-06-23 2:23 a.m., Qu Wenruo wrote:
> Hi guys,
>
> Firstly thanks for the awesome renoir CPUs.
>
> However it looks like there are still some bugs in the Linux
> support, especially with external monitors.
>
> My setup: - Laptop: Lenovo IdeaPad
On Tue, Jun 23, 2020 at 12:51:00AM -0400, Andrey Grodzovsky wrote:
>
> On 6/22/20 12:45 PM, Greg KH wrote:
> > On Mon, Jun 22, 2020 at 12:07:25PM -0400, Andrey Grodzovsky wrote:
> > > On 6/22/20 7:21 AM, Greg KH wrote:
> > > > On Mon, Jun 22, 2020 at 11:51:24AM +0200, Daniel Vetter wrote:
> > > >
Hi,
This is a kindly reminder that the CFP deadline is in less than two
weeks :)
On Fri, 2020-05-15 at 14:15 +, Szwichtenberg, Radoslaw wrote:
> Hello!
>
> Registration & Call for Proposals are now open for XDC 2020, which
> will
> take place at the Gdańsk University of Technology in
On Fri, Jun 19, 2020 at 04:10:11PM -0400, Jerome Glisse wrote:
> Maybe we can audit how user ptr buffer are use today and see if
> we can define a usage pattern that would allow to cut corner in
> kernel. For instance we could use mmu notifier just to block CPU
> pte update while we do GUP and
Hi guys,
Firstly thanks for the awesome renoir CPUs.
However it looks like there are still some bugs in the Linux support,
especially with external monitors.
My setup:
- Laptop: Lenovo IdeaPad S540 13ARE (Or, Xiaoxin Pro 13 in Chinese market)
4800U CPU, with 5.7.4 Arch kernel. (Also tried
On Mon, Jun 22, 2020 at 04:15:40PM -0400, Jerome Glisse wrote:
> On Mon, Jun 22, 2020 at 08:46:17AM -0300, Jason Gunthorpe wrote:
> > On Fri, Jun 19, 2020 at 04:31:47PM -0400, Jerome Glisse wrote:
> > > Not doable as page refcount can change for things unrelated to GUP, with
> > > John changes we
On Fri, Jun 12, 2020 at 1:35 AM Felix Kuehling wrote:
>
> Am 2020-06-11 um 10:15 a.m. schrieb Jason Gunthorpe:
> > On Thu, Jun 11, 2020 at 10:34:30AM +0200, Daniel Vetter wrote:
> >>> I still have my doubts about allowing fence waiting from within shrinkers.
> >>> IMO ideally they should use a
Am 22.06.20 um 23:41 schrieb Paul Menzel:
[SNIP]
For example, if the user added the parameter intentionally, maybe
they made a typo, and it’s actually not applied. Or there is a bug
in the parameter handling. Having explicit log messages is good in
my opinion.
Secondly, the parameter could
Am 23.06.20 um 07:11 schrieb Andrey Grodzovsky:
On 6/22/20 3:40 PM, Christian König wrote:
Am 21.06.20 um 08:03 schrieb Andrey Grodzovsky:
entity->rq becomes null aftre device unplugged so just return early
in that case.
Mhm, do you have a backtrace for this?
This should only be called by
45 matches
Mail list logo
