RE: [PATCH 1/2] drm/amdgpu/sriov: Add one parameter for mcbp debug

2020-09-20 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Hi Emily There is already a amdgpu_mcbp parameter there, can you try to leverage that one ? e.g.: we refactor our driver's code and reduce the checking logic from "if (amdgpu_mcbp || amdgpu_sriov_vf(adev))" to something like "if(

RE: [PATCH 1/2] drm/amdgpu/sriov: Add one parameter for mcbp debug

2020-09-20 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Ping . >-Original Message- >From: Emily.Deng >Sent: Friday, September 18, 2020 11:27 AM >To: amd-gfx@lists.freedesktop.org >Cc: Deng, Emily >Subject: [PATCH 1/2] drm/amdgpu/sriov: Add one parameter for mcbp debug > >For debug

[PATCH 1/2] drm/amd/pm: decouple the watermark table setting from socclk/uclk dpms

2020-09-20 Thread Evan Quan
As they have no real dependence. And for Navi1x, the socclk/uclk dpms are enabled after DAL initialization. Change-Id: Ia66a92155aadff40e4e2e46edbedce840cfb57ca Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 15 +++ 1 file changed, 7 insertions(+), 8

[PATCH 2/2] drm/amd/pm: drop redundant watermarks bitmap setting

2020-09-20 Thread Evan Quan
As this is already set inside the implementation of smu_set_watermarks_table(). Change-Id: I4d4d40855f0aad43f6d21d471b64f1c7e696f0e7 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH] drm/amd/pm: correct the pmfw version check for Navi14

2020-09-20 Thread Evan Quan
Otherwise, that will be always true for Navi14. Change-Id: Ief94150d10e4987e405d97674d9ae4efe89246fb Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

RE: [PATCH] drm/amdgpu: Fix dead lock issue for vblank

2020-09-20 Thread Zhang, Hawking
[AMD Public Use] I see. The patch is Reviewed-by: Hawking Zhang -Original Message- From: Deng, Emily Sent: Monday, September 21, 2020 09:14 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: Fix dead lock issue for vblank Hi Hawking, It already

RE: [PATCH] drm/amdgpu: Fix dead lock issue for vblank

2020-09-20 Thread Deng, Emily
Hi Hawking, It already exit in the original file, for before patch, I move it to another place, for this V2 patch, I just use: static int dce_virtual_pageflip(struct amdgpu_device *adev, >+ unsigned crtc_id); >-Original Message- >From: Zhang, Hawking

RE: [PATCH] drm/amd/powerplay: optimize the mclk dpm policy settings

2020-09-20 Thread Quan, Evan
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan -Original Message- From: Alex Deucher Sent: Friday, July 31, 2020 2:17 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Deucher, Alexander Subject: [PATCH] drm/amd/powerplay: optimize the mclk dpm policy