There is no need to reset DPM for PPTable uploading on
dimgrey_cavefish and PMFW can handle it, same as navy_flounder.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
[AMD Official Use Only - Internal Distribution Only]
In the subject Ptable->pptable, except that,
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Tuesday, November 17, 2020 11:32 AM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Alex Deucher
From: amd-gfx on behalf of Tao Zhou
Sent: Monday, November 16, 2020 10:31 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
The PPTable provided by VBIOS can be used.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
index
On Mon, Nov 16, 2020 at 12:41 PM Lee Jones wrote:
>
> Also removing the call to
> amdgpu_atombios_encoder_get_backlight_level_from_reg()
> since, according to Alex Deucher, "We call it again below indirectly".
>
> Fixes the following W=1 kernel build warning(s):
>
>
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_prime.c:43:24: warning: no previous prototype
> for ‘radeon_gem_prime_import_sg_table’ [-Wmissing-prototypes]
> 43 | struct drm_gem_object
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/r600_hdmi.c:177:6: warning: no previous prototype for
> ‘r600_hdmi_update_acr’ [-Wmissing-prototypes]
> 177 | void r600_hdmi_update_acr(struct drm_encoder *encoder,
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/r600_cs.c:2343:5: warning: no previous prototype for
> ‘r600_dma_cs_next_reloc’ [-Wmissing-prototypes]
> 2343 | int r600_dma_cs_next_reloc(struct radeon_cs_parser
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/vce_v2_0.c:111:6: warning: no previous prototype for
> ‘vce_v2_0_enable_mgcg’ [-Wmissing-prototypes]
> 111 | void vce_v2_0_enable_mgcg(struct radeon_device *rdev,
On 11/16/20 3:36 PM, Christian König wrote:
Am 16.11.20 um 20:00 schrieb Andrey Grodzovsky:
On 11/16/20 4:48 AM, Christian König wrote:
Am 15.11.20 um 07:34 schrieb Andrey Grodzovsky:
On 11/14/20 4:51 AM, Daniel Vetter wrote:
On Sat, Nov 14, 2020 at 9:41 AM Christian König
wrote:
Am
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/vce_v1_0.c:102:6: warning: no previous prototype for
> ‘vce_v1_0_enable_mgcg’ [-Wmissing-prototypes]
> 102 | void vce_v1_0_enable_mgcg(struct radeon_device *rdev,
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/cik_sdma.c:331:6: warning: no previous prototype for
> ‘cik_sdma_enable’ [-Wmissing-prototypes]
> 331 | void cik_sdma_enable(struct radeon_device *rdev, bool
Am 16.11.20 um 20:00 schrieb Andrey Grodzovsky:
On 11/16/20 4:48 AM, Christian König wrote:
Am 15.11.20 um 07:34 schrieb Andrey Grodzovsky:
On 11/14/20 4:51 AM, Daniel Vetter wrote:
On Sat, Nov 14, 2020 at 9:41 AM Christian König
wrote:
Am 13.11.20 um 21:52 schrieb Andrey Grodzovsky:
On
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/si_dpm.c:3802:4: warning: no previous prototype for
> ‘si_get_ddr3_mclk_frequency_ratio’ [-Wmissing-prototypes]
> 3802 | u8 si_get_ddr3_mclk_frequency_ratio(u32
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/cik.c:6413:6: warning: no previous prototype for
> ‘cik_init_cp_pg_table’ [-Wmissing-prototypes]
> 6413 | void cik_init_cp_pg_table(struct radeon_device *rdev)
> |
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/cik.c:4845:5: warning: no previous prototype for
> ‘cik_gpu_check_soft_reset’ [-Wmissing-prototypes]
> 4845 | u32 cik_gpu_check_soft_reset(struct radeon_device
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/si.c:5678:5: warning: no previous prototype for
> ‘si_get_csb_size’ [-Wmissing-prototypes]
> 5678 | u32 si_get_csb_size(struct radeon_device *rdev)
> |
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/dce6_afmt.c:32:5: warning: no previous prototype for
> ‘dce6_endpoint_rreg’ [-Wmissing-prototypes]
> 32 | u32 dce6_endpoint_rreg(struct radeon_device *rdev,
> |
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/rv770_dpm.c:62:30: warning: no previous prototype for
> ‘evergreen_get_pi’ [-Wmissing-prototypes]
> 62 | struct evergreen_power_info *evergreen_get_pi(struct
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/si.c:4186:6: warning: no previous prototype for
> ‘si_vram_gtt_location’ [-Wmissing-prototypes]
> 4186 | void si_vram_gtt_location(struct radeon_device *rdev,
> |
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/si.c:3768:5: warning: no previous prototype for
> ‘si_gpu_check_soft_reset’ [-Wmissing-prototypes]
> 3768 | u32 si_gpu_check_soft_reset(struct radeon_device *rdev)
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/si.c:1570:5: warning: no previous prototype for
> ‘si_mc_load_microcode’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David Airlie
>
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/cik.c:1868:5: warning: no previous prototype for
> ‘ci_mc_load_microcode’ [-Wmissing-prototypes]
> 1868 | int ci_mc_load_microcode(struct radeon_device *rdev)
> |
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/atombios_encoders.c:186:6: warning: no previous
> prototype for ‘radeon_atom_backlight_init’ [-Wmissing-prototypes]
> 186 | void radeon_atom_backlight_init(struct
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/atombios_encoders.c:2721:1: warning: no previous
> prototype for ‘radeon_add_atom_encoder’ [-Wmissing-prototypes]
> 2721 | radeon_add_atom_encoder(struct drm_device
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/ni.c:1733:5: warning: no previous prototype for
> ‘cayman_gpu_check_soft_reset’ [-Wmissing-prototypes]
> 1733 | u32 cayman_gpu_check_soft_reset(struct radeon_device
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/evergreen.c:4380:5: warning: no previous prototype
> for ‘evergreen_rlc_resume’ [-Wmissing-prototypes]
> 4380 | int evergreen_rlc_resume(struct radeon_device *rdev)
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/evergreen.c:3825:5: warning: no previous prototype
> for ‘evergreen_gpu_check_soft_reset’ [-Wmissing-prototypes]
> 3825 | u32 evergreen_gpu_check_soft_reset(struct
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/r600.c:3480:5: warning: no previous prototype for
> ‘r600_ih_ring_alloc’ [-Wmissing-prototypes]
> 3480 | int r600_ih_ring_alloc(struct radeon_device *rdev)
> |
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/r600.c:1615:5: warning: no previous prototype for
> ‘r600_gpu_check_soft_reset’ [-Wmissing-prototypes]
> 1615 | u32 r600_gpu_check_soft_reset(struct radeon_device
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/ni.c:1378:6: warning: no previous prototype for
> ‘cayman_cp_int_cntl_setup’ [-Wmissing-prototypes]
> 1378 | void cayman_cp_int_cntl_setup(struct radeon_device
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/ni_dpm.c:727:23: warning: no previous prototype for
> ‘ni_get_pi’ [-Wmissing-prototypes]
> 727 | struct ni_power_info *ni_get_pi(struct radeon_device *rdev)
> |
Hi
Am 16.11.20 um 12:28 schrieb Christian König:
> Am 13.11.20 um 08:59 schrieb Thomas Zimmermann:
>> Hi Christian
>>
>> Am 12.11.20 um 18:16 schrieb Christian König:
>>> Am 12.11.20 um 14:21 schrieb Thomas Zimmermann:
In order to avoid eviction of vmap'ed buffers, pin them in their GEM
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/rv770_dpm.c:47:18: warning: no previous prototype for
> ‘rv770_get_ps’ [-Wmissing-prototypes]
> 47 | struct rv7xx_ps *rv770_get_ps(struct radeon_ps *rps)
> |
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/evergreen_hdmi.c:37:6: warning: no previous prototype
> for ‘dce4_audio_enable’ [-Wmissing-prototypes]
> drivers/gpu/drm/radeon/evergreen_hdmi.c:67:6: warning: no
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_prime.c:34:18: warning: no previous prototype
> for ‘radeon_gem_prime_get_sg_table’ [-Wmissing-prototypes]
> 34 | struct sg_table
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/atombios_i2c.c:100:5: warning: no previous prototype
> for ‘radeon_atom_hw_i2c_xfer’ [-Wmissing-prototypes]
> 100 | int radeon_atom_hw_i2c_xfer(struct i2c_adapter
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_irq_kms.c:53:13: warning: no previous
> prototype for ‘radeon_driver_irq_handler_kms’ [-Wmissing-prototypes]
> 53 | irqreturn_t
On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_ttm.c:931:5: warning: no previous prototype
> for ‘radeon_mmap’ [-Wmissing-prototypes]
> 931 | int radeon_mmap(struct file *filp, struct vm_area_struct *vma)
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/evergreen.c:1281:6: warning: no previous prototype
> for ‘evergreen_fix_pci_max_read_req_size’ [-Wmissing-prototypes]
> 1281 | void
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/dce3_1_afmt.c:30:6: warning: no previous prototype
> for ‘dce3_2_afmt_hdmi_write_speaker_allocation’ [-Wmissing-prototypes]
> 30 | void
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_pm.c:74:6: warning: no previous prototype for
> ‘radeon_pm_acpi_event_handler’ [-Wmissing-prototypes]
> 74 | void radeon_pm_acpi_event_handler(struct
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/rv770.c:1138:6: warning: no previous prototype for
> ‘rv770_set_clk_bypass_mode’ [-Wmissing-prototypes]
> 1138 | void rv770_set_clk_bypass_mode(struct radeon_device
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or
> member 'irq' not described in 'radeon_driver_irq_handler_kms'
> drivers/gpu/drm/radeon/radeon_irq_kms.c:56:
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1746:1: warning: no previous
> prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes]
> 1746 | radeon_add_legacy_encoder(struct
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1745:1: warning: no
> previous prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes]
> 1745 | radeon_add_legacy_encoder(struct
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_ttm.c: At top level:
> drivers/gpu/drm/radeon/radeon_ttm.c:817:5: warning: no previous prototype
> for ‘radeon_ttm_init’ [-Wmissing-prototypes]
> 817 | int
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or
> member 'dev' not described in 'radeon_info_ioctl'
> drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_kms.c:756:5: warning: no previous prototype
> for ‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes]
> 756 | u32 radeon_get_vblank_counter_kms(struct
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Unfortunately, a suitable one didn't already exist.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype
> for ‘radeon_device_is_virtual’ [-Wmissing-prototypes]
On Mon, Nov 16, 2020 at 12:30 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous
> prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes]
> 1791 | bool radeon_atom_get_tv_timings(struct
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_kms.c:756:5: warning: no previous prototype for
‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes]
756 | u32 radeon_get_vblank_counter_kms(struct drm_crtc *crtc)
| ^
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/r600_cs.c:2343:5: warning: no previous prototype for
‘r600_dma_cs_next_reloc’ [-Wmissing-prototypes]
2343 | int r600_dma_cs_next_reloc(struct radeon_cs_parser *p,
| ^~
Cc: Alex Deucher
Cc: "Christian
[sending again, as `git send-email` crashed!]
This set contains fixes for some "wouldn't it be nice if" issues,
however most of the patches seen here have been on the MLs, but
were left unreviewed.
Lee Jones (43):
drm/radeon/atombios_encoders: Move 'radeon_atom_get_tv_timings()'s
prototype
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/atombios_encoders.c:2721:1: warning: no previous
prototype for ‘radeon_add_atom_encoder’ [-Wmissing-prototypes]
2721 | radeon_add_atom_encoder(struct drm_device *dev,
| ^~~
Cc: Alex Deucher
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or
member 'irq' not described in 'radeon_driver_irq_handler_kms'
drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or
member 'arg' not described in
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_ttm.c: At top level:
drivers/gpu/drm/radeon/radeon_ttm.c:817:5: warning: no previous prototype for
‘radeon_ttm_init’ [-Wmissing-prototypes]
817 | int radeon_ttm_init(struct radeon_device *rdev)
| ^~~
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/r600.c:1615:5: warning: no previous prototype for
‘r600_gpu_check_soft_reset’ [-Wmissing-prototypes]
1615 | u32 r600_gpu_check_soft_reset(struct radeon_device *rdev)
| ^
Cc: Alex Deucher
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/atombios_i2c.c:100:5: warning: no previous prototype
for ‘radeon_atom_hw_i2c_xfer’ [-Wmissing-prototypes]
100 | int radeon_atom_hw_i2c_xfer(struct i2c_adapter *i2c_adap,
| ^~~
This set contains fixes for some "wouldn't it be nice if" issues,
however most of the patches seen here have been on the MLs, but
were left unreviewed.
Lee Jones (42):
drm/amd/amdgpu/atombios_encoders: Remove set but unused variable
'backlight_level'
drm/armada/armada_overlay: Staticify
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1745:1: warning: no previous
prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes]
1745 | radeon_add_legacy_encoder(struct drm_device *dev, uint32_t
encoder_enum, uint32_t
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or member
'dev' not described in 'radeon_info_ioctl'
drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function parameter
'rdev' description in 'radeon_info_ioctl'
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/evergreen.c:4380:5: warning: no previous prototype for
‘evergreen_rlc_resume’ [-Wmissing-prototypes]
4380 | int evergreen_rlc_resume(struct radeon_device *rdev)
| ^~~~
Cc: Alex Deucher
Cc: "Christian
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_prime.c:34:18: warning: no previous prototype
for ‘radeon_gem_prime_get_sg_table’ [-Wmissing-prototypes]
34 | struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
|
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/evergreen.c:3825:5: warning: no previous prototype for
‘evergreen_gpu_check_soft_reset’ [-Wmissing-prototypes]
3825 | u32 evergreen_gpu_check_soft_reset(struct radeon_device *rdev)
| ^~
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/ni.c:1378:6: warning: no previous prototype for
‘cayman_cp_int_cntl_setup’ [-Wmissing-prototypes]
1378 | void cayman_cp_int_cntl_setup(struct radeon_device *rdev,
| ^~~~
Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg()
since, according to Alex Deucher, "We call it again below indirectly".
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/ni_dpm.c:727:23: warning: no previous prototype for
‘ni_get_pi’ [-Wmissing-prototypes]
727 | struct ni_power_info *ni_get_pi(struct radeon_device *rdev)
| ^
drivers/gpu/drm/radeon/ni_dpm.c:734:15: warning: no
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/cik.c:4845:5: warning: no previous prototype for
‘cik_gpu_check_soft_reset’ [-Wmissing-prototypes]
4845 | u32 cik_gpu_check_soft_reset(struct radeon_device *rdev)
| ^~~~
Cc: Alex Deucher
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/si.c:5678:5: warning: no previous prototype for
‘si_get_csb_size’ [-Wmissing-prototypes]
5678 | u32 si_get_csb_size(struct radeon_device *rdev)
| ^~~
drivers/gpu/drm/radeon/si.c:5710:6: warning: no previous
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or
member 'irq' not described in 'radeon_driver_irq_handler_kms'
drivers/gpu/drm/radeon/radeon_irq_kms.c:56: warning: Function parameter or
member 'arg' not described in
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/rv770_dpm.c:62:30: warning: no previous prototype for
‘evergreen_get_pi’ [-Wmissing-prototypes]
62 | struct evergreen_power_info *evergreen_get_pi(struct radeon_device *rdev)
| ^~~~
Cc: Alex Deucher
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/evergreen.c:1281:6: warning: no previous prototype for
‘evergreen_fix_pci_max_read_req_size’ [-Wmissing-prototypes]
1281 | void evergreen_fix_pci_max_read_req_size(struct radeon_device *rdev)
|
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_ttm.c: At top level:
drivers/gpu/drm/radeon/radeon_ttm.c:817:5: warning: no previous prototype for
‘radeon_ttm_init’ [-Wmissing-prototypes]
817 | int radeon_ttm_init(struct radeon_device *rdev)
| ^~~
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/vce_v2_0.c:111:6: warning: no previous prototype for
‘vce_v2_0_enable_mgcg’ [-Wmissing-prototypes]
111 | void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable)
| ^~~~
Cc: Alex Deucher
Cc:
[sending again, as `git send-email` crashed!]
This set contains fixes for some "wouldn't it be nice if" issues,
however most of the patches seen here have been on the MLs, but
were left unreviewed.
Lee Jones (42):
drm/amd/amdgpu/atombios_encoders: Remove set but unused variable
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/atombios_encoders.c:186:6: warning: no previous
prototype for ‘radeon_atom_backlight_init’ [-Wmissing-prototypes]
186 | void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder,
| ^~
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/r600_hdmi.c:177:6: warning: no previous prototype for
‘r600_hdmi_update_acr’ [-Wmissing-prototypes]
177 | void r600_hdmi_update_acr(struct drm_encoder *encoder, long offset,
| ^~~~
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/r600.c:3480:5: warning: no previous prototype for
‘r600_ih_ring_alloc’ [-Wmissing-prototypes]
3480 | int r600_ih_ring_alloc(struct radeon_device *rdev)
| ^~
drivers/gpu/drm/radeon/r600.c:3516:6: warning:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/dce3_1_afmt.c:30:6: warning: no previous prototype for
‘dce3_2_afmt_hdmi_write_speaker_allocation’ [-Wmissing-prototypes]
30 | void dce3_2_afmt_hdmi_write_speaker_allocation(struct drm_encoder
*encoder,
|
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_atombios.c:1791:6: warning: no previous
prototype for ‘radeon_atom_get_tv_timings’ [-Wmissing-prototypes]
1791 | bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index,
| ^~
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/vce_v1_0.c:102:6: warning: no previous prototype for
‘vce_v1_0_enable_mgcg’ [-Wmissing-prototypes]
102 | void vce_v1_0_enable_mgcg(struct radeon_device *rdev, bool enable)
| ^~~~
Cc: Alex Deucher
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/evergreen_hdmi.c:37:6: warning: no previous prototype
for ‘dce4_audio_enable’ [-Wmissing-prototypes]
drivers/gpu/drm/radeon/evergreen_hdmi.c:67:6: warning: no previous prototype
for ‘evergreen_hdmi_update_acr’
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1746:1: warning: no previous
prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes]
1746 | radeon_add_legacy_encoder(struct drm_device *dev, uint32_t
encoder_enum, uint32_t
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/rv770.c:1138:6: warning: no previous prototype for
‘rv770_set_clk_bypass_mode’ [-Wmissing-prototypes]
1138 | void rv770_set_clk_bypass_mode(struct radeon_device *rdev)
| ^
Cc: Alex Deucher
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/dce6_afmt.c:32:5: warning: no previous prototype for
‘dce6_endpoint_rreg’ [-Wmissing-prototypes]
32 | u32 dce6_endpoint_rreg(struct radeon_device *rdev,
| ^~
drivers/gpu/drm/radeon/dce6_afmt.c:46:6:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/ni.c:1733:5: warning: no previous prototype for
‘cayman_gpu_check_soft_reset’ [-Wmissing-prototypes]
1733 | u32 cayman_gpu_check_soft_reset(struct radeon_device *rdev)
| ^~~
Cc: Alex Deucher
Cc:
Unfortunately, a suitable one didn't already exist.
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype
for ‘radeon_device_is_virtual’ [-Wmissing-prototypes]
637 | bool radeon_device_is_virtual(void)
|
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/si.c:4186:6: warning: no previous prototype for
‘si_vram_gtt_location’ [-Wmissing-prototypes]
4186 | void si_vram_gtt_location(struct radeon_device *rdev,
| ^~~~
drivers/gpu/drm/radeon/si.c:5186:6:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_legacy_encoders.c:1746:1: warning: no previous
prototype for ‘radeon_add_legacy_encoder’ [-Wmissing-prototypes]
1746 | radeon_add_legacy_encoder(struct drm_device *dev, uint32_t
encoder_enum, uint32_t
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_irq_kms.c:53:13: warning: no previous prototype
for ‘radeon_driver_irq_handler_kms’ [-Wmissing-prototypes]
53 | irqreturn_t radeon_driver_irq_handler_kms(int irq, void *arg)
| ^
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_prime.c:43:24: warning: no previous prototype
for ‘radeon_gem_prime_import_sg_table’ [-Wmissing-prototypes]
43 | struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device
*dev,
|
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/si_dpm.c:3802:4: warning: no previous prototype for
‘si_get_ddr3_mclk_frequency_ratio’ [-Wmissing-prototypes]
3802 | u8 si_get_ddr3_mclk_frequency_ratio(u32 memory_clock)
| ^~~~
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/si.c:1570:5: warning: no previous prototype for
‘si_mc_load_microcode’ [-Wmissing-prototypes]
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: amd-gfx@lists.freedesktop.org
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/cik.c:6413:6: warning: no previous prototype for
‘cik_init_cp_pg_table’ [-Wmissing-prototypes]
6413 | void cik_init_cp_pg_table(struct radeon_device *rdev)
| ^~~~
drivers/gpu/drm/radeon/cik.c:6670:5:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/rv770_dpm.c:47:18: warning: no previous prototype for
‘rv770_get_ps’ [-Wmissing-prototypes]
47 | struct rv7xx_ps *rv770_get_ps(struct radeon_ps *rps)
| ^~~~
drivers/gpu/drm/radeon/rv770_dpm.c:54:26: warning: no
Unfortunately, a suitable one didn't already exist.
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype
for ‘radeon_device_is_virtual’ [-Wmissing-prototypes]
637 | bool radeon_device_is_virtual(void)
|
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/rv770.c:1138:6: warning: no previous prototype for
‘rv770_set_clk_bypass_mode’ [-Wmissing-prototypes]
1138 | void rv770_set_clk_bypass_mode(struct radeon_device *rdev)
| ^
Cc: Alex Deucher
Cc:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_kms.c:756:5: warning: no previous prototype for
‘radeon_get_vblank_counter_kms’ [-Wmissing-prototypes]
756 | u32 radeon_get_vblank_counter_kms(struct drm_crtc *crtc)
| ^
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or member
'dev' not described in 'radeon_info_ioctl'
drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function parameter
'rdev' description in 'radeon_info_ioctl'
Cc:
1 - 100 of 129 matches
Mail list logo
