[AMD Public Use]
Hi Guchun,
Thanks for your review.
Regards,
Stanley
> -Original Message-
> From: Chen, Guchun
> Sent: Wednesday, November 25, 2020 2:45 PM
> To: Yang, Stanley ; amd-gfx@lists.freedesktop.org;
> Chen, JingWen
> Subject: RE: [PATCH V2 1/1] drm/amdgpu: only skip smc
Please review. This fixes an LDS hang that occurs with NGG, but may occur
with other shader stages too.
Thanks,
Marek
From 89f7f1ff17b851b5bd513a6c7e7c26546b775d69 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?=
Date: Wed, 25 Nov 2020 01:40:51 -0500
Subject: [PATCH]
[AMD Public Use]
Okay. With that fixed, the patch is:
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: Yang, Stanley
Sent: Tuesday, November 24, 2020 10:37 PM
To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Chen,
JingWen
Subject: RE: [PATCH V2 1/1] drm/amdgpu:
Hi Luben,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.10-rc5 next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented
On 25/11/20 1:38 am, Harry Wentland wrote:
On 2020-11-24 10:55 a.m., Pratik Vishwakarma wrote:
[Why]
Changes in video resolution during playback cause
dispclk to ramp higher but sets incompatile fclk
and dcfclk values for MPO.
[How]
Check for MPO and set proper min clk values
for this case
[AMD Public Use]
Hi @Stanley.Yang,
I assume we could not add such patch directly, as it may break the KFD test for
Vega10 bare metal case.
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Stanley.Yang
Sent: Monday, November 23, 2020 9:14 PM
To:
Add a "done" list to which all completed jobs are added
to be freed. The drm_sched_job_done() callback is the
producer of jobs to this list.
Add a "done" thread which consumes from the done list
and frees up jobs. Now, the main scheduler thread only
pushes jobs to the GPU and the "done" thread
Introduce a macro DRM_THREAD_NAME_LEN
and use that to define ring name size,
instead of hardcoding it to 16.
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +-
include/drm/gpu_scheduler.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff
The job done callback is called from various
places, in two ways: in job done role, and
as a fence callback role.
Essentialize the callback to an atom
function to just complete the job,
and into a second function as a prototype
of fence callback which calls to complete
the job.
This is used in
The job timeout handler now returns status
indicating back to the DRM layer whether the job
was successfully cancelled or whether more time
should be given to the job to complete.
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 --
include/drm/gpu_scheduler.h
Rename "ring_mirror_list" to "pending_list",
to describe what something is, not what it does,
how it's used, or how the hardware implements it.
This also abstracts the actual hardware
implementation, i.e. how the low-level driver
communicates with the device it drives, ring, CAM,
etc., shouldn't
Hi guys,
This series of patches implements a pending list for
jobs which are in the hardware, and a done list for
tasks which are done and need to be freed.
It implements a second thread, dedicated to freeing
tasks from the done list. The main scheduler thread no
longer frees (cleans up) done
Rename "node" to "list" in struct drm_sched_job,
in order to make it consistent with what we see
being used throughout gpu_scheduler.h, for
instance in struct drm_sched_entity, as well as
the rest of DRM and the kernel.
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
I can test some more tonight. I'll also try to prepare a standalone
trace so you can observe the exact pattern being used on your end.
Vulkan traces tend to be GPU and driver-specific. We'll use Mesa as the
driver, but what GPU would be most convenient on your side for
replaying? On our end I
On 11/24/20 9:49 AM, Daniel Vetter wrote:
On Sat, Nov 21, 2020 at 12:21:20AM -0500, Andrey Grodzovsky wrote:
Avoids NULL ptr due to kobj->sd being unset on device removal.
Signed-off-by: Andrey Grodzovsky
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +++-
Hi Thomas.
Nice clean-up series - quite an effort to move one member to deprecated!
I have read through most of the patches. I left a few notes in my
replies but nothing buggy. Just nitpicks.
On Tue, Nov 24, 2020 at 12:38:09PM +0100, Thomas Zimmermann wrote:
> The pdev field in struct
Hi Thomas,
On Tue, Nov 24, 2020 at 12:38:24PM +0100, Thomas Zimmermann wrote:
> We have DRM drivers based on USB, SPI and platform devices. All of them
> are fine with storing their device reference in struct drm_device.dev.
> PCI devices should be no exception. Therefore struct drm_device.pdev
Hi Thomas.
On Tue, Nov 24, 2020 at 12:38:18PM +0100, Thomas Zimmermann wrote:
> Using struct drm_device.pdev is deprecated. Convert nouveau to struct
> drm_device.dev. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Ben Skeggs
Suggestion to an alternative implmentation
Hi Thomas.
On Tue, Nov 24, 2020 at 12:38:14PM +0100, Thomas Zimmermann wrote:
> Using struct drm_device.pdev is deprecated. Convert gma500 to struct
> drm_device.dev. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Patrik Jakobsson
This patch includes several whitespace
On 2020-11-24 10:55 a.m., Pratik Vishwakarma wrote:
[Why]
Changes in video resolution during playback cause
dispclk to ramp higher but sets incompatile fclk
and dcfclk values for MPO.
[How]
Check for MPO and set proper min clk values
for this case also. This was missed during previous
patch.
On 2020-11-24 12:40 p.m., Christian König wrote:
> Am 24.11.20 um 18:11 schrieb Luben Tuikov:
>> On 2020-11-24 2:50 a.m., Christian König wrote:
>>> Am 24.11.20 um 02:12 schrieb Luben Tuikov:
On 2020-11-23 3:06 a.m., Christian König wrote:
> Am 23.11.20 um 06:37 schrieb Andrey Grodzovsky:
On 2020-11-24 12:17 p.m., Andrey Grodzovsky wrote:
>
> On 11/24/20 12:11 PM, Luben Tuikov wrote:
>> On 2020-11-24 2:50 a.m., Christian König wrote:
>>> Am 24.11.20 um 02:12 schrieb Luben Tuikov:
On 2020-11-23 3:06 a.m., Christian König wrote:
> Am 23.11.20 um 06:37 schrieb Andrey
Am 24.11.20 um 18:11 schrieb Luben Tuikov:
On 2020-11-24 2:50 a.m., Christian König wrote:
Am 24.11.20 um 02:12 schrieb Luben Tuikov:
On 2020-11-23 3:06 a.m., Christian König wrote:
Am 23.11.20 um 06:37 schrieb Andrey Grodzovsky:
On 11/22/20 6:57 AM, Christian König wrote:
Am 21.11.20 um
Reviewed-by: Nirmoy Das
On 11/24/20 5:52 PM, Alex Deucher wrote:
No longer exists.
Fixes: fa7580010fde1b ("drm/amd/display: init soc bounding box for dcn3.01.")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 --
1 file changed, 2 deletions(-)
On 11/24/20 12:11 PM, Luben Tuikov wrote:
On 2020-11-24 2:50 a.m., Christian König wrote:
Am 24.11.20 um 02:12 schrieb Luben Tuikov:
On 2020-11-23 3:06 a.m., Christian König wrote:
Am 23.11.20 um 06:37 schrieb Andrey Grodzovsky:
On 11/22/20 6:57 AM, Christian König wrote:
Am 21.11.20 um
On 2020-11-24 2:50 a.m., Christian König wrote:
> Am 24.11.20 um 02:12 schrieb Luben Tuikov:
>> On 2020-11-23 3:06 a.m., Christian König wrote:
>>> Am 23.11.20 um 06:37 schrieb Andrey Grodzovsky:
On 11/22/20 6:57 AM, Christian König wrote:
> Am 21.11.20 um 06:21 schrieb Andrey Grodzovsky:
No longer exists.
Fixes: fa7580010fde1b ("drm/amd/display: init soc bounding box for dcn3.01.")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
Am 24.11.20 um 17:22 schrieb Andrey Grodzovsky:
On 11/24/20 2:41 AM, Christian König wrote:
Am 23.11.20 um 22:08 schrieb Andrey Grodzovsky:
On 11/23/20 3:41 PM, Christian König wrote:
Am 23.11.20 um 21:38 schrieb Andrey Grodzovsky:
On 11/23/20 3:20 PM, Christian König wrote:
Am 23.11.20
Applied. Thanks!
Alex
On Mon, Nov 23, 2020 at 7:42 PM Quan, Evan wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Reviewed-by: Evan Quan
>
> -Original Message-
> From: Colin King
> Sent: Monday, November 23, 2020 6:54 PM
> To: Deucher, Alexander ; Koenig, Christian
On Mon, Nov 23, 2020 at 6:21 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:382:23: warning:
> ‘ecc_umc_mcumc_status_addrs’ defined but not used [-Wunused-const-variable=]
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:720: warning:
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:382:23: warning:
> ‘ecc_umc_mcumc_status_addrs’ defined but not used [-Wunused-const-variable=]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc:
On Mon, Nov 23, 2020 at 6:21 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:618: warning: Function parameter or
> member 'flush_type' not described in 'gmc_v8_0_flush_gpu_tlb_pasid'
> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:618:
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:433: warning: Function parameter or
> member 'flush_type' not described in 'gmc_v7_0_flush_gpu_tlb_pasid'
> drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:433:
On 11/24/20 2:41 AM, Christian König wrote:
Am 23.11.20 um 22:08 schrieb Andrey Grodzovsky:
On 11/23/20 3:41 PM, Christian König wrote:
Am 23.11.20 um 21:38 schrieb Andrey Grodzovsky:
On 11/23/20 3:20 PM, Christian König wrote:
Am 23.11.20 um 21:05 schrieb Andrey Grodzovsky:
On 11/25/20
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:448: warning: Function parameter or
> member 'flags' not described in 'uvd_v4_2_ring_emit_fence'
> drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:448: warning:
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/cik_sdma.c:282: warning: Function parameter or
> member 'flags' not described in 'cik_sdma_ring_emit_fence'
> drivers/gpu/drm/amd/amdgpu/cik_sdma.c:282: warning:
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/dimgrey_cavefish_reg_init.c:28:
> drivers/gpu/drm/amd/amdgpu/../include/dimgrey_cavefish_ip_offset.h:151:29:
> warning: ‘UMC_BASE’ defined
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/gpu/drm/amd/amdgpu/vangogh_reg_init.c:28:
> drivers/gpu/drm/amd/amdgpu/../include/vangogh_ip_offset.h:210:29: warning:
> ‘USB_BASE’ defined but not used
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from
> drivers/gpu/drm/amd/amdgpu/sienna_cichlid_reg_init.c:28:
> drivers/gpu/drm/amd/amdgpu/../include/sienna_cichlid_ip_offset.h:186:29:
> warning: ‘USB0_BASE’ defined
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/gpu/drm/amd/amdgpu/navi12_reg_init.c:27:
> drivers/gpu/drm/amd/amdgpu/../include/navi12_ip_offset.h:179:29: warning:
> ‘USB0_BASE’ defined but not used
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/gpu/drm/amd/amdgpu/navi14_reg_init.c:27:
> drivers/gpu/drm/amd/amdgpu/../include/navi14_ip_offset.h:179:29: warning:
> ‘USB0_BASE’ defined but not used
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/gpu/drm/amd/amdgpu/arct_reg_init.c:27:
> drivers/gpu/drm/amd/amdgpu/../include/arct_ip_offset.h:227:29: warning:
> ‘DBGU_IO_BASE’ defined but not used
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/gpu/drm/amd/amdgpu/navi10_reg_init.c:27:
> drivers/gpu/drm/amd/amdgpu/../include/navi10_ip_offset.h:127:29: warning:
> ‘UMC_BASE’ defined but not used
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> In file included from drivers/gpu/drm/amd/amdgpu/vega20_reg_init.c:27:
> drivers/gpu/drm/amd/amdgpu/../include/vega20_ip_offset.h:154:29: warning:
> ‘XDMA_BASE’ defined but not used [-Wunused-const-variable=
> 154 | static const struct
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:192: warning: Function parameter or
> member 'async' not described in 'dce_v6_0_page_flip'
> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:1050: warning:
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:91: warning: Function parameter or
> member 'job' not described in 'uvd_v3_1_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c:91: warning:
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:1903: warning: Function parameter or
> member 'timeout' not described in 'gfx_v6_0_ring_test_ib'
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc:
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function parameter or
> member 'addr' not described in 'si_dma_ring_emit_fence'
> drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1590: warning: Function parameter or
> member 'instance' not described in 'gfx_v7_0_select_se_sh'
> drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:1788:
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/cik_sdma.c:226: warning: Function parameter or
> member 'job' not described in 'cik_sdma_ring_emit_ib'
> drivers/gpu/drm/amd/amdgpu/cik_sdma.c:226: warning:
On Tuesday, November 24, 2020 4:46 PM, Alex Deucher
wrote:
> On Fri, Nov 20, 2020 at 3:19 PM Simon Ser cont...@emersion.fr wrote:
>
> > Setting any rotation on the cursor plane is ignored by amdgpu.
> > Because of DCE/DCN design, it's not possible to rotate the cursor.
> > Instead of displaying
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:185: warning: Function parameter or
> member 'async' not described in 'dce_v8_0_page_flip'
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:157: warning: Function parameter or
> member 'handle' not described in 'uvd_v4_2_hw_init'
> drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c:157: warning: Excess
[Why]
Changes in video resolution during playback cause
dispclk to ramp higher but sets incompatile fclk
and dcfclk values for MPO.
[How]
Check for MPO and set proper min clk values
for this case also. This was missed during previous
patch.
Signed-off-by: Pratik Vishwakarma
---
On Mon, Nov 23, 2020 at 6:20 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:115: warning: Function parameter or
> member 'adev' not described in 'amdgpu_virt_request_full_gpu'
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:115:
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype
> for ‘radeon_device_is_virtual’ [-Wmissing-prototypes]
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc:
On 11/24/20 9:53 AM, Daniel Vetter wrote:
On Sat, Nov 21, 2020 at 12:21:18AM -0500, Andrey Grodzovsky wrote:
Some of the stuff in amdgpu_device_fini such as HW interrupts
disable and pending fences finilization must be done right away on
pci_remove while most of the stuff which relates to
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/cik_ih.c:189: warning: Function parameter or
> member 'ih' not described in 'cik_ih_get_wptr'
> drivers/gpu/drm/amd/amdgpu/cik_ih.c:274: warning: Function
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:127: warning: Function parameter or
> member 'job' not described in 'amdgpu_ib_schedule'
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: David
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1214: warning: Function parameter or
> member 'page_flags' not described in 'amdgpu_ttm_tt_create'
>
> Cc: Alex Deucher
> Cc: "Christian König"
>
On Fri, Nov 20, 2020 at 3:19 PM Simon Ser wrote:
>
> Setting any rotation on the cursor plane is ignored by amdgpu.
> Because of DCE/DCN design, it's not possible to rotate the cursor.
> Instead of displaying the wrong result, stop advertising the rotation
> property for the cursor plane.
>
> Now
[AMD Public Use]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Liu, Shaoyun
Sent: Tuesday, November 24, 2020 23:32
To: amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu/dce_virtual: Enable vBlank control for vf
[AMD Official Use
[AMD Official Use Only - Internal Distribution Only]
Ping
-Original Message-
From: Liu, Shaoyun
Sent: Monday, November 23, 2020 12:25 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun
Subject: [PATCH] drm/amdgpu/dce_virtual: Enable vBlank control for vf
This function actually
On Sat, Nov 21, 2020 at 12:21:18AM -0500, Andrey Grodzovsky wrote:
> Some of the stuff in amdgpu_device_fini such as HW interrupts
> disable and pending fences finilization must be done right away on
> pci_remove while most of the stuff which relates to finilizing and
> releasing driver data
On Sat, Nov 21, 2020 at 12:21:20AM -0500, Andrey Grodzovsky wrote:
> Avoids NULL ptr due to kobj->sd being unset on device removal.
>
> Signed-off-by: Andrey Grodzovsky
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +++-
> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 +++-
> 2 files
On Mon, Nov 23, 2020 at 08:38:46PM +, Mark Brown wrote:
> On Fri, 20 Nov 2020 12:21:39 -0600, Gustavo A. R. Silva wrote:
> > This series aims to fix almost all remaining fall-through warnings in
> > order to enable -Wimplicit-fallthrough for Clang.
> >
> > In preparation to enable
On Mon, Nov 23, 2020 at 04:03:45PM -0400, Jason Gunthorpe wrote:
> On Fri, Nov 20, 2020 at 12:21:39PM -0600, Gustavo A. R. Silva wrote:
>
> > IB/hfi1: Fix fall-through warnings for Clang
> > IB/mlx4: Fix fall-through warnings for Clang
> > IB/qedr: Fix fall-through warnings for Clang
> >
On Sat, Nov 21, 2020 at 03:16:15PM +0100, Christian König wrote:
> Am 21.11.20 um 06:21 schrieb Andrey Grodzovsky:
> > Invalidate all BOs CPU mappings once device is removed.
> >
> > v3: Move the code from TTM into drm_dev_unplug
> >
> > Signed-off-by: Andrey Grodzovsky
>
> Reviewed-by:
[AMD Public Use]
Hi Guchun,
This is an oversight. I forgot to remove it from patch version first.
Regards,
Stanley
> -Original Message-
> From: Chen, Guchun
> Sent: Tuesday, November 24, 2020 9:47 PM
> To: Yang, Stanley ; amd-gfx@lists.freedesktop.org;
> Chen, JingWen
> Cc: Yang,
On Tue, Nov 24, 2020 at 02:56:51PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 24.11.20 um 14:36 schrieb Christian König:
> > Am 24.11.20 um 13:15 schrieb Thomas Zimmermann:
> > > [SNIP]
> > > > > > > First I wanted to put this into
> > > > > > > drm_gem_ttm_vmap/vunmap(), but then wondered why
>
Am 24.11.20 um 14:56 schrieb Thomas Zimmermann:
Hi
Am 24.11.20 um 14:36 schrieb Christian König:
Am 24.11.20 um 13:15 schrieb Thomas Zimmermann:
[SNIP]
First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but
then wondered why ttm_bo_vmap() doe not acquire the lock
internally? I'd
Hi
Am 24.11.20 um 14:36 schrieb Christian König:
Am 24.11.20 um 13:15 schrieb Thomas Zimmermann:
[SNIP]
First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but
then wondered why ttm_bo_vmap() doe not acquire the lock
internally? I'd expect that vmap/vunmap are close together and do
[AMD Public Use]
--- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/vega10_smumgr.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/vega10_smumgr.c
@@ -208,14 +208,13 @@ static int vega10_smu_init(struct pp_hwmgr *hwmgr)
unsigned long tools_size;
int ret;
struct cgs_firmware_info
Am 24.11.20 um 13:15 schrieb Thomas Zimmermann:
[SNIP]
First I wanted to put this into drm_gem_ttm_vmap/vunmap(), but
then wondered why ttm_bo_vmap() doe not acquire the lock
internally? I'd expect that vmap/vunmap are close together and do
not overlap for the same BO.
We have use cases
Hi
Am 24.11.20 um 12:54 schrieb Christian König:
Am 24.11.20 um 12:44 schrieb Thomas Zimmermann:
Hi
Am 24.11.20 um 12:30 schrieb Christian König:
Am 24.11.20 um 10:16 schrieb Thomas Zimmermann:
Hi Christian
Am 16.11.20 um 12:28 schrieb Christian König:
Am 13.11.20 um 08:59 schrieb Thomas
Am 24.11.20 um 12:44 schrieb Thomas Zimmermann:
Hi
Am 24.11.20 um 12:30 schrieb Christian König:
Am 24.11.20 um 10:16 schrieb Thomas Zimmermann:
Hi Christian
Am 16.11.20 um 12:28 schrieb Christian König:
Am 13.11.20 um 08:59 schrieb Thomas Zimmermann:
Hi Christian
Am 12.11.20 um 18:16
Hi
Am 24.11.20 um 12:30 schrieb Christian König:
Am 24.11.20 um 10:16 schrieb Thomas Zimmermann:
Hi Christian
Am 16.11.20 um 12:28 schrieb Christian König:
Am 13.11.20 um 08:59 schrieb Thomas Zimmermann:
Hi Christian
Am 12.11.20 um 18:16 schrieb Christian König:
Am 12.11.20 um 14:21
Using struct drm_device.pdev is deprecated. Convert i915 to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
---
drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
Using struct drm_device.pdev is deprecated. Convert ast to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_drv.c | 4 ++--
drivers/gpu/drm/ast/ast_main.c | 25 +
drivers/gpu/drm/ast/ast_mm.c | 17
Using struct drm_device.pdev is deprecated. Convert vmwgfx to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Roland Scheidegger
---
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 8
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c| 27 +-
Using struct drm_device.pdev is deprecated. Convert qxl to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Gerd Hoffmann
---
drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
drivers/gpu/drm/qxl/qxl_ioctl.c | 3 ++-
drivers/gpu/drm/qxl/qxl_irq.c | 3 ++-
Using struct drm_device.pdev is deprecated. Convert radeon to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Alex Deucher
Cc: Christian König
---
drivers/gpu/drm/radeon/atombios_encoders.c| 6 +-
drivers/gpu/drm/radeon/r100.c | 27
We have DRM drivers based on USB, SPI and platform devices. All of them
are fine with storing their device reference in struct drm_device.dev.
PCI devices should be no exception. Therefore struct drm_device.pdev is
deprecated.
Instead upcast from struct drm_device.dev with to_pci_dev().
Using struct drm_device.pdev is deprecated. Convert vboxvideo to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Hans de Goede
---
drivers/gpu/drm/vboxvideo/vbox_drv.c | 11 ++-
drivers/gpu/drm/vboxvideo/vbox_irq.c | 4 +++-
Using struct drm_device.pdev is deprecated. Convert bochs to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Gerd Hoffmann
---
drivers/gpu/drm/bochs/bochs_drv.c | 1 -
drivers/gpu/drm/bochs/bochs_hw.c | 4 ++--
2 files changed, 2 insertions(+), 3
Using struct drm_device.pdev is deprecated. Convert virtgpu to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Gerd Hoffmann
---
drivers/gpu/drm/virtio/virtgpu_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c
Using struct drm_device.pdev is deprecated. Convert gma500 to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c| 30 +++---
drivers/gpu/drm/gma500/cdv_intel_crt.c | 3 +-
Using struct drm_device.pdev is deprecated. Convert nouveau to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Ben Skeggs
---
drivers/gpu/drm/nouveau/dispnv04/arb.c | 12 +++-
drivers/gpu/drm/nouveau/dispnv04/disp.h | 14 --
Using struct drm_device.pdev is deprecated. Convert mgag200 to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 20 +++-
drivers/gpu/drm/mgag200/mgag200_i2c.c | 2 +-
drivers/gpu/drm/mgag200/mgag200_mm.c
Using struct drm_device.pdev is deprecated. Convert hibmc to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Xinliang Liu
Cc: Tian Tao
Cc: John Stultz
Cc: Xinwei Kong
Cc: Chen Feng
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 10 +-
Using struct drm_device.pdev is deprecated. Convert amdgpu to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Alex Deucher
Cc: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 ++---
The pdev field in struct drm_device points to a PCI device structure and
goes back to UMS-only days when all DRM drivers where for PCI devices.
Meanwhile we also support USB, SPI and platform devices. Each of those
uses the generic device stored in struct drm_device.dev.
To reduce duplications
Using struct drm_device.pdev is deprecated. Convert cirrus to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Gerd Hoffmann
---
drivers/gpu/drm/tiny/cirrus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/cirrus.c
Am 24.11.20 um 10:16 schrieb Thomas Zimmermann:
Hi Christian
Am 16.11.20 um 12:28 schrieb Christian König:
Am 13.11.20 um 08:59 schrieb Thomas Zimmermann:
Hi Christian
Am 12.11.20 um 18:16 schrieb Christian König:
Am 12.11.20 um 14:21 schrieb Thomas Zimmermann:
In order to avoid eviction
The KFDTopologyTest.BasicTest will failed if skip smc, sdma, sos, ta
and asd fw in SRIOV for vega10, so adjust above fw and skip load them
in SRIOV only for navi12.
v2: remove unnecessary asic type check.
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 3
Hi Christian
Am 16.11.20 um 12:28 schrieb Christian König:
Am 13.11.20 um 08:59 schrieb Thomas Zimmermann:
Hi Christian
Am 12.11.20 um 18:16 schrieb Christian König:
Am 12.11.20 um 14:21 schrieb Thomas Zimmermann:
In order to avoid eviction of vmap'ed buffers, pin them in their GEM
object's
On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote:
> it's not for me to prove that such patches don't affect code
> generation. That's for the patch author and (unfortunately) for reviewers.
Ideally, that proof would be provided by the compilation system itself
and not patch authors nor
On Mon, 23 Nov 2020, Miguel Ojeda wrote:
> On Mon, 23 Nov 2020, Finn Thain wrote:
>
> > On Sun, 22 Nov 2020, Miguel Ojeda wrote:
> >
> > >
> > > It isn't that much effort, isn't it? Plus we need to take into
> > > account the future mistakes that it might prevent, too.
> >
> > We should
On Mon, 23 Nov 2020, Joe Perches wrote:
> On Tue, 2020-11-24 at 11:58 +1100, Finn Thain wrote:
> > it's not for me to prove that such patches don't affect code
> > generation. That's for the patch author and (unfortunately) for
> > reviewers.
>
> Ideally, that proof would be provided by the
Small register overlooked.
0001-Added-omitted-SMUIO-v11.0.0-register-ROM_SW_SECURE.patch
Description: Binary data
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
100 matches
Mail list logo
