RE: [PATCH] drm/amdgpu: do optimization for psp command submit

2020-12-24 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Emily.Deng >-Original Message- >From: amd-gfx On Behalf Of Peng >Ju Zhou >Sent: Friday, December 25, 2020 3:02 PM >To: amd-gfx@lists.freedesktop.org >Subject: [PATCH] drm/amdgpu: do optimization for psp command submit >

[PATCH] drm/amdgpu: do optimization for psp command submit

2020-12-24 Thread Peng Ju Zhou
From: pengzhou In the psp command submit logic, the function msleep(1) delayed too long, Changing it to usleep_range(10, 100) to have a better performance. Signed-off-by: Peng Ju Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

RE: [PATCH] drm/amdgpu: reduce the full access time by about 50ms

2020-12-24 Thread Zhou, Peng Ju
[AMD Official Use Only - Internal Distribution Only] Hi Paul 1. The 50 ms is the whole full access time reduced, not one msleep(1), During amdgpu driver init, it will hit msleep(1) several times which increased the total time of full access. I load amdgpu in the guest VM and collect

[PATCH] drm/amdgpu: reduce delay in psp command submit

2020-12-24 Thread Peng Ju Zhou
From: pengzhou In the psp command submit logic, the function msleep(1) can be delayed to 10+ ms sometimes, During the driver init, it will hit msleep(1) several times which increased the total time of full access. Changing msleep(1) to usleep_range(10, 100) and it can reduce about 50ms delay of

RE: [PATCH] drm/amdgpu: reduce the full access time by about 50ms

2020-12-24 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Emily.Deng >-Original Message- >From: amd-gfx On Behalf Of >pengzhou >Sent: Thursday, December 24, 2020 2:05 PM >To: amd-gfx@lists.freedesktop.org >Subject: [PATCH] drm/amdgpu: reduce the full access time by about 50ms >

Re: [PATCH] drm/amdgpu: reduce the full access time by about 50ms

2020-12-24 Thread Paul Menzel
Dear Peng Ju, Thank you for your patch. Am 24.12.20 um 07:04 schrieb pengzhou: Could you please configure your name in git: git config --global user.name "Peng Zhou" # or Peng Ju Zhou Also, please mention PSP in some way in the git commit message summary. Maybe: > drm/amdgpu: Reduce

Re: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h

2020-12-24 Thread Paul Menzel
Dear Chenyang, Am 23.12.20 um 02:19 schrieb Chenyang Li: In line 24 "_AMDGPU_TRACE_H" is missing an underscore. Nice catch. Could you please update the commit message summary, by adding a space after the prefix (colon), and using imperative mood [1]? drm/amdgpu: Fix macro name