[PATCH] drm/amdgpu/vcn3.0: add wptr/rptr reset/update for share memory

2021-02-10 Thread Sonny Jiang
Because of dpg, the rptr/wptr need to be saved on fw shared memory, and restore them back in RBC_RB_RPTR/WPTR in kernel at power up. Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 12 +++- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 24 +++- 2

[PATCH][next] drm/radeon/nislands_smc.h: Replace one-element array with flexible-array member in struct NISLANDS_SMC_SWSTATE

2021-02-10 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Use

[PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct _ATOM_Vega10_GFXCLK_Dependency_Table

2021-02-10 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Use

[PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE

2021-02-10 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2].

[pull] amdgpu drm-fixes-5.11

2021-02-10 Thread Alex Deucher
Hi Dave, Daniel, Just a single revert to fix a blank screen. The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3: Linux 5.11-rc7 (2021-02-07 13:57:38 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v4 11/14] drm/amdgpu: Guard against write accesses after device removal

2021-02-10 Thread Andrey Grodzovsky
On 2/9/21 10:40 AM, Christian König wrote: Am 09.02.21 um 15:30 schrieb Andrey Grodzovsky: [SNIP] Question - Why can't we just set those PTEs to point to system memory (another RO dummy page) filled with 1s ? Then writes are not discarded. E.g. the 1s would change to something else.

Re: [RFC PATCH 8/9] drm/gem: Associate GEM objects with drm cgroup

2021-02-10 Thread Brian Welty
On 2/9/2021 2:54 AM, Daniel Vetter wrote: > On Tue, Jan 26, 2021 at 01:46:25PM -0800, Brian Welty wrote: >> This patch adds tracking of which cgroup to make charges against for a >> given GEM object. We associate the current task's cgroup with GEM objects >> as they are created. First user of

Re: Why no spatial dithering to 10 bit depth on DCE?

2021-02-10 Thread Alex Deucher
On Wed, Feb 10, 2021 at 4:08 PM Mario Kleiner wrote: > > Resending this one as well, in the hope of some clarification or background > information. > I suspect this may have been a limitation from DCE11.0 (E.g., carrizo/stoney APUs). They had some bandwidth limitations with respect to high bit

[PATCH][next] drm/amd/display: Fix potential integer overflow

2021-02-10 Thread Gustavo A. R. Silva
Fix potential integer overflow by casting actual_calculated_clock_100hz to u64, in order to give the compiler complete information about the proper arithmetic to use. Notice that such variable is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following

Re: Why no spatial dithering to 10 bit depth on DCE?

2021-02-10 Thread Mario Kleiner
Resending this one as well, in the hope of some clarification or background information. Thanks, -mario On Mon, Jan 25, 2021 at 3:56 AM Mario Kleiner wrote: > Hi Harry and Nicholas, > > I'm still on an extended quest to squeeze as much HDR out of Linux + your > hw as possible, although the

Re: [PATCH 2/2] drm/amd/display: Fix HDMI deep color output for DCE 6-11.

2021-02-10 Thread Mario Kleiner
Ping. Any bit of info appreciated wrt. the DCE-11.2+ situation. -mario On Mon, Jan 25, 2021 at 8:24 PM Mario Kleiner wrote: > Thanks Alex and Nicholas! Brings quite a bit of extra shiny to those older > asics :) > > Nicholas, any thoughts on my cover-letter wrt. why a similar patch (that I >

Re: [PATCH 1/2] drm/amdgpu: do not keep debugfs dentry

2021-02-10 Thread Nirmoy
On 2/10/21 7:22 PM, Christian König wrote: Am 10.02.21 um 17:06 schrieb Nirmoy Das: Cleanup unwanted  debugfs dentries. Maybe write unnecessary instead of unwanted. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |  4 ---  

Re: [PATCH 1/2] drm/amdgpu: do not keep debugfs dentry

2021-02-10 Thread Christian König
Am 10.02.21 um 17:06 schrieb Nirmoy Das: Cleanup unwanted debugfs dentries. Maybe write unnecessary instead of unwanted. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 12 +++-

[PATCH 1/1] drm/amdgpu/display: remove hdcp_srm sysfs

2021-02-10 Thread Nirmoy Das
Fixes: 9037246bb2da5 ("drm/amd/display: Add sysfs interface for set/get srm") Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 3 ++- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.h | 2

[PATCH 2/2] drm/radeon: cleanup debugfs

2021-02-10 Thread Nirmoy Das
Remove unwanted debugfs dentries and also radeon_ttm_debugfs_fini() as drm_debugfs_cleanup() will recursively remove debugfs files. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon.h | 5 - drivers/gpu/drm/radeon/radeon_ttm.c | 24 +--- 2 files changed, 5

[PATCH 1/2] drm/amdgpu: do not keep debugfs dentry

2021-02-10 Thread Nirmoy Das
Cleanup unwanted debugfs dentries. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 12 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 34 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h

Re: [PATCH] Revert "drm/amd/display: reuse current context instead of recreating one"

2021-02-10 Thread Kazlauskas, Nicholas
On 2021-02-10 9:25 a.m., Alex Deucher wrote: This reverts commit 8866a67ab86cc0812e65c04f1ef02bcc41e24d68. This breaks hotplug of HDMI on some systems, resulting in a blank screen. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=211649>> Signed-off-by: Alex Deucher --- Hotplug is still

[PATCH] Revert "drm/amd/display: reuse current context instead of recreating one"

2021-02-10 Thread Alex Deucher
This reverts commit 8866a67ab86cc0812e65c04f1ef02bcc41e24d68. This breaks hotplug of HDMI on some systems, resulting in a blank screen. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=211649 Signed-off-by: Alex Deucher --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 +---

Re: [PATCH 05/27] drm/amd/display: reuse current context instead of recreating one

2021-02-10 Thread youling 257
test drm-next branch, can reproduce this problem. 2021-02-10 12:43 GMT+08:00, Alex Deucher : > On Tue, Feb 9, 2021 at 11:02 PM youling257 wrote: >> >> From: youling 257 >> >> This patch cause replug hdmi blackscreen, >> https://bugzilla.kernel.org/show_bug.cgi?id=211649 > > Can you test with my

[PATCH][next] drm/amd/pm: fix spelling mistake in various messages "power_dpm_force_perfomance_level"

2021-02-10 Thread Colin King
From: Colin Ian King There are spelling mistakes in error and warning messages, the text power_dpm_force_perfomance_level is missing a letter r and should be power_dpm_force_performance_level. Fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c |

Re: [PATCH] drm/amd/pm: do not issue message while write "r" into pp_od_clk_voltage

2021-02-10 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: Huang, Ray Sent: Tuesday, February 9, 2021 11:41 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Du, Xiaojian ; Huang, Ray Subject: [PATCH] drm/amd/pm: do not

Re: [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 08:45:56AM +0100, Christian König wrote: > Reviewed-by: Christian König for the series. Smash it into -misc? -Daniel > > Am 10.02.21 um 00:48 schrieb Rikard Falkeborn: > > Constify a few static vm_operations_struct that are never modified. Their > > only usage is to

Re: [RFC PATCH 8/9] drm/gem: Associate GEM objects with drm cgroup

2021-02-10 Thread Daniel Vetter
On Wed, Feb 10, 2021 at 08:52:29AM +0100, Thomas Zimmermann wrote: > Hi > > Am 09.02.21 um 11:54 schrieb Daniel Vetter: > > *: vmwgfx is the only non-gem driver, but there's plans to move at least > > vmwgfx internals (maybe not the uapi, we'll see) over to gem. Once that's > > done it's truly