On Thu, Nov 18, 2021 at 11:33 PM Alexei Starovoitov
wrote:
>
> On Thu, Nov 18, 2021 at 03:28:40PM -0500, Kenny Ho wrote:
> > + for_each_possible_cpu(cpu) {
> > + /* allocate first, connect the cgroup later */
> > + events[i] = perf_event_create_kernel_counter(attr,
[AMD Official Use Only]
Ping
-Original Message-
From: Liu, Shaoyun
Sent: Thursday, November 18, 2021 11:58 AM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun
Subject: [PATCH] drm/amd/amdgpu: move kfd post_reset out of reset_sriov function
For sriov XGMI configuration, the host
Seems reasonable.
Series is Acked-by: Luben Tuikov
Regards,
Luben
On 2021-11-18 14:54, Alex Deucher wrote:
> Apply the same check we do for dGPUs for APUs as well.
>
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 15 +--
> 1 file changed, 13
Applied. Thanks!
Alex
On Thu, Nov 18, 2021 at 5:57 AM Jiapeng Chong
wrote:
>
> Eliminate the follow smatch warning:
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/amd_powerplay.c:1554
> pp_asic_reset_mode_2() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng
On Thu, Nov 18, 2021 at 11:37 AM Amol wrote:
>
> Hello,
>
> The function radeon_get_atom_connector_info_from_object_table,
> at location [1], ends up parsing ATOM_COMMON_TABLE_HEADER
> as ATOM_COMMON_RECORD_HEADER if
> enc_obj->asObjects[k].usRecordOffset is zero. It is found to be zero
> in the
[Public]
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Ramesh
Errabolu
Sent: Thursday, November 18, 2021 5:11 PM
To: amd-gfx@lists.freedesktop.org
Cc: Errabolu, Ramesh ; kernel test robot
Subject: [PATCH] drm/amdgpu: Declare Unpin BO api as static
Fixes warning report from kernel test robot
Reported-by: kernel test robot
Signed-off-by: Ramesh Errabolu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
[AMD Official Use Only]
Reviewed-by: Graham Sider
> Remove unused entries in kfd_device_info table: num_xgmi_sdma_engines
> and num_sdma_queues_per_engine. They are calculated in
> kfd_get_num_sdma_engines and kfd_get_num_xgmi_sdma_engines
> instead.
>
> Signed-off-by: Amber Lin
> ---
>
Per an earlier discussion last year[1], I have been looking for a mechanism to
a) collect resource usages for devices (GPU for now but there could be other
device type in the future) and b) possibly enforce some of the resource usages.
An obvious mechanism was to use cgroup but there are too
Change-Id: Ie2580c3a71e2a5116551879358cb5304b04d3838
Signed-off-by: Kenny Ho
---
include/linux/trace_events.h | 9 +
kernel/trace/bpf_trace.c | 28
2 files changed, 37 insertions(+)
diff --git a/include/linux/trace_events.h
This provides the ability to allocate cgroup specific perf_event by
bpf-cgroup in later patch
Change-Id: I13aa7f3dfc2883ba3663c0b94744a6169504bbd8
Signed-off-by: Kenny Ho
---
include/linux/cgroup.h | 2 ++
include/linux/perf_event.h | 2 ++
kernel/cgroup/cgroup.c | 4 ++--
Remove unused entries in kfd_device_info table: num_xgmi_sdma_engines
and num_sdma_queues_per_engine. They are calculated in
kfd_get_num_sdma_engines and kfd_get_num_xgmi_sdma_engines instead.
Signed-off-by: Amber Lin
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 58 -
Apply the same check we do for dGPUs for APUs as well.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
Renoir and newer gfx9 APUs have new TSC register that is
not part of the gfxoff tile, so it can be read without
needing to disable gfx off.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 46 ---
1 file changed, 35 insertions(+), 11 deletions(-)
Am 2021-11-18 um 1:53 a.m. schrieb Alistair Popple:
> On Tuesday, 16 November 2021 6:30:18 AM AEDT Alex Sierra wrote:
>> Device memory that is cache coherent from device and CPU point of view.
>> This is used on platforms that have an advanced system bus (like CAPI
>> or CXL). Any page of a
Add debugfs hook.
Signed-off-by: Andrey Grodzovsky
Reviewed-by: Lijo Lazar
Reviewed-by: Luben Tuikov
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c| 2 +
drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 1 +
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 86 +++
3 files changed,
Add STB implementation for sienna_cichlid
Signed-off-by: Andrey Grodzovsky
Reviewed-by: Lijo Lazar
Reviewed-by: Luben Tuikov
---
.../amd/include/asic_reg/mp/mp_11_0_offset.h | 7 +++
.../amd/include/asic_reg/mp/mp_11_0_sh_mask.h | 12
.../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 55
Add interface to collect STB logs.
Signed-off-by: Andrey Grodzovsky
Reviewed-by: Lijo Lazar
Reviewed-by: Luben Tuikov
---
drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 15 +++
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 18 ++
2 files changed, 33 insertions(+)
diff
The Smart Trace Buffer (STB), is a cyclic data buffer used to
log information about system execution for characterization and debug
purposes. If at any point should a system encounter a functional
failure the trace can be collected without need for reproducing
the failure while running
[AMD Official Use Only]
Agree.
Patch applied. Thanks for your review
-Leo
-Original Message-
From: Alex Deucher
Sent: Thursday, November 18, 2021 12:02 PM
To: Ma, Leo
Cc: Kazlauskas, Nicholas ; amd-gfx list
; Deucher, Alexander
; Choi, Nicholas ; Wentland,
Harry
Subject: Re:
On Thu, Nov 18, 2021 at 11:53 AM Leo (Hanghong) Ma wrote:
>
> [Why & How]
> It doesn't make sense to guard DC_LOG_DP2 by CONFIG_DRM_AMD_DCN, and
> this also caused build failure for allmodconfig; So drop the guard
> to fix the compile failure;
>
> Signed-off-by: Leo (Hanghong) Ma
Reviewed-by:
For sriov XGMI configuration, the host driver will handle the hive reset,
so in guest side, the reset_sriov only be called once on one device. This will
make kfd post_reset unblanced with kfd pre_reset since kfd pre_reset already
been moved out of reset_sriov function. Move kfd post_reset out of
[Why & How]
It doesn't make sense to guard DC_LOG_DP2 by CONFIG_DRM_AMD_DCN, and
this also caused build failure for allmodconfig; So drop the guard
to fix the compile failure;
Signed-off-by: Leo (Hanghong) Ma
---
drivers/gpu/drm/amd/display/include/logger_types.h | 4
1 file changed, 4
On 2021-11-18 11:39 a.m., Felix
Kuehling wrote:
Am 2021-11-18 um 11:19 a.m. schrieb philip yang:
On 2021-11-17 7:14 p.m., Felix Kuehling wrote:
On 2021-11-16 10:43 p.m., Philip Yang wrote:
unmap
Am 2021-11-18 um 11:19 a.m. schrieb philip yang:
>
>
> On 2021-11-17 7:14 p.m., Felix Kuehling wrote:
>>
>> On 2021-11-16 10:43 p.m., Philip Yang wrote:
>>> unmap range always set svms->drain_pagefaults flag to simplify both
>>> parent range and child range unmap. Deferred list work takes mmap
Hello,
The function radeon_get_atom_connector_info_from_object_table,
at location [1], ends up parsing ATOM_COMMON_TABLE_HEADER
as ATOM_COMMON_RECORD_HEADER if
enc_obj->asObjects[k].usRecordOffset is zero. It is found to be zero
in the BIOS found at [2].
Thankfully, the loop that follows exits
On 2021-11-17 7:14 p.m., Felix Kuehling
wrote:
On 2021-11-16 10:43 p.m., Philip Yang wrote:
unmap range always set
svms->drain_pagefaults flag to simplify both
parent range and child range unmap. Deferred list
On Thu, Nov 18, 2021 at 10:01 AM Lazar, Lijo wrote:
>
> [Public]
>
>
> BTW, I'm not sure if 'reset always' on resume is a good idea for GPUs in a
> hive (assuming those systems also get suspended and get hiccups). At this
> point the hive isn't reinitialized.
Yeah, we should probably not
Am 2021-11-18 um 10:55 a.m. schrieb philip yang:
>
>
> On 2021-11-18 10:07 a.m., Felix Kuehling wrote:
>> Am 2021-11-18 um 10:00 a.m. schrieb philip yang:
>>> On 2021-11-17 7:10 p.m., Felix Kuehling wrote:
On 2021-11-16 10:43 p.m., Philip Yang wrote:
> VMA may be removed before unmap
On 2021-11-18 10:07 a.m., Felix
Kuehling wrote:
Am 2021-11-18 um 10:00 a.m. schrieb philip yang:
On 2021-11-17 7:10 p.m., Felix Kuehling wrote:
On 2021-11-16 10:43 p.m., Philip Yang wrote:
VMA may
On Thu, 18 Nov 2021 09:29:27 -0500
Jason Baron wrote:
> On 11/16/21 3:46 AM, Pekka Paalanen wrote:
> > On Fri, 12 Nov 2021 10:08:41 -0500
> > Jason Baron wrote:
> >
> >> On 11/12/21 6:49 AM, Vincent Whitchurch wrote:
> >>> On Thu, Nov 11, 2021 at 03:02:04PM -0700, Jim Cromie wrote:
>
Am 2021-11-18 um 10:00 a.m. schrieb philip yang:
>
>
> On 2021-11-17 7:10 p.m., Felix Kuehling wrote:
>> On 2021-11-16 10:43 p.m., Philip Yang wrote:
>>> VMA may be removed before unmap notifier callback, restore pages take
>>> mmap write lock to lookup VMA to avoid race,
>>
>> The old code looked
[Public]
BTW, I'm not sure if 'reset always' on resume is a good idea for GPUs in a
hive (assuming those systems also get suspended and get hiccups). At this point
the hive isn't reinitialized.
Thanks,
Lijo
On 2021-11-17 7:10 p.m., Felix Kuehling
wrote:
On
2021-11-16 10:43 p.m., Philip Yang wrote:
VMA may be removed before unmap notifier
callback, restore pages take
mmap write lock to lookup VMA to avoid race,
[AMD Official Use Only]
Series looks good to me.
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Lazar, Lijo
Sent: Thursday, November 18, 2021 22:41
To: Yang, Stanley ; amd-gfx@lists.freedesktop.org; Zhang,
Hawking ; Clements, John ; Quan,
Evan ; Wang,
On 11/18/2021 6:05 PM, Yang, Stanley wrote:
[AMD Official Use Only]
-邮件原件-
发件人: Lazar, Lijo
发送时间: Thursday, November 18, 2021 7:33 PM
收件人: Yang, Stanley ; amd-
g...@lists.freedesktop.org; Zhang, Hawking ;
Clements, John ; Quan, Evan
; Wang, Yang(Kevin)
主题: Re: [PATCH Review 3/4]
Eliminate the follow smatch warning:
drivers/gpu/drm/amd/amdgpu/../pm/powerplay/amd_powerplay.c:1554
pp_asic_reset_mode_2() warn: inconsistent indenting.
Reported-by: Abaci Robot
Signed-off-by: Jiapeng Chong
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 2 +-
1 file changed, 1
On 11/16/21 3:46 AM, Pekka Paalanen wrote:
> On Fri, 12 Nov 2021 10:08:41 -0500
> Jason Baron wrote:
>
>> On 11/12/21 6:49 AM, Vincent Whitchurch wrote:
>>> On Thu, Nov 11, 2021 at 03:02:04PM -0700, Jim Cromie wrote:
Sean Paul proposed, in:
On 2021-11-17 6:18 p.m., Felix Kuehling
wrote:
On
2021-11-16 10:43 p.m., Philip Yang wrote:
kfd process mmu release notifier callback
drain retry fault to ensure no
retry fault comes after removing kfd process from the
On 11/18/2021 7:55 PM, Alex Deucher wrote:
On Thu, Nov 18, 2021 at 9:15 AM Lazar, Lijo wrote:
On 11/18/2021 7:41 PM, Christian König wrote:
Am 18.11.21 um 15:09 schrieb Lazar, Lijo:
On 11/18/2021 7:36 PM, Alex Deucher wrote:
On Thu, Nov 18, 2021 at 8:11 AM Liang, Prike
wrote:
On Thu, Nov 18, 2021 at 9:15 AM Lazar, Lijo wrote:
>
>
>
> On 11/18/2021 7:41 PM, Christian König wrote:
> > Am 18.11.21 um 15:09 schrieb Lazar, Lijo:
> >> On 11/18/2021 7:36 PM, Alex Deucher wrote:
> >>> On Thu, Nov 18, 2021 at 8:11 AM Liang, Prike
> >>> wrote:
>
> [Public]
>
>
On 11/18/2021 7:41 PM, Christian König wrote:
Am 18.11.21 um 15:09 schrieb Lazar, Lijo:
On 11/18/2021 7:36 PM, Alex Deucher wrote:
On Thu, Nov 18, 2021 at 8:11 AM Liang, Prike
wrote:
[Public]
-Original Message-
From: Lazar, Lijo
Sent: Thursday, November 18, 2021 4:01 PM
To:
Am 18.11.21 um 15:09 schrieb Lazar, Lijo:
On 11/18/2021 7:36 PM, Alex Deucher wrote:
On Thu, Nov 18, 2021 at 8:11 AM Liang, Prike
wrote:
[Public]
-Original Message-
From: Lazar, Lijo
Sent: Thursday, November 18, 2021 4:01 PM
To: Liang, Prike ; amd-gfx@lists.freedesktop.org
Cc:
On 11/18/2021 7:36 PM, Alex Deucher wrote:
On Thu, Nov 18, 2021 at 8:11 AM Liang, Prike wrote:
[Public]
-Original Message-
From: Lazar, Lijo
Sent: Thursday, November 18, 2021 4:01 PM
To: Liang, Prike ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Huang, Ray
Subject:
On Thu, Nov 18, 2021 at 8:11 AM Liang, Prike wrote:
>
> [Public]
>
> > -Original Message-
> > From: Lazar, Lijo
> > Sent: Thursday, November 18, 2021 4:01 PM
> > To: Liang, Prike ; amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander ; Huang, Ray
> >
> > Subject: Re: [PATCH]
[Public]
> -Original Message-
> From: Lazar, Lijo
> Sent: Thursday, November 18, 2021 4:01 PM
> To: Liang, Prike ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Huang, Ray
>
> Subject: Re: [PATCH] drm/amdgpu: reset asic after system-wide suspend
> aborted
>
>
>
> On
[AMD Official Use Only]
> -邮件原件-
> 发件人: Lazar, Lijo
> 发送时间: Thursday, November 18, 2021 7:33 PM
> 收件人: Yang, Stanley ; amd-
> g...@lists.freedesktop.org; Zhang, Hawking ;
> Clements, John ; Quan, Evan
> ; Wang, Yang(Kevin)
> 主题: Re: [PATCH Review 3/4] drm/amdgpu: add message smu to
On 11/18/2021 3:03 PM, Stanley.Yang wrote:
support ECC TABLE message, this table include umc ras error count
and error address
v2:
add smu version check to query whether support ecctable
call smu_cmn_update_table to get ecctable directly
Signed-off-by: Stanley.Yang
---
[Public]
Reviewed-by: Guchun Chen
Regards,
Guchun
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Thursday, November 18, 2021 4:27 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Quan, Evan
; Koenig, Christian
Subject: [PATCH] drm/amdgpu: update the
[AMD Official Use Only]
Thanks Evan,
Will update patch 1 and 3 title before submit.
Regards,
Stanley
> -邮件原件-
> 发件人: Quan, Evan
> 发送时间: Thursday, November 18, 2021 5:58 PM
> 收件人: Yang, Stanley ; amd-
> g...@lists.freedesktop.org; Zhang, Hawking ;
> Clements, John ; Lazar, Lijo
> ;
[AMD Official Use Only]
Better to update the patch title as "drm/amd/pm: Update smu driver interface
for aldebaran" as all other power related patches.
And please update patch3 also.
Other than above, patch 1, 3 are reviewed-by: Evan Quan
> -Original Message-
> From: Stanley.Yang
>
if smu support ECCTABLE, driver can message smu to get ecc_table
then query umc error info from ECCTABLE
v2:
optimize source code makes logical more reasonable
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 42 +++
support ECC TABLE message, this table include umc ras error count
and error address
v2:
add smu version check to query whether support ecctable
call smu_cmn_update_table to get ecctable directly
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 8 +++
add message smu to query error information
v2:
rename message_smu to ecc_info
Signed-off-by: Stanley.Yang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 16 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h | 4 +
drivers/gpu/drm/amd/amdgpu/umc_v6_7.c | 161
3 files
update smu driver if version to 0x08 to avoid mismatch log
A version mismatch can still happen with an older FW
Change-Id: I97f2bc4ed9a9cba313b744e2ff6812c90b244935
Signed-off-by: Stanley.Yang
---
.../drm/amd/pm/inc/smu13_driver_if_aldebaran.h | 18 +-
On Tuesday, 16 November 2021 6:30:18 AM AEDT Alex Sierra wrote:
> Device memory that is cache coherent from device and CPU point of view.
> This is used on platforms that have an advanced system bus (like CAPI
> or CXL). Any page of a process can be migrated to such memory. However,
> no one
On Tuesday, 16 November 2021 6:30:23 AM AEDT Alex Sierra wrote:
> In order to configure device coherent in test_hmm, two module parameters
> should be passed, which correspond to the SP start address of each
> device (2) spm_addr_dev0 & spm_addr_dev1. If no parameters are passed,
> private device
On Tuesday, 16 November 2021 6:30:19 AM AEDT Alex Sierra wrote:
> This case is used to migrate pages from device memory, back to system
> memory. Device coherent type memory is cache coherent from device and CPU
> point of view.
>
> Signed-off-by: Alex Sierra
> ---
> v2:
> condition added when
After switching to generic framebuffer framework, we rely on the
->dumb_create routine for frame buffer creation. However, the
different domain flags used are not optimal. Add the contiguous
flag to directly allocate the scanout BO as one linear buffer.
Fixes: 844612e1149d ("drm/amdgpu: use
On 11/18/2021 12:32 PM, Prike Liang wrote:
Do ASIC reset at the moment Sx suspend aborted behind of amdgpu suspend
to keep AMDGPU in a clean reset state and that can avoid re-initialize
device improperly error.
Signed-off-by: Prike Liang
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1
60 matches
Mail list logo
