[PATCH v1 3/3] drm/amd/pm: vangogh: support to send SMT enable message

2023-03-21 Thread Wenyou Yang
Add the support to PPSMC_MSG_SetCClkSMTEnable(0x58) message to pmfw for vangogh. Signed-off-by: Wenyou Yang --- .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h| 3 ++- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 ++- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 19 +++

[PATCH v1 1/3] cpu/smt: add a notifier to notify the SMT changes

2023-03-21 Thread Wenyou Yang
Add the notifier chain to notify the cpu SMT status changes Signed-off-by: Wenyou Yang --- include/linux/cpu.h | 5 + kernel/cpu.c| 11 ++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/include/linux/cpu.h b/include/linux/cpu.h index

[PATCH v1 2/3] drm/amd/pm: send the SMT-enable message to pmfw

2023-03-21 Thread Wenyou Yang
When the CPU SMT status change in the fly, sent the SMT-enable message to pmfw to notify it that the SMT status changed. Signed-off-by: Wenyou Yang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 41 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 5 +++ 2 files

[PATCH v1 0/3] send message to pmfw when SMT changes

2023-03-21 Thread Wenyou Yang
When the CPU SMT changes on the fly, send the message to pmfw to notify the SMT status changed. Wenyou Yang (3): cpu/smt: add a notifier to notify the SMT changes drm/amd/pm: send the SMT-enable message to pmfw drm/amd/pm: vangogh: support to send SMT enable message

[PATCH] drm/amd/display: Clean up some inconsistent indenting

2023-03-21 Thread Jiapeng Chong
No functional modification involved. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4585 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/display: Remove the unused variable dppclk_delay_subtotal

2023-03-21 Thread Jiapeng Chong
Variable dppclk_delay_subtotal is not effectively used, so delete it. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:1004:15: warning: variable 'dppclk_delay_subtotal' set but not used. Reported-by: Abaci Robot Link:

RE: [PATCH] drm/amdgpu: skip unload tmr when tmr is not loaded

2023-03-21 Thread Chen, Guchun
> -Original Message- > From: Tong Liu01 > Sent: Wednesday, March 22, 2023 10:37 AM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Chen, Horace > ; Tuikov, Luben ; > Koenig, Christian ; Deucher, Alexander > ; Xiao, Jack ; Zhang, > Hawking ; Liu, Monk ; Xu, > Feifei ; Wang,

[PATCH] drm/amdgpu: skip unload tmr when tmr is not loaded

2023-03-21 Thread Tong Liu01
[why] For Navi12 and CHIP_SIENNA_CICHLID SRIOV, TMR is not loaded. Should also skip tmr unload Signed-off-by: Tong Liu01 --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

RE: [PATCH] drm/amdgpu: skip unload tmr when tmr is not loaded

2023-03-21 Thread Chen, Guchun
[Public] struct psp_gfx_cmd_resp *cmd = acquire_psp_cmd_buf(psp); + /* For Navi12 and CHIP_SIENNA_CICHLID SRIOV, do not set up TMR. +* Already set up by host driver. +*/ + if (amdgpu_sriov_vf(psp->adev) && psp_skip_tmr(psp)) + return 0; This

Re: [PATCH 25/32] drm/amdkfd: add debug suspend and resume process queues operation

2023-03-21 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: In order to inspect waves from the saved context at any point during a debug session, the debugger must be able to preempt queues to trigger context save by suspending them. On queue suspend, the KFD will copy the context save header information so

Re: [PATCH 24/32] drm/amdkfd: add debug wave launch mode operation

2023-03-21 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: Allow the debugger to set wave behaviour on to either normally operate, halt at launch, trap on every instruction, terminate immediately or stall on allocation. v2: add gfx11 support and remove deprecated launch mode options Signed-off-by: Jonathan Kim

Re: [PATCH 23/32] drm/amdkfd: add debug wave launch override operation

2023-03-21 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: This operation allows the debugger to override the enabled HW exceptions on the device. On debug devices that only support the debugging of a single process, the HW exceptions are global and set through the SPI_GDBG_TRAP_MASK register. Because they are

Re: [PATCH 21/32] drm/amdkfd: update process interrupt handling for debug events

2023-03-21 Thread Felix Kuehling
On 2023-01-25 14:53, Jonathan Kim wrote: The debugger must be notified by any debugger subscribed exception that comes from hardware interrupts. If a debugger session exits, any exceptions it subscribed to may still have interrupts in the interrupt ring buffer or KGD/KFD pipeline. To prevent

Re: [PATCH 07/11] drm/amdgpu: add UAPI to query GFX shadow sizes

2023-03-21 Thread Alex Deucher
On Mon, Mar 20, 2023 at 8:31 PM Marek Olšák wrote: > > On Mon, Mar 20, 2023 at 1:38 PM Alex Deucher > wrote: >> >> Add UAPI to query the GFX shadow buffer requirements >> for preemption on GFX11. UMDs need to specify the shadow >> areas for preemption. >> >> Signed-off-by: Alex Deucher >> ---

Re: [PATCH 07/11] drm/amdgpu: add UAPI to query GFX shadow sizes

2023-03-21 Thread Alex Deucher
On Mon, Mar 20, 2023 at 8:30 PM Marek Olšák wrote: > > > On Mon, Mar 20, 2023 at 1:38 PM Alex Deucher > wrote: >> >> Add UAPI to query the GFX shadow buffer requirements >> for preemption on GFX11. UMDs need to specify the shadow >> areas for preemption. >> >> Signed-off-by: Alex Deucher >>

[PATCH] drm/amd/display: Slightly optimize dm_dmub_outbox1_low_irq()

2023-03-21 Thread Christophe JAILLET
A kzalloc()+memcpy() can be optimized in a single kmemdup(). This saves a few cycles because some memory doesn't need to be zeroed. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

RE: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-21 Thread Sider, Graham
[Public] > -Original Message- > From: Christian König > Sent: Tuesday, March 21, 2023 2:53 PM > To: Sider, Graham ; Russell, Kent > ; Mahfooz, Hamza ; > amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: Re: [PATCH] drm/amdgpu: add print for iommu translation mode > >

[PATCH 2/2] drm/amdgpu: add debugfs interface for reading MQDs

2023-03-21 Thread Alex Deucher
Provide a debugfs interface to access the MQD. Useful for debugging issues with the CP and MES hardware scheduler. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 60 +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] drm/amdgpu: track MQD size for gfx and compute

2023-03-21 Thread Alex Deucher
It varies by generation and we need to know the size to expose this via debugfs. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + 2 files changed, 3 insertions(+) diff --git

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

2023-03-21 Thread Christian König
Am 17.03.23 um 15:45 schrieb Alex Deucher: On Thu, Mar 16, 2023 at 7:09 PM Stefano Stabellini wrote: On Thu, 16 Mar 2023, Juergen Gross wrote: On 16.03.23 14:53, Alex Deucher wrote: On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote: On 16.03.23 14:45, Alex Deucher wrote: On Thu, Mar 16,

Re: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-21 Thread Christian König
Am 17.03.23 um 21:04 schrieb Sider, Graham: [AMD Official Use Only - General] -Original Message- From: Russell, Kent Sent: Friday, March 17, 2023 3:58 PM To: Mahfooz, Hamza ; Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: RE: [PATCH] drm/amdgpu: add

Re: BUG: KASAN: slab-use-after-free in drm_sched_get_cleanup_job+0x47b/0x5c0 [gpu_sched]

2023-03-21 Thread Christian König
Hi Mikhail, Am 20.03.23 um 13:05 schrieb Mikhail Gavrilov: Hi, after enabling KASAN literally I was bombarded with messages about slab-use-after-free in drm_sched_get_cleanup_job. mhm, interesting. All messages has similar backtrace: [ 1138.492091]

[linux-next:master] BUILD REGRESSION f3594f0204b756638267242e26d9de611435c3ba

2023-03-21 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: f3594f0204b756638267242e26d9de611435c3ba Add linux-next specific files for 20230321 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202303082135.njdx1bij-...@intel.com https

Re: [PATCH 02/11] drm/amdgpu/gfx11: check the CP FW version CP GFX shadow support

2023-03-21 Thread Christian König
Am 20.03.23 um 18:38 schrieb Alex Deucher: Only set the supported flag if we have new enough CP FW. XXX: don't commit this until the CP FW versions are finalized! Signed-off-by: Alex Deucher Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 9 + 1 file

RE: [PATCH 00/19] DC Patches Mar 20th, 2023

2023-03-21 Thread Wheeler, Daniel
[AMD Official Use Only - General] Hi all, This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2, with AMD Ryzen 5 5650U Lenovo Thinkpad T13s Gen4 with AMD Ryzen 5 6600U Reference AMD RX6800 These systems were tested on the following display types: eDP,

Re: [PATCH] drm/amdgpu: skip unload tmr when tmr is not loaded

2023-03-21 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Tong Liu01 Sent: Tuesday, March 21, 2023 5:19 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Chen, Horace ; Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang, Hawking ; Liu01, Tong

Re: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-21 Thread Christian König
Yes, I would like to avoid having multiple code paths for context creation. Setting it later on should be equally to specifying it on creation since we only need it during CS. Regards, Christian. Am 21.03.23 um 14:00 schrieb Sharma, Shashank: [AMD Official Use Only - General] When we

[PATCH] tests/amdgpu: Allow to exclude a test or a suite of tests

2023-03-21 Thread Luben Tuikov
Add the command line argument -e s[.t] to exclude (disable) suite s, or to exclude suite s test t. This is useful for instance to run the Basic Suite, but disable the GPU reset test, on the command line, like this: amdgpu_tests -s 1 -e 1.13 This option can be specified more than once on the

Re: [PATCH v2 00/21] Enable Colorspace connector property in amdgpu

2023-03-21 Thread Sebastian Wick
FWIW, I still think this series is good (minus the UAPI changes) and would allow us to work on user space HDR support without custom kernels. On Fri, Jan 13, 2023 at 5:24 PM Harry Wentland wrote: > > This patchset enables the DP and HDMI infoframe properties > in amdgpu. > > The first two

RE: [PATCH 3/3] drm/amdgpu: resume ras for gfx v11_0_3 during reset on SRIOV

2023-03-21 Thread Yang, Stanley
[AMD Official Use Only - General] The series is Reviewed-by: Stanley Yang Regards, Stanley > -Original Message- > From: amd-gfx On Behalf Of > YiPeng Chai > Sent: Tuesday, March 21, 2023 10:40 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao ; Zhang, Hawking > ; Chai, Thomas ;

RE: [PATCH v3 1/5] drm/amdgpu: add UAPI for workload hints to ctx ioctl

2023-03-21 Thread Sharma, Shashank
[AMD Official Use Only - General] When we started this patch series, the workload hint was a part of the ctx_flag only, But we changed that after the design review, to make it more like how we are handling PSTATE. Details: https://patchwork.freedesktop.org/patch/496111/ Regards Shashank

Re: [PATCH 00/10] drm/radeon: Convert fbdev to DRM client

2023-03-21 Thread Thomas Zimmermann
Hi Am 20.03.23 um 16:23 schrieb Alex Deucher: On Mon, Mar 20, 2023 at 11:19 AM Thomas Zimmermann wrote: Hi Am 20.03.23 um 16:11 schrieb Christian König: Am 17.03.23 um 10:20 schrieb Thomas Zimmermann: Hi Christian Am 17.03.23 um 09:53 schrieb Christian König: Am 16.03.23 um 10:37

[PATCH] drm/amdgpu: skip unload tmr when tmr is not loaded

2023-03-21 Thread Tong Liu01
[why] For Navi12 and CHIP_SIENNA_CICHLID SRIOV, TMR is not loaded. Should also skip tmr unload Signed-off-by: Tong Liu01 --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c