Re: [PATCH] Revert "drm/amdgpu: remove TOPDOWN flags when allocating VRAM in large bar system"

2023-05-26 Thread Arunpravin Paneer Selvam
On 5/22/2023 8:52 AM, Xiao, Shane wrote: [AMD Official Use Only - General] -Original Message- From: Kuehling, Felix Sent: Sunday, May 21, 2023 2:39 AM To: Paneer Selvam, Arunpravin ; amd- g...@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Xiao, Shane Subject:

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
With the documentation about RGB and YCC variants added the drm core patches are Reviewed-by: Sebastian Wick On Fri, May 26, 2023 at 6:24 PM Sebastian Wick wrote: > > On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > > > On Thu, 25 May 2023 15:17:56 -0400 > > Harry Wentland wrote: >

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:37 PM Simon Ser wrote: > > On Friday, May 26th, 2023 at 18:27, Sebastian Wick > wrote: > > > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > > + * Driver specific behavior. > > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > > + * Driver specific behavior. > > > > TBH this is still

Re: [PATCH v4 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-05-26 Thread Simon Ser
On Friday, May 26th, 2023 at 18:40, Sebastian Wick wrote: > On Thu, May 25, 2023 at 9:18 PM Harry Wentland harry.wentl...@amd.com wrote: > > > We want compositors to be able to set the output > > colorspace on DP and HDMI outputs, based on the > > caps reported from the receiver via EDID. > >

Re: [PATCH v4 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-05-26 Thread Sebastian Wick
On Thu, May 25, 2023 at 9:18 PM Harry Wentland wrote: > > We want compositors to be able to set the output > colorspace on DP and HDMI outputs, based on the > caps reported from the receiver via EDID. This commit message seems wrong for multiple reasons. The Colorspace property documentation

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Simon Ser
On Friday, May 26th, 2023 at 18:27, Sebastian Wick wrote: > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > + * Driver specific behavior. > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > + * Driver specific behavior. > > TBH this is still confusing me. Is DEFAULT really just driver specific > behavior?

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Thu, May 25, 2023 at 9:18 PM Harry Wentland wrote: > > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" > -

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > On Thu, 25 May 2023 15:17:56 -0400 > Harry Wentland wrote: > > > This patchset is based on Joshua's previous patchset [1], as well > > as my previous patchset [2]. > > > > It is > > - enabling support for the colorspace property in

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Pekka Paalanen
On Thu, 25 May 2023 15:17:56 -0400 Harry Wentland wrote: > This patchset is based on Joshua's previous patchset [1], as well > as my previous patchset [2]. > > It is > - enabling support for the colorspace property in amdgpu, as well as > - allowing drivers to specify the supported set of

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Pekka Paalanen
On Thu, 25 May 2023 15:17:58 -0400 Harry Wentland wrote: > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" >

Re: [v4,12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-26 Thread Thomas Zimmermann
Hi Am 24.05.23 um 22:23 schrieb Sui Jingfeng: Tested-by: Sui Jingfeng This version works fine, I have tested it On LoongArch with drm/loongson(v14) as it is most handy for me. Also because it using fbdev-generic. fbdev of IGT report no error. Then I run fbtest from geert[1], Before

Re: [v4,02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-26 Thread Thomas Zimmermann
Hi Am 24.05.23 um 22:57 schrieb Sui Jingfeng: Hi, we love your patch: On 2023/5/24 17:21, Thomas Zimmermann wrote: For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback

[PATCH] drm: Remove unnecessary (void*) conversions

2023-05-26 Thread Su Hui
Pointer variables of (void*) type do not require type cast. Signed-off-by: Su Hui --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- drivers/gpu/drm/amd/pm/amdgpu_pm.c| 2 +- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--

Re: [PATCH] drm/amdgpu: add the accelerator pcie class

2023-05-26 Thread Christoph Hellwig
On Thu, May 25, 2023 at 08:52:06PM +, Deucher, Alexander wrote: > We already handle this today for CLASS_DISPLAY via a data table provided on > our hardware that details the components on the board. The driver can then > determine whether or not that combination of components is supported.

Re: [PATCH] drm/amdgpu: add a flag to indicate if a VM is attached to fpriv

2023-05-26 Thread Christian König
Am 24.05.23 um 11:23 schrieb Guchun Chen: Recent code stores xcp_id to amdgpu bo for accounting memory usage or find correct KFD node, and this xcp_id is from file private data after opening device. However, not all VMs are attached to this fpriv structure like the case in amdgpu_mes_self_test.

Re: [PATCH] drm: Remove unnecessary (void*) conversions

2023-05-26 Thread Christian König
Am 26.05.23 um 05:32 schrieb Su Hui: Pointer variables of (void*) type do not require type cast. Please split that up by subsystem/driver. Taking it through the misc tree might just cause merge conflicts. Christian. Signed-off-by: Su Hui ---

Re: [PATCH 1/2] drm/amdgpu: Fix no-procfs build

2023-05-26 Thread Neil Armstrong
Hi, On Thu, 25 May 2023 08:52:24 -0700, Rob Clark wrote: > Fixes undefined symbol when PROC_FS is not enabled. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] drm/amdgpu: Fix no-procfs build

Re: [PATCH 2/2] drm/amdgpu: Remove duplicate fdinfo fields

2023-05-26 Thread Neil Armstrong
Hi Rob, On 25/05/2023 17:52, Rob Clark wrote: From: Rob Clark Some of the fields that are handled by drm_show_fdinfo() crept back in when rebasing the patch. Remove them again. Fixes: 376c25f8ca47 ("drm/amdgpu: Switch to fdinfo helper") Signed-off-by: Rob Clark ---