[PATCH] drm/amdgpu: Print client id for the unregistered interrupt resource

2023-06-08 Thread Ma Jun
Modify the debug information and print the clien id for these interrupts as well. Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c

Re: [PATCH] drm/amdgpu: Raname DRM schedulers in amdgpu TTM

2023-06-08 Thread Christian König
Am 07.06.23 um 17:26 schrieb Mukul Joshi: Rename mman.entity to mman.high_pr to make the distinction clearer that this is a high priority scheduler. Similarly, rename the recently added mman.delayed to mman.low_pr to make it clear it is a low priority scheduler. No functional change in this

Re: [PATCH] drm/amd/pm: workaround for compute workload type on some skus

2023-06-08 Thread Lazar, Lijo
On 6/9/2023 8:25 AM, Kenneth Feng wrote: On smu 13.0.0, the compute workload type cannot be set on all the skus due to some other problems. This workaround is to make sure compute workload type can also run on some specific skus. Signed-off-by: Kenneth Feng ---

[PATCH] Align eccinfo table structure with smu v13_0_0 interface

2023-06-08 Thread Candice Li
Update eccinfo table structure according to smu v13_0_0 interface. Signed-off-by: Candice Li Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/umc_v8_10.h | 3 +++ drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)

RE: [PATCH] drm/amd/pm: workaround for compute workload type on some skus

2023-06-08 Thread Xu, Feifei
[AMD Official Use Only - General] Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Kenneth Feng Sent: Friday, June 9, 2023 10:56 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: workaround for compute workload type on

[PATCH] drm/amd/pm: workaround for compute workload type on some skus

2023-06-08 Thread Kenneth Feng
On smu 13.0.0, the compute workload type cannot be set on all the skus due to some other problems. This workaround is to make sure compute workload type can also run on some specific skus. Signed-off-by: Kenneth Feng --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 26 +++ 1

Re: [PATCH v3] drm/amd/pm: enable more Pstates profile levels for yellow_carp

2023-06-08 Thread Huang, Tim
[Public] Hi Shikai From: Guo, Shikai Sent: Thursday, June 8, 2023 6:27 PM To: amd-gfx@lists.freedesktop.org Cc: Liang, Prike ; Liu, Aaron ; Huang, Tim ; Deucher, Alexander ; Guo, Shikai Subject: [PATCH v3] drm/amd/pm: enable more Pstates profile levels for

RE: [PATCH v4] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-08 Thread Lin, Wayne
[Public] > -Original Message- > From: Jani Nikula > Sent: Thursday, June 8, 2023 8:26 PM > To: Lin, Wayne ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org > Cc: ly...@redhat.com; ville.syrj...@linux.intel.com; imre.d...@intel.com; > Wentland, Harry ; Zuo, Jerry > ; Lin,

[PATCH v2] drm/amdkfd: To enable traps for GC_11_0_4 and up

2023-06-08 Thread Ji, Ruili
From: Ruili Ji Flag trap_en should be enabled for trap handler. Signed-off-by: Ruili Ji Signed-off-by: Aaron Liu Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-08 Thread Sui Jingfeng
Hi, On 2023/6/9 03:19, Bjorn Helgaas wrote: On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, which doesn't sound right. At least, it also works on the Mips and LoongArch platforms. Tested with the

Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

2023-06-08 Thread Sui Jingfeng
Hi, On 2023/6/9 03:12, Bjorn Helgaas wrote: Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function

Re: [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format

2023-06-08 Thread Sui Jingfeng
Hi, On 2023/6/9 03:07, Bjorn Helgaas wrote: Capitalize subject to match ("Tidy ...") On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng This patch replaces the leading space with a tab and removes the double blank line, no functional change. Can you move this

Re: [PATCH] drm/amdgpu: add the accelerator pcie class

2023-06-08 Thread Bjorn Helgaas
s/pcie/PCIe/ in the subject. On Tue, May 23, 2023 at 12:02:32PM +0800, Shiwu Zhang wrote: > v2: add the base class id for accelerator (lijo) Please include a commit log. For PCI, the "v2: ..." stuff would go below the "---" so it doesn't get included in the git commit. I don't know what the

Re: [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-08 Thread Bjorn Helgaas
On Thu, Jun 08, 2023 at 07:43:22PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The vga_is_firmware_default() function is arch-dependent, which doesn't > sound right. At least, it also works on the Mips and LoongArch platforms. > Tested with the drm/amdgpu and drm/radeon drivers. However,

Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

2023-06-08 Thread Bjorn Helgaas
Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the > pci_get_subsys() function with pci_get_class(). Filter the non pci

Re: [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format

2023-06-08 Thread Bjorn Helgaas
Capitalize subject to match ("Tidy ...") On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > This patch replaces the leading space with a tab and removes the double > blank line, no functional change. Can you move this to the end of the series? The

Re: [PATCH] drm/amdgpu: Wrap -Wunused-but-set-variable in cc-option

2023-06-08 Thread Hamza Mahfooz
ase-commit: 6bd4b01e8938779b0d959bdf33949a9aa258a363 change-id: 20230608-amdgpu-wrap-wunused-but-set-variable-in-cc-option-0be9528ac5c8 Best regards, -- Hamza

[PATCH v3 1/5] drm/amdkfd: add event age tracking

2023-06-08 Thread James Zhu
Add event age tracking Signed-off-by: James Zhu --- include/uapi/linux/kfd_ioctl.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h index 1781e7669982..93f1c0bc5caf 100644 ---

[PATCH v3 2/5] drm/amdkfd: add event_age tracking when receiving interrupt

2023-06-08 Thread James Zhu
Add event_age tracking when receiving interrupt. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 6 ++ drivers/gpu/drm/amd/amdkfd/kfd_events.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_events.c

[PATCH v3 0/5] new event wait support

2023-06-08 Thread James Zhu
In kernel amdgpu driver, kfd_wait_on_events is used to support user space signal event wait function. For multiple threads waiting on same event scenery, race condition could occur since some threads after checking signal condition, before calling kfd_wait_on_events, the event interrupt could

[PATCH v3 4/5] drm/amdkfd: update user space last_event_age

2023-06-08 Thread James Zhu
Update user space last_event_age when event age is enabled. It is only for KFD_EVENT_TYPE_SIGNAL which is checked by user space. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git

[PATCH v3 5/5] drm/amdkfd: bump kfd ioctl minor version for event age availability

2023-06-08 Thread James Zhu
Bump the minor version to declare event age tracking feature is now available. Signed-off-by: James Zhu --- include/uapi/linux/kfd_ioctl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h index

[PATCH v3 3/5] drm/amdkfd: set activated flag true when event age unmatchs

2023-06-08 Thread James Zhu
Set waiter's activated flag true when event age unmatchs with last_event_age. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_events.c

[PATCH] drm/amdgpu: Wrap -Wunused-but-set-variable in cc-option

2023-06-08 Thread Nathan Chancellor
le +subdir-ccflags-y += $(call cc-option, -Wunused-but-set-variable) subdir-ccflags-y += -Wno-unused-parameter subdir-ccflags-y += -Wno-type-limits subdir-ccflags-y += -Wno-sign-compare --- base-commit: 6bd4b01e8938779b0d959bdf33949a9aa258a363 change-id: 20230608-amdgpu-wrap-wunused-but-se

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2023-06-08 Thread Lucas Stach
Hi all, and almost 2 years later I stumbled across this exact issue still being present in the scheduler: if the driver bails out of the timeout handling before calling drm_sched_stop(), the timeout job will be leaked and the TDR timer will potentially not be restarted as the job isn't put back

Re: [PATCH] drm/amdgpu: vcn_4_0 set instance 0 init sched score to 1

2023-06-08 Thread Liu, Leo
[Public] Reviewed-by: Leo Liu From: amd-gfx on behalf of Sonny Jiang Sent: June 8, 2023 10:54 AM To: amd-gfx@lists.freedesktop.org Cc: Jiang, Sonny Subject: [PATCH] drm/amdgpu: vcn_4_0 set instance 0 init sched score to 1 From: Sonny Jiang Only vcn0 can

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-08 Thread Michel Dänzer
On 6/8/23 16:31, Pillai, Aurabindo wrote: > > Thanks Michel, > > I reached out to windows driver team, and they have a monitor specific quirk > to disable FAMS on this model. I suspect the issue is only present on certain > fw revisions on the monitor which is why we cant see your issue. > >

[PATCH] drm/amdgpu: vcn_4_0 set instance 0 init sched score to 1

2023-06-08 Thread Sonny Jiang
From: Sonny Jiang Only vcn0 can process AV1 codecx. In order to use both vcn0 and vcn1 in h264/265 transcode to AV1 cases, set vcn0 sched score to 1 at initialization time. Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-08 Thread Pillai, Aurabindo
[Public] Thanks Michel, I reached out to windows driver team, and they have a monitor specific quirk to disable FAMS on this model. I suspect the issue is only present on certain fw revisions on the monitor which is why we cant see your issue. Unfortunately, having the patches in question

Re: [PATCH 10/66] drm/amd/display: Do not set drr on pipe commit

2023-06-08 Thread Michel Dänzer
On 6/7/23 19:35, Pillai, Aurabindo wrote: > > Do you see the issue if you force disable FAMS? Neither hang occurs with FAMS disabled. -- Earthling Michel Dänzer| https://redhat.com Libre software enthusiast | Mesa and Xwayland developer

Re: [PATCH v4] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-08 Thread Jani Nikula
On Thu, 08 Jun 2023, Wayne Lin wrote: > [Why] > The sequence for collecting down_reply from source perspective should > be: > > Request_n->repeat (get partial reply of Request_n->clear message ready > flag to ack DPRX that the message is received) till all partial > replies for Request_n are

[PATCH v4] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-06-08 Thread Wayne Lin
[Why] The sequence for collecting down_reply from source perspective should be: Request_n->repeat (get partial reply of Request_n->clear message ready flag to ack DPRX that the message is received) till all partial replies for Request_n are received->new Request_n+1. Now there is chance that

[PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-08 Thread Sui Jingfeng
From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, which doesn't sound right. At least, it also works on the Mips and LoongArch platforms. Tested with the drm/amdgpu and drm/radeon drivers. However, it's difficult to enumerate all arch-driver combinations. I'm wrong if

[PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

2023-06-08 Thread Sui Jingfeng
From: Sui Jingfeng vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non pci display device out. There no need to process the non display PCI device. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 22

[PATCH v3 1/4] PCI/VGA: tidy up the code and comment format

2023-06-08 Thread Sui Jingfeng
From: Sui Jingfeng This patch replaces the leading space with a tab and removes the double blank line, no functional change. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 26 +- include/linux/vgaarb.h | 8 +++- 2 files changed, 16 insertions(+), 18

[PATCH v3 2/4] PCI/VGA: Use unsigned type for the io_state variable

2023-06-08 Thread Sui Jingfeng
From: Sui Jingfeng The io_state variable in the vga_arb_write() function is declared with unsigned int type, while the vga_str_to_iostate() function takes int * type. To keep them consistent, replace the third argument of vga_str_to_iostate() function with the unsigned int * type.

[PATCH v3 0/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-08 Thread Sui Jingfeng
From: Sui Jingfeng Patch 1,2 and 3 do basic clean up to the vgaarb module. Patch 4 introduce is_boot_device function callback to vga_client_register Sui Jingfeng (4): PCI/VGA: tidy up the code and comment format PCI/VGA: Use unsigned type for the io_state variable PCI/VGA: only deal with

[PATCH v3] drm/amd/pm: enable more Pstates profile levels for yellow_carp

2023-06-08 Thread shikaguo
This patch enables following UMD stable Pstates profile levels for power_dpm_force_performance_level interface. - profile_peak - profile_min_mclk - profile_min_sclk - profile_standard Signed-off-by: shikaguo --- .../drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c | 140 +-

Re: [PATCH v2] drm/amd/pm: enable more Pstates profile levels for yellow_carp

2023-06-08 Thread Huang, Tim
[Public] Hi Shikai, From: Guo, Shikai Sent: Thursday, June 8, 2023 11:27 AM To: amd-gfx@lists.freedesktop.org Cc: Liang, Prike ; Liu, Aaron ; Huang, Tim ; Deucher, Alexander ; Guo, Shikai Subject: [PATCH v2] drm/amd/pm: enable more Pstates profile levels for

[PATCH] drm/amdgpu: expose num_hops and num_links xgmi info through dev attr

2023-06-08 Thread Shiwu Zhang
Add these two dev attrs for xgmi info details which is helpful for developers checking the xgmi topology by catting the sys file directly. Take 4 cards with xgmi connection as an example, get the num_hops for each device or node through xmig_hive_info dir like, cat