RE: [Patch v2 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-07 Thread Lin, Wayne
[AMD Official Use Only - General] Thanks for your time, Lyude! Regards, Wayne > -Original Message- > From: Lyude Paul > Sent: Tuesday, August 8, 2023 4:23 AM > To: Lin, Wayne ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org > Cc: jani.nik...@intel.com;

RE: [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

2023-08-07 Thread Lin, Wayne
[AMD Official Use Only - General] > -Original Message- > From: Imre Deak > Sent: Tuesday, August 8, 2023 12:00 AM > To: Lin, Wayne > Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > ly...@redhat.com; jani.nik...@intel.com; ville.syrj...@linux.intel.com; > Wentland,

[PATCH] drm/amdgpu: disable mcbp if parameter zero is set

2023-08-07 Thread jiadong.zhu
From: Jiadong Zhu The parameter amdgpu_mcbp shall have priority against the default value calculated from the chip version. User could disable mcbp by setting the parameter mcbp as zero. Signed-off-by: Jiadong Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 + 1 file changed, 5

Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch

2023-08-07 Thread Alex Deucher
On Mon, Aug 7, 2023 at 12:04 PM Michel Dänzer wrote: > > On 7/28/23 19:20, Alex Deucher wrote: > > On Fri, Jul 28, 2023 at 1:19 PM Michel Dänzer wrote: > >> On 7/28/23 18:43, Alex Deucher wrote: > >>> On Fri, Jul 28, 2023 at 10:25 AM Michel Dänzer wrote: > On 7/28/23 11:30, Michel Dänzer

[PATCH V2 4/5] drm/amdkfd: drop IOMMUv2 support

2023-08-07 Thread Alex Deucher
Now that we use the dGPU path for all APUs, drop the IOMMUv2 support. v2: drop the now unused queue manager functions for gfx7/8 APUs Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 10 - drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 7 -

[PATCH V2 1/5] drm/amdkfd: ignore crat by default

2023-08-07 Thread Alex Deucher
We are dropping the IOMMUv2 path, so no need to enable this. It's often buggy on consumer platforms anyway. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c

[PATCH V2 2/5] drm/amdkfd: disable IOMMUv2 support for KV/CZ

2023-08-07 Thread Alex Deucher
Use the dGPU path instead. There were a lot of platform issues with IOMMU in general on these chips due to windows not enabling IOMMU at the time. The dGPU path has been used for a long time with newer APUs and works fine. This also paves the way to simplify the driver significantly. v2: use

[PATCH V2 5/5] drm/amdkfd: rename device_queue_manager_init_v10_navi10()

2023-08-07 Thread Alex Deucher
Drop the navi10 in the name for consistency with other families. All gfx10 parts use the same implementation. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h | 2 +-

[PATCH V2 3/5] drm/amdkfd: disable IOMMUv2 support for Raven

2023-08-07 Thread Alex Deucher
Use the dGPU path instead. There were a lot of platform issues with IOMMU in general on these chips due to windows not enabling IOMMU at the time. The dGPU path has been used for a long time with newer APUs and works fine. This also paves the way to simplify the driver significantly.

Re: [Patch v2 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-07 Thread Lyude Paul
Oo! This is a wonderful idea so far - keeping track of the status of allocations like this solves a lot of problems, especially with regards to the fact this actually seems to make it possible for us to have much better handling of payload failures in drivers - especially in situations like

[PATCH] drm/amdgpu/gfx11: only enable CP GFX shadowing on SR-IOV

2023-08-07 Thread Alex Deucher
This is only required for SR-IOV world switches, but it adds additional latency leading to reduced performance in some benchmarks. Disable for now on bare metal. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH v3] drm/amdgpu: refine amdgpu_bo_create_kernel_at()

2023-08-07 Thread Christian König
Am 03.08.23 um 17:27 schrieb Yu, Lang: [Public] Ping *发件人:* Yu, Lang *发送时间:* 星期二, 八月 1, 2023 15:16 *收件人:* amd-gfx@lists.freedesktop.org *抄送:* Koenig, Christian ; Paneer Selvam, Arunpravin ; Zhang, Yifan ; Yu, Lang

Re: [PATCH] drm/amdgpu: Clean up errors in vcn_v3_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:53 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open brace '{' > ERROR: "foo * bar" should be "foo *bar" > ERROR: space required before the open parenthesis '(' > ERROR: that open brace {

Re: [PATCH] drm/amdgpu: Clean up errors in tonga_ih.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:50 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/tonga_ih.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH] drm/amdgpu: Clean up errors in gfx_v7_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:49 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: trailing statements should be on next line > ERROR: open brace '{' following struct go on the same line >

Re: [PATCH] drm/amdgpu: Clean up errors in vcn_v4_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:43 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > spaces required around that '==' (ctx:VxV) > ERROR: space required before the open parenthesis '(' > ERROR: that open brace { should be on the previous line > > Signed-off-by:

Re: [PATCH] drm/amdgpu: Clean up errors in uvd_v3_1.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:37 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH] drm/amdgpu: Clean up errors in mxgpu_vi.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:35 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '-=' (ctx:WxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/amdgpu: Clean up errors in nv.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:34 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 48 +++-- > 1 file

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_virt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:31 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_ring.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:28 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that ':' (ctx:VxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_trace.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:26 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required after that ',' (ctx:VxV) > ERROR: "foo* bar" should be "foo *bar" > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++--

Re: [PATCH] drm/amdgpu: Clean up errors in mes_v11_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:24 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_atombios.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:23 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 9 +++-- > 1 file changed, 3

Re: [PATCH] drm/amdgpu: Clean up errors in soc21.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:21 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/soc21.c | 30 ++ > 1 file

Re: [PATCH] drm/amdgpu: Clean up errors in dce_v8_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:18 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: code indent should use tabs where possible > ERROR: space required before the open brace '{' > >

Re: [PATCH] drm/amdgpu/jpeg: Clean up errors in vcn_v1_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:12 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open parenthesis '(' > ERROR: space prohibited after that '~' (ctx:WxW) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:06 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c

Re: [PATCH] drm/amdgpu: Clean up errors in dce_v10_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:04 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 30 +- > 1 file

Re: [PATCH] drm/jpeg: Clean up errors in jpeg_v2_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 3:00 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [PATCH] drm/amdgpu: Clean up errors in uvd_v7_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:58 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that ':' (ctx:VxE) > that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c

Re: [PATCH] drm/amd: Clean up errors in amdgpu_cgs.c

2023-08-07 Thread Alex Deucher
Already fixed. On Wed, Aug 2, 2023 at 2:55 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: switch and case should be at the same indent > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 64 - > 1 file changed,

Re: [PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:51 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '>=' (ctx:WxV) > ERROR: spaces required around that '!=' (ctx:WxV) > ERROR: code indent should use tabs where possible > > Signed-off-by:

Re: [PATCH] drm/amdgpu: Clean up errors in mmhub_v9_4.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:48 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amdgpu: Clean up errors in vega20_ih.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:46 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing statements should be on next line > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amdgpu: Clean up errors in ih_v6_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:43 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing statements should be on next line > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_psp.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:40 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: open brace '{' following enum go on the same line > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amdgpu: Clean up errors in vce_v3_0.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:38 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 9 +++-- > 1 file changed, 3

Re: [PATCH] drm/amdgpu: Clean up errors in cik_ih.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:35 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/amdgpu/cik_ih.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH] drm/amd/display: Clean up errors in dce_clk_mgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:26 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '?' (ctx:VxE) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amd/display: Clean up errors in display_mode_vba_30.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:20 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 6 ++ > 1 file changed, 2

Re: [PATCH] drm/amd/display: Clean up errors in dcn10_dpp_dscl.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:16 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [PATCH] drm/amd/display: Clean up errors in dc_stream.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Wed, Aug 2, 2023 at 2:14 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 3 +-- > 1 file changed, 1

Re: [PATCH] drm/amd/display: Clean up errors in bios_parser2.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! As a follow up patch, care to drop the break statements after a return? On Tue, Aug 1, 2023 at 11:23 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: switch and case should be at the same indent > ERROR: code indent should use tabs where

Re: [PATCH] drm/amd/display: Clean up errors in dcn316_smu.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 11:03 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/display: Clean up errors in dcn316_clk_mgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 11:01 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c | 6 ++ > 1

Re: [PATCH] drm/amd/display: Clean up errors in dcn315_smu.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:58 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/display: Clean up errors in dce112_hw_sequencer.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:54 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open brace '{' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dce112/dce112_hw_sequencer.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amd/display: Clean up errors in dce110_hw_sequencer.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:53 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required before the open brace '{' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amd/display: Clean up errors in dce110_timing_generator.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:52 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:WxV) > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c | 4 ++-- > 1 file

Re: [PATCH] drm/amd/dc: Clean up errors in hpd_regs.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:47 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h | 10 +- > 1 file changed, 5

Re: [PATCH] drm/amd/display: Clean up errors in ddc_regs.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:44 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/display/dc/gpio/ddc_regs.h| 40 +-- > 1 file changed,

Re: [PATCH] drm/amd/display: Clean up errors in color_gamma.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:40 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing whitespace > ERROR: else should follow close brace '}' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 5 ++---

Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu_pm.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:31 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in sislands_smc.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:25 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/legacy-dpm/sislands_smc.h | 63 +++ > 1 file

Re: [PATCH] drm/amd/pm: Clean up errors in r600_dpm.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:15 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h | 3 +-- > 1 file changed, 1

Re: [PATCH] drivers/amd/pm: Clean up errors in smu8_smumgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 10:10 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in smu8_smumgr.h

2023-08-07 Thread Alex Deucher
Need to be careful with these changes to make sure we aren't changing the size calculations somewhere. Alex On Tue, Aug 1, 2023 at 10:03 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: Use C99 flexible arrays > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in smu75.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:59 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before open square bracket '[' > ERROR: "foo * bar" should be "foo *bar" > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in smu73.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:56 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > ERROR: "foo * bar" should be "foo *bar" > >

Re: [PATCH] drm/amd/pm: Clean up errors in hwmgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:48 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: Use C99 flexible arrays > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h |

Re: [PATCH] drm/amd/pm: Clean up errors in hardwaremanager.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:39 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 3 +-- > 1 file

Re: [PATCH] drm/amd/pm: Clean up errors in pp_thermal.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:38 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/pp_thermal.h | 6 ++ > 1 file changed,

Re: [PATCH] drm/amd/pm: Clean up errors in smu7.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:31 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++ > 1 file changed, 2

Re: [PATCH] drm/amd/pm: Clean up errors in smu7_fusion.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:29 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in smu71.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 9:23 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in smu9_driver_if.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:51 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/inc/smu9_driver_if.h | 20 +-- > 1 file

Re: [PATCH] drm/amd/pm: Clean up errors in polaris_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:47 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/hwmgr/polaris_baco.c | 30 +++ > 1 file

Re: [PATCH] drm/amd/pm: Clean up errors in vega20_pptable.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:44 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_hwmgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:38 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following enum go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.h | 3 +-- > 1 file changed,

Re: [PATCH] drm/amd/pm/powerplay/hwmgr/hwmgr: Clean up errors in hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:37 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited after that '~' (ctx:WxW) > ERROR: spaces required around that '||' (ctx:VxW) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in tonga_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:34 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/hwmgr/tonga_baco.c | 30 +++ > 1 file

Re: [PATCH] gpu: amd: Clean up errors in ppatomfwctrl.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:30 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomfwctrl.h | 3 +-- > 1 file

Re: [PATCH] drm/amdgpu/powerplay: Clean up errors in vega20_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:28 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > ERROR: space required before the open parenthesis '(' > ERROR: space prohibited before that close parenthesis ')' > >

Re: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:25 AM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: amd-gfx On Behalf Of Ran > > Sun > > Sent: Tuesday, August 1, 2023 4:03 PM > > To: Deucher, Alexander ;

Re: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:25 AM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: amd-gfx On Behalf Of Ran > > Sun > > Sent: Tuesday, August 1, 2023 10:39 AM > > To: Deucher, Alexander ;

Re: [PATCH] drm/amdgpu/powerplay: Clean up errors in smu_helper.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:22 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before that close parenthesis ')' > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu_helper.h | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amd: Clean up errors in vega10_processpptables.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:19 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: "foo* bar" should be "foo *bar" > ERROR: space required before the open brace '{' > ERROR: space required before the open parenthesis '(' > > Signed-off-by: Ran Sun >

Re: [PATCH] drm/amd: Clean up errors in pptable_v1_0.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:02 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/pptable_v1_0.h | 3 +-- > 1 file

Re: [PATCH] drm/amd: Clean up errors in smu7_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 5:00 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: spaces required around that '=' (ctx:VxV) > ERROR: spaces required around that '<' (ctx:VxV) > >

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_pptable.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 4:40 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../amd/pm/powerplay/hwmgr/vega10_pptable.h| 18 ++ > 1

Re: [PATCH] drm/amdgpu: Clean up errors in ppatomctrl.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 4:37 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.h | 6 ++ > 1 file

Re: [PATCH] drm/amdgpu: Clean up errors in smu_helper.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 4:00 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:VxV) > ERROR: spaces required around that '<' (ctx:VxV) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amdgpu: Clean up errors in common_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 3:55 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/common_baco.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amdgpu: Clean up errors in smu7_powertune.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 2:15 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 2:09 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_baco.c | 12 > 1 file

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_pptable.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Tue, Aug 1, 2023 at 2:04 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: open brace '{' following struct go on the same line > ERROR: space prohibited before open square bracket '[' > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_hwmgr.c

2023-08-07 Thread Alex Deucher
This one doesn't apply due to whitespace differences. Alex On Tue, Aug 1, 2023 at 1:58 AM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: trailing statements should be on next line > ERROR: space required before the open brace '{' > ERROR: space required before

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_powertune.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:38 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space prohibited after that open parenthesis '(' > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in fiji_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:16 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- > .../drm/amd/pm/powerplay/hwmgr/fiji_baco.c| 24 +++ > 1 file

Re: [PATCH] drm/amd/pm: Clean up errors in smu10_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:09 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm/powerplay/hwmgr/ppevvmath: Clean up errors in ppevvmath.h

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 11:03 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: return is not a function, parentheses are not required > ERROR: space required after that ',' (ctx:VxV) > ERROR: space required before the open parenthesis '(' >

Re: [PATCH] drm/amd/pm: Clean up errors in vega12_hwmgr.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:57 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: need consistent spacing around '/' (ctx:WxV) > ERROR: code indent should use tabs where possible > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in vega10_baco.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:45 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > ERROR: space prohibited before that ',' (ctx:WxV) > >

Re: [PATCH] drm/amd/pm: Clean up errors in amd_powerplay.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:37 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: spaces required around that '||' (ctx:WxO) > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in amdgpu_smu.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:28 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: spaces required around that '=' (ctx:WxV) > ERROR: spaces required around that '&&' (ctx:VxW) > ERROR: that open brace { should be on the previous line > ERROR: space

Re: [PATCH] drm/amd: Clean up errors in smu_v13_0_5_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:11 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 4 ++-- > 1 file changed, 2

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_5_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:08 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/amd/pm: Clean up errors in smu_v13_0_6_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:06 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: code indent should use tabs where possible > ERROR: that open brace { should be on the previous line > > Signed-off-by: Ran Sun > --- >

Re: [PATCH] drm/amd/pm: Clean up errors in aldebaran_ppt.c

2023-08-07 Thread Alex Deucher
Applied. Thanks! On Mon, Jul 31, 2023 at 10:01 PM Ran Sun wrote: > > Fix the following errors reported by checkpatch: > > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > ERROR: spaces required around that '=' (ctx:VxW) > ERROR: else

  1   2   >