[V3 3/7] drm/amd/pm: add fan temperature/pwm curve OD setting support for SMU13

2023-08-29 Thread Evan Quan
Add SMU13 fan temperature/pwm curve OD setting support. Signed-off-by: Evan Quan -- v1->v2: - add missing kerneldoc for the new interface(Alex) v2->v3: - rich the document for the new interface(Alex) --- Documentation/gpu/amdgpu/thermal.rst | 6 +

[V3 7/7] drm/amd/pm: add fan minimum pwm OD setting support for SMU13

2023-08-29 Thread Evan Quan
Add SMU13 fan minimum pwm OD setting support. Signed-off-by: Evan Quan -- v1->v2: - add missing kerneldoc for the new interface(Alex) v2->v3: - rich the document for the new interface(Alex) --- Documentation/gpu/amdgpu/thermal.rst | 6 ++ .../gpu/drm/amd/include/kgd_pp_interface.h

[V3 6/7] drm/amd/pm: add fan target temperature OD setting support for SMU13

2023-08-29 Thread Evan Quan
Add SMU13 fan target temperature OD setting support. Signed-off-by: Evan Quan -- v1->v2: - add missing kerneldoc for the new interface(Alex) v2->v3: - rich the document for the new interface(Alex) --- Documentation/gpu/amdgpu/thermal.rst | 6 ++

[V3 4/7] drm/amd/pm: add fan acoustic limit OD setting support for SMU13

2023-08-29 Thread Evan Quan
Add SMU13 fan acoustic limit OD setting support. Signed-off-by: Evan Quan -- v1->v2: - add missing kerneldoc for the new interface(Alex) v2->v3: - rich the document for the new interface(Alex) --- Documentation/gpu/amdgpu/thermal.rst | 6 ++

[V3 2/7] drm/amdgpu: revise the device initialization sequences

2023-08-29 Thread Evan Quan
By placing the sysfs interfaces creation after `.late_int`. Since some operations performed during `.late_init` may affect how the sysfs interfaces should be created. Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 37 -- 1 file changed, 21

[V3 0/7] A new set of Linux OD interfaces

2023-08-29 Thread Evan Quan
The existing OD interface `pp_od_clk_voltage` is unable to meet the growing demands for more OD functionalities. Since the buf used within it comes with size limit as one page. With more OD functionalities added, we will hit that limit soon. To better meet the growing demainds, a new set of OD

[PATCH] drm/amdgpu: Use correct KIQ MEC engine for gfx9.4.3

2023-08-29 Thread Victor Lu
amdgpu_kiq_wreg/rreg is hardcoded to use MEC engine 0. Add an "xcc_id" parameter to them so its uses the correct XCD's engine Signed-off-by: Victor Lu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 24 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +

[PATCH] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-29 Thread Hamza Mahfooz
This reverts commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e. We still need to call dcn20_adjust_freesync_v_startup() for older DCN3+ ASICs otherwise it can cause DP to HDMI 2.1 PCONs to fail to light up. So, reintroduce the reverted code and limit it to ASICs older than DCN31. Cc:

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Alex Hung
On 2023-08-29 11:03, Jani Nikula wrote: On Tue, 29 Aug 2023, Jani Nikula wrote: On Tue, 29 Aug 2023, Alex Deucher wrote: On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: On Wed, 23 Aug 2023, Jani Nikula wrote: On Tue, 22 Aug 2023, Alex Hung wrote: On 2023-08-22 06:01, Jani Nikula

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Jani Nikula
On Tue, 29 Aug 2023, Jani Nikula wrote: > On Tue, 29 Aug 2023, Alex Deucher wrote: >> On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: >>> >>> On Wed, 23 Aug 2023, Jani Nikula wrote: >>> > On Tue, 22 Aug 2023, Alex Hung wrote: >>> >> On 2023-08-22 06:01, Jani Nikula wrote: >>> >>> Over the

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Jani Nikula
On Tue, 29 Aug 2023, Alex Deucher wrote: > On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: >> >> On Wed, 23 Aug 2023, Jani Nikula wrote: >> > On Tue, 22 Aug 2023, Alex Hung wrote: >> >> On 2023-08-22 06:01, Jani Nikula wrote: >> >>> Over the past years I've been trying to unify the override

RE: [PATCH] drm/amdkfd: Fix reg offset for setting CWSR grace period

2023-08-29 Thread Kim, Jonathan
[Public] > -Original Message- > From: Joshi, Mukul > Sent: Tuesday, August 29, 2023 10:55 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Kim, Jonathan > ; Joshi, Mukul > Subject: [PATCH] drm/amdkfd: Fix reg offset for setting CWSR grace period > > This patch fixes the

[PATCH] drm/amdkfd: Fix unaligned 64-bit doorbell warning

2023-08-29 Thread Mukul Joshi
This patch fixes the following unaligned 64-bit doorbell warning seen when submitting packets on HIQ on GFX v9.4.3 by making the HIQ doorbell 64-bit aligned. The warning is seen when GPU is loaded in any mode other than SPX mode. [ +0.000301] [ cut here ] [ +0.03]

RE: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Wu, Hersen
[AMD Official Use Only - General] + Charlie Wang -Original Message- From: Alex Deucher Sent: Tuesday, August 29, 2023 11:44 AM To: Jani Nikula Cc: Hung, Alex ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Li, Sun peng (Leo) ; intel-...@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Alex Deucher
On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: > > On Wed, 23 Aug 2023, Jani Nikula wrote: > > On Tue, 22 Aug 2023, Alex Hung wrote: > >> On 2023-08-22 06:01, Jani Nikula wrote: > >>> Over the past years I've been trying to unify the override and firmware > >>> EDID handling as well as EDID

[PATCH] drm/amdgpu: Free ras cmd input buffer properly

2023-08-29 Thread Hawking Zhang
Do not access the pointer for ras input cmd buffer if it is even not allocated. Signed-off-by: Hawking Zhang Reviewed-by: Stanley Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

RE: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Wu, Hersen
[AMD Official Use Only - General] + Charlie -Original Message- From: Jani Nikula Sent: Tuesday, August 29, 2023 6:49 AM To: Hung, Alex ; dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo) ; David Airlie ; intel-...@lists.freedesktop.org; Siqueira,

RE: [PATCH] drm/amdgpu: Free ras cmd input buffer properly

2023-08-29 Thread Zhang, Hawking
[AMD Official Use Only - General] Sorry about that, will send it out a clean up version. Regards, Hawking -Original Message- From: Yang, Stanley Sent: Tuesday, August 29, 2023 23:00 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org; Zhou1, Tao Subject: RE: [PATCH] drm/amdgpu: Free

[PATCH] drm/amdgpu: Free ras cmd input buffer properly

2023-08-29 Thread Hawking Zhang
Do not access the pointer for ras input cmd buffer if it is even not allocated. Signed-off-by: Hawking Zhang Reviewed-by: Stanley Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

RE: [PATCH] drm/amdgpu: Free ras cmd input buffer properly

2023-08-29 Thread Yang, Stanley
[AMD Official Use Only - General] Reviewed-by: Stanley.Yang Regards, Stanley > -Original Message- > From: Zhang, Hawking > Sent: Tuesday, August 29, 2023 10:55 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; > Yang, Stanley > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu:

[PATCH] drm/amdgpu: Free ras cmd input buffer properly

2023-08-29 Thread Hawking Zhang
Do not access the pointer for ras input cmd buffer if it is even not allocated. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c

[PATCH] drm/amdkfd: Fix reg offset for setting CWSR grace period

2023-08-29 Thread Mukul Joshi
This patch fixes the case where the code currently passes absolute register address and not the reg offset, which HWS expects, when sending the PM4 packet to set/update CWSR grace period. Additionally, cleanup the signature of build_grace_period_packet_info function as it no longer needs the inst

Re: [PATCH v2] drm/amd/display: Adjust kdoc for 'optc35_set_odm_combine'

2023-08-29 Thread Rodrigo Siqueira Jordao
On 8/29/23 08:38, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_optc.c:46: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC

[PATCH v2] drm/amd/display: Adjust kdoc for 'optc35_set_odm_combine'

2023-08-29 Thread Srinivasan Shanmugam
Fixes the following W=1 kernel build warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn35/dcn35_optc.c:46: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Enable CRTC Cc: Qingqing Zhuo Cc: Rodrigo Siqueira Cc: Harry

Keyword Review - Re: [PATCH v3 2/2] drm/amdgpu: Put page tables to GTT memory for gfx10 onwards APUs

2023-08-29 Thread Christian König
*sigh* yeah that's exactly what we have seen before as well. Let me know when you need help with that. Regards, Christian. Am 29.08.23 um 08:17 schrieb Zhang, Yifan: [AMD Official Use Only - General] Validated on Phoenix and Raphael w/ IOMMU remapping mode, and found random page fault

Re: [PATCH] drm/amd/display: Fix up kdoc for 'optc35_set_odm_combine'

2023-08-29 Thread Rodrigo Siqueira Jordao
Hi, Consider renaming the commit title to something like "Adjust kernel-doc for ...". Anyway, avoid use the keyword "Fix/Fixes" for kernel-doc. On 8/28/23 22:50, Srinivasan Shanmugam wrote: Fixes the following W=1 kernel build warning:

Re: [PATCH] Revert "Revert "drm/amd/display: Implement zpos property""

2023-08-29 Thread Melissa Wen
On 08/29, Hamza Mahfooz wrote: > This reverts commit 984612bd4649c91f12e9c7c7f9e914fdc8ba7d3f. > > The problematic IGT test case (i.e. kms_atomic@plane-immutable-zpos) has > been fixed as of commit cb77add45011 ("tests/kms_atomic: remove zpos < > N-planes assert") to the IGT repo. So, reintroduce

Re: [PATCH] Revert "Revert "drm/amd/display: Implement zpos property""

2023-08-29 Thread Alex Deucher
On Tue, Aug 29, 2023 at 7:40 AM Hamza Mahfooz wrote: > > This reverts commit 984612bd4649c91f12e9c7c7f9e914fdc8ba7d3f. > > The problematic IGT test case (i.e. kms_atomic@plane-immutable-zpos) has > been fixed as of commit cb77add45011 ("tests/kms_atomic: remove zpos < > N-planes assert") to the

Re: [PATCH] drm/amdgpu: fix amdgpu_cs_p1_user_fence

2023-08-29 Thread Alex Deucher
On Tue, Aug 29, 2023 at 8:00 AM Christian König wrote: > > The offset is just 32bits here so this can potentially overflow if > somebody specifies a large value. Instead reduce the size to calculate > the last possible offset. > > The error handling path incorrectly drops the reference to the

[PATCH AUTOSEL 6.4 17/17] drm/amd/pm: Fix temperature unit of SMU v13.0.6

2023-08-29 Thread Sasha Levin
From: Lijo Lazar [ Upstream commit 8d036427f0042a91136e6f19a39542eedec4e96c ] Temperature needs to be reported in millidegree Celsius. Signed-off-by: Lijo Lazar Reviewed-by: Yang Wang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

Re: radeon.ko/i586: BUG: kernel NULL pointer dereference,address:00000004

2023-08-29 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. I still have this issue on my list of tracked regressions. Was this fixed in between? Doesn't look like it from here, but I might be missing something. Ciao, Thorsten

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

2023-08-29 Thread Pekka Paalanen
On Mon, 28 Aug 2023 12:56:04 -0100 Melissa Wen wrote: > On 08/28, Pekka Paalanen wrote: > > On Mon, 28 Aug 2023 09:45:44 +0100 > > Joshua Ashton wrote: > > > > > Degamma has always been on the plane on AMD. CRTC DEGAMMA_LUT has actually > > > just been applying it to every plane pre-blend.

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Jani Nikula
On Wed, 23 Aug 2023, Jani Nikula wrote: > On Tue, 22 Aug 2023, Alex Hung wrote: >> On 2023-08-22 06:01, Jani Nikula wrote: >>> Over the past years I've been trying to unify the override and firmware >>> EDID handling as well as EDID property updates. It won't work if drivers >>> do their own

[PATCH] Revert "Revert "drm/amd/display: Implement zpos property""

2023-08-29 Thread Hamza Mahfooz
This reverts commit 984612bd4649c91f12e9c7c7f9e914fdc8ba7d3f. The problematic IGT test case (i.e. kms_atomic@plane-immutable-zpos) has been fixed as of commit cb77add45011 ("tests/kms_atomic: remove zpos < N-planes assert") to the IGT repo. So, reintroduce the reverted code. Link:

Re: [PATCH 6/7] Revert "drm/amd/display: Implement zpos property"

2023-08-29 Thread Melissa Wen
On 08/18, Leo Li wrote: > > > On 2023-08-18 04:25, Melissa Wen wrote: > > On 07/26, Aurabindo Pillai wrote: > > > This reverts commit 6c8ff1683d30024c8cff137d30b740a405cc084e. > > > > > > This patch causes IGT test case 'kms_atomic@plane-immutable-zpos' to > > > fail on AMDGPU hardware. > > >

[PATCH] drm/amdgpu: fix amdgpu_cs_p1_user_fence

2023-08-29 Thread Christian König
The offset is just 32bits here so this can potentially overflow if somebody specifies a large value. Instead reduce the size to calculate the last possible offset. The error handling path incorrectly drops the reference to the user fence BO resulting in potential reference count underflow.

Re: [PATCH v3 5/7] drm/amdgpu: Set/Reset GPU workload profile

2023-08-29 Thread Christian König
Am 28.08.23 um 14:26 schrieb Arvind Yadav: This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. v3: - Addressed the review comment about changing the function name from *_set() to *_get(). That looks

RE: [PATCH v3 2/2] drm/amdgpu: Put page tables to GTT memory for gfx10 onwards APUs

2023-08-29 Thread Zhang, Yifan
[AMD Official Use Only - General] Validated on Phoenix and Raphael w/ IOMMU remapping mode, and found random page fault when launching Xorg. I will debug this issue and update the patch. Best Regards, Yifan From: Deucher, Alexander Sent: Tuesday, August 29, 2023 2:06 AM To: Koenig, Christian