Re: [RFC,drm-misc-next v4 3/9] drm/radeon: Implement .be_primary() callback

2023-09-04 Thread Christian König
Am 04.09.23 um 21:57 schrieb Sui Jingfeng: From: Sui Jingfeng On a machine with multiple GPUs, a Linux user has no control over which one is primary at boot time. Question is why is that useful? Should we give users the ability to control that? I don't see an use case for this. Regards,

Re: [PATCH] drm/amd: Fix the flag setting code for interrupt request

2023-09-04 Thread Christian König
Am 04.09.23 um 08:05 schrieb Ma Jun: [1] Remove the irq flags setting code since pci_alloc_irq_vectors() handles these flags. [2] Free the msi vectors in case of error. Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 43 ++--- 1 file changed, 25

Re: [PATCH] drm/amdgpu: calling address translation functions to simplify codes

2023-09-04 Thread Christian König
Am 04.09.23 um 10:18 schrieb Yifan Zhang: Use amdgpu_gmc_vram_pa to simplify codes. Signed-off-by: Yifan Zhang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfxhub_v11_5_0.c | 3 +-- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c| 3 +--

RE: [PATCH 3/3] drm/amdgpu: Add umc v12_0 ras functions

2023-09-04 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Li, Candice > Sent: Monday, September 4, 2023 3:20 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice ; Zhou1, Tao > Subject: [PATCH 3/3] drm/amdgpu: Add umc v12_0 ras functions

RE: [PATCH] drm/amdgpu: Restrict bootloader wait to SMUv13.0.6

2023-09-04 Thread Kamal, Asad
[AMD Official Use Only - General] Reviewed-by: Asad Kamal asad.ka...@amd.com Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Monday, September 4, 2023 6:32 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Ma, Le ; Kamal, Asad ; Zhang,

[PATCH 3/3] Documentation/amdgpu: Modify pp_dpm_*clk details

2023-09-04 Thread Lijo Lazar
pp_dpm_*clk nodes also could show the frequencies when a clock is in 'sleep' state. Add documentation related to that. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH 1/3] drm/amd/pm: Fix clock reporting for SMUv13.0.6

2023-09-04 Thread Lijo Lazar
On SMU v13.0.6, effective clocks are reported by FW which won't exactly match with DPM level. Report the current clock based on the values matching closest to the effective clock. Also, when deep sleep is applied to a clock, report it with a special level "S:" as in sample clock levels below S:

[PATCH 2/3] drm/amd/pm:Fix GFX deep sleep clock reporting

2023-09-04 Thread Lijo Lazar
For SMU v13.0.6, keep GFX deep sleep clock reporting style consistent with that of other clocks. Sample format below. S: 78Mhz * 0: 600Mhz 1: 800Mhz Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang Reviewed-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 10

[PATCH] drm/amdgpu: Restrict bootloader wait to SMUv13.0.6

2023-09-04 Thread Lijo Lazar
Restrict the wait for boot loader steady state only to SMUv13.0.6. For older SOCs, ASIC init has a longer wait period and that takes care. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] drm/amdgpu: Use min_t to replace min

2023-09-04 Thread Christian König
Am 03.09.23 um 08:52 schrieb Srinivasan Shanmugam: Use min_t to replace min, min_t is a bit fast because min use twice typeof. Well that is probably negligibly. The point is that using min_t is cleaner here since the min/max macros do a typecheck while min_t()/max_t() to an explicit type

Re: [PATCH] drm/amdgpu: Declare array with strings as pointers constant

2023-09-04 Thread Christian König
Am 03.09.23 um 08:05 schrieb Srinivasan Shanmugam: This warning is for the declaration of a static array, and it is recommended to declare it as type "static const char * const" instead of "static const char *". an array pointer declared as type "static const char *" can point to a different

[PATCH] drm/amdgpu: calling address translation functions to simplify codes

2023-09-04 Thread Yifan Zhang
Use amdgpu_gmc_vram_pa to simplify codes. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/gfxhub_v11_5_0.c | 3 +-- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0.c| 3 +-- drivers/gpu/drm/amd/amdgpu/gfxhub_v3_0_3.c | 3 +-- drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c | 3 +--

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-09-04 Thread Daniel Vetter
On Fri, 1 Sept 2023 at 21:00, Alex Deucher wrote: > > On Thu, Aug 31, 2023 at 6:01 PM Alex Hung wrote: > > > > > > > > On 2023-08-30 01:29, Jani Nikula wrote: > > > On Tue, 29 Aug 2023, Alex Hung wrote: > > >> On 2023-08-29 11:03, Jani Nikula wrote: > > >>> On Tue, 29 Aug 2023, Jani Nikula

RE: [PATCH 1/3] drm/amdgpu: Add RREG64_PCIE_EXT/WREG64_PCIE_EXT functions

2023-09-04 Thread Zhang, Hawking
[AMD Official Use Only - General] Please split the change in amdgpu_device_indirect_rreg|wreg_ext to another patch. With above addressed, the series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Monday, September 4,

Re: [RFT PATCH 14/15] drm/radeon: Call drm_helper_force_disable_all() at shutdown/remove time

2023-09-04 Thread Maxime Ripard
On Fri, 1 Sep 2023 16:41:25 -0700, Douglas Anderson wrote: > Based on grepping through the source code, this driver appears to be > missing a call to drm_atomic_helper_shutdown(), or in this case the > non-atomic equivalent drm_helper_force_disable_all(), at system > shutdown time and at driver

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-09-04 Thread Eddie Chapman
On 01/09/2023 07:02, Christian König wrote: Am 31.08.23 um 20:55 schrieb Chia-I Wu: On Thu, Aug 31, 2023 at 7:01 AM Greg KH wrote: On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: Am 31.08.23 um 12:56 schrieb Greg KH: On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König

[PATCH 3/3] drm/amdgpu: Add umc v12_0 ras functions

2023-09-04 Thread Candice Li
Add umc v12_0 ras error querying. Signed-off-by: Candice Li Reviewed-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/Makefile| 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 16 +- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 256 + drivers/gpu/drm/amd/amdgpu/umc_v12_0.h

[PATCH 2/3] drm/amd: Add umc v12_0_0 ip headers

2023-09-04 Thread Candice Li
Add umc v12_0_0 ip headers. Signed-off-by: Candice Li Reviewed-by: Tao Zhou --- .../include/asic_reg/umc/umc_12_0_0_offset.h | 33 +++ .../include/asic_reg/umc/umc_12_0_0_sh_mask.h | 95 +++ 2 files changed, 128 insertions(+) create mode 100644

[PATCH 1/3] drm/amdgpu: Add RREG64_PCIE_EXT/WREG64_PCIE_EXT functions

2023-09-04 Thread Candice Li
1. Add 64bits register access support on register whose address is greater than 32bits. 2. Update RREG32_PCIE_EXT/WREG32_PCIE_EXT. Signed-off-by: Candice Li Reviewed-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 11 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 119

RE: [Patch v2 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-09-04 Thread Lin, Wayne
[Public] Thank you Lyude and Alex! Regards, Wayne > -Original Message- > From: Alex Deucher > Sent: Saturday, September 2, 2023 3:38 AM > To: Lyude Paul > Cc: Lin, Wayne ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org; jani.nik...@intel.com; imre.d...@intel.com; >

Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-04 Thread Andi Shyti
Hi Jim, On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > By at least strong convention, a print-buffer's trailing newline says > "message complete, send it". The exception (no TNL, followed by a call > to pr_cont) proves the general rule. > > Most DRM.debug calls already comport

[PATCH] drm/amd: Fix the flag setting code for interrupt request

2023-09-04 Thread Ma Jun
[1] Remove the irq flags setting code since pci_alloc_irq_vectors() handles these flags. [2] Free the msi vectors in case of error. Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 43 ++--- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git