Re: [PATCH 8/8] drm/amdgpu: Track pending retry faults in IH and VM (v2)

2017-09-13 Thread Alex Deucher
smaller and the FIFO longer. I never want the > FIFO to fill up, because that would make prescreen take longer. > 128 pending page faults should be enough to keep migrations busy. > > Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com> Reviewed-by: Alex Deucher &

Re: [PATCH] drm/radeon: properly initialize r600_audio_status() data

2017-09-18 Thread Alex Deucher
On Sat, Sep 16, 2017 at 8:20 AM, Christian König wrote: > Am 15.09.2017 um 22:06 schrieb Arnd Bergmann: >> >> The structure returned from r600_audio_status() is only partially >> initialized, and older gcc versions (4.3 and 4.4) warn about this: >> >>

[pull] amdgpu drm-next-4.15-dc

2017-10-06 Thread Alex Deucher
Hi Dave, Latest cleanups for DC from you and Harry. Note that there is some flickering on some older asics with this branch due to a regression in powerplay that has already been fixed and will be included in my next non-DC pull request next week. The following changes since commit

Re: [PATCH 1/3] drm/amdgpu: add smu_memory_pool_size module parameter

2017-10-10 Thread Alex Deucher
On Tue, Oct 10, 2017 at 6:39 AM, Rex Zhu wrote: > used to clamp system memmoy for smu debug usage. > > Change-Id: I8399f55069b8dcc05a3a79f9285744fcc8549af0 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + >

Re: [PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address

2017-10-16 Thread Alex Deucher
On Mon, Oct 16, 2017 at 5:09 AM, Evan Quan wrote: > Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 > Signed-off-by: Evan Quan Please provide a more detailed commit message. Seems like we should look at converting the psp to use the common ring

Re: [PATCH] drm/amdgpu: use ARRAY_SIZE

2017-10-16 Thread Alex Deucher
On Mon, Oct 16, 2017 at 3:48 AM, Christian König wrote: > Am 16.10.2017 um 04:29 schrieb Jérémy Lefaure: >> >> Using the ARRAY_SIZE macro improves the readability of the code. >> >> Found with Coccinelle with the following semantic patch: >> @r depends on (org ||

Re: [PATCH 07/20] drm/amd/display: Add chip mask to HDMI retimer/redriver check

2017-10-16 Thread Alex Deucher
On Mon, Oct 16, 2017 at 4:31 PM, Harry Wentland wrote: > From: Andrew Jiang > > There were cases where the chip caps held additional bits that led to > the retimer/redriver check failing; use the proper mask to ensure that > we have only the bits

Re: [PATCH 5/6] drm/amd/display: Fix typo

2017-10-13 Thread Alex Deucher
On Thu, Oct 12, 2017 at 5:15 PM, <sunpeng...@amd.com> wrote: > From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> > > undersacn -> underscan > > Signed-off-by: Leo (Sunpeng) Li <sunpeng...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com

Re: [PATCH 6/6] drm/amd/display: Remove useless pcrtc pointer

2017-10-13 Thread Alex Deucher
On Thu, Oct 12, 2017 at 5:15 PM, <sunpeng...@amd.com> wrote: > From: "Leo (Sunpeng) Li" <sunpeng...@amd.com> > > in amdgpu_dm_atomic_commit_tail. Just use crtc instead. > > Signed-off-by: Leo (Sunpeng) Li <sunpeng...@amd.com> Reviewed-

Re: [PATCH] drm/amdgpu: correct reference clock value on vega10

2017-10-11 Thread Alex Deucher
On Wed, Oct 11, 2017 at 4:48 AM, Wang, Ken wrote: > From: Ken Wang > > Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474 > Signed-off-by: Ken Wang NAK. We use 10khz units for all other asics. We already multiply this by 10 in

[pull] amdgpu drm-next-4.15-dc

2017-10-13 Thread Alex Deucher
) Alex Deucher (12): drm/amd/display: fix typo in function name drm/amd/display: whitespace cleanup in amdgpu_dm.c/h drm/amd/display: make a bunch of stuff in amdgpu_dm.c static drm/amd/display: drop unused functions in amdgpu_dm.c drm/amd/display: drop unused functions

[PATCH libdrm] tests/amdgpu: add missing header to SOURCES

2017-08-30 Thread Alex Deucher
Fixes the tarball generation. fixes: 9d133dd08720d80dfc8ce098bf0972 (tests/amdgpu: add uvd encode unit tests) bug: https://bugs.freedesktop.org/show_bug.cgi?id=102391 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- tests/amdgpu/Makefile.am | 3 ++- 1 file changed, 2 insertions

Re: [PATCH 1/1] drm/amdgpu: Fix IB allocation sizes for page table updates

2017-08-30 Thread Alex Deucher
On Wed, Aug 30, 2017 at 5:08 PM, Felix Kuehling <felix.kuehl...@amd.com> wrote: > set_pte_pde commands need 10 dwords. > > Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd

Re: [PATCH 1/2] drm/amdgpu: add support for request SI/CI firmware in CGS

2017-09-11 Thread Alex Deucher
On Fri, Sep 8, 2017 at 2:40 AM, Rex Zhu <rex@amd.com> wrote: > Change-Id: If3ab520f8c65bec070e97cd8787041919d687ad3 > Signed-off-by: Rex Zhu <rex@amd.com> Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/dr

Re: [PATCH 1/2] amdgpu: Only destroy fbdev framebuffer if it was initialized

2017-09-11 Thread Alex Deucher
t;> framebuffer was initialized, which can happen since the DRM fbdev helper >> code supports deferred setup. >> >> Signed-off-by: Michel Dänzer <michel.daen...@amd.com> > > > Acked-by: Christian König <christian.koe...@amd.com> for both. Series is: Revi

Re: [PATCH v2] drm/amd/display: Disable pre-Vega ASICs by default

2017-09-12 Thread Alex Deucher
On Tue, Sep 12, 2017 at 8:30 PM, Ernst Sjöstrand wrote: > Add Fiji to the help text? Maybe just say DCE8, 10, 11. Alex > > Regards > //Ernst > > 2017-09-12 22:46 GMT+02:00 Harry Wentland : >> v2: Clarify help text for pre-vega config >> >>

[pull] amdgpu and ttm drm-next-4.14

2017-09-12 Thread Alex Deucher
://people.freedesktop.org/~agd5f/linux drm-next-4.14 for you to fetch changes up to 3d138c14c4174a2c80874a96935c87eee7c82ecf: drm/amdgpu: revert "fix deadlock of reservation between cs and gpu reset v2" (2017-09-12 22:16:31 -0400) ---- Al

Re: [PATCH v3] drm/amd/display: Disable pre-Vega ASICs by default

2017-09-13 Thread Alex Deucher
On Wed, Sep 13, 2017 at 10:13 AM, Harry Wentland <harry.wentl...@amd.com> wrote: > v2: Clarify help text for pre-vega config > v3: Refer to older ASIC in more generic DCE 8,10,11 fashion > > Signed-off-by: Harry Wentland <harry.wentl...@amd.com> Reviewed-by: Alex

Re: [PATCH 1/2] drm/amdgpu: move amdgpu_ttm_tt_* declarations into amdgpu_ttm.h

2017-09-10 Thread Alex Deucher
On Fri, Sep 8, 2017 at 11:52 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > Just some cleanup. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc..

Re: [PATCH 1/5] drm/amdgpu: fix cgs alignment handling

2017-09-12 Thread Alex Deucher
On Tue, Sep 12, 2017 at 5:08 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > This always allocated on PAGE_SIZE alignment. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex D

Re: [PATCH libdrm] amdgpu: print error messages when amdgpu_device_initialize is failing

2017-09-12 Thread Alex Deucher
On Tue, Sep 12, 2017 at 1:39 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> > Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > amdgpu/amdgpu_device.c | 19 --- > 1 file changed, 16 insertions(

Re: [PATCH 3/5] drm/amdgpu: fix and cleanup amdgpu_bo_create

2017-09-12 Thread Alex Deucher
struct ttm_placement *placement, >>> - struct reservation_object *resv, >>> - uint64_t init_value, >>> - struct amdgpu_bo **bo_ptr) >>> +static int amdgpu_bo_do_cr

Re: [PATCH] drm/amd/powerplay: remove unnecessary call to memset

2017-09-11 Thread Alex Deucher
On Mon, Sep 11, 2017 at 8:37 AM, Himanshu Jha wrote: > call to memset to assign 0 value immediately after allocating > memory with kzalloc is unnecesaary as kzalloc allocates the memory > filled with 0 value. > > Semantic patch used to resolve this issue: > > @@ >

Re: [PATCH] radeon and amdgpu drm-fixes-4.14

2017-09-26 Thread Alex Deucher
Whoops. subject should say [pull]. Alex On Tue, Sep 26, 2017 at 3:33 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: > Hi Dave, > > A few fixes for 4.14. Nothing too major. > > The following changes since commit 47e0cd6b1dbbbff7591fe7eecc20bac5ca674351: > > Merge br

[PATCH] radeon and amdgpu drm-fixes-4.14

2017-09-26 Thread Alex Deucher
://people.freedesktop.org/~agd5f/linux drm-fixes-4.14 for you to fetch changes up to 820608548737e315c6f93e3099b4e65bde062334: drm/radeon: disable hard reset in hibernate for APUs (2017-09-15 11:55:27 -0400) Alex Deucher (1

[pull] radeon, amdgpu, ttm drm-next-4.15

2017-09-26 Thread Alex Deucher
://people.freedesktop.org/~agd5f/linux drm-next-4.15 for you to fetch changes up to 6f87a895709eecc1542fe947e349364ad061ac00: drm/amdgpu: clarify license in amdgpu_trace_points.c (2017-09-26 15:14:37 -0400) Alex Deucher (14): drm/amdgpu

[pull] amdgpu dc drm-next-4.15-dc

2017-09-26 Thread Alex Deucher
) AMD\ktsao (1): drm/amd/display: remove DCN1 guard as DCN1 is already open sourced. Alex Deucher (18): drm/amd/dc/dm: remove redundant display structs drm/amd/display: Enable DCE12 support drm/amd/display: Remove

Re: [PATCH] dmr/amd/powerplay: Fix typo in ci_populate_fuzzy_fan()

2017-09-26 Thread Alex Deucher
On Tue, Sep 26, 2017 at 11:38 AM, Tom St Denis <tom.stde...@amd.com> wrote: > Ping :-) > > Tom > > > On 25/09/17 01:33 PM, Tom St Denis wrote: >> >> Signed-off-by: Tom St Denis <tom.stde...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.co

Re: [PATCH 2/2] drm/amdgpu/sriov:fix memory leak in psp_load_fw

2017-09-26 Thread Alex Deucher
d-off-by: Monk Liu <monk@amd.com> A couple of comments below. With those fixed, series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > d

Re: [PATCH 10/10] drm/amd/powerplay: export new interfaces in amd_pm_funcs

2017-09-26 Thread Alex Deucher
On Mon, Sep 25, 2017 at 9:49 AM, Rex Zhu <rex@amd.com> wrote: > Change-Id: If13500f76da6e42f50d40fc794fc5e1e5dc143bf > Signed-off-by: Rex Zhu <rex@amd.com> Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm

Re: [PATCH] amdgpu/pp: move PhwVega10_Magic to static const.

2017-09-28 Thread Alex Deucher
On Wed, Sep 27, 2017 at 7:33 PM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > This isn't used outside this file. > > Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>

Re: [PATCH] amdgpu/pp/vega10: mark vega10_pp_tables_initialize as static.

2017-09-28 Thread Alex Deucher
On Thu, Sep 28, 2017 at 3:17 AM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > This isn't used outside this file. > > Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>

Re: [PATCH] drm/amdgpu: use designated initialiser for thermal_irq_src.

2017-09-28 Thread Alex Deucher
On Thu, Sep 28, 2017 at 2:13 AM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > This fixes the 0-day build warning. > > Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Alex Deucher <alexander.deuc...@am

Re: [PATCH] drm/amdgpu: map compute rings by least recently used pipe

2017-09-28 Thread Alex Deucher
d ring aliasing which can result in work executing in > time-sliced mode instead of truly parallel mode. > > Signed-off-by: Andres Rodriguez <andre...@gmail.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> And applied. Alex > --- > drivers/gpu/drm/amd/amdgpu

Re: [PATCH] amdgpu/pp: remove ci_smc/smumgr split.

2017-09-28 Thread Alex Deucher
code, > please start cleaning them up. Ideally the function table is in the > same file as all the implementations used in it. > > Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay

Re: [PATCH 0/2] Selectively spread compute rings across pipes

2017-09-28 Thread Alex Deucher
On Tue, Sep 26, 2017 at 2:15 PM, Felix Kuehling wrote: > The series is Acked-by: Felix Kuehling > > Regards, > Felix > > > On 2017-09-26 12:22 PM, Andres Rodriguez wrote: >> This was disabled due to an OCL perf regression as discussed on amd-gfx.

Re: [PATCH] drm/amdgpu: Set the correct value for PDEs/PTEs of ATC memory

2017-09-27 Thread Alex Deucher
Signed-off-by: Yong Zhao <yong.z...@amd.com> Glad we finally got this sorted. Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/dri

Re: [PATCH] amdgpu/pp: move amdgpu_fuses_default into static const.

2017-09-28 Thread Alex Deucher
ave Airlie <airl...@redhat.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c | 4 ++-- > drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 2 -- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c |

Re: [PATCH][drm-next] drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible"

2017-09-28 Thread Alex Deucher
On Thu, Sep 28, 2017 at 6:35 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in pr_err error message and ASSERT > messages. > > Signed-off-by: Colin Ian King Applied. thanks! Alex

Re: [PATCH] drm/amdgpu: correct reference clock value on vega10

2017-09-29 Thread Alex Deucher
On Fri, Sep 29, 2017 at 3:42 AM, wrote: > From: Ken Wang > > Change-Id: I377029075af1e2e002f7cfd793ddd58d8610e474 > Signed-off-by: Ken Wang > --- > drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/2] drm/amd/powerplay: fix a logic error in pp_hw_init

2017-10-01 Thread Alex Deucher
On Fri, Sep 29, 2017 at 10:50 PM, Rex Zhu <rex@amd.com> wrote: > Change-Id: I8607e51a0e4153b36268e2bcf4fe594c2bfbfe23 > Signed-off-by: Rex Zhu <rex@amd.com> Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/amd_power

Re: [PATCH] drm/amd/powerplay: fix a warning in pp_hw_init

2017-10-01 Thread Alex Deucher
On Fri, Sep 29, 2017 at 10:41 PM, Zhu, Rex <rex@amd.com> wrote: > Hi Alex, > > Thanks for pointing out the logic error in pp_hw_init. > Please review the attached patch. Acked-by: Alex Deucher <alexander.deuc...@amd.com> > > Best Regards > Rex > > >

Re: [PATCH] amdgpu/nbio: use constant nbio_hdp_flush_reg structs.

2017-09-29 Thread Alex Deucher
On Thu, Sep 28, 2017 at 8:47 PM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > This removes the init path as well, since the init path > just did some constant init of some structs. > > Signed-off-by: Dave Airlie <airl...@redha

[PATCH] drm/radeon/dp: make radeon_dp_get_dp_link_config static

2017-09-29 Thread Alex Deucher
It's not used outside this file any longer. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/radeon/atombios_dp.c | 8 drivers/gpu/drm/radeon/radeon_mode.h | 4 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH] drm/amd/powerplay: fix a warning in pp_hw_init

2017-09-29 Thread Alex Deucher
Make sure hwmgr is valid. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pow

Re: [amd-staging-drm-next] regression - no fan info (sensors) on RX580

2017-09-29 Thread Alex Deucher
Rex, probably related to the recent cleanups in powerplay. On Fri, Sep 29, 2017 at 10:09 AM, Dieter Nützel wrote: > Hello all, > > since latest update > > 1d7da702e70d3c27408a3bb312c71d6be9f7bebe > drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible" > > I

[PATCH] drm/radeon: move ci_send_msg_to_smc to where it's used

2017-09-29 Thread Alex Deucher
It's used in ci_dpm.c so move it there and make it static. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/radeon/ci_dpm.c | 22 ++ drivers/gpu/drm/radeon/ci_dpm.h | 1 - drivers/gpu/drm/radeon/ci_smc.c | 21 - 3 files c

Re: [PATCH 2/2] amdgpu/pp: constify soft_dummy_pp_table.

2017-09-29 Thread Alex Deucher
On Thu, Sep 28, 2017 at 8:39 PM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerp

Re: [PATCH][drm-next] drm/radeon: make functions alloc_pasid and free_pasid static

2017-09-29 Thread Alex Deucher
On Thu, Sep 28, 2017 at 9:46 AM, Colin King wrote: > From: Colin Ian King > > The functions alloc_pasid and free_pasid are local to the > source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: >

Re: [PATCH] drm/amd/powerplay: fix typo on avfs disable

2017-09-29 Thread Alex Deucher
On Fri, Sep 29, 2017 at 9:15 PM, Evan Quan <evan.q...@amd.com> wrote: > Change-Id: I172c1e05ce026b5d600f5b3607778ab48ee2c812 > Signed-off-by: Evan Quan <evan.q...@amd.com> Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/hw

Re: [PATCH 0/3] DC pull request cleanup

2017-09-27 Thread Alex Deucher
; drm/amd/display: Remove alloc/free macros > drm/amd/display: DC I2C review patches 2, 3, and v2 of patch 1 are: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > > drivers/gpu/drm/amd/display/TODO | 26 + > drivers/gpu/drm/amd/display/amdg

Re: [PATCH] amdgpu/powerplay: constify large struct

2017-09-27 Thread Alex Deucher
<airl...@redhat.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c | 4 ++-- > drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [PATCH 1/2] drm/amdgpu/pp: constify some powerplay tables

2017-09-27 Thread Alex Deucher
On Wed, Sep 27, 2017 at 6:48 PM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > Signed-off-by: Dave Airlie <airl...@redhat.com> Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/

[PATCH] drm/amdgpu: fix vf error handling

2017-09-28 Thread Alex Deucher
The error handling for virtual functions assumed a single vf per VM and didn't properly account for bare metal. Make the error arrays per device and add locking. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 23 ++-- d

Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS

2017-08-24 Thread Alex Deucher
f. Alex > Regards, > Felix > > From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Russell, > Kent <kent.russ...@amd.com> > Sent: Thursday, August 24, 2017 9:06:22 AM > To: Alex Deucher > Cc: Christian König; amd-gfx@lists.freedeskt

Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS

2017-08-24 Thread Alex Deucher
On Thu, Aug 24, 2017 at 5:58 AM, Russell, Kent wrote: > No real reason for sysfs instead of debugfs, I just picked the one that was > more familiar with. I can definitely move it to debugfs instead. I will also > clean up the commit message per Michel's comments. Thank

Re: [PATCH] drm/amdgpu: check memory allocation failure

2017-08-24 Thread Alex Deucher
On Wed, Aug 23, 2017 at 4:39 AM, Christian König wrote: > Am 23.08.2017 um 07:52 schrieb Christophe JAILLET: >> >> Check memory allocation failure and return -ENOMEM in such a case. >> >> 'num_post_dep_syncobjs' still has to be set to 0 before the test in order >> to

Re: [PATCH][drm-next] drm/amdgpu: remove duplicate return statement

2017-08-24 Thread Alex Deucher
On Wed, Aug 23, 2017 at 2:24 PM, Felix Kuehling wrote: > I must have added that accidentally when cherry-picking an internal > patch for upstreaming. Thanks for catching it. > > Reviewed-by: Felix Kuehling Applied. thanks! Alex > > Regards, >

[PATCH 4/4] drm/amdgpu/gfx9: adjust mqd allocation size

2017-08-24 Thread Alex Deucher
To allocate additional space for the dynamic cu masks. Confirmed with the hw team that we only need 1 dword for the mask. The mask is the same for each SE so you only need 1 dword. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

[PATCH 3/4] drm/amdgpu/gfx9: update mqd to include dynamic CU mask

2017-08-24 Thread Alex Deucher
Necessary for proper operation with KIQ. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/include/v9_structs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/include/v9_structs.h b/drivers/gpu/drm/amd/i

[PATCH 1/4] drm/amdgpu/gfx8: apply dynamic cu mask to APUs as well

2017-08-24 Thread Alex Deucher
Confirmed with the hw team. It's the same for all asics. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/d

[PATCH] drm/amdgpu/powerplay/vega10: fix typo in register base index

2017-08-24 Thread Alex Deucher
Probably a copy pasta. No functional difference, both have the same value. Reported-by: Michael von Khurja <mvonkhu...@techpowerup.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 2 +- 1 file changed, 1 ins

[PATCH 2/4] drm/amdgpu/gfx8: drop cz mqd

2017-08-24 Thread Alex Deucher
It was unused and according to hw team, it's the same for all asics in a gfx family so remove it. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/include/vi_structs.h | 259 --- 1 file changed, 259 deletions(-) diff --git a/drive

[PATCH] drm/amdgpu: add automatic per asic settings for gart_size

2017-08-21 Thread Alex Deucher
We need a larger gart for asics that do not support GPUVM on all engines (e.g., MM) to make sure we have enough space for all gtt buffers in physical mode. Change the default size based on the asic type. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/

Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS

2017-08-25 Thread Alex Deucher
On Fri, Aug 25, 2017 at 8:59 AM, Russell, Kent wrote: > There is GPU Power usage reported through amdgpu_pm_info, which also has some > other information as well. I'd like that in sysfs, but I am unsure if we are > allowed to due to the other information reported there. >

Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Alex Deucher
On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell wrote: > sysfs is more stable, and doesn't require root to access > > Signed-off-by: Kent Russell Might as well move the vbios binary itself to sysfs as well. It should be a stable interface :) Alex >

Re: [PATCH] drm/amd/powerplay: delete pp dead code on raven

2017-08-25 Thread Alex Deucher
On Fri, Aug 25, 2017 at 6:18 AM, Rex Zhu <rex@amd.com> wrote: > Change-Id: Ib2a3cd06c540a90eb33fc9e4ce0f3122c5f2c0d3 > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/p

Re: [PATCH] drm/amdgpu: Move VBIOS version to sysfs

2017-08-25 Thread Alex Deucher
On Fri, Aug 25, 2017 at 3:13 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 25.08.2017 um 16:41 schrieb Alex Deucher: >> >> On Fri, Aug 25, 2017 at 9:43 AM, Kent Russell <kent.russ...@amd.com> >> wrote: >>> >>> sysfs is more stable, an

Re: [PATCH 3/3] drm/amdgpu/gfx9: adjust mqd allocation size

2017-08-21 Thread Alex Deucher
team. Alex > > Regards, > Felix > > From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex > Deucher <alexdeuc...@gmail.com> > Sent: Friday, August 18, 2017 11:57:51 PM > To: amd-gfx@lists.freedesktop.or

Re: [PATCH] drm/amdgpu: fix and cleanup shadow handling

2017-08-21 Thread Alex Deucher
On Mon, Aug 21, 2017 at 7:26 AM, Christian König <deathsim...@vodafone.de> wrote: > Ping? Can somebody take a look? > > This is an bugfix and I would like to have it upstream before the next merge > window closes. Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>

Re: [PATCH] drm/amdgpu: discard commands of killed processes

2017-08-21 Thread Alex Deucher
Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/sch

Re: [PATCH] drm/amd/display: fix gamma distortion on Vega

2017-08-21 Thread Alex Deucher
On Mon, Aug 21, 2017 at 4:01 PM, Harry Wentland <harry.wentl...@amd.com> wrote: > From: Roman Li <roman...@amd.com> > > Added missing reg shift/masks to soc base > > Signed-off-by: Roman Li <roman...@amd.com> > Reviewed-by: Harry Wentland <harry.we

Re: [PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

2017-08-30 Thread Alex Deucher
On Fri, Aug 18, 2017 at 2:10 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: > This patch set updates the AMD GPU and Audio CoProcessor (ACP) > audio drivers and the designware i2s driver for Stoney (ST). > ST is an APU similar to Carrizo (CZ) which already has ACP audio >

Re: [radeon-alex:amd-staging-drm-next 68/819] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:154:10: error: 'drm_atomic_helper_connector_dpms' undeclared here (not in a function

2017-08-29 Thread Alex Deucher
On Tue, Aug 29, 2017 at 6:39 PM, Dieter Nützel wrote: > I've send a related kernel crash log to amd-devel some days ago without any > answer, yet... > > Was: > [amd-staging-drm-next] kernel crash with amdgpu on RX580 in > 'drm_object_property_get_value' > > I get this in

Re: [PATCH xf86-video-ati] Require xserver >= 1.13

2017-08-30 Thread Alex Deucher
. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > configure.ac | 8 + > src/Makefile.am | 1 - > src/compat-api.h | 70 +++

Re: [PATCH 14/14] drm/amd/amdgpu: Simplify gfx_v9_0_wait_for_idle()

2017-08-31 Thread Alex Deucher
On Thu, Aug 31, 2017 at 12:06 PM, Tom St Denis <tom.stde...@amd.com> wrote: > Signed-off-by: Tom St Denis <tom.stde...@amd.com> One comment on patch 3. The rest are: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v

Re: [PATCH 03/14] drm/amd/amdgpu: Tidy up gfx_v9_0_gpu_init()

2017-08-31 Thread Alex Deucher
On Thu, Aug 31, 2017 at 12:06 PM, Tom St Denis wrote: > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git

[PATCH] drm/amd/powerplay: fix sclk setting for profile mode for CZ/ST

2017-08-29 Thread Alex Deucher
Need to select dpm0 to avoid clock fluctuations. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 47 +- 1 file changed, 1 insertion(+), 46 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay

Re: [PATCH 5/5] drm/amd/pp: remove polaris10_smc/smumgr split.

2017-10-09 Thread Alex Deucher
r.c| 2226 +- > 4 files changed, 2226 insertions(+), 2400 deletions(-) > delete mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c > delete mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.h Ser

Re: [PATCH 1/9] drm/amd/powerplay: export new smu messages for vega10

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 12:41 AM, Rex Zhu <rex@amd.com> wrote: > Change-Id: I5afa09980174ef191c7aa4e4f9dadaaa189783ca > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/inc/v

Re: [PATCH 2/9] drm/amd/powerplay: add new function point in hwmgr.

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 12:41 AM, Rex Zhu <rex@amd.com> wrote: > used for notify SMU the allocated buffer address. > > Change-Id: I91badca7729b8d9c35faf7fc09dbdee70c26099a > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com

Re: [PATCH 3/9] drm/amd/powrplay: implement function notify_cac_buffer_info on Vega

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 12:42 AM, Rex Zhu <rex@amd.com> wrote: > Change-Id: I4d50bf04ba6f5caf6919b6177517c7b38b9a606a > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/power

Re: [PATCH 4/9] drm/amd/powerplay: implement function notify_cac_buffer_info on VI

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 12:42 AM, Rex Zhu <rex@amd.com> wrote: > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 28 +++ > drivers/gpu/drm/am

Re: [PATCH 9/9] drm/amd/powerplay: delete an outdated comment in amd_powerplay.c

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 12:42 AM, Rex Zhu <rex@amd.com> wrote: > Change-Id: I96abfea4eb7d257d2b6461392683c280b268ef76 > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/amd

Re: [PATCH 7/9] drm/amdgpu: add smu_memory_pool_size module parameter

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 12:42 AM, Rex Zhu wrote: > this allow allocate system memmoy for smu > debug usage. > > Change-Id: Iac0489e528395448abeaf23a22cd6a1031a5b55b > Signed-off-by: Rex Zhu I'd prefer to expose this via debugfs so we can enable/disable it on the

Re: [PATCH 8/9] drm/amdgpu: allocate requested gtt buffer for smu

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 12:42 AM, Rex Zhu wrote: > v2: simplify check smu_memory_size code. > simplify allocate smu memroy code. See my comment in patch 7. More comments below. > > Change-Id: I8eb4f542dc2351c6393e4723f4985df92ff527cd > Signed-off-by: Rex Zhu

Re: [PATCH] drm/amdgpu: SR-IOV data exchange between PF

2017-10-09 Thread Alex Deucher
On Mon, Oct 9, 2017 at 6:29 AM, Horace Chen wrote: > SR-IOV need to exchange some data between PF through shared VRAM > > PF will copy some necessary firmware and information to the shared > VRAM. It also requires some information from VF. PF will send a > key through

[pull] amdgpu pre-reqs for stoney ACP audio support

2017-10-09 Thread Alex Deucher
Hi Dave, Mark, This branch against Linus' master contains the 3 pre-requisite patches for Stoney ACP audio. Mark needs these patches to apply the rest of the Stoney ACP patch set on the audio side. Please pull. Thanks! The following changes since commit

[PATCH 02/11] drm/amd/display: whitespace cleanup in amdgpu_dm.c/h

2017-10-11 Thread Alex Deucher
To match kernel standards. No intended functional change. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 330 ++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 91 +++--- 2 files changed, 192 inse

[PATCH 04/11] drm/amd/display: drop unused functions in amdgpu_dm.c

2017-10-11 Thread Alex Deucher
Not used anywhere. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 82 --- 1 file changed, 82 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amd

[PATCH 03/11] drm/amd/display: make a bunch of stuff in amdgpu_dm.c static

2017-10-11 Thread Alex Deucher
Not used outside of that file. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 136 +++--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 59 -- 2 files changed, 91 insertions(+), 104 deletions(-)

[PATCH 10/11] drm/amd/display: remove unused functions in amdgpu_dm_irq.c

2017-10-11 Thread Alex Deucher
Not used. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 62 -- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h | 5 -- 2 files changed, 67 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amd

[PATCH 09/11] drm/amd/display: whitespace cleanup in amdgpu_dm_irq.c/h

2017-10-11 Thread Alex Deucher
To match kernel standards. No intended functional change. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 111 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h | 38 +++ 2 files changed, 64 inse

[PATCH 01/11] drm/amd/display: fix typo in function name

2017-10-11 Thread Alex Deucher
s/amdgpu_dm_find_first_crct_matching_connector/ amdgpu_dm_find_first_crtc_matching_connector/ And while here, make it static. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++-- drivers/gpu/drm/amd/display/amd

[PATCH 05/11] drm/amd/display: implement dm_delay_in_microseconds

2017-10-11 Thread Alex Deucher
dc uses this. Not sure how important it is. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_service

[PATCH 11/11] drm/amd/display: make amdgpu_dm_irq_handler static

2017-10-11 Thread Alex Deucher
It's not used outside the file. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 6 +++--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.h | 9 - 2 files changed, 3 insertions(+), 12 deletions(-) diff

[PATCH 08/11] drm/amd/display: make log_dpcd static

2017-10-11 Thread Alex Deucher
It's only used in this file. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_type

[PATCH 07/11] drm/amd/display: whitespace cleanup in amdgpu_dm_mst_types.c/h

2017-10-11 Thread Alex Deucher
To match kernel standards. No intended functional change. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 39 +++--- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.h| 5 ++- 2 files changed, 22 inse

Re: [PATCH] drm/amd/pp: add new sysfs pp_alloc_mem_for_smu

2017-10-11 Thread Alex Deucher
On Wed, Oct 11, 2017 at 7:28 AM, Rex Zhu wrote: > Change-Id: Ie06f87445e7d6945472d88ac976693c98d96cd43 > Signed-off-by: Rex Zhu Please add a better patch description. Something like: Add a sysfs interface to allocate a smu logging buffer on the fly.

[PATCH 1/2] drm/amd/display/dc: drop dm_delay_in_microseconds

2017-10-11 Thread Alex Deucher
Use udelay directly. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dm_services.h | 3 --- 3 files changed, 4 inse

<    7   8   9   10   11   12   13   14   15   16   >