[PATCH 2/2] drm/amd/display: drop unused dm_delay_in_microseconds

2017-10-11 Thread Alex Deucher
No longer used. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c b/drivers/gpu/drm/amd/display/amd

Re: [PATCH] drm/amd/display: Add comment for NaN checks in DCN calcs

2017-10-11 Thread Alex Deucher
On Wed, Oct 11, 2017 at 10:55 AM, Harry Wentland <harry.wentl...@amd.com> wrote: > This is confusing as-is and really needs a comment. > > Signed-off-by: Harry Wentland <harry.wentl...@amd.com> Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > dri

[pull] amdgpu drm-fixes-4.14

2017-10-12 Thread Alex Deucher
Hi Dave, One memory management regression fix. The following changes since commit 545036a9944e9d6e50fed4ca03117147c880ff71: Merge tag 'drm-misc-fixes-2017-10-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-10-12 10:38:09 +1000) are available in the git repository at:

Re: [pull] amdgpu drm-fixes-4.14

2017-10-12 Thread Alex Deucher
On Thu, Oct 12, 2017 at 1:02 PM, Christian König <ckoenig.leichtzumer...@gmail.com> wrote: > Am 12.10.2017 um 18:20 schrieb Michel Dänzer: >> >> On 12/10/17 05:58 PM, Alex Deucher wrote: >>> >>> Hi Dave, >>> >>> One memory management r

[PATCH] drm/amdgpu: bump version for vram lost counter query

2017-10-12 Thread Alex Deucher
Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index b9a3258..38cd8bd 100644 --- a/d

Re: [PATCH 2/3] drm/amdgpu:fix vf_error_put

2017-10-18 Thread Alex Deucher
On Wed, Oct 18, 2017 at 5:59 AM, Monk Liu wrote: > it should not work on non-SR-IOV case > > Change-Id: Icf34f88a0642e4b04c857a07b72df3bb772075d6 > Signed-off-by: Monk Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ >

Re: [PATCH] drm/amdgpu: drm/amdgpu: always consider virualised device for checking post (v2)

2017-10-18 Thread Alex Deucher
On Wed, Oct 18, 2017 at 9:44 PM, Pixel Ding wrote: > From: pding > > The post checking on scratch registers isn't reliable for virtual function. > > v2: only change in IGP reading bios. Subject has "drm/amdgpu: drm/amdgpu: " drop one of them. > >

Re: [PATCH] drm/amdgpu: drm/amdgpu: always consider virualised device for checking post (v2)

2017-10-18 Thread Alex Deucher
On Wed, Oct 18, 2017 at 11:09 PM, Ding, Pixel <pixel.d...@amd.com> wrote: > Thanks Alex. Some comments inline. > — > Sincerely Yours, > Pixel > > > > > > > > > On 19/10/2017, 10:34 AM, "Alex Deucher" <alexdeuc...@gmail.com> wrote: > &

Re: [PATCH] drm/amdgpu/psp: prevent page fault by checking write_frame address(v2) -v2: update the ring_buffer_end address

2017-10-17 Thread Alex Deucher
On Mon, Oct 16, 2017 at 11:26 PM, Evan Quan wrote: > Change-Id: If3b79428b32ffab57b4e75f9c20c2b2d7e600223 > Signed-off-by: Evan Quan Please include a better commit message. Something like: Prevent a a possible buffer overflow when updating the ring buffer

[PATCH 2/4] ASoC: AMD: DMA driver changes for Stoney Platform

2017-10-18 Thread Alex Deucher
lution is supported. SRAM bank 1 & SRAM bank 2 will be used for playback scenario. SRAM Bank 3 & SRAM Bank 4 will be used for Capture scenario. Acked-by: Mark Brown <broo...@kernel.org> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Vijendar Mukunda <vij

[PATCH 1/4] ASoC: AMD: disabling memory gating in stoney platform

2017-10-18 Thread Alex Deucher
ernel.org> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- v2: Added comments in code and removed locally defined macros for STONEY and Carrizo. v3: add

[PATCH 4/4] ASoC: AMD: Add machine driver for cz rt5650

2017-10-18 Thread Alex Deucher
From: Akshu Agrawal <akshu.agra...@amd.com> The driver is used for AMD board using rt5650 codec. Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Akshu Agrawal <akshu.agra...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Signed

[PATCH 3/4] ASoC: AMD: Audio buffer related changes for Stoney

2017-10-18 Thread Alex Deucher
From: Vijendar Mukunda <vijendar.muku...@amd.com> Stoney uses 16kb SRAM memory for playback and 16Kb for capture.Modified Max buffer size to have the correct mapping between System Memory and SRAM. Added snd_pcm_hardware structures for playback and capture for Stoney. Reviewed-by: Alex D

[PATCH 0/4 resend] Add ASoC support for AMD Stoney APUs

2017-10-18 Thread Alex Deucher
This patch set updates the AMD GPU and Audio CoProcessor (ACP) audio drivers and the designware i2s driver for Stoney (ST). ST is an APU similar to Carrizo (CZ) which already has ACP audio support. The i2s controller and ACP audio DMA engine are part of the GPU and both need updating so I would

[pull] amdgpu drm-fixes-4.14

2017-10-18 Thread Alex Deucher
7:47 -0400) ---- Alex Deucher (1): Revert "drm/amdgpu: discard commands of killed processes" drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) ___

Re: [PATCH] drm/amd/pp: Fix overflow when setup decf/pix/disp dpm table.

2017-10-18 Thread Alex Deucher
missing any tables. or something like that. With that fixed: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerpla

Re: [PATCH] drm/amdgpu:fix wb_clear

2017-10-18 Thread Alex Deucher
lear the right bit. With that fixed: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/

Re: [PATCH] drm/amd/amdgpu: Remove workaround check for UVD6 on APUs

2017-10-23 Thread Alex Deucher
On Mon, Oct 23, 2017 at 1:03 PM, Tom St Denis <tom.stde...@amd.com> wrote: > On APUs the uvd6 driver was skipping proper suspend/resume routines resulting > in a broken state upon resume. > > Signed-off-by: Tom St Denis <tom.stde...@amd.com> Acked-by: Alex Deucher &l

[pull] amdgpu drm-next-4.15

2017-11-15 Thread Alex Deucher
Hi Dave, Misc fixes for 4.15. The following changes since commit a9386bb051931778436db3dd6e3a163f7db92b56: Merge tag 'drm-misc-next-fixes-2017-11-08' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2017-11-09 11:59:30 +1000) are available in the git repository at:

[pull] amdgpu dc drm-next-4.15-dc

2017-11-15 Thread Alex Deucher
Hi Dave, Various fixes for DC for 4.15. It doesn't look like you pulled the smatch fixes for DC that I sent out last week. Those are also on this branch. The following changes since commit f368d3bfde225199eef2216b03e0ba4944a3434a: amd/display: Fix potential null dereference in dce_calcs.c

[PATCH] Revert "drm/radeon: dont switch vt on suspend"

2017-11-14 Thread Alex Deucher
Fixes distorted colors on some cards on resume from suspend. This reverts commit b9729b17a414f99c61f4db9ac9f9ed987fa0cbfe. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98832 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Cc: sta...@vger.kernel.org --- drivers/gpu/drm/

Re: [PATCH 03/13] drm/amdgpu: use simpler remove_conflicting_pci_framebuffers()

2017-11-27 Thread Alex Deucher
On Fri, Nov 24, 2017 at 12:53 PM, Michał Mirosław <mirq-li...@rere.qmqm.pl> wrote: > Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> radeon and amdgpu patches (3 and 7) are: Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/a

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Alex Deucher
On Mon, Nov 27, 2017 at 3:44 PM, Christian König wrote: > Am 27.11.2017 um 21:01 schrieb Felix Kuehling: >> >> On 2017-11-27 02:37 PM, Koenig, Christian wrote: >>> >>> And that is a clear NAK to this approach. >> >> Hi Christian, >> >> Do you have other objections than

Re: [PATCH v2 2/2] drm/amd/display: Don't call dm_log_to_buffer directly in dc_conn_log

2017-11-28 Thread Alex Deucher
On Tue, Nov 28, 2017 at 6:09 AM, Michel Dänzer <mic...@daenzer.net> wrote: > > Ping on this series. > > This patch is v2 of a previously single patch, which was reviewed by Harry. > > Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > On 2017-11

[PATCH 1/2] drm/amdgpu: add license to Makefiles

2017-11-30 Thread Alex Deucher
Was missing license text. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/acp/Makefile | 21 drivers/gpu/drm/amd/amdgpu/Makefile| 21 drivers/gpu/drm/amd/amdkfd/Ma

[PATCH 2/2] drm/amdgpu: add license to files where it was missing

2017-11-30 Thread Alex Deucher
These files were missing it before. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 23 ++ drivers/gpu/drm/amd/display/dc/core/dc_debug.c

Re: [PATCH v2 xf86-video-amdgpu] Add amdgpu_dirty_src_drawable helper

2017-11-27 Thread Alex Deucher
d-off-by: Michel Dänzer <michel.daen...@amd.com> Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > src/amdgpu_drv.h | 18 +- > src/amdgpu_kms.c | 7 ++- > 2 files changed, 11 insertions(+), 14 deletions(-) > > diff --git a/src/a

Re: [PATCH] Revert "drm/amdgpu: fix rmmod KCQ disable failed error"

2017-11-27 Thread Alex Deucher
On Sun, Nov 26, 2017 at 10:53 PM, Liu, Monk <monk@amd.com> wrote: > Anyone review this one ? Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of > Monk Li

Re: [PATCH 1/3] drm/amdgpu: Add SOC15 IP offset define file

2017-11-27 Thread Alex Deucher
On Mon, Nov 27, 2017 at 4:28 PM, Christian König <christian.koe...@amd.com> wrote: > Am 27.11.2017 um 21:56 schrieb Alex Deucher: >> >> On Mon, Nov 27, 2017 at 3:44 PM, Christian König >> <christian.koe...@amd.com> wrote: >>> >>> Am 27.11.2017 um

[pull] radeon, amdgpu, and ttm drm-fixes-4.15

2017-11-29 Thread Alex Deucher
) Alex Deucher (4): drm/amdgpu/gfx7: cache raster_config values drm/amdgpu: used cached gca values for cik_read_register Revert "drm/amdgpu: fix rmmod KCQ disable failed error" drm/amdgpu: drop experimental flag

Re: [PATCH 1/2] drm/amd/display: Use macro for isnan check

2017-11-29 Thread Alex Deucher
On Wed, Nov 29, 2017 at 3:21 PM, Harry Wentland wrote: > In code provided by HW teams we do a NaN check on floats > by comparing the number against itself. This confuses most > people including myself. Macro it out to make it self-explanatory. > > Don't do a NaN check for

Re: [PATCH v2 1/2] drm/amd/display: Use macro for isnan check

2017-11-29 Thread Alex Deucher
Don't do a NaN check for int. > > v2: parantheses around 'number' expression > > Signed-off-by: Harry Wentland <harry.wentl...@amd.com> Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.c | 18

[PATCH] drm/amd/display: add mod_freesync_user_enable to dm_connector_state

2017-12-04 Thread Alex Deucher
We don't currently expose variable refresh rate, but add the state to the connector state to make it easier to maintain the support for it from a hw support perspective while we figure out the uapi for drm. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/d

Re: [PATCH libdrm 3/3] amdgpu: Only remember the device's marketing name

2017-12-04 Thread Alex Deucher
g > name. > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > amdgpu/Android.mk| 3 +- > amdgpu/Makefile.am | 5 +-- > amdgpu/amdgpu_asic_id.c | 88 > --

Re: [PATCH 0/2] Move scheduler out of AMDGPU

2017-12-04 Thread Alex Deucher
On Fri, Dec 1, 2017 at 10:55 AM, Christian König wrote: > Am 01.12.2017 um 16:28 schrieb Lucas Stach: >> >> Hi all, >> >> so this is the first step to make the marvelous AMDGPU scheduler useable >> for other drivers. I have a (mostly) working prototype of Etnaviv using

[PATCH 2/3] drm/amdgpu: drop scratch regs save and restore from GPU reset handling

2017-12-12 Thread Alex Deucher
The expectation is that the base driver doesn't mess with these. Some components interact with these directly so let the components handle these directly. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- 1 file changed, 2 del

Re: [PATCH] drm/amdgpu: setup the shared and private apertures on gfx9

2017-12-14 Thread Alex Deucher
On Fri, Dec 8, 2017 at 3:10 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: > Same as previous asics. This was not yet set for gfx9. Ping? > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 17 -

Re: [PATCH 2/2] drm/amdgpu:impl virt_gart_flush_tlbs

2017-12-13 Thread Alex Deucher
On Tue, Dec 12, 2017 at 10:42 PM, Monk Liu wrote: > a new gart flush tlb function implemented for SRIOV, > and invoke it during RUNTIME for gart flush TLBs > > this could avoid the issue that gart flush (via CPU MMIO) > being interrupted by word switch which lead to DMAR error >

[pull] amdgpu and ttm drm-fixes-4.15

2017-12-14 Thread Alex Deucher
Hi Dave, Nothing too major here. A couple more ttm fixes for huge page and a kiq fix for amdgpu. The following changes since commit 90eeb3aa34831ff3d031589c0c24892eb8a07e51: Merge tag 'drm-misc-fixes-2017-12-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2017-12-08

Re: [PATCH] drm/amdgpu: implement 2+1 PD support for Raven v2

2017-12-14 Thread Alex Deucher
On Thu, Dec 14, 2017 at 7:03 AM, Christian König wrote: > Instead of falling back to 2 level and very limited address space use > 2+1 PD support and 128TB + 512GB of virtual address space. > > v2: cleanup defines, rebase on top of level enum > > Signed-off-by:

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Alex Deucher
+- > drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +- For amdgpu: Acked-by: Alex Deucher <alexander.deuc...@amd.com> > drivers/media/i2c/msp3400-kthreads.c | 2 +- > drivers/message/fusion/mptsas.c | 2 +- > drive

Re: [PATCH 5/5] drm/amd/pp: implement force_dpm_level on rv

2017-12-18 Thread Alex Deucher
;rex@amd.com> Patches 1-4: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 127 > + > drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h | 15 +++ > 2 files changed, 142 insertions(+) > >

Re: [PATCH 2/4] drm/amd/pp: update smu_version value for CI/VI

2017-12-19 Thread Alex Deucher
ngs fixed: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c | 1 + > drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c | 2 +- > drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c| 2 +- > 3 files changed

Re: [PATCH 3/4] drm/amd/pp: get Rv smu_version and notify amdgpu

2017-12-19 Thread Alex Deucher
On Tue, Dec 19, 2017 at 3:11 AM, Rex Zhu <rex@amd.com> wrote: Please include a patch description. E.g., The smu firmware is loaded by the sbios on APUs, so query it from the smu and update the smu fw version info that is reported to userspace. With that fixed: Reviewed-by: Alex D

Re: [PATCH 1/4] drm/amd/pp: move smu_version out vega to hwmgr

2017-12-19 Thread Alex Deucher
On Tue, Dec 19, 2017 at 3:11 AM, Rex Zhu <rex@amd.com> wrote: Please include a better patch description. Something like: Move the smu_version to common code so it can be shared by other asics. With that fixed: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>

Re: [PATCH 4/4] drm/amd/pp: implement force_dpm_level on rv

2017-12-19 Thread Alex Deucher
On Tue, Dec 19, 2017 at 3:11 AM, Rex Zhu <rex@amd.com> wrote: > user can change engine/mclk/soc/vcn clocks on Rv > > v3: add smu version check > v2: fix no return statement Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > > Signed-off-by: Rex Zhu <rex.

[PATCH 2/2] drm/amdgpu: use defines for mmBIF_IOV_FUNC_IDENTIFIER fields

2017-12-19 Thread Alex Deucher
Rather than magic numbers. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index c59b37365e4d..da2b99

[PATCH 1/2] drm/amdgpu: only check mmBIF_IOV_FUNC_IDENTIFIER on tonga/fiji

2017-12-19 Thread Alex Deucher
We only support SR-IOV on tonga/fiji. Don't check this register on other VI parts. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/vi.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH 02/16] drm/amdgpu: use consistent naming for static funcs in amdgpu_device.c

2017-12-15 Thread Alex Deucher
Prefix the functions with device or device_ip for functions which deal with ip blocks for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 176 +++-- 1 file changed, 90 insertions(+), 86 del

[PATCH 07/16] drm/amdgpu: rename amdgpu_pci_config_reset

2017-12-15 Thread Alex Deucher
add device for consistency with other functions in this file. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/cik.c | 2 +- drivers/gpu/d

[PATCH 15/16] drm/amdgpu: move amdgpu_need_backup to amdgpu_object.c

2017-12-15 Thread Alex Deucher
It's the only place it's used. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 8 3 files changed, 8 insertions

[PATCH 01/16] drm/amdgpu: move atom functions from amdgpu_device.c

2017-12-15 Thread Alex Deucher
and move them to amdgpu_atombios.c for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 236 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_de

[PATCH 11/16] drm/amdgpu: rename ip block helper functions

2017-12-15 Thread Alex Deucher
add device to the name for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 38 + drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 50 +-- drivers/gpu/d

[PATCH 05/16] drm/amdgpu: rename amdgpu_wb_* functions

2017-12-15 Thread Alex Deucher
add device for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c| 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 00/16] clean up amdgpu_device.c

2017-12-15 Thread Alex Deucher
to amdgpu_atombios.c 4. moves a bunch of helper functions local to where they are used Alex Deucher (16): drm/amdgpu: move atom functions from amdgpu_device.c drm/amdgpu: use consistent naming for static funcs in amdgpu_device.c drm/amdgpu: rename amdgpu_suspend to amdgpu_device_ip_suspend drm/amdgpu: move

[PATCH 10/16] drm/amdgpu: move fw_reserve functions to amdgpu_ttm.c

2017-12-15 Thread Alex Deucher
It's the only place they are used. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 95 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH 03/16] drm/amdgpu: rename amdgpu_suspend to amdgpu_device_ip_suspend

2017-12-15 Thread Alex Deucher
for consistency with the other functions in that file. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 2 +- 3 files chan

[PATCH 13/16] drm/amdgpu: move dummy page functions to amdgpu_gart.c

2017-12-15 Thread Alex Deucher
It's the only place they are used. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 -- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 45 --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c

[PATCH 08/16] drm/amdgpu: move amdgpu_doorbell_get_kfd_info to amdgpu_amdkfd.c

2017-12-15 Thread Alex Deucher
It's the only place it's used. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 33 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.

[PATCH 12/16] drm/amdgpu: rename amdgpu_need_post

2017-12-15 Thread Alex Deucher
add device to the name for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 3 files changed, 6 insertions

[PATCH 06/16] drm/amdgpu: rename amdgpu_program_register_sequence

2017-12-15 Thread Alex Deucher
add device for consistency with other functions in this file. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +- drivers/gpu/drm/amd/amdgpu/cik.c

[PATCH 14/16] drm/amdgpu: rename amdgpu_gpu_recover

2017-12-15 Thread Alex Deucher
add device to the name for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 09/16] drm/amdgpu: rename amdgpu_*_location functions

2017-12-15 Thread Alex Deucher
add device to the name for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 6 -- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++ drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 4 ++-- drivers/gpu/drm/amd/

[PATCH 04/16] drm/amdgpu: move debugfs functions to their own file

2017-12-15 Thread Alex Deucher
amdgpu_device.c was getting pretty cluttered. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

[PATCH 16/16] drm/amdgpu: rename amdgpu_get_pcie_info

2017-12-15 Thread Alex Deucher
add device to the name for consistency. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/cik.c | 2 +- drivers/gpu/drm/amd/amdgpu/s

[pull] amdgpu drm-fixes-4.15

2017-12-15 Thread Alex Deucher
Hi Dave, I forgot to include the DC fixes from Harry when I sent out my fixes yesterday. This just adds them on top. The following changes since commit 0507f438ea19d4280006467ba02956f6a693deca: drm/amdgpu: fix MAP_QUEUES paramter (2017-12-12 15:40:11 -0500) are available in the git

Re: [PATCH] drm/amd/pp: need to notify umd the pstate clock.

2017-12-13 Thread Alex Deucher
On Wed, Dec 13, 2017 at 4:52 AM, Rex Zhu wrote: > Change-Id: I344731cc6398c40976e08a125808bbfa85cb59a3 > Signed-off-by: Rex Zhu Please include a better patch description. Something like: Flag the stable pstate clocks in sysfs so userspace knows what clocks are

Re: [PATCH] drm/amdgpu: Add gpu_recovery parameter

2017-12-12 Thread Alex Deucher
On Tue, Dec 12, 2017 at 2:16 PM, Andrey Grodzovsky wrote: > Add new parameter to control GPU recovery procedure. > Retire old way of disabling GPU recovery by setting lockup_timeout == 0 and > set default for lockup_timeout to 10s. > > Signed-off-by: Andrey Grodzovsky

[PATCH 1/3] drm/amdgpu: drop scratch regs save and restore from S3/S4 handling

2017-12-12 Thread Alex Deucher
The expectation is that the base driver doesn't mess with these. Some components interact with these directly so let the components handle these directly. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- 1 file changed, 2 del

[PATCH 3/3] drm/amdgpu: drop amdgpu_atombios_scratch_regs_save/restore

2017-12-12 Thread Alex Deucher
No longer used. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 22 -- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 2 -- 2 files changed, 24 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atom

[PATCH] drm/amdgpu: remove some old gc 9.x registers

2017-12-12 Thread Alex Deucher
Leftover from bring up. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/clearstate_gfx9.h | 8 ++-- .../drm/amd/include/asic_reg/gc/gc_9_0_default.h | 7 .../drm/amd/include/asic_reg/gc/gc_9_0_offset.h| 14 --- .../drm/amd/i

Re: [PATCH 2/3] drm/amd/include:cleanup vega10 hdp header files.

2017-11-16 Thread Alex Deucher
On Thu, Nov 16, 2017 at 3:03 AM, Feifei Xu <feifei...@amd.com> wrote: > Cleanup asic_reg/vega10/HDP folder, remove hdp_4_0_default.h > > Change-Id: Ia7cd2e660ceb89a1096c195c6a67677714ccbd69 > Signed-off-by: Feifei Xu <feifei...@amd.com> > Reviewed-by: Alex Deucher

Re: [PATCH] drm/amd/pp: fix typecast error in powerplay.

2017-11-17 Thread Alex Deucher
On Fri, Nov 17, 2017 at 3:59 AM, Rex Zhu <rex@amd.com> wrote: > resulted in data truncation > > Change-Id: I110011ba402a85fade89bb797adcf7318c0f0eb0 > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- >

Re: [PATCH 1/4] drm/amdgpu: always make gart.table_addr 64bit

2017-11-17 Thread Alex Deucher
On Fri, Nov 17, 2017 at 5:12 AM, Christian König <ckoenig.leichtzumer...@gmail.com> wrote: > Fixing warning/compile errors on 32bit kernels. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > ---

Re: [PATCH 3/4] drm/amdgpu: align GTT start to 4GB

2017-11-17 Thread Alex Deucher
ize_af; > } > - mc->gart_start = mc->vram_end + 1; > + mc->gart_start = ALIGN(mc->vram_end + 1, 0x10000ULL); Please add a comment here as to why we are doing this. With that fixed: Reviewed-by: Alex Deucher <alexander.deuc...@amd.

Re: [PATCH 2/4] drm/amdgpu: remove VRAM size reduction

2017-11-17 Thread Alex Deucher
ease also fix up gmc_v6_0.c. With that fixed: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > 3 files changed, 1 insertion(+), 41 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 65

Re: [PATCH 4/4] drm/amdgpu: fix VCE buffer placement restrictions

2017-11-17 Thread Alex Deucher
ffers. > > Signed-off-by: Christian König <christian.koe...@amd.com> Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 90 > - > 1 file changed, 88 insertions(+), 2 deletions(-) >

Re: [PATCH] drm/amdgpu: remove amdgpu_pm_sysfs_init in ci_dpm.c

2017-11-17 Thread Alex Deucher
On Fri, Nov 17, 2017 at 3:15 AM, Rex Zhu <rex@amd.com> wrote: > this function was called in amdgpu_device_init > > Change-Id: I69aa77ba7db41d2202c3d6ffd606965f0cad3106 > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com&g

Re: [PATCH 2/4] drm: amd: Fix line continuation formats

2017-11-17 Thread Alex Deucher
On Thu, Nov 16, 2017 at 10:50 AM, Joe Perches wrote: > On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote: >> On 2017-11-16 10:27 AM, Joe Perches wrote: >> > Line continuations with excess spacing causes unexpected output. > [] >> > @@ -872,9 +870,8 @@ static bool

[PATCH] drm/amdgpu/gmc9: make some ECC messages debug only

2017-11-17 Thread Alex Deucher
To avoid spamming the logs on non-ECC boards. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_

Re: [PATCH 3/3] drm/amdgpu: expose the VA above the hole to userspace

2017-11-17 Thread Alex Deucher
e driver version as well. With that, this series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 12 ++-- > include/uapi/drm/amdgpu_drm.h | 4 > 2 files changed, 14 insertions(+), 2 deletions(-) &

Re: [PATCH] drm/amdgpu: set f_mapping on exported DMA-bufs

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 7:13 AM, Christian König <ckoenig.leichtzumer...@gmail.com> wrote: > Otherwise we can't correctly CPU map TTM buffers. > > Signed-off-by: Christian König <christian.koe...@amd.com> Acked-by: Alex Deucher <alexander.deuc...@amd.com> > ---

Re: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver

2017-11-13 Thread Alex Deucher
On Mon, Nov 13, 2017 at 9:40 AM, Chen, Horace wrote: > Reivewed-by: Horace Chen Applied. thanks! Alex > > -Original Message- > From: Liu, Monk > Sent: Monday, November 13, 2017 11:43 AM > To: Chen, Horace ; Colin King >

Re: [PATCH 0/7] *** GPU recover V3 ***

2017-11-13 Thread Alex Deucher
trace of a kernel panic if it happens, is it correct ? Yes, the deadlock in the GPU scheduler was the issue preventing that from working properly. Alex > > Thx > Julien > > On 9 November 2017 at 18:08, Alex Deucher <alexdeuc...@gmail.com> wrote: >> >> On Thu, Nov 9

Re: [PATCH] drm/amdgpu: Properly allocate VM invalidate eng v2

2017-11-14 Thread Alex Deucher
t; Signed-off-by: Oak Zeng <oak.z...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.

[PATCH] drm/amdgpu: don't skip attributes when powerplay is enabled

2017-11-20 Thread Alex Deucher
The function checks non-powerplay structures so regressed when the pp_enabled check was removed. This should ideally be implemented similarly for powerplay. Fixes: 6d07fe7bcae57 ("drm/amdgpu: delete pp_enable in adev") Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> ---

Re: [amd-staging-drm-next] regression - no fan info (sensors) on RX580

2017-11-20 Thread Alex Deucher
adev > > amdgpu not care powerplay or dpm is enabled. > just check ip functions and pp functions > > Change-Id: Iaac75d45170ef9b20e212465f837eaaa798365bd > Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > Signed-off-by: R

[PATCH] drm/radeon: fix possible memory leak in radeon_bo_create

2017-11-20 Thread Alex Deucher
if ttm_bo_init fails, don't leak the bo object. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/radeon/radeon_object.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c

Re: [PATCH] drm/radeon: fix possible memory leak in radeon_bo_create

2017-11-20 Thread Alex Deucher
On Mon, Nov 20, 2017 at 11:36 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: > if ttm_bo_init fails, don't leak the bo object. > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Ignore this patch. ttm cleans up for us. Alex > --- > drivers/gpu/drm/radeon/

[PATCH 1/2] drm/radeon: Add dpm quirk for Jet PRO

2017-11-21 Thread Alex Deucher
Fixes stability issues. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103370 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/radeon/si_dpm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si

[pull] amdgpu drm-next-4.15

2017-11-21 Thread Alex Deucher
) Alex Deucher (2): Revert "drm/radeon: dont switch vt on suspend" drm/amdgpu: don't skip attributes when powerplay is enabled Eric Huang (1): drm/amd/powerplay: fix unfreeze level smc message for smu7 Monk Liu (2): drm/amdgpu:fix memleak i

Re: [PATCH 1/5] drm/amd/powerplay: Minor fixes in processpptables.c

2017-11-21 Thread Alex Deucher
't actually hit this case, but if we did, it's fine to return success. Alex > > Regards > //Ernst > > 2017-11-21 16:15 GMT+01:00 Alex Deucher <alexdeuc...@gmail.com>: >> On Sun, Nov 19, 2017 at 12:52 PM, Ernst Sjöstrand <ern...@gmail.com> wrote: >>> Reported by

Re: [PATCH] drm/amdgpu: move UVD/VCE and VCN structure out from union

2017-11-21 Thread Alex Deucher
cn.num_enc_rings" is not zero because of the union. For some reason the patch doesn't seem to have come through properly on the mailing list. Acked-by: Alex Deucher <alexander.deuc...@amd.com> > > [ 9066.794232] BUG: unable to handle kernel paging request at > 99b64000

Re: [PATCH 1/5] drm/amd/powerplay: Minor fixes in processpptables.c

2017-11-21 Thread Alex Deucher
On Sun, Nov 19, 2017 at 12:52 PM, Ernst Sjöstrand wrote: > Reported by smatch: > init_overdrive_limits() error: uninitialized symbol 'result'. > get_clock_voltage_dependency_table() warn: inconsistent indenting > > Signed-off-by: Ernst Sjöstrand > --- >

Re: [PATCH 1/5] drm/amd/powerplay: Minor fixes in processpptables.c

2017-11-21 Thread Alex Deucher
On Tue, Nov 21, 2017 at 10:15 AM, Alex Deucher <alexdeuc...@gmail.com> wrote: > On Sun, Nov 19, 2017 at 12:52 PM, Ernst Sjöstrand <ern...@gmail.com> wrote: >> Reported by smatch: >> init_overdrive_limits() error: uninitialized symbol 'result'. >> get_cloc

[PATCH] drm/amdgpu: used cached gca values for cik_read_register

2017-11-21 Thread Alex Deucher
Using the cached values has less latency for bare metal and prevents reading back bogus values if the engine is powergated. This was implemented for VI and SI, but somehow CIK got missed. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/cik.c

Re: [PATCH] drm/amd/vce: correct vce fw data and stack size config for sriov

2017-11-21 Thread Alex Deucher
On Tue, Nov 21, 2017 at 3:33 AM, Frank Min wrote: Please provide a better patch description. What was the problem and how did you fix it? Alex > Signed-off-by: Frank Min > --- > drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 30 +- >

Re: [PATCH] drm/amdgpu: always make gart.table_addr 64bit

2017-11-16 Thread Alex Deucher
On Thu, Nov 16, 2017 at 12:31 PM, Christian König <ckoenig.leichtzumer...@gmail.com> wrote: > Fixing warning/compile errors on 32bit kernels. > > Signed-off-by: Christian König <christian.koe...@amd.com> Acked-by: Alex Deucher <alexander.deuc...@amd.com> > ---

Re: [PATCH] Revert "drm/radeon: dont switch vt on suspend"

2017-11-16 Thread Alex Deucher
Ping? On Tue, Nov 14, 2017 at 5:33 PM, Alex Deucher <alexdeuc...@gmail.com> wrote: > Fixes distorted colors on some cards on resume from suspend. > > This reverts commit b9729b17a414f99c61f4db9ac9f9ed987fa0cbfe. > > Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98832

Re: [PATCH] drm/amd/display: remove unnecessary cast and use kcalloc instead of kzalloc

2017-11-16 Thread Alex Deucher
On Wed, Nov 15, 2017 at 10:45 AM, Colin King wrote: > From: Colin Ian King > > Use kcalloc instead of kzalloc and the cast on the return from kzalloc is > unnecessary and can be removed. > > Signed-off-by: Colin Ian King

<    8   9   10   11   12   13   14   15   16   17   >