Re: [PATCH 03/12] drm/amdgpu: allow flushing VMID0 before IB execution as well

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > This allows us to queue IBs which needs an up to date system domain as well. > > Signed-off-by: Christian König <christian.koe.

Re: [PATCH 06/12] drm/amdgpu: bind BOs with GTT space allocated directly

2017-06-30 Thread Alex Deucher
mismatch between documentation and function name. I prefer the full amdgpu_gtt_mgr_is_allocated or even better amdgpu_gtt_mgr_addr_is_allocated. With that fixed up: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > +{ > + struct drm_mm_node *node = mem->mm_node; &

Re: [PATCH 12/12] drm/amdgpu: add gtt_sys_limit

2017-06-30 Thread Alex Deucher
BO size > we can swap out. The last phrase can be dropped as it's no longer relevant. Acked-by: Alex Deucher <alexander.deuc...@amd.com> > > Signed-off-by: Christian König <christian.koe...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ > drivers/

Re: [PATCH 04/12] drm/amdgpu: add vm_needs_flush parameter to amdgpu_copy_buffer

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > This allows us to flush the system VM here. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex D

Re: [PATCH 08/12] drm/amdgpu: add amdgpu_gart_map function

2017-06-30 Thread Alex Deucher
ristian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 64 > > 2 files changed, 52 insertions(+), 15 deletions(-)

[PATCH] drm/amdgpu/acp: properly handle powergating in hw_fini

2017-06-30 Thread Alex Deucher
Stoney does not have powergating, so make the powergating teardown dependent on whether we have a genpd structure. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-)

Re: [PATCH 07/12] drm/amdgpu: reserve the first 2x2MB of GART

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König wrote: > From: Christian König > > We want to use them as remap address space. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c |

Re: [PATCH 01/12] drm/amdgpu: move ring helpers to amdgpu_ring.h

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > Keep them where they belong. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex D

Re: [PATCH 05/12] drm/amdgpu: bind BOs to TTM only once

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > No need to do this on every round. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex D

Re: [PATCH 09/12] drm/amdgpu: use the GTT windows for BO moves

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > This way we don't need to map the full BO at a time any more. > > Signed-off-by: Christian König <christian.koe...@amd.c

Re: [PATCH 10/12] drm/amdgpu: stop mapping BOs to GTT

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > No need to map BOs to GTT on eviction and intermediate transfers any more. > > Signed-off-by: Christian König <christian.koe...@am

Re: [PATCH 11/12] drm/amdgpu: remove maximum BO size limitation.

2017-06-30 Thread Alex Deucher
On Fri, Jun 30, 2017 at 7:22 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > We can finally remove this now. > > Signed-off-by: Christian König <christian.koe...@amd.com> Woot! Reviewed-by: Alex D

[PATCH 3/5] drm/amdgpu/atombios: add function for whether we need asic_init

2017-06-30 Thread Alex Deucher
Check the atom scratch registers to see if asic_init is complete or not. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 10 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 1 + 2 files changed, 11 insertions(+) diff

[PATCH 1/5] drm/amdgpu/atombios: use bios_scratch_reg_offset for atombios

2017-06-30 Thread Alex Deucher
Align with the atomfirmware code. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/g

[PATCH 4/5] drm/amdgpu: check scratch registers to see if we need post

2017-06-30 Thread Alex Deucher
Rather than checking the CONGIG_MEMSIZE register as that may not be reliable on some APUs. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/d

[PATCH 2/5] drm/amdgpu: unify some atombios/atomfirmware scratch reg functions

2017-06-30 Thread Alex Deucher
Now that we use a pointer to the scratch reg start offset, most of the functions were duplicated. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 35 drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.

Re: [PATCH 08/12] drm/amdgpu: disallow foreign BOs for UVD/VCE

2017-07-03 Thread Alex Deucher
On Mon, Jul 3, 2017 at 5:11 PM, Felix Kuehling wrote: > From: Christian König > > They don't support VM mode yet. > > Signed-off-by: Christian König > Reviewed-by: Felix Kuehling This could

Re: [PATCH 2/2] drm/amdgpu: Don't call amd_powerplay_destroy() if we don't have powerplay

2017-07-02 Thread Alex Deucher
9] RIP: kfree+0x57/0x160 RSP: c90003403cc0 > [ 91.560761] CR2: ffffebe00620 > [ 91.560765] ---[ end trace 08a9f3cd82223c1d ]--- > > Fixes: 1c8638024846 (drm/amd/powerplay: refine powerplay interface.) > Signed-off-by: John Brooks <j...@fastquake.com> Both patches a

[PATCH 2/2] drm/amdgpu/gfx9: fix driver reload with KIQ

2017-07-04 Thread Alex Deucher
Drop the KCQ disabling via KIQ. We disable the MEC shortly after anyway, so there is no need to wait for all of this. Doing so seems to leave the MEC in a bad way. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.

[PATCH 1/2] drm/amdgpu/gfx8: fix driver reload with KIQ

2017-07-04 Thread Alex Deucher
Drop the deactivation in KIQ init and drop the KCQ disabling via KIQ. We disable the MEC shortly after anyway, so there is no need to wait for all of this. Doing so seems to leave the MEC in a bad way. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/powerplay: fix bug fail to remove sysfs when rmmod amdgpu.

2017-07-04 Thread Alex Deucher
On Tue, Jul 4, 2017 at 4:42 AM, Rex Zhu <rex@amd.com> wrote: > when hw_fini, pp will disable dpm.so remove sysfs before > disable dpm. > > Change-Id: I17114f5c964b870802abbde32544b28eeb6173ab > Signed-off-by: Rex Zhu <rex@amd.com> Reviewed-by: Alex Deucher

[PATCH] drm/amdgpu: check scratch registers to see if we need post (v2)

2017-07-03 Thread Alex Deucher
Rather than checking the CONGIG_MEMSIZE register as that may not be reliable on some APUs. v2: The scratch register is only used on CIK+ Reviewed-by: Christian König <christian.koe...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH][drm-next] drm/amdgpu: make arrays pctl0_data and pctl1_data static

2017-07-06 Thread Alex Deucher
On Thu, Jul 6, 2017 at 5:58 AM, Colin King wrote: > From: Colin Ian King > > The arrays pctl0_data and pctl1_data do not need to be in global scope, > so them both static. > > Cleans up sparse warnings: > symbol 'pctl0_data' was not declared.

Re: [PATCH 01/11] drm/amdgpu: reserve the first 2x512 of GART

2017-07-06 Thread Alex Deucher
On Mon, Jul 3, 2017 at 5:44 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > We want to use them as remap address space. > > Signed-off-by: Christian König <christian.koe...@amd.com> 2x512 pages. Wit

Re: [PATCH 02/11] drm/amdgpu: add amdgpu_gart_map function v2

2017-07-06 Thread Alex Deucher
e unused assignment > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 62 > +++

Re: [PATCH 03/11] drm/amdgpu: use the GTT windows for BO moves v2

2017-07-06 Thread Alex Deucher
n König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 125 > +++- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 2 + > 2 files changed, 108 insertions(+),

Re: [PATCH 04/11] drm/amdgpu: stop mapping BOs to GTT

2017-07-06 Thread Alex Deucher
On Mon, Jul 3, 2017 at 5:44 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > No need to map BOs to GTT on eviction and intermediate transfers any more. > > Signed-off-by: Christian König <christian.koe.

Re: [PATCH 05/11] drm/amdgpu: remove maximum BO size limitation v2

2017-07-06 Thread Alex Deucher
;christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 12 > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > b/drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH 06/11] drm/amdgpu: use TTM values instead of MC values for the info queries

2017-07-06 Thread Alex Deucher
On Mon, Jul 3, 2017 at 5:44 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > Use the TTM values instead of the hardware config here. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed

Re: [PATCH 08/11] drm/amdgpu: move SYSVM struct and function into amdgpu_sysvm.h

2017-07-06 Thread Alex Deucher
efer gart to sysvm for the naming. Acked-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 48 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_sysvm.h | 77 > +++ > drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH 10/11] drm/amdgpu: setup GTT size directly from module parameter

2017-07-06 Thread Alex Deucher
On Mon, Jul 3, 2017 at 5:44 AM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > Instead of relying on the sysvm_size to be the same as the module parameter. > > Signed-off-by: Christian König <christian.koe.

Re: [PATCH 09/11] drm/amdgpu: move amdgpu_sysvm_location into amdgpu_sysvm.c as well

2017-07-06 Thread Alex Deucher
On Mon, Jul 3, 2017 at 5:44 AM, Christian König wrote: > From: Christian König > > No intended functional change. > > Signed-off-by: Christian König I think I'd prefer to keep this together with the vram_location

Re: [PATCH 11/11] drm/amdgpu: add sysvm_size

2017-07-06 Thread Alex Deucher
Update the description. The limitation is removed now. > > v2: rebased and cleaned up after GART to SYSVM rename. > > Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgp

Re: [PATCH xf86-video-amdgpu] Only call drmmode_scanout_free for non-GPU screens in LeaveVT

2017-06-27 Thread Alex Deucher
;Use drmmode_crtc_scanout_* helpers for RandR 1.4 > scanout pixmaps") > (Ported from radeon commit c9dd28cb0c9c3de676eadac61e727732510f6b9b) > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> &

Re: [PATCH xf86-video-ati 2/2] Improve drmmode_fb_reference debugging code

2017-06-27 Thread Alex Deucher
rror). > > (Ported from amdgpu commit 1b6ff5fd9933c00ec1ec90dfc62e0b531927749b) > > Signed-off-by: Michel Dänzer <michel.daen...@amd.com> Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > src/drmmode_display.h | 29 ++--- &

Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-29 Thread Alex Deucher
On Wed, Jun 28, 2017 at 7:08 PM, Gustavo A. R. Silva wrote: > Hi Alex, > > Quoting "Deucher, Alexander" : > >>> -Original Message- >>> From: Gustavo A. R. Silva [mailto:garsi...@embeddedor.com] >>> Sent: Wednesday, June 28, 2017 10:22 AM

[pull] amdgpu drm-next-4.13

2017-07-05 Thread Alex Deucher
to remove sysfs when rmmod amdgpu. (2017-07-05 13:18:50 -0400) Alex Deucher (6): drm/amd/powerplay/cz: print message if smc message fails drm/amdgpu/psp: upper_32_bits/lower_32_bits for address setup drm/amdgpu: fix

Re: Question about porting VCE1 to amdgpu

2017-06-27 Thread Alex Deucher
On Tue, Jun 27, 2017 at 1:08 PM, Alexandre Demers wrote: > Just a quick update: things a getting into shape slowly since my paternal > vacancy is over, but I'm still progressing. I'm debugging things as I can. I > managed to work around the missing header with the

[PATCH 2/2] drm/amdgpu/soc15: init nbio registers for vega10

2017-07-06 Thread Alex Deucher
Call nbio init registers on hw_init to set up any nbio registers that need initialization at hw init time. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/soc15.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc1

[PATCH 1/2] drm/amdgpu: add nbio 6.1 register init function

2017-07-06 Thread Alex Deucher
Used for nbio registers that need to be initialized. Currently only used for a golden setting that got missed on some boards. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 13 + drivers/gpu/drm/amd/amdgpu/nbio_v6_1.h |

Re: [PATCH] drm/amdgpu: NO KIQ usage on nbio hdp flush routine

2017-07-05 Thread Alex Deucher
un@amd.com> > > Please split this patch in two, one to add the new macro, the next to convert > the nbio code. With that fixed: > Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > >> --- >> drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c| 2 +- >> dr

[PATCH 3/3] drm/amdgpu/gmc9: get vram width from atom for Raven

2017-07-05 Thread Alex Deucher
Get it from the system info table. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 76 ++- 1 file changed, 40 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/g

[PATCH 1/3] drm/amdgpu/atom: fix atom_fw check

2017-07-05 Thread Alex Deucher
Not all vbios images seem to set the version appropriately. Switch the check based on asic type instead. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff

[PATCH 2/3] drm/amdgpu/atomfirmware: implement vram_width for APUs

2017-07-05 Thread Alex Deucher
Implement support using the new atomfirmware system info table. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 33 drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.h | 1 + 2 files changed, 34 inse

Re: [PATCH] drm/amdgpu: add parameter to allocate high priority contexts v8

2017-04-25 Thread Alex Deucher
On Tue, Apr 25, 2017 at 4:28 PM, Andres Rodriguez wrote: > > > On 2017-04-25 02:01 PM, Nicolai Hähnle wrote: >> >> On 24.04.2017 18:20, Andres Rodriguez wrote: >>> >>> Add a new context creation parameter to express a global context >>> priority. >>> >>> The priority ranking

Re: [PATCH 1/2] drm/radeon: Avoid overflows/divide-by-zero in latency_watermark calculations.

2017-04-26 Thread Alex Deucher
Mario Kleiner <mario.kleiner...@gmail.com> > Cc: Alex Deucher <alexander.deuc...@amd.com> Applied the series. thanks! Alex > --- > drivers/gpu/drm/radeon/cik.c | 19 +++ > drivers/gpu/drm/radeon/evergreen.c | 8 +--- > drivers/gpu/drm/radeon/

Re: [PATCH 1/2] drm/amdgpu: Add missing lb_vblank_lead_lines setup to DCE-6 path.

2017-04-26 Thread Alex Deucher
On Sun, Apr 23, 2017 at 7:02 PM, Mario Kleiner <mario.kleiner...@gmail.com> wrote: > This apparently got lost when implementing the new DCE-6 support > and would cause failures in pageflip scheduling and timestamping. > > Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.co

Re: [PATCH] drm/amdgpu: remove unused and mostly unimplemented CGS functions v2

2017-04-27 Thread Alex Deucher
t; Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 198 --- > drivers/gpu/drm/amd/include/cgs_common.h | 270 > --

Re: [PATCH umr] Avoid opening the DRM file by default

2017-04-28 Thread Alex Deucher
ly defer > opening it until --top is invoked. > > Signed-off-by: Tom St Denis <tom.stde...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > src/app/top.c | 7 +++ > src/lib/discover.c | 3 +-- > 2 files changed, 8 insertions(+), 2 de

[pull] radeon and amdgpu drm-next-4.12

2017-04-28 Thread Alex Deucher
: drm/amdgpu: Make amdgpu_bo_reserve use uninterruptible waits for cleanup (2017-04-28 17:33:16 -0400) Alex Deucher (3): drm/amdgpu: fix spelling in header comment drm/amdgpu: bump version number to note race fix and new

Re: [PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations

2017-07-28 Thread Alex Deucher
On Fri, Jul 28, 2017 at 6:08 PM, Andy Furniss <adf.li...@gmail.com> wrote: > Alex Deucher wrote: >> >> May waste a bit of memory, but simplifies the interface >> significantly. > > > Can't boot tonga with this (testing 4.14-wip) Should be fixed with this p

[PATCH 4/9] drm/amdgpu Moving amdgpu asic types to a separate file

2017-07-28 Thread Alex Deucher
From: Akshu Agrawal <akshu.agra...@amd.com> Amdgpu asic types will be required for other drivers too. Hence, its better to keep it in a separate include file. Signed-off-by: Akshu Agrawal <akshu.agra...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> ---

[PATCH 0/9 v2] Add ASoC support for AMD Stoney APUs

2017-07-28 Thread Alex Deucher
This patch set updates the AMD GPU and Audio CoProcessor (ACP) audio drivers and the designware i2s driver for Stoney (ST). ST is an APU similar to Carrizo (CZ) which already has ACP audio support. The i2s controller and ACP audio DMA engine are part of the GPU and both need updating so I would

[PATCH 2/9 v2] drm/amd/amdgpu: Added asic_type as ACP DMA driver platform data

2017-07-28 Thread Alex Deucher
From: Vijendar Mukunda <vijendar.muku...@amd.com> asic_type information is passed to ACP DMA Driver as platform data. Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- v2:Removed asic_type local variable an

[PATCH 3/9 v2] drm/amd/amdgpu: Added a quirk for Stoney platform

2017-07-28 Thread Alex Deucher
rammed to support 32 bit format and 4 bytes bus width only. By setting this quirk,It will override 32 bit format with 16 bit format and 2 bytes as bus width for Stoney. Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> ---

[PATCH 4/4] drm/amdgpu/sdma4: move wptr polling setup

2017-07-28 Thread Alex Deucher
Move it up before ring enablement with all of the other engine setup and explicitly disable it for bare metal. Cc: Frank Min <frank@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/

[PATCH 2/4] drm/amdgpu/sdma4: drop hdp flush from wptr shadow update

2017-07-28 Thread Alex Deucher
The wb buffer is in system memory, not vram so the flush is useless. Cc: Frank Min <frank@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 1 - 1 file c

[PATCH 5/9 v2] ASoC: AMD: disabling memory gating in stoney platform

2017-07-28 Thread Alex Deucher
ndar.muku...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- v2: Added comments in code and removed locally defined macros for STONEY and Carrizo. sound/soc/amd/acp-pcm-dma.c | 79 +++-- 1 file changed, 55 insertions(+), 24

[PATCH 6/9 v2] ASoC: AMD: DMA driver changes for Stoney Platform

2017-07-28 Thread Alex Deucher
lution is supported. SRAM bank 1 & SRAM bank 2 will be used for playback scenario. SRAM Bank 3 & SRAM Bank 4 will be used for Capture scenario. Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- v2: Added

[PATCH 1/9] ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver

2017-07-28 Thread Alex Deucher
From: Vijendar Mukunda <vijendar.muku...@amd.com> Added quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to Designware driver. This quirk will set idx value to 1. By setting this quirk, it will override supported format as 16 bit resolution and bus width as 2 Bytes. Reviewed-by: Alex D

[PATCH 7/9 v2] ASoC: AMD: Audio buffer related changes for Stoney

2017-07-28 Thread Alex Deucher
jendar Mukunda <vijendar.muku...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- v2: Added switch cases for asic type. sound/soc/amd/acp-pcm-dma.c | 73 + 1 file changed, 68 insertions(+), 5 deletions(-) diff --git a/sou

[PATCH 8/9 v2] drm/amd/amdgpu: Disabling Power Gating for Stoney platform

2017-07-28 Thread Alex Deucher
From: Vijendar Mukunda <vijendar.muku...@amd.com> Power Gating is disabled in Stoney platform. Signed-off-by: Vijendar Mukunda <vijendar.muku...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- v2: added missing changes required for power gating and

[PATCH] drm/amdgpu: use 256 bit buffers for all wb allocations (v2)

2017-07-28 Thread Alex Deucher
May waste a bit of memory, but simplifies the interface significantly. v2: convert internal accounting to use 256bit slots Reviewed-by: Christian König <christian.koe...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

Re: [PATCH libdrm 2/2] drm: merge and cleanup amdgpu_bo_free

2017-08-08 Thread Alex Deucher
esktop.org/mesa/drm Alex > > BR Monk > > > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Wednesday, August 9, 2017 12:19 AM > To: Christian König <deathsim...@vodafone.de> > Cc: Liu, Monk <monk@amd.com>; amd-

Re: [PATCH xf86-video-ati v2 1/3] Use root window (pixmap) instead of screen pixmap for scanout updates

2017-08-01 Thread Alex Deucher
On Tue, Aug 1, 2017 at 5:19 AM, Michel Dänzer <mic...@daenzer.net> wrote: > From: Michel Dänzer <michel.daen...@amd.com> > > Preparation for following changes, no functional change intended yet. > > Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> #

Re: [PATCH libdrm 1/2] drm: fix missing mutex unlock before return

2017-08-07 Thread Alex Deucher
On Mon, Aug 7, 2017 at 10:46 AM, Christian König wrote: > Am 07.08.2017 um 16:35 schrieb Monk Liu: >> >> From: Monk Liu >> >> Change-Id: I377dde976648d53bc9a3a2d5ba294c284910b109 >> Signed-off-by: Monk Liu > > > Reviewed-by: Christian

Re: [PATCH libdrm 2/2] drm: merge and cleanup amdgpu_bo_free

2017-08-08 Thread Alex Deucher
On Tue, Aug 8, 2017 at 3:54 AM, Christian König wrote: > Am 08.08.2017 um 09:34 schrieb Monk Liu: >> >> From: Monk Liu >> >> since bo_reference and bo_internal_free are >> all only used by bo_free, so we just merge them >> together >> >> Change-Id:

[PATCH 1/3] dma-buf: dma_fence_put is NULL safe

2017-08-07 Thread Alex Deucher
From: Christian König <christian.koe...@amd.com> No need to check. Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/dma-buf/reservation.c |

[PATCH 0/3] dma-buf changes for ttm and amdgpu

2017-08-07 Thread Alex Deucher
We have some changes in ttm and amdgpu that depend on these patches. Sumit, can you pull these in via dma-buf or should I roll them up through my amdgpu tree? Christian König (3): dma-buf: dma_fence_put is NULL safe dma-buf: add reservation_object_copy_fences dma-buf: fix

[PATCH 2/3] dma-buf: add reservation_object_copy_fences

2017-08-07 Thread Alex Deucher
From: Christian König <christian.koe...@amd.com> Allows us to copy all the fences in a reservation object to another one. Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Alex Deucher <alex

[pull] radeon and amdgpu drm-next-4.14

2017-08-18 Thread Alex Deucher
Hi Dave, More changes for 4.14. Highlights: - command submission overhead improvements - Huge page support for vega10 - physical mode support for mjpeg for asics that don't support UVD vm - improve ttm_mem_type_manager_func debug - misc ttm fixes, cleanups - misc gpuvm cleanups The following

[PATCH 0/6 v3] Add ASoC support for AMD Stoney APUs

2017-08-18 Thread Alex Deucher
This patch set updates the AMD GPU and Audio CoProcessor (ACP) audio drivers and the designware i2s driver for Stoney (ST). ST is an APU similar to Carrizo (CZ) which already has ACP audio support. The i2s controller and ACP audio DMA engine are part of the GPU and both need updating so I would

[PATCH 2/6 v2] drm/amdgpu Moving amdgpu asic types to a separate file

2017-08-18 Thread Alex Deucher
From: Akshu Agrawal <akshu.agra...@amd.com> Amdgpu asic types will be required for other drivers too. Hence, its better to keep it in a separate include file. Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Akshu Agrawal <akshu.agra...@amd.com> Signed-of

[PATCH] drm/amdgpu: fix a bogus warning

2017-08-17 Thread Alex Deucher
Don't validate the default value. Prevents a needless warning. Also fix a spelling typo in the warning message. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

[pull] radeon and amdgpu drm-next-4.14

2017-08-16 Thread Alex Deucher
) Alex Deucher (10): drm/amdgpu: make wb 256bit function names consistent drm/amdgpu: drop old ip definitions for gfxhub and mmhub drm/amdgpu/sdma4: drop unused register header drm/amdgpu/sdma4: set wptr shadow atomically (v2) drm/amdgpu/sdma4

[PATCH 1/3] drm/amdgpu/gfx8: fix spelling typo in mqd allocation

2017-08-18 Thread Alex Deucher
Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c| 12 ++-- drivers/gpu/drm/amd/include/vi_structs.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/d

[PATCH 3/3] drm/amdgpu/gfx9: adjust mqd allocation size

2017-08-18 Thread Alex Deucher
to allocate additional space for the dynamic cu masks. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c| 25 ++--- drivers/gpu/drm/amd/include/v9_structs.h | 8 2 files changed, 26 insertions(+), 7 del

[PATCH 2/3] drm/amdgpu/gfx9: update mqd to include dynamic CU mask

2017-08-18 Thread Alex Deucher
Necessary for proper operation with KIQ. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/include/v9_structs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/include/v9_structs.h b/drivers/gpu/drm/amd/i

[PATCH] drm/amdgpu: set sched_hw_submission higher for KIQ (v2)

2017-08-22 Thread Alex Deucher
performance when there are several KFD processes running. v2: move some expressions to one line change KIQ sched_hw_submission to at least 16 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 16 1 file changed, 12 inse

[PATCH 2/2] drm/amdgpu: move default gart size setting into gmc modules

2017-08-22 Thread Alex Deucher
Move the asic specific code into the IP modules. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 52 drivers/gpu/drm/amd/amdgpu/amdgpu_gart.h | 1 - drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c

[PATCH 1/2] drm/amdgpu: refine default gart size

2017-08-22 Thread Alex Deucher
Be more explicit and add comments explaining each case. Also s/gart/GART/ in the parameter string as per Felix' suggestion. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.

Re: [PATCH] drm/amd/include: Add hdmi_redriver_set to atomfirmware

2017-08-22 Thread Alex Deucher
On Tue, Aug 22, 2017 at 9:35 AM, Harry Wentland <harry.wentl...@amd.com> wrote: > We'll need this for a some upcoming display changes > > Signed-off-by: Harry Wentland <harry.wentl...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > ---

[PATCH] drm/amdgpu: set sched_hw_submission higher for KIQ

2017-08-22 Thread Alex Deucher
performance when there are several KFD processes running. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/g

[PATCH] drm/amdgpu: disable DC on KB/ML for now

2017-08-23 Thread Alex Deucher
Until I've had time to test it better. bug: https://bugs.freedesktop.org/show_bug.cgi?id=102372 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

Re: [PATCH] drm/amdgpu/gfx: drop max_gs_waves_per_vgt

2017-05-03 Thread Alex Deucher
On Wed, May 3, 2017 at 8:41 AM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > On 02.05.2017 21:50, Alex Deucher wrote: >> >> We already have this info: max_gs_threads. Drop the duplicate. > > > max_gs_waves_per_vgt seems to be the better name for this number though

Re: [PATCH 1/6] drm/amdgpu:fix cannot receive rcv/ack irq bug

2017-05-03 Thread Alex Deucher
On Tue, May 2, 2017 at 11:48 PM, Monk Liu <monk@amd.com> wrote: > Change-Id: Ie8672e0c9358d9542810ce05c822d9367249bbd7 > Signed-off-by: Monk Liu <monk@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/mxgpu_a

Re: [PATCH 2/6] drm/amdgpu:need som change on vega10 mailbox

2017-05-03 Thread Alex Deucher
} >> return 0; >> @@ -211,7 +213,7 @@ static int xgpu_ai_mailbox_ack_irq(struct >> amdgpu_device *adev, >> struct amdgpu_irq_src *source, >> struct amdgpu_iv_entry *entry) >> { &

Re: [PATCH 3/6] drm/amdgpu:re-write sriov_reinit_early/late

2017-05-03 Thread Alex Deucher
sr-iov, it's fine. Maybe we can look at unifying things for sr-iov and bare metal in this case in the future. With the ARRAY_SIZE change: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Alex > > BR Monk > > > > -Original Message- > From: Christian König

Re: [PATCH 4/6] drm/amdgpu:cleanups KIQ ring_funcs emit_frame_size

2017-05-03 Thread Alex Deucher
On Tue, May 2, 2017 at 11:48 PM, Monk Liu <monk@amd.com> wrote: > since we don't need hdp flush/inval for KIQ anymore > > Change-Id: I8518f479afebb73c68ef922880f92dae53b665b9 > Signed-off-by: Monk Liu <monk@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...

Re: [PATCH 6/6] drm/amdgpu:PTE flag should be 64 bit width

2017-05-03 Thread Alex Deucher
; Reviewed-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c &g

[PATCH] drm/amdgpu: properly byteswap gpu_info firmware

2017-05-11 Thread Alex Deucher
It's stored in LE format. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/

Re: [PATCH 2/2] drm/amdgpu: export test ring debugfs interface

2017-05-10 Thread Alex Deucher
ubject: [PATCH 2/2] drm/amdgpu: export test ring debugfs interface >> > > >> > > Signed-off-by: Huang Rui <ray.hu...@amd.com> >> > >> > Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> >> >> Not sure if it's important for thi

[PATCH 2/4] drm/radeon/ci: disable mclk switching for high refresh rates

2017-05-11 Thread Alex Deucher
Even if the vblank period would allow it, it still seems to be problematic on some cards. bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/radeon/ci_dpm.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 2/5] drm/amdgpu/gfx9: wait once for all KCQs to be created

2017-05-11 Thread Alex Deucher
Rather than waiting for each queue. Reviewed-by: monk liu <monk@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 60 +-- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/dri

[PATCH 4/4] drm/amd/powerplay/smu7: disable mclk switching for high refresh rates

2017-05-11 Thread Alex Deucher
Even if the vblank period would allow it, it still seems to be problematic on some cards. bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 ++- 1 file changed, 2 inse

[PATCH 1/4] drm/amdgpu/ci: disable mclk switching for high refresh rates

2017-05-11 Thread Alex Deucher
Even if the vblank period would allow it, it still seems to be problematic on some cards. bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 6 ++ 1 file changed, 6 insertions(+)

[PATCH 3/4] drm/amd/powerplay/smu7: add vblank check for mclk switching

2017-05-11 Thread Alex Deucher
Check to make sure the vblank period is long enough to support mclk switching. bug: https://bugs.freedesktop.org/show_bug.cgi?id=96868 Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 31 +--- 1 file chang

[PATCH libdrm 1/3] amdgpu: add raven family id

2017-05-10 Thread Alex Deucher
From: Hawking Zhang <hawking.zh...@amd.com> Signed-off-by: Hawking Zhang <hawking.zh...@amd.com> Signed-off-by: Chunming Zhou <david1.z...@amd.com> Reviewed-by: Junwei Zhang <jerry.zh...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- include/

[PATCH libdrm 2/3] amdgpu/drm: add AMDGPU_HW_IP_VCN_DEC

2017-05-10 Thread Alex Deucher
From: Leo Liu <leo@amd.com> Signed-off-by: Leo Liu <leo@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> --- include/drm/amdgpu_drm.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 090/117] drm/amdgpu: add vcn enc ring type and functions

2017-05-10 Thread Alex Deucher
From: Leo Liu <leo@amd.com> Add the ring function callbacks for the encode rings. Signed-off-by: Leo Liu <leo@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Signed-off-by: Alex Deucher &l

<    4   5   6   7   8   9   10   11   12   13   >