Re: [PATCH] gpu: drm: radeon: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

2019-02-16 Thread Alex Deucher via amd-gfx
On Sat, Feb 16, 2019 at 1:01 AM Lukas Wunner wrote: > > On Fri, Feb 15, 2019 at 11:01:04AM -0500, Alex Deucher wrote: > > On Fri, Feb 15, 2019 at 10:39 AM Rafael J. Wysocki > > wrote: > > > On HP ProBook 4540s, if PM-runtime is enabled in the radeon driver > > > and the direct-complete

[PATCH] drm/amdgpu/psp11: TA firmware is optional (v2)

2019-02-12 Thread Alex Deucher via amd-gfx
Don't warn or fail if it's missing. v2: handle xgmi case more gracefully. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 9 ++-- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 28 ++--- 2 files changed, 23 insertions(+), 14 deletions(-) diff

[PATCH] drm/amdgpu/psp11: TA firmware is optional

2019-02-12 Thread Alex Deucher via amd-gfx
Don't warn or fail if it's missing. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 -- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 28 ++--- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git

[PATCH] drm/amdgpu/psp11: TA firmware is optional (v3)

2019-02-12 Thread Alex Deucher via amd-gfx
Don't warn or fail if it's missing. v2: handle xgmi case more gracefully. v3: handle older kernels properly Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 9 ++-- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 28 ++--- 2 files changed, 23

[PATCH] drm/amdgpu/psp11: TA firmware is optional (v2)

2019-02-12 Thread Alex Deucher via amd-gfx
Don't warn or fail if it's missing. v2: handle xgmi case more gracefully. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 9 ++-- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 28 ++--- 2 files changed, 23 insertions(+), 14 deletions(-) diff

Re: [PATCH v2 1/4] drm/sched: Fix entities with 0 rqs.

2019-02-13 Thread Alex Deucher via amd-gfx
On Wed, Jan 30, 2019 at 5:43 AM Christian König wrote: > > Am 30.01.19 um 02:53 schrieb Bas Nieuwenhuizen: > > Some blocks in amdgpu can have 0 rqs. > > > > Job creation already fails with -ENOENT when entity->rq is NULL, > > so jobs cannot be pushed. Without a rq there is no scheduler to > > pop

[pull] amdgpu, sched drm-fixes-5.0

2019-02-13 Thread Alex Deucher via amd-gfx
Hi Dave, Daniel, A few small fixes for 5.0. amdgpu: - Vega20 psp fix - Add vrr range to debugfs for freesync debugging sched: - Scheduler race fix The following changes since commit 78eb1ca47589f0cd9db2ceb28b60434e8d512131: Merge branch 'vmwgfx-fixes-5.0-2' of

[PATCH] drm/amdgpu/powerplay: declare firmware for CI cards

2019-02-13 Thread Alex Deucher via amd-gfx
Missing firmware declaration caused firmware requirement to not be noted by the module and may cause firmware to not be available in initrd. Fixes: bc4b539e385088 "drm/amdgpu: remove old CI DPM implementation" Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 4

Re: [PATCH] drm/amd/display: Fix reference counting for struct dc_sink.

2019-02-13 Thread Alex Deucher via amd-gfx
Add amd-gfx and some DC people. Alex On Sun, Feb 10, 2019 at 5:13 AM wrote: > > From: Mathias Fröhlich > > Reference counting in amdgpu_dm_connector for amdgpu_dm_connector::dc_sink > and amdgpu_dm_connector::dc_em_sink as well as in dc_link::local_sink seems > to be out of shape. Thus make

[PATCH] drm/amdgpu: remove some old unused dpm helpers

2019-02-14 Thread Alex Deucher via amd-gfx
Carried over from radeon, but no longer used. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 88 - drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 9 --- 2 files changed, 97 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c

[PATCH] drm/amdgpu: don't clamp debugfs register access to the BAR size

2019-02-11 Thread Alex Deucher via amd-gfx
This prevents us from accessing extended registers in tools like umr. The register access functions already check if the offset is beyond the BAR size and use the indirect accessors with locking so this is safe. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 3

Re: [PATCH] drm: Mark expected switch fall-throughs

2019-02-15 Thread Alex Deucher via amd-gfx
On Fri, Feb 15, 2019 at 11:08 AM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in some cases, the code comment is modified > in

Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

2019-02-15 Thread Alex Deucher via amd-gfx
Adding dri-devel. On Thu, Feb 14, 2019 at 2:53 AM Emily Deng wrote: > > For multiple GPUs which has the same BDF, but has different domain ID, > the drmOpenByBusid will return the wrong fd when startx. > > The reproduce sequence as below: > 1. Call drmOpenByBusid to open Card0, then will return

Re: [PATCH] gpu: drm: radeon: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

2019-02-15 Thread Alex Deucher via amd-gfx
On Fri, Feb 15, 2019 at 10:39 AM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > On HP ProBook 4540s, if PM-runtime is enabled in the radeon driver > and the direct-complete optimization is used for the radeon device > during system-wide suspend, the system doesn't resume. > >

[PATCH 6/6] drm/amdgpu: use BACO on vega12 if platform supports it

2019-02-15 Thread Alex Deucher via amd-gfx
Use BACO for reset of the platform supports it. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c index 99ebcf29dcb0..b2cbe4b42a3d 100644 ---

[PATCH 5/6] drm/amdgpu/powerplay: split out common smu9 BACO code

2019-02-15 Thread Alex Deucher via amd-gfx
Several of the BACO functions are common across smu9-based asics. Split the common code out. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 2 +- .../gpu/drm/amd/powerplay/hwmgr/smu9_baco.c | 66 +++

[PATCH 4/6] drm/amdgpu/powerplay: add BACO support for vega12

2019-02-15 Thread Alex Deucher via amd-gfx
This implements BACO (Bus Active, Chip Off) support for vega12. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 3 +- .../gpu/drm/amd/powerplay/hwmgr/vega12_baco.c | 156 ++ .../gpu/drm/amd/powerplay/hwmgr/vega12_baco.h | 32

[PATCH 1/6] drm/amdgpu: add missing license on baco files

2019-02-15 Thread Alex Deucher via amd-gfx
Trivial. Signed-off-by: Alex Deucher --- .../gpu/drm/amd/powerplay/hwmgr/vega10_baco.c | 22 +++ .../gpu/drm/amd/powerplay/hwmgr/vega20_baco.c | 22 +++ 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.c

[PATCH 3/6] drm/amdgpu/powerplay: fix typo in BACO header guards

2019-02-15 Thread Alex Deucher via amd-gfx
s/BOCO/BACO/g Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.h | 4 ++-- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_baco.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.h

[PATCH 2/6] drm/amdgpu/powerplay: fix return codes in BACO code

2019-02-15 Thread Alex Deucher via amd-gfx
Use a proper return code rather than -1. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_baco.c | 4 ++-- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_baco.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git