[PATCH 3/7] drm/amdgpu: remove VM shadow WARN_ONs

From: Christian König <christian.koe...@amd.com> Printing a warning into the logs that we will certainly run into a BUG() is completely nonsense, the BUG() is more than noisy enough. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amd

[PATCH 1/7] drm/amdgpu: fix VM flush for CPU based updates

From: Christian König <christian.koe...@amd.com> We don't have any update fence in that case, so the need for flushing isn't detected atomatically. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++--- 1 file changed, 3 inse

[PATCH 7/7] drm/amdgpu: map VM BOs for CPU based updates only once

From: Christian König <christian.koe...@amd.com> No need to try to map them very time. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 87 -- 1 file changed, 51 insertions(+), 36 deletions(-)

[PATCH 5/7] drm/amdgpu: flush the HDP only once for CPU based VM updates

From: Christian König <christian.koe...@amd.com> No need to do this after every single update. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a

[PATCH 6/7] drm/amdgpu: make sure BOs are always kunmapped

From: Christian König <christian.koe...@amd.com> When a BO is moved or destroyed it shouldn't be kmapped any more. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH 4/7] drm/amdgpu: trace setting VM page tables with the CPU as well

From: Christian König <christian.koe...@amd.com> Handy for debugging. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/dr

[PATCH 2/7] drm/amdgpu: fix amdgpu_vm_bo_wait

From: Christian König <christian.koe...@amd.com> We need to wait with the correct owner on unmap operations or otherwise can run into VM faults. Also always wait for the page directory since this is where the reservation object comes from. So rename the function to amdgpu_vm_wait_pd i

Re: [PATCH 08/12] drm/amdgpu: disallow foreign BOs for UVD/VCE

Am 12.07.2017 um 07:06 schrieb Felix Kuehling: On 17-07-03 10:55 PM, Alex Deucher wrote: On Mon, Jul 3, 2017 at 5:11 PM, Felix Kuehling <felix.kuehl...@amd.com> wrote: From: Christian König <christian.koe...@amd.com> They don't support VM mode yet. Signed-off-by: Chr

Re: [PATCH 1/2] drm/amdgpu: add get_clock_info for atomfirmware

: Alex Deucher <alexander.deuc...@amd.com> ping? this fixes looking up the reference clocks on vega10 and raven. The both two are Acked-by: Chunming Zhou <david1.z...@amd.com> Acked-by: Christian König <christian.koe...@amd.com> as well. I think somebody else should dig into t

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

Am 11.07.2017 um 17:43 schrieb Jason Ekstrand: On Tue, Jul 11, 2017 at 12:17 AM, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de>> wrote: [SNIP] If we ever want to share fences across processes

Re: [PATCH] drm/amdgpu: Optimize recursion in amdgpu_vm_update_level

Am 12.07.2017 um 21:38 schrieb Felix Kuehling: On 17-07-12 03:50 AM, Christian König wrote: That optimization is unnecessary. I have a patch in the pipeline that makes the VM BO permanently CPU mapped and also fixes a couple of bugs in those code path. You mean just for the CPU-update path

Re: [PATCH 5/7] drm/amdgpu: flush the HDP only once for CPU based VM updates

flush comes after the VM flush. I think we could change that, but I'm not 100% sure what the interactions with SRVIO are. Christian. Either way, this is Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com> Regards, Felix On 17-07-12 04:31 AM, Christian König wrote: From: Chr

[PATCH 2/3] drm/amdgpu: only move VM BOs in the LRU during validation

From: Christian König <christian.koe...@amd.com> This should save us a bunch of command submission overhead. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 15 +++-- drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 1/3] drm/amdgpu: track if a PD needs an update

From: Christian König <christian.koe...@amd.com> That should reduce our command submission overhead quite a bit. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 + 2 file

[PATCH 3/3] drm/amdgpu: only bind VM shadows after validation

From: Christian König <christian.koe...@amd.com> No need to do this on every CS. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/dr

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can take a look at it, I just won't have time until next week most likely. I've taken a look, and it's seemingly more complicated than I'm expecting I'd want to land in Mesa

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

Am 17.07.2017 um 05:36 schrieb Dave Airlie: I can take a look at it, I just won't have time until next week most likely. I've taken a look, and it's seemingly more complicated than I'm expecting I'd want to land in Mesa before 17.2 ships, I'd really prefer to just push the new libdrm_amdgpu api

Re: [PATCH 2/2] drm/amdgpu: Implement ttm_bo_driver.access_vram callback

Am 14.07.2017 um 21:44 schrieb Felix Kuehling: On 17-07-14 06:08 AM, Christian König wrote: Am 13.07.2017 um 23:08 schrieb Felix Kuehling: [SNIP] +result += bytes; +buf = (uint8_t *)buf + bytes; +pos += bytes; +len -= bytes; +if (pos >= (nodes->

[PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4

From: Christian König <christian.koe...@amd.com> The hardware can use huge pages to map 2MB of address space with only one PDE. v2: few cleanups and rebased v3: skip PT updates if we are using the PDE v4: rebased, added support for CPU based updates Signed-off-by: Christian König <chri

[PATCH 1/2] drm/amdgpu: increase fragmentation size for Vega10 v2

From: Christian König <christian.koe...@amd.com> The fragment bits work differently for Vega10 compared to previous generations. Increase the fragment size to 2MB for now to better handle that. v2: handle the hardware setup as well Signed-off-by: Christian König <christian.koe..

Re: [PATCH libdrm] amdgpu: revert semaphore support

in place? Thanks. Best Regards, David On 11 Jul 2017, at 5:28 PM, Christian König <deathsim...@vodafone.de> wrote: I hoped that Dave Airlied will land it together with this patch. As far as I know the closed source driver already doesn't use that any more either. Regards, Christian. Am 11.0

Re: [PATCH libdrm] amdgpu: revert semaphore support

version in specific? We still rely on legacy semaphore implementation and we have to use it if sync object still takes time. Thanks. Best Regards, David On 11 Jul 2017, at 5:15 PM, Christian König <deathsim...@vodafone.de> wrote: From: Christian König <christian.koe...@amd.com>

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

Am 11.07.2017 um 11:20 schrieb Dave Airlie: On 11 July 2017 at 18:36, Christian König <deathsim...@vodafone.de> wrote: Am 11.07.2017 um 08:49 schrieb Dave Airlie: On 7 July 2017 at 19:07, Christian König <deathsim...@vodafone.de> wrote: Hi Dave, on first glance that looks rathe

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

Am 11.07.2017 um 08:49 schrieb Dave Airlie: On 7 July 2017 at 19:07, Christian König <deathsim...@vodafone.de> wrote: Hi Dave, on first glance that looks rather good to me, but there is one things I don't really like and I strongly think Marek will absolutely agree on that: When we add

[PATCH libdrm] amdgpu: revert semaphore support

From: Christian König <christian.koe...@amd.com> This reverts commit 6b79c66b841dded6ffa6b56f14e4eb10a90a7c07 and commit 6afadeaf13279fcdbc48999f522e1dc90a9dfdaf. Semaphore support was never used by any open source project and not even widely by any closed source driver. This should be re

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

Am 10.07.2017 um 17:28 schrieb Jason Ekstrand: On Wed, Jul 5, 2017 at 6:04 PM, Dave Airlie > wrote: From: Dave Airlie > This interface will allow sync object to be used to back Vulkan

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

and the reason why that even Microsoft forbids that under windows. Christian. Alex Bin Xie *From:*amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] *On Behalf Of *Jason Ekstrand *Sent:* Monday, July 10, 2017 11:53 AM *To:* Christian König <deathsim...@vodafone.de> *Cc:* Dave Airlie

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

Am 10.07.2017 um 17:52 schrieb Jason Ekstrand: On Mon, Jul 10, 2017 at 8:45 AM, Christian König <deathsim...@vodafone.de <mailto:deathsim...@vodafone.de>> wrote: Am 10.07.2017 um 17:28 schrieb Jason Ekstrand: On Wed, Jul 5, 2017 at 6:04 PM, Dave Airlie <ai

Re: [PATCH 1/6] drm: Add helper to check exporting driver of a DMA-buf

admore a function which returns the casted GEM object or NULL in mind, but that should o it as well. Patch is Reviewed-by: Christian König <christian.koe...@amd.com> Regards, Christian. --- drivers/gpu/drm/drm_prime.c | 24 include/drm/drmP.h | 2 ++ 2 files

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

Hi Dave, on first glance that looks rather good to me, but there is one things I don't really like and I strongly think Marek will absolutely agree on that: When we add a new CS function then let's get ride of all this abstraction! The new function should get an amdgpu_device_handle and a

[PATCH 5/6] drm/amdgpu: add new gttsize module parameter

From: Christian König <christian.koe...@amd.com> This allows setting the gtt size independent of the gart size. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++

[PATCH 6/6] drm/amdgpu: change gartsize default to 256MB

From: Christian König <christian.koe...@amd.com> Limit the default GART size and save a lot of VRAM. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +--- dri

[PATCH 3/6] drm/amdgpu: consistent name all GART related parts

From: Christian König <christian.koe...@amd.com> Rename symbols from gtt_ to gart_ as appropriate. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 22 +++--- dri

[PATCH 1/6] drm/amdgpu: move GART struct and function into amdgpu_gart.h v2

From: Christian König <christian.koe...@amd.com> No functional change, just cleanup. v2: rebased, keep gart name. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 48 +--- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 2/6] drm/amdgpu: remove gtt_base_align handling

From: Christian König <christian.koe...@amd.com> Not used any more. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c |

Re: [PATCH] drm/amdgpu: implement si_read_bios_from_rom

Am 12.07.2017 um 15:19 schrieb Alex Deucher: This allows us to read the vbios image directly from ROM. This is already implemented for other asics, but was not yet available for SI. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Acked-by: Christian König <christian.koe..

Re: [PATCH 05/12] drm/amdgpu: Send no-retry XNACK for all fault types

still worth doing in the short term IMO. Yeah, agree. Especially avoiding the interrupt ring overflow sounds like a good idea to me. Patch is Acked-by: Christian König <christian.koe...@amd.com> as well. Christian. Regards, Felix On 17-07-03 05:11 PM, Felix Kuehling wrote:

Re: [PATCH] drm/syncobj: add sync obj wait interface. (v6)

Am 12.07.2017 um 17:53 schrieb Jason Ekstrand: [SNIP] Is that easier than just waiting in the kernel, I'm not sure how optimised we need this path to be. I don't think so. I think it's more-or-less the same code regardless of how it's done. The advantage of doing it in the kernel

[PATCH] drm/amdgpu: fix amdgpu_bo_gpu_accessible()

From: Christian König <christian.koe...@amd.com> The test was relaxed a bit to much. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/dr

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

Am 15.07.2017 um 05:32 schrieb Michel Dänzer: On 15/07/17 04:47 AM, Felix Kuehling wrote: On 17-07-13 11:26 PM, Michel Dänzer wrote: On 14/07/17 06:08 AM, Felix Kuehling wrote: Allows gdb to access contents of user mode mapped BOs. VRAM access requires the driver to implement a new callback

Re: [PATCH 1/5] drm: radeon: constify pci_device_id.

com> Impressive result for such a simple change. Patch is Reviewed-by: Christian König <christian.koe...@amd.com> Are the PCI IDs already const in amdgpu or do we need a similar patch there as well? I only see patch 1 of 5 in my inbox. Christian. --- drivers/gpu/drm/radeon/rade

Re: [PATCH 2/2] drm/amdgpu: Implement ttm_bo_driver.access_vram callback

Am 13.07.2017 um 23:08 schrieb Felix Kuehling: Allows gdb to access contents of user mode mapped VRAM BOs. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 59 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 2

Re: [PATCH 1/2] drm: Implement vm_operations_struct.access

Am 13.07.2017 um 23:08 schrieb Felix Kuehling: Allows gdb to access contents of user mode mapped BOs. VRAM access requires the driver to implement a new callback in ttm_bo_driver. One more comment additionally to what Michel already wrote below, apart from that it looks good to me.

Re: [PATCH libdrm 1/2] drm/amdgpu: add syncobj create/destroy/import/export apis

Am 18.07.2017 um 02:48 schrieb Dave Airlie: From: Dave Airlie <airl...@redhat.com> These are just wrappers using the amdgpu device handle. Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Christian König <christian.koe...@amd.com> for this one. --- amdgp

Re: [PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4

on that? Regards, Christian. Am 18.07.2017 um 04:24 schrieb zhoucm1: Still holding on? I thought this patch was pushed in earlier with my RB. Regards, David Zhou On 2017年07月18日 05:02, Christian König wrote: From: Christian König <christian.koe...@amd.com> The hardware can use huge pages to m

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

Am 18.07.2017 um 04:29 schrieb zhoucm1: On 2017年07月18日 01:35, Christian König wrote: Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie <airl...@gmail.com> wrote: I can take a look at it, I just won't have time until next week most likely. I've

Re: [PATCH] drm/amdgpu:fix gfx fence allocate size

think in total we use something like maybe ~40 at maximum. This way we wouldn't need 3 different get/free functions and save us a bunch of logic spread around everywhere. Anyway that can come later, let's fix the bug first. So with Alex suggestions the patch is Reviewed-by: Christian Kön

Re: [PATCH 1/2] drm/ttm: Implement vm_operations_struct.access v2

more generic to handle private memory pools * document callback return value * WARN_ON -> WARN_ON_ONCE Signed-off-by: Felix Kuehling <felix.kuehl...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> for both. --- drivers/gpu/drm/ttm/t

Re: [PATCH libdrm 2/2] drm/amdgpu: add new low overhead command submission API.

Am 18.07.2017 um 02:48 schrieb Dave Airlie: From: Dave Airlie This just sends chunks to the kernel API for a single command stream. This should provide a more future proof and extensible API for command submission. Signed-off-by: Dave Airlie ---

Re: [PATCH libdrm] drm/amdgpu: add new low overhead command submission API. (v2)

ctions to access bo and context internals. Signed-off-by: Dave Airlie <airl...@redhat.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- amdgpu/amdgpu.h| 30 ++ amdgpu/amdgpu_cs.c | 47 +++ 2

Re: [PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4

From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Christian König <deathsim...@vodafone.de> Sent: Monday, July 17, 2017 17:02 To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: [PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4 Fro

Re: [PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4

Am 17.07.2017 um 23:30 schrieb Felix Kuehling: On 17-07-17 05:02 PM, Christian König wrote: + if (p->adev->asic_type < CHIP_VEGA10 || + nptes != AMDGPU_VM_PTE_COUNT(p->adev) || + p->func != amdgpu_vm_do_set_ptes || + !(flags & AMDGPU_PTE

[PATCH v8 1/6] PCI: add a define for the PCI resource type mask v2

From: Christian König <christian.koe...@amd.com> We use this mask multiple times in the bus setup. v2: fix some style nit picks Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> --- drivers/pci/pci.h |

Resizeable PCI BAR support V8

Hi everyone, This is the eighth incarnation of this set of patches. It enables device drivers to resize and most likely also relocate the PCI BAR of devices they manage to allow the CPU to access all of the device local memory at once. This is very useful for GFX device drivers where the

[PATCH v8 3/6] PCI: add functionality for resizing resources v7

From: Christian König <christian.koe...@amd.com> This allows device drivers to request resizing their BARs. The function only tries to reprogram the windows of the bridge directly above the requesting device and only the BAR of the same type (usually mem, 64bit, prefetchable). This i

[PATCH v8 6/6] drm/amdgpu: resize VRAM BAR for CPU access v4

From: Christian König <christian.koe...@amd.com> Try to resize BAR0 to let CPU access all of VRAM. v2: rebased, style cleanups, disable mem decode before resize, handle gmc_v9 as well, round size up to power of two. v3: handle gmc_v6 as well, release and reassign all BARs in the driv

[PATCH v8 5/6] drm/amdgpu: move hw generation check into amdgpu_doorbell_init v2

From: Christian König <christian.koe...@amd.com> This way we can safely call it on SI as well. v2: fix type in commit message Signed-off-by: Christian König <christian.koe...@amd.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/am

[PATCH v8 4/6] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v4

From: Christian König <christian.koe...@amd.com> Most BIOS don't enable this because of compatibility reasons. Manually enable a 64bit BAR of 64GB size so that we have enough room for PCI devices. v2: style cleanups, increase size, add resource name, set correct flags, print m

Re: [PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4

submit the code, it allows more people to experiment with it. Regards, Felix On 17-07-18 09:54 AM, Christian König wrote: Yeah, I mean it looks good from the software side but we still don't see the hardware react as it should. It doesn't seem to hurt anything, so I'm torn apart between pushing

[PATCH 1/2] drm/amdgpu: increase fragmentation size for Vega10 v2

From: Christian König <christian.koe...@amd.com> The fragment bits work differently for Vega10 compared to previous generations. Increase the fragment size to 2MB for now to better handle that. v2: handle the hardware setup as well Signed-off-by: Christian König <christian.koe..

[PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v5

From: Christian König <christian.koe...@amd.com> The hardware can use huge pages to map 2MB of address space with only one PDE. v2: few cleanups and rebased v3: skip PT updates if we are using the PDE v4: rebased, added support for CPU based updates v5: fix CPU based updates once more

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

Am 20.07.2017 um 16:59 schrieb Marek Olšák: On Jul 19, 2017 10:21 PM, "zhoucm1" > wrote: On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" > wrote:

Re: [PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

Yeah, with the coding style fixed Reviewed-by: Christian König <christian.koe...@amd.com> as well. Christian. Am 20.07.2017 um 05:01 schrieb zhoucm1: one small nit pick, with that fix, Reviewed-by: Chunming Zhou <david1.z...@amd.com> On 2017年07月20日 10:46, Alex Xie wrote: In R

Re: [PATCH] drm/amdgpu: reduce the time of reading VBIOS

t; You added the signed-off-by line twice, please fix this. With that fixed and the commit message improved a bit the patch is Reviewed-by: Christian König <christian.koe...@amd.com>. Regards, Christian. --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] drm/amdgpu: fix spelling mistake: "suuport"-> "support"

Am 25.07.2017 um 00:45 schrieb Colin King: From: Colin Ian King <colin.k...@canonical.com> Trivial fix to spelling mistake in WARN_ONCE message Signed-off-by: Colin Ian King <colin.k...@canoical.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- drivers/

Re: [PATCH] drm/amdgpu/dce_virtual: remove error message for vega10

Am 25.07.2017 um 11:50 schrieb Xiangliang.Yu: Vega10 also support virtual display, remove the error message. Signed-off-by: Xiangliang.Yu <xiangliang...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 ++ 1 fil

Re: 答复: [PATCH 1/4] drm/amdgpu/gmc6: disable legacy vga features in gmc init (v2)

The term "legacy VGA" sounds like the whole render functionality which actually isn't part of the GMC AFAIK. But what Alex primary disables here is the old VGA BAR in the CPU address space and that is part of the GMC (or at least related to it). BTW: Patch are Acked-by: Chris

Re: [PATCH 1/4] drm/amdgpu/gmc6: disable legacy vga features in gmc init (v2)

Am 25.07.2017 um 05:30 schrieb Alex Deucher: Needs to be done when the MC is set up. v2: make consistent with other asics Signed-off-by: Alex Deucher On first glance it kind of looks a bit odd to have that in the GMC code, but on second glance it actually makes

Re: [PATCH 2/2] drm/amdgpu: Support IOMMU on Raven

Am 26.07.2017 um 22:46 schrieb Yong Zhao: We achieved that by setting the PTEs to 2 (the SYSTEM bit is set) when the corresponding addresses are not occupied by gpu driver allocated buffers. Change-Id: I995c11c7a25bdaf7a16700d9e08a8fe287d49417 Signed-off-by: Yong Zhao

Re: [PATCH 1/2] drm/amdgpu: Add support for filling a buffer with 64 bit value

Please make sure that you only change the type, with that fixed the patch is Reviewed-by: Christian König <christian.koe...@amd.com>. Regards, Christian. { struct amdgpu_device *adev = amdgpu_ttm_adev(bo->tbo.bdev); + /* max_bytes applies to SDMA_OP

Re: [PATCH] drm/amdgpu: fix header on gfx9 clear state

Am 27.07.2017 um 04:13 schrieb Alex Deucher: This got missed when we open sourced this. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Ups, indeed that should be fixed ASAP. Reviewed-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/clear

Re: [PATCH] drm/amdgpu: remove unused power control for vcn

Am 27.07.2017 um 04:44 schrieb Deucher, Alexander: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Leo Liu Sent: Wednesday, July 26, 2017 3:08 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH] drm/amdgpu: remove unused power

Re: [PATCH] drm/amdgpu: disable vcn power control for now

on runs, disable it for now till pg/cg. Also remove clock manual setting when dpm disabled, which was inherited from uvd. Signed-off-by: Leo Liu <leo@amd.com> Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com>

Re: [PATCH 2/5] drm/amdgpu/sdma4: set wptr shadow atomically

Am 27.07.2017 um 22:50 schrieb Alex Deucher: On Thu, Jul 27, 2017 at 4:39 PM, Felix Kuehling wrote: On 17-07-27 03:46 PM, Alex Deucher wrote: No functional change until wptr polling uses this location (future patch). Cc: Frank Min Signed-off-by:

Re: [PATCH 1/5] drm/amdgpu/sdma4: drop unused register header

Am 27.07.2017 um 21:46 schrieb Alex Deucher: nbio registers are not used in this file. Cc: Frank Min <frank@amd.com> Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Patches #1 and #3-#5 are Reviewed-by: Christian König <christian.koe...@amd.com>. I agree

Re: [PATCH 1/2] drm/amdgpu: Add a parameter to amdgpu_bo_create()

leanup which removes a bunch of references to amdgpu_bo_create(), so don't be surprised when you need to rebase your patch once more before pushing. The patch is Reviewed-by: Christian König <christian.koe...@amd.com> and that rebase should only require you to remove changes, so feel f

Re: [PATCH 2/2] drm/amdgpu: Support IOMMU on Raven

-by: Yong Zhao <yong.z...@amd.com> Reviewed-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 +++ 2 files changed, 27 insertions(+), 5 deletions(-) diff --g

Re: [PATCH] drm/amdgpu: make wb 256bit function names consistent

Am 27.07.2017 um 22:43 schrieb Alex Deucher: Use a lower case b to be consistent with the other wb functions. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> I still suggest to get rid of all those variants and always allocate 256bits, but anyway the patch is Reviewed-by: Chr

Re: [PATCH] drm/amd/powerplay: rv: Use designated initializers

Am 28.07.2017 um 03:43 schrieb Alex Deucher: On Tue, Jul 25, 2017 at 5:47 PM, Kees Cook wrote: As done for vega10 in commit 3ddd396f6b57 ("drm/amd/powerplay: Use designated initializers") mark other tableFunction entries with designated initializers. The randstruct

Re: [PATCH] drm/amdgpu: drop old ip definitions for gfxhub and mmhub

Am 28.07.2017 um 05:41 schrieb Alex Deucher: The gfxhub and mmhub code are now helpers for gmc rather than standalone IPs. When that changes these were left over. Remove them. Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> Reviewed-by: Christian König <christian.koe..

Re: Changes for enabling ATS support from PTE

Hi Yong, looks pretty good to me, but still quite a few comments. First of all please send the patches directly to the mailing list using "git send-email" and not as attachment. Patch #1: + + switch (word_size) { + case 4: + num_dw = num_loops *

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

Am 30.06.2017 um 04:24 schrieb Michel Dänzer: On 29/06/17 07:05 PM, Daniel Vetter wrote: On Thu, Jun 29, 2017 at 06:58:05PM +0900, Michel Dänzer wrote: On 29/06/17 05:23 PM, Christian König wrote: Am 29.06.2017 um 04:35 schrieb Michel Dänzer: On 29/06/17 08:26 AM, John Brooks wrote: On Wed

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

Am 30.06.2017 um 03:36 schrieb Michel Dänzer: On 30/06/17 12:03 AM, Marek Olšák wrote: Do you have any concern if we also stop using the CPU_ACCESS flag on radeon? No concern from my side for radeon. On Thu, Jun 29, 2017 at 4:51 PM, Christian König <deathsim...@vodafone.de> wrote: Y

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

Am 30.06.2017 um 08:51 schrieb Michel Dänzer: We can deal with that internally in the kernel, while fixing the existing flag for userspace. And as I said, NAK to that approach. I'm not going to add a CPU_ACCESS_REALLY_REQUIRED flag in the kernel just because mesa has messed up it's use case.

Re: [PATCH] drm/amdgpu: Make KIQ read/write register routine be atomic

Am 30.06.2017 um 03:21 schrieb Michel Dänzer: On 30/06/17 06:08 AM, Shaoyun Liu wrote: 1. Use spin lock instead of mutex in KIQ 2. Directly write to KIQ fence address instead of using fence_emit() 3. Disable the interrupt for KIQ read/write and use CPU polling This list indicates that this

[PATCH 01/12] drm/amdgpu: move ring helpers to amdgpu_ring.h

From: Christian König <christian.koe...@amd.com> Keep them where they belong. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 44 drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 02/12] drm/amdgpu: fix amdgpu_ring_write_multiple

From: Christian König <christian.koe...@amd.com> Overwriting still used ring content has a low probability to cause problems, not writing at all has 100% probability to cause problems. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH 04/12] drm/amdgpu: add vm_needs_flush parameter to amdgpu_copy_buffer

From: Christian König <christian.koe...@amd.com> This allows us to flush the system VM here. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 4 ++-- drivers/gpu/dr

[PATCH 05/12] drm/amdgpu: bind BOs to TTM only once

From: Christian König <christian.koe...@amd.com> No need to do this on every round. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 70 ++--- 1 file changed, 29 insertions(+), 41 deletions(-)

[PATCH 11/12] drm/amdgpu: remove maximum BO size limitation.

From: Christian König <christian.koe...@amd.com> We can finally remove this now. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amd

[PATCH 06/12] drm/amdgpu: bind BOs with GTT space allocated directly

From: Christian König <christian.koe...@amd.com> This avoids binding them later on. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 49 ++

[PATCH 12/12] drm/amdgpu: add gtt_sys_limit

From: Christian König <christian.koe...@amd.com> Limit the size of the GART table for the system domain. This saves us a bunch of visible VRAM, but also limitates the maximum BO size we can swap out. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/dr

[PATCH 10/12] drm/amdgpu: stop mapping BOs to GTT

From: Christian König <christian.koe...@amd.com> No need to map BOs to GTT on eviction and intermediate transfers any more. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 19 ++- 1 file changed, 2 inser

[PATCH 03/12] drm/amdgpu: allow flushing VMID0 before IB execution as well

From: Christian König <christian.koe...@amd.com> This allows us to queue IBs which needs an up to date system domain as well. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2

[PATCH 07/12] drm/amdgpu: reserve the first 2x2MB of GART

From: Christian König <christian.koe...@amd.com> We want to use them as remap address space. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 5 - drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 3 +++ 2 files changed,

[PATCH 09/12] drm/amdgpu: use the GTT windows for BO moves

From: Christian König <christian.koe...@amd.com> This way we don't need to map the full BO at a time any more. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 127 +++- drivers/gpu/drm/amd/amdgpu/

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

Am 30.06.2017 um 09:14 schrieb Michel Dänzer: On 30/06/17 03:59 PM, Christian König wrote: Am 30.06.2017 um 08:51 schrieb Michel Dänzer: We can deal with that internally in the kernel, while fixing the existing flag for userspace. And as I said, NAK to that approach. I'm not going to add

Re: [PATCH] drm/amdgpu/cgs: always set reference clock in mode_info

-by: Alex Deucher <alexander.deuc...@amd.com> Cc: sta...@vger.kernel.org Acked-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

Yeah, I was thinking something similar. See the intention behind CPU_ACCESS_REQUIRED is to always guarantee that CPU access is immediately possible. If you ask me that is not really useful for the UMD and was never meant to be used by Mesa (only the closed source UMD and some kernel internal

Re: [PATCH RFC 1/2] drm/amdgpu: Add AMDGPU_BO_FLAG_CPU_ACCESS

Am 30.06.2017 um 17:18 schrieb John Brooks: For userspace BO allocations, replace AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED with a new AMDGPU_BO_FLAG_CPU_ACCESS flag. This flag will be used to indicate that a BO should currently be CPU accessible. Unlike the CPU_ACCESS_REQUIRED flag, it is meant to

<    4   5   6   7   8   9   10   11   12   13   >